RE: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers

2019-01-31 Thread Lindenmaier, Goetz
Hi Jini, I pushed it into our testing: https://ci.sapmachine.io/view/Build%20My%20Branch/job/branch-build-service/43/ the build is running ... Best regards, Goetz. > -Original Message- > From: serviceability-dev On > Behalf Of Jini George > Sent: Mittwoch, 30. Januar 2019 12:59 > To

RE: HotSpot Serviceability Agent (SA) Survey

2019-01-31 Thread Lindenmaier, Goetz
Hi, any news on this? We get questions for the results by the people I made participate in this :) Best regards, Goetz. > -Original Message- > From: serviceability-dev On > Behalf Of Stephen Fitch > Sent: Dienstag, 3. Juli 2018 14:18 > To: Per Liden ; serviceability-dev@openjdk.jav

RE: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers

2019-01-31 Thread Lindenmaier, Goetz
... and the tests passed. https://ci.sapmachine.io/job/branch-build-linux_x86_64/12/JT_20Report_20hotspot/ Unfortunately one can not see the jtr file to verify the right exception was thrown. But they passed, so it's good. Why do you remove some checks for test failures from some tests? Like

Re: HotSpot Serviceability Agent (SA) Survey

2019-01-31 Thread Stephen Fitch
Hi Goetz, I will sync with Raga, my fellow manager in this (SA) domain, and get more effort into getting the summary out ASAP. Apologies for the delay. Regards,  Stephen -- On 1/31/19 05:17, Lindenmaier, Goetz wrote: Hi, any news on this? We get questions for the results by the people I mad

Re: RFR (12) JDK-8218025: disable pop_frame and force_early_return caps for Graal

2019-01-31 Thread Alex Menkov
Hi guys, thank you for the feedback. updated webrev (used the way suggested by David & Igor): http://cr.openjdk.java.net/~amenkov/tck_red_disable_caps/webrev.02/ --alex On 01/30/2019 21:31, serguei.spit...@oracle.com wrote: On 1/30/19 21:24, David Holmes wrote: On 31/01/2019 3:18 pm, dean.l.

Re: RFR (12) JDK-8218025: disable pop_frame and force_early_return caps for Graal

2019-01-31 Thread Igor Ignatyev
Hi Alex, you have 'if INCLUDE_JVMCI' inside 'ifndef ZERO', although we currently don't have zero builds w/ JVMCI (and I don't think such builds would make much sense), it's better not to rely on that. not a blocker from my point of view though. Thanks, -- Igor > On Jan 31, 2019, at 10:38 AM,

Re: RFR (12) JDK-8218025: disable pop_frame and force_early_return caps for Graal

2019-01-31 Thread Alex Menkov
On 01/31/2019 10:52, Igor Ignatyev wrote: Hi Alex, you have 'if INCLUDE_JVMCI' inside 'ifndef ZERO', although we currently don't have zero builds w/ JVMCI (and I don't think such builds would make much sense), it's better not to rely on that. not a blocker from my point of view though.

Re: RFR (12) JDK-8218025: disable pop_frame and force_early_return caps for Graal

2019-01-31 Thread Igor Ignatyev
Hi Alex, sure I understand that, but let's say we decide to add these capabilities to ZERO or remove all ZERO-specific code. I am *not* saying we are going to do that, just speculating. In such cases, your code[1] will require more effort to figure that should be changed comparing to the almost

Re: RFR (12) JDK-8218025: disable pop_frame and force_early_return caps for Graal

2019-01-31 Thread serguei.spit...@oracle.com
Hi Alex, Looks fine to me. Thanks, Serguei On 1/31/19 10:38, Alex Menkov wrote: Hi guys, thank you for the feedback. updated webrev (used the way suggested by David & Igor): http://cr.openjdk.java.net/~amenkov/tck_red_disable_caps/webrev.02/ --alex On 01/30/2019 21:31, serguei.spit...@ora

Re: RFR 8205654: serviceability/dcmd/framework/HelpTest.java timed out

2019-01-31 Thread serguei.spit...@oracle.com
Hi Daniil, I have some secondary comment on new file: http://cr.openjdk.java.net/~dtitov/8205654/webrev.03/src/jdk.jcmd/linux/classes/sun/tools/ProcessHelper.java.html 70 for (int i = 0; i < parts.length && mainClass == null; i++)

Re: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers

2019-01-31 Thread Jini George
Thank you very much, Goetz, for running the tests and for taking a look at the changes. The only reason jstackOutput used to be null was due to the attach permission issues -- but now with the current change, test.run would throw the SkippedException for such cases, and would not reach the code

Re: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers

2019-01-31 Thread David Holmes
On 1/02/2019 1:11 am, Lindenmaier, Goetz wrote: ... and the tests passed. https://ci.sapmachine.io/job/branch-build-linux_x86_64/12/JT_20Report_20hotspot/ Unfortunately one can not see the jtr file to verify the right exception was thrown. But they passed, so it's good. Why do you remove some

Re: RFR (12) JDK-8218025: disable pop_frame and force_early_return caps for Graal

2019-01-31 Thread David Holmes
+1 David On 1/02/2019 5:39 am, serguei.spit...@oracle.com wrote: Hi Alex, Looks fine to me. Thanks, Serguei On 1/31/19 10:38, Alex Menkov wrote: Hi guys, thank you for the feedback. updated webrev (used the way suggested by David & Igor): http://cr.openjdk.java.net/~amenkov/tck_red_disab

RE: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers

2019-01-31 Thread Sharath Ballal
+1 Thanks, Sharath -Original Message- From: Jini George Sent: Friday, February 01, 2019 9:46 AM To: Lindenmaier, Goetz; serviceability-dev@openjdk.java.net Subject: Re: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers Thank you very much, Goetz, for running t

Re: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers

2019-01-31 Thread Jini George
Thanks, Sharath. -jini. On 2/1/2019 11:30 AM, Sharath Ballal wrote: +1 Thanks, Sharath -Original Message- From: Jini George Sent: Friday, February 01, 2019 9:46 AM To: Lindenmaier, Goetz; serviceability-dev@openjdk.java.net Subject: Re: JDK-8217473: SA: Tests using ClhsdbLauncher fa