On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Tue, 9 Mar 2021 21:08:54 GMT, Daniel D. Daugherty wrote:
> Add three tests from JDK-4413752 ported to JVM/TI:
>
> - RawMonitorEnter() with SuspendThread()
> -
> test/hotspot/jtreg/serviceability/jvmti/SuspendWithRawMonitorEnter/SuspendWithRawMonitorEnter.java
> -
> test/hotspot/jtreg/se
On Thu, 8 Apr 2021 07:17:48 GMT, Robbin Ehn wrote:
>> A suspend request is done by handshaking thread target thread(s). When
>> executing the handshake operation we know the target mutator thread is in a
>> dormant state (as in safepoint safe state). We have a guarantee that it will
>> check i
On Wed, 7 Apr 2021 07:23:26 GMT, Robbin Ehn wrote:
>> src/hotspot/share/runtime/handshake.cpp line 415:
>>
>>> 413: // Adds are done lock free and so is arming.
>>> 414: // Calling this method with lock held is considered an error.
>>> 415: assert(!_lock.owned_by_self(), "Lock should not b
On Wed, 7 Apr 2021 07:25:29 GMT, Robbin Ehn wrote:
>> src/hotspot/share/runtime/handshake.cpp line 463:
>>
>>> 461: ThreadInVMForHandshake tivm(_handshakee);
>>> 462: {
>>> 463: ttyLocker::break_tty_lock_for_safepoint(os::current_thread_id());
>>
>> Why is this needed when it is inside
On Thu, 8 Apr 2021 16:08:06 GMT, Richard Reingruber wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - White space fixes
>> - Merge branch 'master' into SuspendInHandshake
>> - Review fixe
On Fri, 9 Apr 2021 15:29:30 GMT, Daniel D. Daugherty wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - White space fixes
>> - Merge branch 'master' into SuspendInHandshake
>> - Review fix
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Fri, 9 Apr 2021 04:32:14 GMT, David Holmes wrote:
> Hi Vladimir,
>
> This looks good to me - I went through all the files.
>
> It was nice to see how nicely compartmentalized the AOT feature was - that
> made checking the changes quite simple. The one exception was the
> fingerprinting cod
On Fri, 9 Apr 2021 16:15:28 GMT, Daniel D. Daugherty wrote:
>> src/hotspot/share/runtime/handshake.cpp line 632:
>>
>>> 630: }
>>> 631:
>>> 632: void HandshakeState::self_suspened() {
>>
>> Typo: s/self_suspened/self_suspended/
>
> I'm not fond of `self_suspended` as the function name.
> Perha
On Fri, 9 Apr 2021 17:09:58 GMT, Vladimir Kozlov wrote:
>> Hi Vladimir,
>>
>> This looks good to me - I went through all the files.
>>
>> It was nice to see how nicely compartmentalized the AOT feature was - that
>> made checking the changes quite simple. The one exception was the
>> fingerpr
On Fri, 9 Apr 2021 02:44:23 GMT, David Holmes wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> src/hotspot/cpu/x86/compiledIC_x86.cpp line 134:
>
>> 132: #ifdef AS
On Fri, 9 Apr 2021 08:29:21 GMT, Aleksey Shipilev wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> src/hotspot/cpu/x86/globalDefinitions_x86.hpp line 73:
>
>> 71:
On Fri, 9 Apr 2021 03:03:33 GMT, David Holmes wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> src/hotspot/share/memory/heap.hpp line 174:
>
>> 172: bool contain
On Fri, 9 Apr 2021 08:32:59 GMT, Aleksey Shipilev wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> src/hotspot/share/code/compiledIC.cpp line 715:
>
>> 713: tt
On Fri, 9 Apr 2021 16:30:41 GMT, Igor Veresov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> src/hotspot/share/oops/instanceKlass.hpp line 257:
>
>> 255: _mi
On Fri, 9 Apr 2021 16:34:58 GMT, Igor Veresov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> src/hotspot/share/jvmci/jvmciCodeInstaller.cpp line 1184:
>
>> 1182:
On Fri, 9 Apr 2021 16:54:35 GMT, Ioi Lam wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> src/hotspot/share/oops/methodCounters.cpp line 77:
>
>> 75: }
>> 76:
>>
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to
> Ahead-of-Time Compiler from JDK:
>
> - `jdk.aot` module — the `jaotc` tool
> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
> - related HotSpot code guarded by `#if INCLUDE_AOT`
>
> A
On Fri, 9 Apr 2021 21:59:04 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Sat, 10 Apr 2021 01:10:37 GMT, Alex Menkov wrote:
> The test actually failed starting from jdk13, but the error is masked by
> JDK-8264667 (and shell part of the test didn't verify result of the java
> execution)
> The fix:
> - updates JvmtiClassFileReconstituter to add attributes in the sam
The test actually failed starting from jdk13, but the error is masked by
JDK-8264667 (and shell part of the test didn't verify result of the java
execution)
The fix:
- updates JvmtiClassFileReconstituter to add attributes in the same order as
javac does
- makes the test java instead of shell
- a
On Fri, 9 Apr 2021 16:54:51 GMT, Ioi Lam wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> LGTM. Just a small nit.
@iklam
I thought the fingerprint code was also us
On Fri, 9 Apr 2021 16:54:51 GMT, Ioi Lam wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> LGTM. Just a small nit.
> @iklam
> I thought the fingerprint code was als
27 matches
Mail list logo