Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v5]

2022-02-09 Thread Emanuel Peter
> Deprecated ExtendedDTraceProbes. > Edited help messages and man pages accordingly. > Added flag to VMDeprecatedOptions test. > > Checked that tests are not affected. Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision: Revert "removed

Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v3]

2022-02-09 Thread Emanuel Peter
On Wed, 19 Jan 2022 01:10:34 GMT, David Holmes wrote: >> Emanuel Peter has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge branch 'JDK-8278423' of https://github.com/eme64/jdk into >> JDK-8278423 >> - added flag to VMDeprecatedOpti

Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v6]

2022-02-09 Thread Emanuel Peter
> Deprecated ExtendedDTraceProbes. > Edited help messages and man pages accordingly. > Added flag to VMDeprecatedOptions test. > > Checked that tests are not affected. Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision: replaced with 3

Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v4]

2022-02-09 Thread Emanuel Peter
On Tue, 18 Jan 2022 18:42:27 GMT, Harold Seigel wrote: > Can you replace the use of -XX:+ExtendedDTraceProbes in > test/hotspot/jtreg/serviceability/7170638/SDTProbesGNULinuxTest.java with the > three new flags ? Thank you @hseigel , I patched it according to your suggestion. - P

Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v4]

2022-02-09 Thread Emanuel Peter
On Wed, 19 Jan 2022 01:12:16 GMT, David Holmes wrote: >> Emanuel Peter has updated the pull request incrementally with one additional >> commit since the last revision: >> >> moved deprecated flag to deprecated section in manpages > > src/hotspot/share/runtime/arguments.cpp line 2884: > >> 2

Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v7]

2022-02-09 Thread Emanuel Peter
> Deprecated ExtendedDTraceProbes. > Edited help messages and man pages accordingly. > Added flag to VMDeprecatedOptions test. > > Checked that tests are not affected. Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision: updated warning

Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v4]

2022-02-09 Thread Emanuel Peter
On Wed, 19 Jan 2022 01:17:21 GMT, David Holmes wrote: >> Emanuel Peter has updated the pull request incrementally with one additional >> commit since the last revision: >> >> moved deprecated flag to deprecated section in manpages > > src/java.base/share/man/java.1 line 4001: > >> 3999: .TP

Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v7]

2022-02-09 Thread Harold Seigel
On Wed, 9 Feb 2022 16:20:49 GMT, Emanuel Peter wrote: >> Deprecated ExtendedDTraceProbes. >> Edited help messages and man pages accordingly, added the 3 flags to man >> pages. >> Added flag to VMDeprecatedOptions test. >> Replaced the flag with 3 flags in SDTProbesGNULinuxTest.java. >> >> Check

Re: RFR: 8281267: VM HeapDumper dumps array classes several times

2022-02-09 Thread Chris Plummer
On Tue, 8 Feb 2022 16:49:41 GMT, Alex Menkov wrote: > ClassLoaderDataGraph::classes_do description says: > // Walking classes through the ClassLoaderDataGraph include array classes. > So do_load_class callback should not dump arrays for the classes and dumper > doesn't need to call Universe::bas

Re: RFR: 8281267: VM HeapDumper dumps array classes several times

2022-02-09 Thread Chris Plummer
On Tue, 8 Feb 2022 16:49:41 GMT, Alex Menkov wrote: > ClassLoaderDataGraph::classes_do description says: > // Walking classes through the ClassLoaderDataGraph include array classes. > So do_load_class callback should not dump arrays for the classes and dumper > doesn't need to call Universe::bas

Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v7]

2022-02-09 Thread David Holmes
On Wed, 9 Feb 2022 16:20:49 GMT, Emanuel Peter wrote: >> Deprecated ExtendedDTraceProbes. >> Edited help messages and man pages accordingly, added the 3 flags to man >> pages. >> Added flag to VMDeprecatedOptions test. >> Replaced the flag with 3 flags in SDTProbesGNULinuxTest.java. >> >> Check