On Sun, 27 Mar 2022 08:59:40 GMT, Christoph Langer wrote:
> Fix risv64 -> riscv64
This pull request has now been integrated.
Changeset: f4eaa16c
Author:Christoph Langer
URL:
https://git.openjdk.java.net/jdk/commit/f4eaa16c0fe0659376325cec1c912a13ef0f1be8
Stats: 0 lines in 1
On Sun, 27 Mar 2022 08:59:40 GMT, Christoph Langer wrote:
> Fix risv64 -> riscv64
Interestingly, the thing compiles as the package name inside of
RISCV64ThreadContext.java is correct and the compiler doesn't bother about the
path. Only my Eclipse IDE complained.
Thanks for the reviews.
JVMTI heap walking marks objects in order to track which have been visited
already. In order to do that, it uses bits in the object header. Those are the
same bits that are also used by some GCs to mark objects (the lowest two bits,
also used by locking code). Some GCs also use the bits in
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
This pull request has now been integrated.
Changeset: c0aecd15
Author:Alisen Chung
Committer: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/commit/c0aecd15ae8d7abf37901f785fccaff2317c3b23
On Mon, 28 Mar 2022 06:19:39 GMT, David Holmes wrote:
>> `JvmtiEnv::SetSystemProperty` eventually calls `PathString::set_value` in
>> arguments.cpp, which aborts the VM when it fails to allocate a string copy
>> of the property value.
>>
>>
>> bool PathString::set_value(const char *value) {
On Sat, 26 Mar 2022 20:50:34 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 languate feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduce duplication.
> Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
> statement`
Marked as
Let's take advantage of Java 7 languate feature - "Catching Multiple Exception
Types".
It simplifies code. Reduce duplication.
Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
statement`
-
Commit messages:
- [PATCH] Collapse identical catch branches in
In a few places String.indexOf/lastIndexOf methods are called with default
parameter for index: `0` for `indexOf`, length() for `lastIndexOf`.
I propose to cleanup such calls. It makes code a bit easier to read. In case of
`indexOf` it even could be faster, as there is separate intrinsic for
In this test the debuggee creates a couple of threads, and the debugger checks
to make sure it gets a ThreadStartEvent for each of these threads, plus one for
the main debuggee thread. Once it has done this, it disables the
ThreadStartRequest and sends a "quit" command to the debuggee. However,
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
I confirm that this is an exact backout of
[JDK-8280400](https://bugs.openjdk.java.net/browse/JDK-8280400).
-
Marked as reviewed by kcr (Author).
PR:
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote:
> In a few places String.indexOf/lastIndexOf methods are called with default
> parameter for index: `0` for `indexOf`, length() for `lastIndexOf`.
> I propose to cleanup such calls. It makes code a bit easier to read. In case
> of
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote:
> In a few places String.indexOf/lastIndexOf methods are called with default
> parameter for index: `0` for `indexOf`, length() for `lastIndexOf`.
> I propose to cleanup such calls. It makes code a bit easier to read. In case
> of
This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
-
Commit messages:
- Revert "8280400: JDK 19 L10n resource files update - msgdrop 10"
Changes: https://git.openjdk.java.net/jdk/pull/8005/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8005=00
Issue:
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote:
> In a few places String.indexOf/lastIndexOf methods are called with default
> parameter for index: `0` for `indexOf`, length() for `lastIndexOf`.
> I propose to cleanup such calls. It makes code a bit easier to read. In case
> of
On Tue, 29 Mar 2022 04:24:15 GMT, Ioi Lam wrote:
>> `JvmtiEnv::SetSystemProperty` eventually calls `PathString::set_value` in
>> arguments.cpp, which aborts the VM when it fails to allocate a string copy
>> of the property value.
>>
>>
>> bool PathString::set_value(const char *value) {
>>
On Tue, 29 Mar 2022 04:58:32 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @dholmes-ora comments: simplify the changes
>
> src/hotspot/share/runtime/arguments.hpp line 113:
>
>> 111: bool
On Tue, 29 Mar 2022 04:24:15 GMT, Ioi Lam wrote:
>> `JvmtiEnv::SetSystemProperty` eventually calls `PathString::set_value` in
>> arguments.cpp, which aborts the VM when it fails to allocate a string copy
>> of the property value.
>>
>>
>> bool PathString::set_value(const char *value) {
>>
On Mon, 28 Mar 2022 19:58:59 GMT, Chris Plummer wrote:
> In this test the debuggee creates a couple of threads, and the debugger
> checks to make sure it gets a ThreadStartEvent for each of these threads,
> plus one for the main debuggee thread. Once it has done this, it disables the
>
On Tue, 29 Mar 2022 04:24:15 GMT, Ioi Lam wrote:
>> `JvmtiEnv::SetSystemProperty` eventually calls `PathString::set_value` in
>> arguments.cpp, which aborts the VM when it fails to allocate a string copy
>> of the property value.
>>
>>
>> bool PathString::set_value(const char *value) {
>>
On Tue, 29 Mar 2022 05:24:59 GMT, Ioi Lam wrote:
>> src/hotspot/share/runtime/arguments.hpp line 113:
>>
>>> 111: bool writeable() const { return _writeable; }
>>> 112:
>>> 113: bool readable() const {
>>
>> Might be better/simpler to keep is_readable and change to
On Mon, 28 Mar 2022 22:19:49 GMT, Alex Menkov wrote:
> After pushing fix for JDK-8282241 (https://github.com/openjdk/jdk/pull/7676)
> random tests from serviceability/jvmti/RedefineClasses start to fail with
> java.lang.NoClassDefFoundError:
> jdk/test/lib/helpers/ClassFileInstaller$Manifest
>
On Mon, 28 Mar 2022 18:34:31 GMT, Ioi Lam wrote:
>> `JvmtiEnv::SetSystemProperty` eventually calls `PathString::set_value` in
>> arguments.cpp, which aborts the VM when it fails to allocate a string copy
>> of the property value.
>>
>>
>> bool PathString::set_value(const char *value) {
>>
On Mon, 28 Mar 2022 19:58:59 GMT, Chris Plummer wrote:
> In this test the debuggee creates a couple of threads, and the debugger
> checks to make sure it gets a ThreadStartEvent for each of these threads,
> plus one for the main debuggee thread. Once it has done this, it disables the
>
On Sat, 26 Mar 2022 20:50:34 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 languate feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduce duplication.
> Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
> statement`
Marked as
On Thu, 24 Mar 2022 02:53:00 GMT, Julian Waters wrote:
> Tested and compiled successfully with 2019 and 2022
This pull request has now been integrated.
Changeset: 9b49900b
Author:Julian Waters
Committer: David Holmes
URL:
On Mon, 28 Mar 2022 22:06:12 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @dholmes-ora comments: changed implementation to work with
>> JvmtiEnv::SetSystemProperty
>
>
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
This pull request has now been integrated.
Changeset: 634800a5
Author:Alisen Chung
Committer: Naoto Sato
URL:
After pushing fix for JDK-8282241 (https://github.com/openjdk/jdk/pull/7676)
random tests from serviceability/jvmti/RedefineClasses start to fail with
java.lang.NoClassDefFoundError: jdk/test/lib/helpers/ClassFileInstaller$Manifest
This is caused by JTReg classpath directories sharing between
On Mon, 28 Mar 2022 19:58:59 GMT, Chris Plummer wrote:
> In this test the debuggee creates a couple of threads, and the debugger
> checks to make sure it gets a ThreadStartEvent for each of these threads,
> plus one for the main debuggee thread. Once it has done this, it disables the
>
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8005
> `JvmtiEnv::SetSystemProperty` eventually calls `PathString::set_value` in
> arguments.cpp, which aborts the VM when it fails to allocate a string copy of
> the property value.
>
>
> bool PathString::set_value(const char *value) {
> if (_value != NULL) {
> FreeHeap(_value);
> }
>
31 matches
Mail list logo
