On Mon, 4 Apr 2022 17:51:28 GMT, Roman Kennke wrote:
>> JVMTI heap walking marks objects in order to track which have been visited
>> already. In order to do that, it uses bits in the object header. Those are
>> the same bits that are also used by some GCs to mark objects (the lowest two
>> bi
On Thu, 7 Apr 2022 05:47:56 GMT, Feilong Jiang wrote:
> Add riscv which doesn't have shared memory connector.
> Following tests passed with this patch and
> [CODETOOLS-7903138](https://github.com/openjdk/jtreg/pull/66):
>
> - vmTestbase/nsk/jdb/options/connect/connect003/connect003.java
> - vmT
On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeliński wrote:
> This patch adds missing `r` in `string`s
This pull request has now been integrated.
Changeset: 5bafcfdc
Author:Daniel Jeliński
URL:
https://git.openjdk.java.net/jdk/commit/5bafcfdc171b5a514ecf620703e77fa2f4a49c58
Stats: 1
On Thu, 7 Apr 2022 13:31:31 GMT, Thomas Stuefe wrote:
> Since the JVMTI heap walk usually walks the whole heap, the bitmap may not be
> as sparse as we think. It would materialize a lot - possibly all - of its
> fragments. The increased memory consumption during JVMTI heap walk may mess
> with
On Mon, 4 Apr 2022 17:51:28 GMT, Roman Kennke wrote:
>> JVMTI heap walking marks objects in order to track which have been visited
>> already. In order to do that, it uses bits in the object header. Those are
>> the same bits that are also used by some GCs to mark objects (the lowest two
>> bi
> JVMTI heap walking marks objects in order to track which have been visited
> already. In order to do that, it uses bits in the object header. Those are
> the same bits that are also used by some GCs to mark objects (the lowest two
> bits, also used by locking code). Some GCs also use the bits
On Thu, 7 Apr 2022 16:37:22 GMT, Thomas Stuefe wrote:
> If you add my proposed comment for bitset.hpp, or some variation of it, then
> the rest looks good to me in its current form. Thanks for considering my
> proposals!
>
> Thanks, Thomas
I did that, and some more of your suggestions, please
On Thu, 7 Apr 2022 17:20:41 GMT, Roman Kennke wrote:
>> JVMTI heap walking marks objects in order to track which have been visited
>> already. In order to do that, it uses bits in the object header. Those are
>> the same bits that are also used by some GCs to mark objects (the lowest two
>> bi
On Thu, 7 Apr 2022 17:22:12 GMT, Thomas Stuefe wrote:
>> Roman Kennke has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Add comment describing ObjectBitSet
>> - Refactor JVMTI usage of ObjectBitSet
>> - Typedef ObjectBitSet to JFRBitS
On Thu, 7 Apr 2022 17:20:41 GMT, Roman Kennke wrote:
>> JVMTI heap walking marks objects in order to track which have been visited
>> already. In order to do that, it uses bits in the object header. Those are
>> the same bits that are also used by some GCs to mark objects (the lowest two
>> bi
On Thu, 7 Apr 2022 17:20:41 GMT, Roman Kennke wrote:
>> JVMTI heap walking marks objects in order to track which have been visited
>> already. In order to do that, it uses bits in the object header. Those are
>> the same bits that are also used by some GCs to mark objects (the lowest two
>> bi
> JVMTI heap walking marks objects in order to track which have been visited
> already. In order to do that, it uses bits in the object header. Those are
> the same bits that are also used by some GCs to mark objects (the lowest two
> bits, also used by locking code). Some GCs also use the bits
On Thu, 31 Mar 2022 04:09:55 GMT, Chris Plummer wrote:
> Test is getting an `com.sun.jdi.ObjectCollectedException` during an invoke.
> The reason is because an allocated object is not being prevented from being
> gc'd:
>
>
> StringReference stringObj = vm().mirrorOf("test string");
>
On Thu, 7 Apr 2022 05:47:56 GMT, Feilong Jiang wrote:
> Add riscv which doesn't have shared memory connector.
> Following tests passed with this patch and
> [CODETOOLS-7903138](https://github.com/openjdk/jtreg/pull/66):
>
> - vmTestbase/nsk/jdb/options/connect/connect003/connect003.java
> - vmT
On Thu, 7 Apr 2022 10:12:21 GMT, Lutz Schmidt wrote:
>> Zhengyu Gu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix
>
> Looks good to me.
> Good catch! Thanks for finding and fixing the leak.
Thanks for the review, @RealLucy
---
On Thu, 7 Apr 2022 02:57:29 GMT, Zhengyu Gu wrote:
>> Please review this small patch to fix a possible memory leak.
>>
>> Test:
>> - [x] hotspot_serviceability
>
> Zhengyu Gu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix
Marked as r
On Wed, 6 Apr 2022 23:30:13 GMT, Zhengyu Gu wrote:
> Please review this small patch to fix a possible memory leak.
>
> Test:
> - [x] hotspot_serviceability
This pull request has now been integrated.
Changeset: d4a48843
Author:Zhengyu Gu
URL:
https://git.openjdk.java.net/jdk/commit/
On Thu, 7 Apr 2022 20:09:24 GMT, Leonid Mesnik wrote:
>> Zhengyu Gu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix
>
> Marked as reviewed by lmesnik (Reviewer).
Thanks, @lmesnik
-
PR: https://git.openjdk.java.net/jdk/
Tests are updated to ensure that classes are alive while test checks them.
Actually, fixed by @AlanBateman in repo-loom.
-
Commit messages:
- 8284556: Ensure reachability of classes in
runtime/whitebox/TestHiddenClassIsAlive.java and
serviceability/dcmd/vm/ClassLoaderHierarchyTest.
On Thu, 7 Apr 2022 23:29:41 GMT, Leonid Mesnik wrote:
> Tests are updated to ensure that classes are alive while test checks them.
> Actually, fixed by @AlanBateman in repo-loom.
Marked as reviewed by cjplummer (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8152
On Thu, 7 Apr 2022 14:49:41 GMT, Leonid Mesnik wrote:
>> Add riscv which doesn't have shared memory connector.
>> Following tests passed with this patch and
>> [CODETOOLS-7903138](https://github.com/openjdk/jtreg/pull/66):
>>
>> - vmTestbase/nsk/jdb/options/connect/connect003/connect003.java
>>
On Thu, 7 Apr 2022 05:47:56 GMT, Feilong Jiang wrote:
> Add riscv which doesn't have shared memory connector.
> Following tests passed with this patch and
> [CODETOOLS-7903138](https://github.com/openjdk/jtreg/pull/66):
>
> - vmTestbase/nsk/jdb/options/connect/connect003/connect003.java
> - vmT
On Mon, 4 Apr 2022 21:53:28 GMT, Roman Kennke wrote:
> > One open question is which MEMFLAGS to use. mtTracing doesn't seem to be
> > exactly right. Should I templatize BitSet and make JVMTI use
> > mtServiceability and JRF use mtTracing as it did before?
>
> Yes, I think templatizing for MEMF
On Thu, 7 Apr 2022 18:28:42 GMT, Roman Kennke wrote:
>> JVMTI heap walking marks objects in order to track which have been visited
>> already. In order to do that, it uses bits in the object header. Those are
>> the same bits that are also used by some GCs to mark objects (the lowest two
>> bi
On Fri, 8 Apr 2022 02:01:50 GMT, Kim Barrett wrote:
> > > One open question is which MEMFLAGS to use. mtTracing doesn't seem to be
> > > exactly right. Should I templatize BitSet and make JVMTI use
> > > mtServiceability and JRF use mtTracing as it did before?
> >
> >
> > Yes, I think templat
On Wed, 6 Apr 2022 12:44:35 GMT, Yasumasa Suenaga wrote:
>> jcmd uses
>> src/jdk.internal.jvmstat/linux/classes/sun/jvmstat/PlatformSupportImpl.java
>> to scan temporary directories to find out processes in the container. It
>> checks inode to ensure the temp directory is not conflicted. Howev
On Thu, 7 Apr 2022 18:28:42 GMT, Roman Kennke wrote:
>> JVMTI heap walking marks objects in order to track which have been visited
>> already. In order to do that, it uses bits in the object header. Those are
>> the same bits that are also used by some GCs to mark objects (the lowest two
>> bi
On Wed, 6 Apr 2022 12:44:35 GMT, Yasumasa Suenaga wrote:
>> jcmd uses
>> src/jdk.internal.jvmstat/linux/classes/sun/jvmstat/PlatformSupportImpl.java
>> to scan temporary directories to find out processes in the container. It
>> checks inode to ensure the temp directory is not conflicted. Howev
28 matches
Mail list logo
