Volker,
I’ve look at the following files:
src/share/native/sun/management/DiagnosticCommandImpl.c:
nit: “legel” - “legal” (two times)
In Java_sun_management_DiagnosticCommandImpl_getDiagnosticCommandInfo() if you
allow dcmd_info_array to become NULL, then
On 15/01/2014 06:24, David Holmes wrote:
I'm not a fan of runtime checks of this kind though if it is only a
very samll number of values it might be okay.
Another option would be to make those classes into templates as done
with Version.java.template and substitute the right values at build
Staffan, thank you for pointing out performance and test.src issues!
The webrev with fixes can be found here:
http://cr.openjdk.java.net/~ykantser/7185591/webrev.01/
Please, see my comments in-lined.
Thanks,
Katja
On 01/13/2014 01:19 PM, Staffan Larsen wrote:
Katja,
Katja,
test/lib/testlibrary/jdk/testlibrary/JcmdBase.java
The toolArgs parameter should be renamed jcmdArgs.
test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java
423 public int indexOf(String pattern) {
You don’t have to convert the List to an array before iterating through it. Use
On Wed, Jan 15, 2014 at 10:03 AM, Alan Bateman alan.bate...@oracle.comwrote:
On 15/01/2014 06:24, David Holmes wrote:
I'm not a fan of runtime checks of this kind though if it is only a very
samll number of values it might be okay.
Another option would be to make those classes into
Staffan,
The webrev with changes can be found here:
http://cr.openjdk.java.net/~ykantser/7185591/webrev.02/
If it looks good, could you please be my sponsor and push the changes?
The patch is attached to this mail.
Thanks,
Katja
On 01/15/2014 11:37 AM, Staffan Larsen wrote:
Katja,
Hi,
Please take a look at the new review.
Webrev for jdk part:
http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.02/
Webrev for hs part:
http://cr.openjdk.java.net/~anazarov/7195249/hs/webrev.02/
My answers are inline:
On 08.01.2014 17:46, Staffan Larsen wrote:
Hi Taras,
Thanks for
Hi Staffan,
thanks for the review. Please find my comments inline:
On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen
staffan.lar...@oracle.comwrote:
Volker,
I’ve look at the following files:
src/share/native/sun/management/DiagnosticCommandImpl.c:
nit: “legel” - “legal” (two times)
In
Changeset: 9e91793fd516
Author:vlivanov
Date: 2014-01-15 20:48 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e91793fd516
8031502: JSR292: IncompatibleClassChangeError in LambdaForm for
CharSequence.toString() method handle type converter
Reviewed-by: sundar, lagergren,
On Wed, Jan 15, 2014 at 6:27 PM, Volker Simonis volker.simo...@gmail.com
wrote:
On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis
volker.simo...@gmail.com wrote:
Hi Staffan,
thanks for the review. Please find my comments inline:
On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen
Hi Everybody,
Please review small, test-only fix.
http://cr.openjdk.java.net/~dsamersoff/JDK-8024049/webrev.01/
fix summary:
grep/cut chain is replaced with awk.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't
On 15 jan 2014, at 18:27, Volker Simonis volker.simo...@gmail.com wrote:
On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis
volker.simo...@gmail.com wrote:
Hi Staffan,
thanks for the review. Please find my comments inline:
On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen
Yes, that looks like a good solution.
/Staffan
On 15 jan 2014, at 17:34, Volker Simonis volker.simo...@gmail.com wrote:
Hi Staffan,
thanks for the review. Please find my comments inline:
On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen staffan.lar...@oracle.com
wrote:
Volker,
I’ve
On 15 jan 2014, at 18:52, Volker Simonis volker.simo...@gmail.com wrote:
On Wed, Jan 15, 2014 at 6:27 PM, Volker Simonis volker.simo...@gmail.com
wrote:
On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis
volker.simo...@gmail.com wrote:
Hi Staffan,
thanks for the review. Please find
Looks good!
Thanks,
/Staffan
On 15 jan 2014, at 19:23, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
Hi Everybody,
Please review small, test-only fix.
http://cr.openjdk.java.net/~dsamersoff/JDK-8024049/webrev.01/
fix summary:
grep/cut chain is replaced with awk.
--
Hi,
Please review this simple fix, the test needs more time to wait
Phaser.awaitAdvanceInterruptibly(...).
webrev: http://cr.openjdk.java.net/~sjiang/JDK-8029378/00/
bug: https://bugs.openjdk.java.net/browse/JDK-8029378
Thanks,
Shanliang
16 matches
Mail list logo
