Re: RFR(XS): JDK-8167034: Re-enable TestDaemonThread.java once JDK-8167001 is fixed

2016-10-13 Thread Chris Plummer
Thanks Serguei and Jesper! Chris On 10/13/16 3:27 PM, serguei.spit...@oracle.com wrote: It is good. Thanks, Serguei On 10/13/16 12:45, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8167034

Re: RFR(XS): JDK-8167034: Re-enable TestDaemonThread.java once JDK-8167001 is fixed

2016-10-13 Thread serguei.spit...@oracle.com
It is good. Thanks, Serguei On 10/13/16 12:45, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8167034 - diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++

Re: RFR(XS): JDK-8167034: Re-enable TestDaemonThread.java once JDK-8167001 is fixed

2016-10-13 Thread Jesper Wilhelmsson
Looks good! /Jesper Den 13/10/16 kl. 21:45, skrev Chris Plummer: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8167034 - diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++

RFR(XS): JDK-8167034: Re-enable TestDaemonThread.java once JDK-8167001 is fixed

2016-10-13 Thread Chris Plummer
Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8167034 - diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++ b/test/ProblemList.txt @@ -134,8 +134,6 @@

Re: RFR: 8158797: Test java/lang/management/MemoryMXBean/LowMemoryTest.java fails when GC is specified explicitly

2016-10-13 Thread Alexander Kulyakhtin
Hi Sergey, Thank you very much for the review. Best regards, Alexander - Original Message - From: serguei.spit...@oracle.com To: alexander.kulyakh...@oracle.com, dmitry.samers...@oracle.com, dmitry.dmitr...@oracle.com Cc: serviceability-dev@openjdk.java.net Sent: Thursday, October 13,

Re: RFR: 8158797: Test java/lang/management/MemoryMXBean/LowMemoryTest.java fails when GC is specified explicitly

2016-10-13 Thread serguei.spit...@oracle.com
Alexander, It looks good to me. Thanks, Serguei On 10/13/16 05:37, Alexander Kulyakhtin wrote: Dmitry, Thank you very much for the review. I still need a (R)eveiwer to approve the fix. Could someone, please, review this simple one-line change? Best regards, Alexander - Original

Re: RFR: 8158797: Test java/lang/management/MemoryMXBean/LowMemoryTest.java fails when GC is specified explicitly

2016-10-13 Thread Alexander Kulyakhtin
Dmitry, Thank you very much for the review. I still need a (R)eveiwer to approve the fix. Could someone, please, review this simple one-line change? Best regards, Alexander - Original Message - From: dmitry.dmitr...@oracle.com To: alexander.kulyakh...@oracle.com,

Re: RFR : 8167294 - MXBean javadoc should be updated to take modules into account

2016-10-13 Thread Alan Bateman
On 13/10/2016 07:42, Amit Sapre wrote: Hello, Please review this small javadoc update. Bug ID : https://bugs.openjdk.java.net/browse/JDK-8167294 Webrev : http://cr.openjdk.java.net/~jgeorge/sponsorships/8167294/webrev.00/

RFR : 8167294 - MXBean javadoc should be updated to take modules into account

2016-10-13 Thread Amit Sapre
Hello, Please review this small javadoc update. Bug ID : https://bugs.openjdk.java.net/browse/JDK-8167294 Webrev : http://cr.openjdk.java.net/~jgeorge/sponsorships/8167294/webrev.00/ Thanks, Amit