RFR: JDK-7107018: sun.jvm.hotspot.utilities.soql.JSJavaHeap.forEachClass incorrect test

2016-11-02 Thread Jini Susan George
Please review the trivial fix for the bug below (Unfortunately, the bug is marked confidential): https://bugs.openjdk.java.net/browse/JDK-7107018 Webrev: http://cr.openjdk.java.net/~jgeorge/7107018/webrev.00/index.html Thanks, - Jini Susan George

Re: RFR - JDK-8006078 : [findbugs] java.lang.management.ThreadInfo returns mutable objects

2016-11-02 Thread Frederic Parain
Looks good to me too. Fred On 11/02/2016 05:58 AM, Amit Sapre wrote: Hello, Can I have one more review for these changes ? -Original Message- From: David Holmes Sent: Saturday, October 29, 2016 12:22 AM To: Amit Sapre; serviceability-dev Subject: Re: RFR - JDK-8006078 : [findbugs]

RE: RFR - JDK-8006078 : [findbugs] java.lang.management.ThreadInfo returns mutable objects

2016-11-02 Thread Amit Sapre
Hello, Can I have one more review for these changes ? > -Original Message- > From: David Holmes > Sent: Saturday, October 29, 2016 12:22 AM > To: Amit Sapre; serviceability-dev > Subject: Re: RFR - JDK-8006078 : [findbugs] > java.lang.management.ThreadInfo returns mutable objects > > Hi