Hi Serguei,
Please find below my answers to the concerns you mentioned in the previous
email.
1.
> I have a concern about the checks for thread->is_exiting().
> - the lines 632-633 are useless as they do not really protect from returning
> an exiting thread
> It is interesting what might
Hi Erik,
Thanks for the additional details (I can't say I fully understand them :) ).
David
On 17/09/2019 11:39 pm, Erik Joelsson wrote:
Hello,
On 2019-09-17 05:59, David Holmes wrote:
Hi Magnus,
On 17/09/2019 9:26 pm, Magnus Ihse Bursie wrote:
On 2019-09-17 01:01, David Holmes wrote:
Hi
On 18/09/2019 12:10 am, Hohensee, Paul wrote:
Thanks, Serguei. :)
David, are you ok with the patch?
Yep, nothing further from me.
David
Paul
*From: *"serguei.spit...@oracle.com"
*Date: *Tuesday, September 17, 2019 at 2:26 AM
*To: *"Hohensee, Paul" , David Holmes
, Mandy Chung
*Cc:
Hello,
On 2019-09-17 05:59, David Holmes wrote:
Hi Magnus,
On 17/09/2019 9:26 pm, Magnus Ihse Bursie wrote:
On 2019-09-17 01:01, David Holmes wrote:
Hi Christoph,
Sorry for the delay getting back you.
cc'd build-dev to get some clarification on the below ...
On 12/09/2019 7:30 pm, Langer,
Hi Magnus,
On 17/09/2019 9:26 pm, Magnus Ihse Bursie wrote:
On 2019-09-17 01:01, David Holmes wrote:
Hi Christoph,
Sorry for the delay getting back you.
cc'd build-dev to get some clarification on the below ...
On 12/09/2019 7:30 pm, Langer, Christoph wrote:
Hi David,
please review an
On 2019-09-17 01:01, David Holmes wrote:
Hi Christoph,
Sorry for the delay getting back you.
cc'd build-dev to get some clarification on the below ...
On 12/09/2019 7:30 pm, Langer, Christoph wrote:
Hi David,
please review an enhancement which I've identified when working with
Hi Serguei and Thomas , thanks for the reviews.
>Should I open a bug for these ?
> Probably, two different bug are needed: hotspot/runtime and AWT.
Regarding the atoi on input provided by getenv - I’ll open 2 bugs for this.
Best regards, Matthias
From: serguei.spit...@oracle.com
Sent:
Hi Serguei,
On 17/09/2019 7:10 pm, serguei.spit...@oracle.com wrote:
Hi Daniil,
On 9/16/19 21:36, Daniil Titov wrote:
Hi David,
The case you have described is exact the reason why we still have a
code inside
ThreadsList::find_JavaThread_from_java_tid() method that does a linear
scan and
Hi Paul,
Thank you for refactoring and fixing the test.
It looks great now!
Thanks,
Serguei
On 9/15/19 02:52, Hohensee, Paul wrote:
Hi, Serguei, thanks for the review. New
webrev at
Hi Daniil,
On 9/16/19 21:36, Daniil Titov wrote:
Hi David,
The case you have described is exact the reason why we still have a code inside
ThreadsList::find_JavaThread_from_java_tid() method that does a linear scan and
adds
the requested thread to the thread table if it is not there (
Hi David,
It is a nice catch!
I would suggest to rewrite this fragment in a safe way:
95 {
96 MutexLocker ml(ThreadTableCreate_lock);
97 if (!_is_initialized) {
98 create_table(threads->length());
99
Hi Daniil,
Thank you for you patience in working on this issue!
Also, I like that the current thread related optimizations in
management.cpp were factored out.
It was a good idea to separate them.
I have a concern about the checks for
12 matches
Mail list logo
