resend, with correct subject line
On 6/18/20 8:12 PM, Jonathan Gibbons wrote:
Please review some changes to fix typos in some recent doc updates.
In two places, ${docRoot} is used instead of {@docRoot}
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8247784
Patch:
diff -r
Please review some changes to fix typos in some recent doc updates.
In two places, ${docRoot} is used instead of {@docRoot}
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8247784
Patch:
diff -r c5904de55565 src/jdk.jdi/share/classes/com/sun/jdi/Type.java
---
I have filed JDK-8247901, to cover an issue detected by doclint, regarding
two conflicting @return descriptions for a single method.
I can make the fix, if you want, but I need confirmation of which one should
be deleted and which should be retained. I can make an informed guess
(one of them
Hi Serguei,
I tested vmTestbase/nsk/jdi with webrev.03, all tests work fine on my laptop.
http://cr.openjdk.java.net/~ysuenaga/JDK-8247729/webrev.03/
Thanks,
Yasumasa
On 2020/06/19 9:22, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It would be even more safe to run the JDI tests as
[I've added runtime-dev to this SA review since understanding
interpreter invokes (code generated by
TemplateInterpreterGenerator::generate_normal_entry()) and stack walking
is probably more important than understanding SA.]
Hello,
Please help review the following:
Hi Yasumasa,
It would be even more safe to run the JDI tests as well.
The ObjectReference owningThread(), waitingThreads() and entryCount()
are based on this JVMTI function.
See:
https://docs.oracle.com/en/java/javase/14/docs/api/jdk.jdi/com/sun/jdi/ObjectReference.html
Thanks,
Serguei
On
Thanks Serguei!
I fixed them, and the change works fine on my laptop with serviceability/jvmti
and vmTestbase/nsk/jvmti on Linux x64.
I will push it later.
Yasumasa
On 2020/06/19 6:42, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
This looks good, nice simplification.
A couple of minor
+1
Thanks,
Serguei
On 6/18/20 16:16, Mandy Chung wrote:
+1
Mandy
On 6/18/20 4:00 PM, Jonathan Gibbons
wrote:
Please review a trivial fix for an invalid @see tag in
+1
Mandy
On 6/18/20 4:00 PM, Jonathan Gibbons wrote:
Please review a trivial fix for an invalid @see tag in
java/lang/management/package.html.
The presumed intent of the original is not a supported variant. The
fix is to remove the
`{@linkplain ...}` wrapper.
-- Jon
JBS:
+1
-Joe
On 6/18/2020 4:00 PM, Jonathan Gibbons wrote:
Please review a trivial fix for an invalid @see tag in
java/lang/management/package.html.
The presumed intent of the original is not a supported variant. The
fix is to remove the
`{@linkplain ...}` wrapper.
-- Jon
JBS:
Please review a trivial fix for an invalid @see tag in
java/lang/management/package.html.
The presumed intent of the original is not a supported variant. The fix
is to remove the
`{@linkplain ...}` wrapper.
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8247894
Patch inline:
diff -r
On 6/18/20 1:43 AM, David Holmes wrote:
On 18/06/2020 4:49 pm, Chris Plummer wrote:
On 6/17/20 10:29 PM, David Holmes wrote:
On 18/06/2020 3:13 pm, Chris Plummer wrote:
On 6/17/20 10:09 PM, David Holmes wrote:
On 18/06/2020 2:33 pm, Chris Plummer wrote:
On 6/17/20 7:43 PM, David Holmes
On 6/18/20 3:25 AM, Stefan Karlsson wrote:
Hi Coleen,
On 2020-06-17 23:25, coleen.phillim...@oracle.com wrote:
Summary: Remove JVMTI oops_do calls from JVMTI and GCs
Tested with tier1-3, also built shenandoah to verify shenandoah changes.
open webrev at
This request is for a pair of backports. 8231209 is the first (and primary),
8231968 is a minor cleanup. There are CSR’s for both. The effect is to add a
convenience method getCurrentThreadAllocatedBytes() to
com.sun.management.ThreadMXBean that can be implemented more efficiently than
the
Hi Daniel,
On 2020/06/18 23:38, Daniel D. Daugherty wrote:
On 6/18/20 5:07 AM, Yasumasa Suenaga wrote:
On 2020/06/18 17:36, David Holmes wrote:
On 18/06/2020 3:47 pm, Yasumasa Suenaga wrote:
Hi David,
Both ThreadsListHandle and ResourceMarks would use `Thread::current()` for
their
Hi David, Dan
Thanks for the comment!
I will update the comment as below before pushing:
// This needs to be performed at a safepoint to gather stable data
// because monitor owner / waiters might not be suspended.
Yasumasa
On 2020/06/18 23:09, David Holmes wrote:
On 19/06/2020 12:06
On 6/18/20 5:07 AM, Yasumasa Suenaga wrote:
On 2020/06/18 17:36, David Holmes wrote:
On 18/06/2020 3:47 pm, Yasumasa Suenaga wrote:
Hi David,
Both ThreadsListHandle and ResourceMarks would use
`Thread::current()` for their resource. It is set as default
parameter in c'tor.
Do you mean we
On 19/06/2020 12:06 am, Daniel D. Daugherty wrote:
On 6/18/20 10:04 AM, David Holmes wrote:
On 18/06/2020 11:55 pm, Daniel D. Daugherty wrote:
On 6/18/20 9:18 AM, David Holmes wrote:
On 18/06/2020 7:07 pm, Yasumasa Suenaga wrote:
On 2020/06/18 17:36, David Holmes wrote:
On 18/06/2020 3:47
On 6/18/20 10:04 AM, David Holmes wrote:
On 18/06/2020 11:55 pm, Daniel D. Daugherty wrote:
On 6/18/20 9:18 AM, David Holmes wrote:
On 18/06/2020 7:07 pm, Yasumasa Suenaga wrote:
On 2020/06/18 17:36, David Holmes wrote:
On 18/06/2020 3:47 pm, Yasumasa Suenaga wrote:
Hi David,
Both
On 18/06/2020 11:55 pm, Daniel D. Daugherty wrote:
On 6/18/20 9:18 AM, David Holmes wrote:
On 18/06/2020 7:07 pm, Yasumasa Suenaga wrote:
On 2020/06/18 17:36, David Holmes wrote:
On 18/06/2020 3:47 pm, Yasumasa Suenaga wrote:
Hi David,
Both ThreadsListHandle and ResourceMarks would use
On 6/18/20 9:18 AM, David Holmes wrote:
On 18/06/2020 7:07 pm, Yasumasa Suenaga wrote:
On 2020/06/18 17:36, David Holmes wrote:
On 18/06/2020 3:47 pm, Yasumasa Suenaga wrote:
Hi David,
Both ThreadsListHandle and ResourceMarks would use
`Thread::current()` for their resource. It is set as
On 18/06/2020 7:07 pm, Yasumasa Suenaga wrote:
On 2020/06/18 17:36, David Holmes wrote:
On 18/06/2020 3:47 pm, Yasumasa Suenaga wrote:
Hi David,
Both ThreadsListHandle and ResourceMarks would use
`Thread::current()` for their resource. It is set as default
parameter in c'tor.
Do you mean
On 6/17/20 9:46 PM, serguei.spit...@oracle.com wrote:
Hi Coleen,
Nice simplification!
It looks good to me.
I assume you will run the nsk.jvmti tests.
Thanks Serguei. The nsk jvmti tests are run with tier3, I believe but
I'll run them on the command line to verify.
thanks!
Coleen
On 2020-06-17 05:19, Ioi Lam wrote:
On 6/16/20 6:20 PM, David Holmes wrote:
Hi Ioi,
On 17/06/2020 6:14 am, Ioi Lam wrote:
https://bugs.openjdk.java.net/browse/JDK-8246019
http://cr.openjdk.java.net/~iklam/jdk16/8246019-avoid-PerfClassTraceTime.v01/
PerfClassTraceTime is (a rarely
On 2020/06/18 17:36, David Holmes wrote:
On 18/06/2020 3:47 pm, Yasumasa Suenaga wrote:
Hi David,
Both ThreadsListHandle and ResourceMarks would use `Thread::current()` for
their resource. It is set as default parameter in c'tor.
Do you mean we should it explicitly in c'tor?
Yes pass
On 18/06/2020 4:49 pm, Chris Plummer wrote:
On 6/17/20 10:29 PM, David Holmes wrote:
On 18/06/2020 3:13 pm, Chris Plummer wrote:
On 6/17/20 10:09 PM, David Holmes wrote:
On 18/06/2020 2:33 pm, Chris Plummer wrote:
On 6/17/20 7:43 PM, David Holmes wrote:
Hi Chris,
On 18/06/2020 6:34 am,
On 18/06/2020 3:47 pm, Yasumasa Suenaga wrote:
Hi David,
Both ThreadsListHandle and ResourceMarks would use `Thread::current()`
for their resource. It is set as default parameter in c'tor.
Do you mean we should it explicitly in c'tor?
Yes pass current_thread so we don't do the additional
Hi Coleen,
On 2020-06-17 23:25, coleen.phillim...@oracle.com wrote:
Summary: Remove JVMTI oops_do calls from JVMTI and GCs
Tested with tier1-3, also built shenandoah to verify shenandoah changes.
open webrev at http://cr.openjdk.java.net/~coleenp/2020/8247808.01/webrev
On 6/17/20 10:29 PM, David Holmes wrote:
On 18/06/2020 3:13 pm, Chris Plummer wrote:
On 6/17/20 10:09 PM, David Holmes wrote:
On 18/06/2020 2:33 pm, Chris Plummer wrote:
On 6/17/20 7:43 PM, David Holmes wrote:
Hi Chris,
On 18/06/2020 6:34 am, Chris Plummer wrote:
Hello,
Please help review
29 matches
Mail list logo
