RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr
The test searches for "JShellToolProvider" in the main thread's stack trace, which is pulled from an SA heap dump. Typically the main thread is blocked in Object.wait(), so SA can determine its stack trace. However, the wait has a 100ms timeout, so the thread does periodically wake up and does a few things before waiting again. If SA tries to get the stack trace while the thread is active, it may not be able to, and this causes the test to fail. I determined this only happens about 1 in 5000-1 runs. So as a fix I'm allowing the test to do one retry. That should make it extremely unlikely that we ever see this failure again. I also bumped up the amount of time the test waits before doing the heap dump from 2 seconds to 4 just to make absolutely sure the main thread is fully started before doing the heap dump. - Commit messages: - Retry heap dump if main thread stack trace is not present. Changes: https://git.openjdk.java.net/jdk/pull/6795/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6795=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269556 Stats: 26 lines in 1 file changed: 19 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/6795.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6795/head:pull/6795 PR: https://git.openjdk.java.net/jdk/pull/6795
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. hmmm, I thought we had taken care of that test. I will investigate - PR: https://git.openjdk.java.net/jdk18/pull/5
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 02:48:43 GMT, Jonathan Gibbons wrote: >> Please review this semi-automatic update for the nroff man pages for JDK 18. >> The changes update the version number, copyright year, and incorporate the >> changes from the latest upstream files. > > We will also want to regenerate any appropriate files if any more updates to > the man pages are made during the ramp down period. Hi @jonathan-gibbons , I have a couple of manpage related tasks for early in the 19 release cycle that will take care of updating the version number. Unfortunately for this change it looks like whomever did the source uodate to the javadoc manpage did not know about the test: test/langtools/jdk/javadoc/tool/CheckManPageOptions.java which is now failing on all platforms. :( I will file a bug. David - PR: https://git.openjdk.java.net/jdk18/pull/5
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk18/pull/5
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Hi David, The copyright year will naturally sort itself out in a few weeks time ;-) When these changes make their way down from 18 to 19, we will probably want to regenerate these files with 19-EA. -- Jon We will also want to regenerate any appropriate files if any more updates to the man pages are made during the ramp down period. - PR: https://git.openjdk.java.net/jdk18/pull/5
[jdk18] Integrated: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. This pull request has now been integrated. Changeset: ed5d53ae Author:Jonathan Gibbons URL: https://git.openjdk.java.net/jdk18/commit/ed5d53ae0eb0b12de11fb3d79ae0371c093ce434 Stats: 858 lines in 28 files changed: 448 ins; 146 del; 264 mod 8273179: Update nroff pages in JDK 18 before RC Reviewed-by: dholmes - PR: https://git.openjdk.java.net/jdk18/pull/5
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Hi Jon, This all looks good - I'm familiar with many of the changes made to the sources but not yet generated. We will have to be careful not to regress the copyright year or version if any subsequent updates are made before next year, or before the version loses the EA designator. Thanks, David - Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk18/pull/5
[jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
Please review this semi-automatic update for the nroff man pages for JDK 18. The changes update the version number, copyright year, and incorporate the changes from the latest upstream files. - Commit messages: - JDK-8273179: Update nroff pages in JDK 18 before RC Changes: https://git.openjdk.java.net/jdk18/pull/5/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18=5=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273179 Stats: 858 lines in 28 files changed: 448 ins; 146 del; 264 mod Patch: https://git.openjdk.java.net/jdk18/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/5/head:pull/5 PR: https://git.openjdk.java.net/jdk18/pull/5
[jdk18] Integrated: 8278521: ProblemList java/lang/management/ThreadMXBean/ThreadLists.java
On Thu, 9 Dec 2021 21:57:13 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/lang/management/ThreadMXBean/ThreadLists.java on all configs. This pull request has now been integrated. Changeset: d40e90b4 Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk18/commit/d40e90b4a1b55753a178d824c4c60209bc46efac Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8278521: ProblemList java/lang/management/ThreadMXBean/ThreadLists.java Reviewed-by: bpb - PR: https://git.openjdk.java.net/jdk18/pull/3
[jdk18] Integrated: 8278521: ProblemList java/lang/management/ThreadMXBean/ThreadLists.java
A trivial fix to ProblemList java/lang/management/ThreadMXBean/ThreadLists.java on all configs. - Commit messages: - 8278521: ProblemList java/lang/management/ThreadMXBean/ThreadLists.java Changes: https://git.openjdk.java.net/jdk18/pull/3/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18=3=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278521 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18/pull/3.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/3/head:pull/3 PR: https://git.openjdk.java.net/jdk18/pull/3
Re: [jdk18] Integrated: 8278521: ProblemList java/lang/management/ThreadMXBean/ThreadLists.java
On Thu, 9 Dec 2021 21:59:19 GMT, Brian Burkhalter wrote: >> A trivial fix to ProblemList >> java/lang/management/ThreadMXBean/ThreadLists.java on all configs. > > Marked as reviewed by bpb (Reviewer). @bplb - Thanks for the lightning fast review! - PR: https://git.openjdk.java.net/jdk18/pull/3
Re: [jdk18] Integrated: 8278521: ProblemList java/lang/management/ThreadMXBean/ThreadLists.java
On Thu, 9 Dec 2021 21:57:13 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/lang/management/ThreadMXBean/ThreadLists.java on all configs. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk18/pull/3
