Hi Ioi,
Regarding the changes in javaClasses.cpp, I saw that in your new code in
systemDictionaryShared.cpp, the
java_lang_Class::update_archived_mirror_native_pointers(m) won't be
called if MetaspaceShared::relocation_delta() is 0. But I noticed
there's another code path to
java_lang_Class:
On 4/16/20 11:12 AM, Ioi Lam wrote:
On 4/16/20 10:08 AM, Calvin Cheung wrote:
Hi Ioi,
Regarding the changes in javaClasses.cpp, I saw that in your new code
in systemDictionaryShared.cpp, the
java_lang_Class::update_archived_mirror_native_pointers(m) won't be
called if MetaspaceS
On 5/5/20 10:59 AM, Ioi Lam wrote:
Hi Yumin,
Looks good.
Just small nits. No need for new webrev.
[1] I think this should be named _libzip_loaded to be consistent with
other fields
static int libzip_loaded; // used to sync loading zip.
[2] This introduces dependency on atom
Looks good.
thanks,
Calvin
On 5/5/20 1:32 PM, Yumin Qi wrote:
Hi, Ioi and Calvin
There is an file classLoader.inline.hpp which also includes
atomic.hpp. I put load_zip_library_if_needed in it. Updated webrev:
http://cr.openjdk.java.net/~minqi/8237750/webrev-03/
Also, double checked the
:
Hi Calvin,
The changes look good.
Thanks
- Ioi
On 11/14/18 4:40 PM, Calvin Cheung wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8201375
webrev: http://cr.openjdk.java.net/~ccheung/8201375/webrev.00/
This change is for adding a diagnostic vm option
(AllowArchivingWithJavaAgent) to
ou wrote:
+1
Adding serviceability-dev mailing list. It would be good to have
this reviewed by the JVMTI experts also to make sure all cases are
covered.
Thanks,
Jiangli
On 11/15/18 9:29 AM, Ioi Lam wrote:
Hi Calvin,
The changes look good.
Thanks
- Ioi
On 11/14/18 4:40 PM, Calvin C
"Must enable AllowArchivingWithJavaAgent in order to run Java agent
during CDS dumping");*
*+ }*
Thanks,
Serguei
Thanks,
Serguei
On 11/16/18 10:18, Ioi Lam wrote:
On 11/16/18 9:45 AM, serguei.spit...@oracle.com wrote:
Hi Calvin,
On 11/16/18 09:26, Calvin Cheung wrote:
rent run.
thanks,
Calvin
Thanks,
Serguei
On 11/16/18 12:09 PM, Calvin Cheung wrote:
Hi Serguei,
I've updated the webrev based on your suggestions:
http://cr.openjdk.java.net/~ccheung/8201375/webrev.01/
Files changed since last time:
thead.cpp - your suggestion below
filemap.cpp - ad
Thanks, Serguei!
Calvin
On 11/16/18, 3:22 PM, serguei.spit...@oracle.com wrote:
Hi Calvin,
It looks good to me.
No need in new webrev if you update this comment as below.
Thanks,
Serguei
On 11/16/18 2:00 PM, Calvin Cheung wrote:
On 11/16/18, 1:04 PM, serguei.spit...@oracle.com wrote
Hi Ioi,
The following call is probably slower than before because it involves
reading from a jar file.
cfs = FileMapInfo::open_stream_for_jvmti(ik, CHECK_NULL);
It is probably ok since the above is called under the following condition:
if (JvmtiExport::should_post_class_file_load_hook())
Minor
bug: https://bugs.openjdk.java.net/browse/JDK-8204110
webrev: http://cr.openjdk.java.net/~ccheung/8204110/webrev.00/
For fixing the ClhsdbSymbol.java test, I've added dumping the symbols
from the sharedTable if it isn't null.
The change touches all 3 files in the webrev.
SymbolTable.java - a
Thanks for your review, Jini.
Calvin
On 6/7/18, 10:04 PM, Jini George wrote:
Your changes look good to me, Calvin.
Thanks,
Jini.
On 6/7/2018 10:24 PM, Calvin Cheung wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8204110
webrev: http://cr.openjdk.java.net/~ccheung/8204110/webrev.00
Thanks for your review, Serguei.
Calvin
On 6/8/18, 9:14 AM, serguei.spit...@oracle.com wrote:
+1
Thanks,
Serguei
On 6/7/18 22:04, Jini George wrote:
Your changes look good to me, Calvin.
Thanks,
Jini.
On 6/7/2018 10:24 PM, Calvin Cheung wrote:
bug: https://bugs.openjdk.java.net/browse
Thanks for your review, Ioi.
Calvin
On 6/8/18, 9:26 AM, Ioi Lam wrote:
Hi Calvin,
The changes look good to me. Thanks!
- Ioi
On 6/7/18 9:54 AM, Calvin Cheung wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8204110
webrev: http://cr.openjdk.java.net/~ccheung/8204110/webrev.00/
For
Looks good!
thanks,
Calvin
On 8/14/18, 4:50 PM, Ioi Lam wrote:
Please review this simple fix.
https://bugs.openjdk.java.net/browse/JDK-8207832
http://cr.openjdk.java.net/~iklam/jdk12/8207832_ClhsdbCDSCore_file_location.v01/
On Linux, the core file location can be controlled via
/proc/
Hi Ioi,
This is a very nice cleanup and looks good.
In the SA native code, I'm wondering instead of:
#include "../../../../hotspot/share/include/cds.h"
is it possible to omit the relative path and just have the following?
#include "cds.h"
I think it probably involves some makefile changes.
I
Hi Ioi,
Just a few minor comments. No need to see another webrev.
compactHashtable.cpp:
71 _num_entries ++;
extra space before ++
similarly in lines 80, 112, 123, 125
118 Entry tent = bucket->at(i);
It is clearer if 'tent' is just 'ent' since the code in this block is
not dealing w
Changeset: 72b7e96c1922
Author:twisti
Date: 2013-09-26 12:07 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/72b7e96c1922
8024545: make develop and notproduct flag values available in product builds
Reviewed-by: dholmes, kvn
! agent/src/share/classes/sun/jvm/hotspo
Changeset: ebfa5793d349
Author:katleman
Date: 2013-10-02 13:26 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ebfa5793d349
Added tag jdk8-b110 for changeset 6209b0ed51c0
! .hgtags
Changeset: 562a3d356de6
Author:amurillo
Date: 2013-10-04 14:10 -0700
URL:
Changeset: 02d171a3b5d1
Author:cl
Date: 2013-10-10 10:08 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/02d171a3b5d1
Added tag jdk8-b111 for changeset f6962730bbde
! .hgtags
Changeset: 4a845c7a4638
Author:amurillo
Date: 2013-10-11 13:00 -0700
URL:
Changeset: aeae561a6d0b
Author:cl
Date: 2013-10-17 09:40 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aeae561a6d0b
Added tag jdk8-b112 for changeset 0ed9a90f45e1
! .hgtags
Changeset: 23b8db5ea31d
Author:amurillo
Date: 2013-10-18 21:30 -0700
URL:
Changeset: f9d4ed6c88dd
Author:dholmes
Date: 2013-10-21 20:51 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f9d4ed6c88dd
8026872: [TESTBUG] Classes OOMCrashClass4000_1.class and
OOMCrashClass1960_2.class from runtime/ClassFile/ tests won't run on compact
profile
On Tue, 13 Oct 2020 06:46:27 GMT, Ioi Lam wrote:
>> **Problem:** when iterating over the cloned vtables, the original code
>> assumes that they are laid out consecutively in
>> memory. However, since
>> [JDK-8224509](https://bugs.openjdk.java.net/browse/JDK-8224509), the memory
>> allocated
On Tue, 22 Dec 2020 17:42:49 GMT, Daniel D. Daugherty
wrote:
> This is a trivial fix to ProblemList com/sun/jdi/AfterThreadDeathTest.java on
> Linux-X64.
Looks good and trivial.
-
Marked as reviewed by ccheung (Reviewer).
PR: https://git.openjdk.java.net/jdk16/pull/59
On Fri, 26 Feb 2021 00:03:40 GMT, Yumin Qi wrote:
> Hi, Please review
>
> Added jcmd option for dumping CDS archive during application runtime.
> Before this change, user has to dump shared archive in two steps: first run
> application with
> `java -XX:DumpLoadedClassList= `
> to c
On Wed, 24 Mar 2021 15:35:55 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>
On Wed, 24 Mar 2021 15:35:55 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>
On Wed, 24 Mar 2021 15:35:55 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>
On Mon, 29 Mar 2021 17:40:09 GMT, Harold Seigel wrote:
> Please review this change for JDK-8264193 to remove unneeded TRAPS parameters
> from modules and default methods files. Besides removing TRAPS,
> Modules::get_named_module() was changed to return an oop instead of a
> jobject, removing
On Tue, 13 Apr 2021 23:04:24 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>
On Tue, 13 Apr 2021 23:04:24 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>
On Thu, 24 Jun 2021 18:51:01 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList serviceability/dcmd/gc/RunFinalizationTest.java
> on Win-X64 and linux-aarch64.
One question.
test/hotspot/jtreg/ProblemList.txt line 113:
> 111:
> serviceability/jvmti/HeapMonitor/MyPackage/HeapMoni
On Thu, 24 Jun 2021 19:04:05 GMT, Daniel D. Daugherty
wrote:
>> test/hotspot/jtreg/ProblemList.txt line 113:
>>
>>> 111:
>>> serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java
>>> 8224150 generic-all
>>> 112: serviceability/jvmti/ModuleAwareAgents/ThreadStart/
On Thu, 24 Jun 2021 18:51:01 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList serviceability/dcmd/gc/RunFinalizationTest.java
> on Win-X64 and linux-aarch64.
Marked as reviewed by ccheung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/138
On Thu, 30 Sep 2021 16:23:34 GMT, Yumin Qi wrote:
>> Please review,
>> Refactor fundamental CDS FileMapHeader code for reliable reading of basic
>> info from shared archive.
>> With the change, it makes it possible to read an archive generated by
>> different version of hotspot. Also it is
On Wed, 6 Oct 2021 21:53:30 GMT, Yumin Qi wrote:
>> Please review,
>> Refactor fundamental CDS FileMapHeader code for reliable reading of basic
>> info from shared archive.
>> With the change, it makes it possible to read an archive generated by
>> different version of hotspot. Also it is p
On Fri, 10 Dec 2021 15:01:29 GMT, Harold Seigel wrote:
> Please review this change to obsolete deprecated CDS options UseSharedSpaces,
> RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The
> change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows
> and M
On Fri, 14 Jan 2022 17:41:20 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-x64.
LGTM.
-
Marked as reviewed by ccheung (Reviewer).
PR: https://git.openjdk.java.net/jdk18/pull/102
On Fri, 28 Jan 2022 01:53:09 GMT, Ioi Lam wrote:
> The discussion of CDS in the man pages need to be cleaned up and updated to
> match the latest functionalities and intended usage.
>
> For java.md:
>
> - Reorganized the flow of the doc: Overview -> How to use -> How to create ->
> Restricti
39 matches
Mail list logo
