Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Daniel Fuchs
On 5/29/13 1:18 PM, shanliang wrote: Jaroslav, Introspector.java - Line 496 - 515 It is good to do check: (Modifier.isPublic(c.getModifiers()) || MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN) but it is not necessary if an interface is not equal to clMBeanName. is it possible to

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Daniel Fuchs
On 5/29/13 4:44 PM, Jaroslav Bachorik wrote: On Wed 29 May 2013 03:38:59 PM CEST, Daniel Fuchs wrote: On 5/29/13 1:18 PM, shanliang wrote: Jaroslav, Introspector.java - Line 496 - 515 It is good to do check: (Modifier.isPublic(c.getModifiers

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Daniel Fuchs
On 5/29/13 7:17 PM, Jaroslav Bachorik wrote: On Wed 29 May 2013 05:33:21 PM CEST, Eamonn McManus wrote: I would recommend against changing the code to do additional calls to Class.forName during MBean introspection. As I recall we made the opposite change some years ago, both because Class.forNa

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-06-05 Thread Daniel Fuchs
On 6/5/13 3:55 PM, Jaroslav Bachorik wrote: class A extends B { ...} >class B implements AMBean {...} Yes, I see it now. However, when you check the JMX specification, page 50 onwards, the current implementation does not seem to be correct. "3. If MyClass is an instance of the DynamicMBean inte

hg: jdk8/tl/jaxp: 8013434: Xalan and Xerces internal ObjectFactory need rework

2013-06-06 Thread daniel . fuchs
Changeset: e93beba07830 Author:dfuchs Date: 2013-06-06 20:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e93beba07830 8013434: Xalan and Xerces internal ObjectFactory need rework Summary: With this changeset, DTMManager and XSLTCDTMManager will always use their own defau

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-06-07 Thread Daniel Fuchs
4:10 PM CEST, shanliang wrote: Daniel Fuchs wrote: On 6/5/13 3:55 PM, Jaroslav Bachorik wrote: class A extends B { ...} class B implements AMBean {...} Yes, I see it now. However, when you check the JMX specification, page 50 onwards, the current implementation does not seem to be corr

Re: RFR JDK-8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java

2013-06-17 Thread Daniel Fuchs
Hi Dan, 1. To be on the safe side I'd suggest to use: return Objects.hashCode(listener); rather than plain return listener.hashCode(). (I see that removeNotificationListener(...) does not check for null). 2. I wouldn't have changed WildcardListenerInfo.equals(); If you insist in changing i

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-06-18 Thread Daniel Fuchs
ES: " + failures); instead. best regards, -- daniel On 6/18/13 12:01 PM, Jaroslav Bachorik wrote: On 06/07/2013 11:07 AM, Daniel Fuchs wrote: http://cr.openjdk.java.net/~jbachorik/8010285/webrev.04 Hi Jaroslav, This looks good to me. I assume you've been running both the java.lang

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-06-18 Thread Daniel Fuchs
On 6/18/13 1:27 PM, Jaroslav Bachorik wrote: On Tue 18 Jun 2013 12:30:07 PM CEST, Jaroslav Bachorik wrote: On Tue 18 Jun 2013 12:25:35 PM CEST, Daniel Fuchs wrote: Hi Jaroslav, I've added the tests for the proper behaviour when the "com.sun.jmx.mbeans.allowNonPublic" system

Re: RFR JDK-8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java

2013-06-19 Thread Daniel Fuchs
! (I am not a reviewer). -- daniel -Dan On 06/17/2013 01:03 AM, Daniel Fuchs wrote: Hi Dan, 1. To be on the safe side I'd suggest to use: return Objects.hashCode(listener); rather than plain return listener.hashCode(). (I see that removeNotificationListener(...) does not check for null).

Re: Codereview for JDK-8016221: A unit test should not use a fixed port to run a jmx connector (JDCMD MBean Tests)

2013-06-19 Thread Daniel Fuchs
Hi Shanliang, This change looks good. There's probably a subtle difference between invoking a command through a user created JMXConnectorServer as opposed as sending it through the default agent - but I don't think that's what matters here. cheers, -- daniel On 6/12/13 9:56 AM, shanliang wrote

hg: jdk8/tl/jdk: 8014045: test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently

2013-07-01 Thread daniel . fuchs
Changeset: 3aa541b50a64 Author:dfuchs Date: 2013-07-01 11:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3aa541b50a64 8014045: test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently Summary: this test was failing because it didn't ta

hg: jdk8/tl/jdk: 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger

2013-07-02 Thread daniel . fuchs
Changeset: 020f023f87d1 Author:dfuchs Date: 2013-07-02 11:30 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/020f023f87d1 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger Summary: This patch makes sure that LoggerContext instances crea

hg: jdk8/tl/jdk: 7184195: java.util.logging.Logger.getGlobal().info() doesn't log without configuration

2013-07-02 Thread daniel . fuchs
Changeset: 70bff2d12af0 Author:dfuchs Date: 2013-07-02 19:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70bff2d12af0 7184195: java.util.logging.Logger.getGlobal().info() doesn't log without configuration Summary: Due to subtle synchronization issues between LogManager &

Re: RR(S): 8011038 sourceObj validation during desereliazation of RelationNotification should be relaxed

2013-07-03 Thread Daniel Fuchs
Hi Dmitry, This looks reasonable to me. You should probably log an RFE on javax.management, to make RelationNotification override setSource() and throw IAE when source is null, so that the behavior of setSource is consistent with the constructor. That would be a spec change - but maybe it's som

Re: jmx-dev RFR: 8019584 javax/management/remote/mandatory/loading/MissingClassTest.java failed in nightly against jdk7u45: java.io.InvalidObjectException: Invalid notification: null

2013-07-15 Thread Daniel Fuchs
Hi Jaroslav, This looks reasonable. I assume you have run the JCK to verify that it doesn't break anything else? best regards, -- daniel On 7/11/13 1:48 PM, Jaroslav Bachorik wrote: Please, review the change. http://cr.openjdk.java.net/~jbachorik/8019584/webrev.00/ The combination of the fi

Re: jmx-dev RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object

2013-07-18 Thread Daniel Fuchs
Hi Jaroslav, Looks good overall. Small nit: You should remove the comment lines 322-327 in ModelMBeanInfoSupport.java since your changes make it obsolete. Also the copyright year in ImmutableDataTest should be 2013 (not 2005). No need for another round of review. -- daniel On 7/18/13 11:54

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-23 Thread Daniel Fuchs
Hi Jaroslav, This looks like a tough problem as it is altogether possible that some of the VM daemon threads will terminate during the duration of the call - and if that's the case, the condition: new peak >= old peak + delta might not even be true. I am not a VM specialist so I don't know whe

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-23 Thread Daniel Fuchs
On 7/23/13 11:35 AM, Jaroslav Bachorik wrote: As I wrote in my reply to David the offending thread is j.u.l.LogManager$Cleaner which kicks in randomly. Argh... Logging again :-) This would confirm my observations that the discrepancy is always at most one thread more than expected. What you

Re: RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-23 Thread Daniel Fuchs
On 7/23/13 11:45 AM, David Holmes wrote: On 23/07/2013 7:24 PM, Jaroslav Bachorik wrote: > The result is that the offender is j.u.l.LogManager$Cleaner thread. I > am attaching the profiler snapshot (can be opened in eg. jvisualvm) That doesn't quite make sense. The Cleaner thread is a shutdown

Re: RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-23 Thread Daniel Fuchs
On 7/24/13 8:01 AM, Mandy Chung wrote: On 7/23/2013 5:54 PM, David Holmes wrote: On 23/07/2013 7:53 PM, Daniel Fuchs wrote: On 7/23/13 11:45 AM, David Holmes wrote: On 23/07/2013 7:24 PM, Jaroslav Bachorik wrote: > The result is that the offender is j.u.l.LogManager$Cleaner thread. I &

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-25 Thread Daniel Fuchs
On 7/25/13 2:28 PM, Jaroslav Bachorik wrote: For the time being I propose modifying the test to be less race-prone in java and adding a timeout of 500ms after terminating a number of threads. The test modifications are at http://cr.openjdk.java.net/~jbachorik/8020875/webrev.02 Thanks, Hi Jar

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-25 Thread Daniel Fuchs
BTW - I wonder if you should add 8021335 in the @bug line. -- daniel On 7/25/13 2:37 PM, Daniel Fuchs wrote: On 7/25/13 2:28 PM, Jaroslav Bachorik wrote: For the time being I propose modifying the test to be less race-prone in java and adding a timeout of 500ms after terminating a number of

hg: jdk8/tl/jdk: 8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java is failing intermittently

2013-08-13 Thread daniel . fuchs
Changeset: 78c102c3eefc Author:dfuchs Date: 2013-08-13 16:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78c102c3eefc 8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java is failing intermittently Reviewed-by: mchung, dholmes ! test/java/util/logging/bun

Re: Codereview requested: 6566891 RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed

2013-08-20 Thread Daniel Fuchs
On 8/20/13 11:12 PM, shanliang wrote: Thanks Daniel and Erik for the comments, here is new version: http://cr.openjdk.java.net/~sjiang/JDK-6566891/01/ This new version looks reasonable. I guess you could dispense of the new nullSubjectConnRef by just using 'null' as key in the WeakHashMap (a

Re: Codereview requested: 6566891 RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed

2013-08-21 Thread Daniel Fuchs
On 8/21/13 10:27 AM, shanliang wrote: Jaroslav Bachorik wrote: On 08/21/2013 12:00 AM, Daniel Fuchs wrote: On 8/20/13 11:12 PM, shanliang wrote: Thanks Daniel and Erik for the comments, here is new version: http://cr.openjdk.java.net/~sjiang/JDK-6566891/01/ This new version looks

Re: RFR: 8272120: Avoid looking for standard encodings in "java." modules

2021-08-11 Thread Daniel Fuchs
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote: > This is the continuation of JDK-8233884 and JDK-8271456. This change affects > fewer cases so I fix all "java." modules at once. > > In many places standard charsets are looked up via their names, for example: > absolutePath.getBytes("U

Re: RFR: 8272120: Avoid looking for standard encodings in "java." modules

2021-08-11 Thread Daniel Fuchs
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote: > This is the continuation of JDK-8233884 and JDK-8271456. This change affects > fewer cases so I fix all "java." modules at once. > > In many places standard charsets are looked up via their names, for example: > absolutePath.getBytes("U

Re: RFR: 8272805: Avoid looking up standard charsets [v2]

2021-08-23 Thread Daniel Fuchs
On Sun, 22 Aug 2021 23:02:06 GMT, Sergey Bylokhov wrote: >> This is the continuation of JDK-8233884, JDK-8271456, and JDK-8272120. >> >> In many places standard charsets are looked up via their names, for example: >> absolutePath.getBytes("UTF-8"); >> >> This could be done more efficiently(up t

Re: RFR: 8274168: Avoid String.compareTo == 0 to check String equality in java.management [v2]

2021-09-23 Thread Daniel Fuchs
On Thu, 23 Sep 2021 08:00:25 GMT, Andrey Turbanov wrote: >> Cleanup places, where String.compareTo is used to check String's equality. >> Instead String.equals or switch expression could be used. They are faster >> and code is cleaner. > > Andrey Turbanov has updated the pull request incrementa

Re: RFR: 8274464: Remove redundant stream() call before forEach in java.* modules

2021-09-29 Thread Daniel Fuchs
On Wed, 15 Sep 2021 07:12:25 GMT, Andrey Turbanov wrote: > 8274464: Remove redundant stream() call before forEach in java.* modules LGTM - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5520

Re: RFR: 8274757: Cleanup unnecessary calls to Throwable.initCause() in java.management module

2021-10-05 Thread Daniel Fuchs
On Thu, 16 Sep 2021 20:45:36 GMT, Andrey Turbanov wrote: > Pass cause exception as constructor parameter is shorter and easier to read. Nice simplification. - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5552

Re: RFR: 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management [v2]

2021-10-06 Thread Daniel Fuchs
On Fri, 1 Oct 2021 21:12:57 GMT, Andrey Turbanov wrote: >> There are a few places in code, where manual `for` loop is used with >> Iterator to iterate over Collection. >> Instead of manual `for` cycles, it's preferred to use enhanced-for cycle >> instead: it's less verbose, makes code easier t

Re: RFR: 8275322: Change nested classes in java.management to static nested classes

2021-10-15 Thread Daniel Fuchs
On Fri, 15 Oct 2021 06:43:13 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which can be avoided. Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5962

Re: RFR: 8280010: Remove double buffering of InputStream for Properties.load

2022-01-14 Thread Daniel Fuchs
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote: > `Properties.load` uses `java.util.Properties.LineReader`. LineReader already > buffers input stream. Hence wrapping InputStream in BufferedInputStream is > redundant. Changes to `java.util.logging` look fine. - PR: https:

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-24 Thread Daniel Fuchs
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by dfuchs (Reviewer). LGTM. I hope in the future IDEs will pick that rule up and offer some help when writing `{@link }` `@see`... - PR: https://git

Re: RFR: 8076089: Cleanup: Inline & remove sun.management.Util.newException

2022-01-26 Thread Daniel Fuchs
On Wed, 26 Jan 2022 04:35:58 GMT, Jaikiran Pai wrote: > Can I please get a review for this cleanup that's requested in > https://bugs.openjdk.java.net/browse/JDK-8076089? > > The change here removes a package private method > `sun.management.Util.newException(Exception e)` and inlines its > i

Re: RFR: 6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java

2022-02-07 Thread Daniel Fuchs
On Mon, 7 Feb 2022 17:28:29 GMT, Kevin Walls wrote: > Trivial comment and exception text update, correcting a bug ID to make more > sense. LGTM - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7371

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-10 Thread Daniel Fuchs
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 For simple webserver resource files - should the copyright year be 2022? - PR: https://git.openjdk.java.net/jdk/pull/7765

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-10 Thread Daniel Fuchs
On Thu, 10 Mar 2022 17:00:09 GMT, Naoto Sato wrote: > IIRC, localized resource files should have the same copyright year as the > base English one. That's what I was told by the l10n engineer when I had the > same comment. Thanks Naoto! I have no objection then. - PR: https://git

Re: RFR: 8283092: JMX subclass permission check redundant with strong encapsulation

2022-03-16 Thread Daniel Fuchs
On Tue, 15 Mar 2022 20:22:16 GMT, Kevin Walls wrote: > Removing permission checks which, in the presence of a Security Manager, > would check for a RuntimePermission "className.subclass". This was to > prevent subclassing these classes, but is no longer necessary with strong > encapsulation f

Re: RFR: 8283254: Remove redundant class jdk/internal/agent/spi/AgentProvider

2022-03-23 Thread Daniel Fuchs
On Tue, 22 Mar 2022 21:19:20 GMT, Kevin Walls wrote: > There are no uses of jdk/internal/agent/spi/AgentProvider, since the SNMP > agent was removed ( 8071367 ): this class should be removed. It is not a > public interface. > > Remove > src/jdk.management.agent/share/classes/jdk/internal/age

Re: RFR: 8284161: Implementation of Virtual Threads (Preview)

2022-04-11 Thread Daniel Fuchs
On Fri, 8 Apr 2022 13:43:39 GMT, Alan Bateman wrote: > This is the implementation of JEP 425: Virtual Threads (Preview); TBD which > JDK version to target. > > We will refresh this PR periodically to pick up changes and fixes from the > loom repo. > > Most of the new mechanisms in the HotSpot

Re: RFR: 8284161: Implementation of Virtual Threads (Preview)

2022-04-13 Thread Daniel Fuchs
On Tue, 12 Apr 2022 13:02:44 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/io/BufferedReader.java line 101: >> >>> 99: */ >>> 100: public BufferedReader(Reader in, int sz) { >>> 101: Objects.requireNonNull(in); >> >> Not sure if that even matters - but there will

Re: RFR: 8285366: Fix typos in serviceability

2022-04-21 Thread Daniel Fuchs
On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on modules owned by the serviceability team > (`java.instrument java.management.rmi java.management jdk.attach > jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi > jdk.jdwp.agent jdk.jstatd jdk.

Re: RFR: 8285366: Fix typos in serviceability

2022-04-21 Thread Daniel Fuchs
On Thu, 21 Apr 2022 14:03:39 GMT, Daniel Fuchs wrote: >> I ran `codespell` on modules owned by the serviceability team >> (`java.instrument java.management.rmi java.management jdk.attach >> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi >> j

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v7]

2022-04-26 Thread Daniel Fuchs
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces

2022-04-27 Thread Daniel Fuchs
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote: > To enable more complete doclint checking (courtesy @jonathan-gibbons), please > review this PR to add type-level @param tags where they are missing. > > To the maintainers of java.util.concurrent, those changes could be separated > out in an

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v7]

2022-04-27 Thread Daniel Fuchs
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v7]

2022-04-27 Thread Daniel Fuchs
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

2022-04-27 Thread Daniel Fuchs
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces [v3]

2022-04-28 Thread Daniel Fuchs
On Thu, 28 Apr 2022 01:34:19 GMT, Joe Darcy wrote: >> To enable more complete doclint checking (courtesy @jonathan-gibbons), >> please review this PR to add type-level @param tags where they are missing. >> >> To the maintainers of java.util.concurrent, those changes could be separated >> out

Re: RFR: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable [v2]

2022-05-10 Thread Daniel Fuchs
On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote: >> Method `Class.isAssignableFrom` is often used in form of: >> >> if (clazz.isAssignableFrom(obj.getClass())) { >> Such condition could be simplified to more shorter and performarnt code >> >> if (clazz.isInstance(obj)) { >>

Re: RFR: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable [v2]

2022-05-10 Thread Daniel Fuchs
On Tue, 10 May 2022 11:31:16 GMT, Andrey Turbanov wrote: >> src/java.desktop/share/classes/javax/imageio/spi/ServiceRegistry.java line >> 230: >> >>> 228: List l = new ArrayList<>(); >>> 229: for (Class c : categoryMap.keySet()) { >>> 230: if (c.isInstance(provider))

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Daniel Fuchs
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Logging/JNDI OK - Marked as revi

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v2]

2022-05-20 Thread Daniel Fuchs
On Fri, 20 May 2022 11:32:14 GMT, Alan Bateman wrote: >> This is a test-only change to add some test infrastructure and improve the >> testing of thread dumps in JSON format. The new tests added by JEP 425 for >> this thread dump format search the JSON text for strings but don't parse it >> co

hg: jdk7/tl/jdk: 6651382: The Java JVM SNMP provider reports incorrect stats when asked for multiple OIDs

2008-03-03 Thread daniel . fuchs
Changeset: d8b6af0f01f6 Author:dfuchs Date: 2008-03-03 12:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d8b6af0f01f6 6651382: The Java JVM SNMP provider reports incorrect stats when asked for multiple OIDs Summary: The JvmMemPoolEntryImpl must use the row index when cach

Re: 6610094: Add generic support for platform MXBeans of any type

2008-04-03 Thread Daniel Fuchs
Hy Mandy, Here are my comment. 1) ManagementFactory.java: lines 103-106 I am not sure I really like the idea of adding new methods to existing interfaces. 2) Logging.java: The implementation of getObjectName() is strange - I would have expected the ObjectName to be stored in a stati

hg: jdk7/tl/jdk: 6673853: LegacyIntrospectorTest is testing an old deprecated com.sun API not present in OpenJDK.

2008-05-29 Thread daniel . fuchs
Changeset: b64e68bf6b0b Author:dfuchs Date: 2008-05-29 15:33 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b64e68bf6b0b 6673853: LegacyIntrospectorTest is testing an old deprecated com.sun API not present in OpenJDK. Summary: Removed test from open test suite - the correspo

hg: jdk7/tl/jdk: 6592586: RequiredModelMBean prints a WARNING message when calling getAttributes() for a non-existing attr

2008-05-30 Thread daniel . fuchs
Changeset: 6ca4564520e7 Author:dfuchs Date: 2008-05-30 14:35 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6ca4564520e7 6592586: RequiredModelMBean prints a WARNING message when calling getAttributes() for a non-existing attr Summary: Switched traces to FINER - except when

hg: jdk7/tl/jdk: 6402254: Revisit ModelMBean DescriptorSupport implementation of equals and hashCode.

2008-07-29 Thread daniel . fuchs
Changeset: 8c667d55b79e Author:dfuchs Date: 2008-07-29 19:21 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8c667d55b79e 6402254: Revisit ModelMBean DescriptorSupport implementation of equals and hashCode. Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/mbeanserver/Ut

hg: jdk7/tl/jdk: 6730926: Document that create/registerMBean can throw RuntimeMBeanException from postRegister

2008-07-31 Thread daniel . fuchs
Changeset: 914370f03119 Author:dfuchs Date: 2008-07-31 12:41 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/914370f03119 6730926: Document that create/registerMBean can throw RuntimeMBeanException from postRegister Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/inter

hg: jdk7/tl/jdk: 6689505: Improve MBeanServerNotification.toString

2008-07-31 Thread daniel . fuchs
Changeset: 7622f1de1486 Author:dfuchs Date: 2008-07-31 14:20 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7622f1de1486 6689505: Improve MBeanServerNotification.toString Reviewed-by: emcmanus ! src/share/classes/javax/management/MBeanServerNotification.java + test/javax/man

hg: jdk7/tl/jdk: 6616825: JMX query returns no value in 1.0 compatibility mode - deserialization bug in readObject()

2008-07-31 Thread daniel . fuchs
Changeset: 98caad5c563c Author:dfuchs Date: 2008-07-31 17:38 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98caad5c563c 6616825: JMX query returns no value in 1.0 compatibility mode - deserialization bug in readObject() Reviewed-by: emcmanus ! src/share/classes/javax/manag

Need reviewer for 1-liner fix: 6732192: CORE_PKGS.gmk: need to declare javax.management.event in the CORE_PKGS variable

2008-07-31 Thread Daniel Fuchs
See attached diff... 5108776 has added a new public javax.management.event package. The javax.management.event package must also be declared in CORE_PKGS.gmk in order to be included in the javadoc. cheers, -- daniel http://blogs.sun.com/jmxetc diff --git a/make/docs/CORE_PKGS.gmk b/make/docs/CO

hg: jdk7/tl/jdk: 6732192: CORE_PKGS.gmk: need to declare javax.management.event in the CORE_PKGS variable

2008-08-01 Thread daniel . fuchs
Changeset: e0dc076d99b8 Author:dfuchs Date: 2008-08-01 11:41 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0dc076d99b8 6732192: CORE_PKGS.gmk: need to declare javax.management.event in the CORE_PKGS variable Reviewed-by: emcmanus ! make/docs/CORE_PKGS.gmk

hg: jdk7/tl/jdk: 6733294: MBeans tab - UI issues with writable attributes

2008-08-08 Thread daniel . fuchs
Changeset: 233f8854d8b4 Author:dfuchs Date: 2008-08-08 14:24 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/233f8854d8b4 6733294: MBeans tab - UI issues with writable attributes Reviewed-by: emcmanus ! make/netbeans/jconsole/build.properties ! make/netbeans/jconsole/build.xm

hg: jdk7/tl/jdk: 5072476: RFE: support cascaded (federated) MBean Servers; ...

2008-09-04 Thread daniel . fuchs
Changeset: 9145ff046bb4 Author:dfuchs Date: 2008-09-04 14:46 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9145ff046bb4 5072476: RFE: support cascaded (federated) MBean Servers 6299231: Add support for named MBean Servers Summary: New javax.management.namespace package. Revi

hg: jdk7/tl/jdk: 6745832: jmx namespaces: Some refactoring/commenting would improve code readability.

2008-09-09 Thread daniel . fuchs
Changeset: 5778303e2e14 Author:dfuchs Date: 2008-09-09 17:01 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5778303e2e14 6745832: jmx namespaces: Some refactoring/commenting would improve code readability. Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/interceptor/De

hg: jdk7/tl/jdk: 6746754: jmx namespace: test for leading separator missing; ...

2008-09-10 Thread daniel . fuchs
Changeset: 3e7b9a0f3a6f Author:dfuchs Date: 2008-09-10 16:27 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3e7b9a0f3a6f 6746754: jmx namespace: test for leading separator missing 6669137: RFE: InstanceNotFoundException should have a constructor that takes an ObjectName 6746

hg: jdk7/tl/jdk: 6747899: jmx namespaces: hooks for permission checks should be defined in HandlerInterceptor

2008-09-12 Thread daniel . fuchs
Changeset: 6a49dd6635ba Author:dfuchs Date: 2008-09-12 17:58 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a49dd6635ba 6747899: jmx namespaces: hooks for permission checks should be defined in HandlerInterceptor Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/namesp

hg: jdk7/tl/jdk: 6747983: jmx namespace: unspecified self-link detection logic

2008-09-12 Thread daniel . fuchs
Changeset: 09a7e38337e9 Author:dfuchs Date: 2008-09-12 19:06 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/09a7e38337e9 6747983: jmx namespace: unspecified self-link detection logic Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/namespace/NamespaceInterceptor.java !

hg: jdk7/tl/jdk: 6748745: JConsole: plotters don't resize well when the window is resized

2008-09-17 Thread daniel . fuchs
Changeset: 044bfa235270 Author:dfuchs Date: 2008-09-17 13:40 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/044bfa235270 6748745: JConsole: plotters don't resize well when the window is resized Summary: part of the fix was contributed by jfdenise Reviewed-by: jfdenise ! src/

hg: jdk7/tl/jdk: 6332953: JMX agent should bind to loopback address when starting the local connector server

2008-10-09 Thread daniel . fuchs
Changeset: 6a76dcaf15e3 Author:dfuchs Date: 2008-10-09 14:10 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a76dcaf15e3 6332953: JMX agent should bind to loopback address when starting the local connector server Reviewed-by: emcmanus ! src/share/classes/sun/management/jmxr

hg: jdk7/tl/jdk: 6758165: ConnectorBootstrap.DefaultValues should have a default value for USE_LOCAL_ONLY

2008-10-10 Thread daniel . fuchs
Changeset: f50f9b0d18a8 Author:dfuchs Date: 2008-10-10 10:58 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f50f9b0d18a8 6758165: ConnectorBootstrap.DefaultValues should have a default value for USE_LOCAL_ONLY Reviewed-by: alanb, emcmanus ! src/share/classes/sun/management/

hg: jdk7/tl/jdk: 6683213: CounterMonitor's derived Gauge badly initialized

2008-11-14 Thread daniel . fuchs
Changeset: 67718d2bd49c Author:dfuchs Date: 2008-11-14 17:22 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/67718d2bd49c 6683213: CounterMonitor's derived Gauge badly initialized Reviewed-by: emcmanus ! src/share/classes/javax/management/monitor/CounterMonitor.java ! src/sha

hg: jdk7/tl/jdk: 6774170: LocalRMIServerSocketFactory should protect against ServerSocket.accept().getInetAddress() being null

2008-11-21 Thread daniel . fuchs
Changeset: 97e2e87aa035 Author:dfuchs Date: 2008-11-21 18:18 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/97e2e87aa035 6774170: LocalRMIServerSocketFactory should protect against ServerSocket.accept().getInetAddress() being null Reviewed-by: emcmanus, jfdenise ! src/share

hg: jdk7/tl/jdk: 6319823: new mbean register/unregister notification for groups of mbeans; ...

2008-12-04 Thread daniel . fuchs
Changeset: a99a2d2f3249 Author:dfuchs Date: 2008-12-04 17:58 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a99a2d2f3249 6319823: new mbean register/unregister notification for groups of mbeans 6779698: Merge error caused duplicate example code in MBeanServerNotification Revi

hg: jdk7/tl/jdk: 6768935: Clarify the behaviour of ObjectName pattern matching with regards to namespaces

2008-12-09 Thread daniel . fuchs
Changeset: 61e73bc43e72 Author:dfuchs Date: 2008-12-09 20:20 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/61e73bc43e72 6768935: Clarify the behaviour of ObjectName pattern matching with regards to namespaces Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/intercepto

hg: jdk7/tl/jdk: 3 new changesets

2009-03-18 Thread daniel . fuchs
Changeset: fa87de6b1ac3 Author:dfuchs Date: 2009-03-12 15:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa87de6b1ac3 6661448: Make the SNMP agent optional when OPENJDK=true and IMPORT_BINARY_PLUGS=false Reviewed-by: mchung, ohair ! make/com/sun/jmx/Makefile ! make/java/

<    1   2   3   4