Hi Jesper,
Thanks for opening that issue, if this is implemented
it will help a lot!
Best regards,
Goetz.
> -Original Message-
> From: Jesper Wilhelmsson
> Sent: Thursday, October 1, 2020 11:35 PM
> To: Lindenmaier, Goetz
> Cc: Leonid Mesnik ; serv
Hi,
Please open up a dummy copy JBS issue without confidential
information if you fix a closed, internal Oracle bug.
I missed this before, I only saw it is closed when
this was pushed today.
It is really annoying to still see closed bugs.
I had hoped skara would help to avoid this.
Please find
Hi Christoph,
Looks good to me 😊
Best regards,
Goetz.
-Original Message-
From: nio-dev On Behalf Of Christoph Langer
Sent: Montag, 7. September 2020 06:22
To: hotspot-...@openjdk.java.net; net-...@openjdk.java.net;
nio-...@openjdk.java.net; serviceability-dev@openjdk.java.net
Subjec
Hi Richard,
Thanks for the new webrev.
The small improvements are fine, too.
Reviewed from my side.
Best regards,
Goetz.
> -Original Message-
> From: Reingruber, Richard
> Sent: Thursday, August 27, 2020 10:33 PM
> To: Lindenmaier, Goetz ; serviceability-
> d...@o
rev needed)
Best regards,
Goetz.
-Original Message-
From: Reingruber, Richard
Sent: Dienstag, 18. August 2020 10:44
To: Lindenmaier, Goetz ;
serviceability-dev@openjdk.java.net; hotspot-compiler-...@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net
Subject: RE: RFR(L) 82277
Hi Richard,
Thanks for your two further explanations in the other thread.
That made the points clear to me.
> > I was not that happy with the names saying not_global_escape
> > and similar. I now agreed you have to use the terms of the escape
> > analysis (NoEscape ArgEscape= throughout the run
Hi Richard,
Thanks for the quick reply.
> > > With DeoptimizeObjectsALot enabled internal threads are started that
> > > deoptimize frames and
> > > objects. The number of threads started are given with
> > > DeoptimizeObjectsALotThreadCountAll and
> > > DeoptimizeObjectsALotThreadCountSing
Hi Richard,
> I'll answer to the obvious things in this mail now.
> I'll go through the code thoroughly again and write
> a review of my findings thereafter.
As promised a detailed walk-throug, but without any major findings:
c1_IR.hpp: ok
ci_Env.h|cpp: ok
compiledMethod.cpp, nmethod.cpp: ok
debu
Hi Richard,
I'll answer to the obvious things in this mail now.
I'll go through the code thoroughly again and write
a review of my findings thereafter.
> So here is the new webrev.6
>
> Webrev.6:
> http://cr.openjdk.java.net/~rrich/webrevs/2019/8227745/webrev.6/
> Delta:
> http://cr.openjdk.ja
HI Ralf,
Thanks for the info.
Looks good, in my eyes ready to be pushed.
Best regards,
Goetz.
-Original Message-
From: Schmelter, Ralf
Sent: Montag, 8. Juni 2020 11:38
To: Lindenmaier, Goetz ; Langer, Christoph
Cc: serviceability-dev@openjdk.java.net; hotspot-runtime
d the relative poor performance of
> deflate() ensures that at least 5 to 10 threads will probably always
> be active ;)
Ok, thanks.
Best regards,
Goetz.
From: Lindenmaier, Goetz <mailto:goetz.lindenma...@sap.com>
Sent: Wednesday, June 3
Hi Ralf,
I had a look at your change, webrev.3.
Thanks for contributing this!
Overall, a nicely engineered piece of work. Thus, my
comments are mostly minor details:
diagnosticCommand.hpp
ok.
diagnosticCommand.cpp:
l.510
I would be a bit more precise in the comment:
..."9 the slowest level
rtin 😊)
Best regards,
Goetz.
> -Original Message-
> From: Reingruber, Richard
> Sent: Wednesday, April 1, 2020 8:15 AM
> To: Doerr, Martin ; 'Robbin Ehn'
> ; Lindenmaier, Goetz
> ; David Holmes ;
> Vladimir Kozlov (vladimir.koz...@oracle.com)
Hi,
I had a look at the progress of this change. Nothing
happened since Richard posted his update using more
handshakes [1].
But we (SAP) would appreciate a lot if this change could
be successfully reviewed and pushed.
I think there is basic understanding that this
change is helpful. It fixes a
Hi David,
thanks for adding our failures.
Best regards,
Goetz.
> -Original Message-
> From: David Holmes
> Sent: Donnerstag, 7. November 2019 13:24
> To: Lindenmaier, Goetz ; serviceability-dev
> ; hotspot-runtime-
> d...@openjdk.java.net
> Subject: Re: RFR:
Hi David,
we also see these failures in our CI. It is intermittent and on all platforms.
It happens since Nov 4.
We saw the following ones you already listed:
vmTestbase/nsk/jvmti/scenarios/allocation/AP12/ap12t001/TestDescription.java
vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t005/Test
essage-
> From: Doerr, Martin
> Sent: Freitag, 26. Juli 2019 13:02
> To: serviceability-dev@openjdk.java.net; hotspot-runtime-
> d...@openjdk.java.net; Lindenmaier, Goetz ;
> Gustavo Romero
> Subject: RFR(S): 8228649: [PPC64] SA reads wrong slots from interpreter
> fr
LGTM
Goetz!
> -Original Message-
> From: Doerr, Martin
> Sent: Montag, 20. Mai 2019 17:49
> To: Lindenmaier, Goetz ; serviceability-
> d...@openjdk.java.net; JC Beyler ; Volker Simonis
> (volker.simo...@gmail.com)
> Subject: RE: RFR(S): 8224230: [PPC64, s390] Supp
Best regards,
Goetz.
> -Original Message-
> From: Doerr, Martin
> Sent: Montag, 20. Mai 2019 17:32
> To: serviceability-dev@openjdk.java.net; JC Beyler ;
> Volker Simonis (volker.simo...@gmail.com) ;
> Lindenmaier, Goetz
> Subject: RFR(S): 8224230: [PPC64, s390] Support
s.java
> >serviceability/sa/ClhsdbThread.java
> >
> > Are these all failures that go back to the attach issue?
> >
> > Best regards,
> >Goetz.
> >
> >
> >> -Original Message-
> >> From: Lindenmaier, Goetz
>
ForG1.java
serviceability/sa/ClhsdbScanOops.java
serviceability/sa/ClhsdbThread.java
Are these all failures that go back to the attach issue?
Best regards,
Goetz.
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Donnerstag, 31. Januar 2019 12:54
> To: 'Jini Ge
Hi,
any news on this?
We get questions for the results by the people I made
participate in this :)
Best regards,
Goetz.
> -Original Message-
> From: serviceability-dev On
> Behalf Of Stephen Fitch
> Sent: Dienstag, 3. Juli 2018 14:18
> To: Per Liden ; serviceability-dev@openjdk.jav
Hi Jini,
I pushed it into our testing:
https://ci.sapmachine.io/view/Build%20My%20Branch/job/branch-build-service/43/
the build is running ...
Best regards,
Goetz.
> -Original Message-
> From: serviceability-dev On
> Behalf Of Jini George
> Sent: Mittwoch, 30. Januar 2019 12:59
> To
Sure, I'll try to test it.
Best regards,
Goetz.
> -Original Message-
> From: Jini George
> Sent: Sonntag, 20. Januar 2019 17:12
> To: David Holmes ; Lindenmaier, Goetz
> ; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8215544: SA: Modify Clh
Hi Jini,
we see test failing after this change arrived deeper in our infrastructure.
On a linuxx86_64 docker container it does not work.
This is because you now throw Error() if shouldSAAttach() returns false.
I think you need this:
--- a/test/hotspot/jtreg/serviceability/sa/ClhsdbLauncher.java
Thanks Serguei!
Best regards,
Goetz.
> -Original Message-
> From: serguei.spit...@oracle.com
> Sent: Donnerstag, 3. Januar 2019 10:13
> To: Volker Simonis ; Lindenmaier, Goetz
>
> Cc: serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net&g
. Januar 2019 09:50
> To: Lindenmaier, Goetz
> Cc: gary.ad...@oracle.com; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(S): 8215975: [testbug] Adapt nsk tests to the PPC, S390 and
> AIX platforms.
>
> Looks good to me.
>
> Than
ed by you?
http://cr.openjdk.java.net/~goetz/wr18/8215975-nskTests/02/
Best regards,
Goetz.
> -Original Message-
> From: gary.ad...@oracle.com
> Sent: Montag, 31. Dezember 2018 16:59
> To: Lindenmaier, Goetz ; serviceability-dev
> (serviceability-dev@openjdk.java.net)
touch them.
Webrev with alloc001:
http://cr.openjdk.java.net/~goetz/wr18/8215975-nskTests/02/
Best regards,
Goetz.
>
>
> On 12/31/18 8:48 AM, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > Some of the nsk tests are not properly configured for the
> > above
Hi,
Some of the nsk tests are not properly configured for the
above platforms:
nsk/jvmti/RetransformClasses/retransform003/TestDriver.java:
nsk/jvmti/SetNativeMethodPrefix/SetNativeMethodPrefix002/TestDriver.java
The tests use the path to native libraries, which is named "LIBPATH" on AIX.
Thanks Erik!
Pushed.
Best regards,
Goetz
> -Original Message-
> From: serviceability-dev On
> Behalf Of Erik Gahlin
> Sent: Thursday, December 13, 2018 12:34 PM
> To: security-...@openjdk.java.net; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: 8215534: [t
Thanks Sundar!
Best regards
Goetz
> -Original Message-
> From: Sundararajan Athijegannathan
>
> Sent: Thursday, December 13, 2018 9:47 AM
> To: Lindenmaier, Goetz
> Cc: security-...@openjdk.java.net; serviceability-dev (serviceability-
> d...@openjdk.java.net)
&
Hi,
These tests lack @requires vm.hasJFR, thus they are failing on AIX.
http://cr.openjdk.java.net/~goetz/wr18/8215334-JFR_requires/01/
Please review.
I will push this to jdk12 as it is a testbug if I miss the RDP deadline.
Best regards,
Goetz.
Hi Dalibor,
thanks for the info!
Best regards,
Goetz.
> -Original Message-
> From: dalibor topic
> Sent: Donnerstag, 22. November 2018 11:51
> To: Lindenmaier, Goetz ; Andrew Hughes
> ; serviceability-dev d...@openjdk.java.net>; hotspot-dev
> Subject: R
Hi,
Doesn't this have to be posted to jdk8u-dev?
I had a look at the backport.
Including 7127191 confused me a bit. Is it good to hide the fact that
this was backported in the repository?
In os_linux one fix is missing, is this on purpose? I don't think this is a
critical issue, though, so leav
e review.
Best regards,
Goetz.
> -Original Message-
> From: Sharath Ballal
> Sent: Mittwoch, 3. Oktober 2018 08:03
> To: Lindenmaier, Goetz ; serviceability-dev
>
> Subject: RE: RFR (XS) JDK-8207745: serviceability/sa/TestJmapCore.java times
> out parsing a 4GB h
Hi Sharath,
what do you think about bringing this fix to jdk11u?
We run the tests there regularly and see this problem, too.
Best regards,
Goetz.
> -Original Message-
> From: serviceability-dev On
> Behalf Of Sharath Ballal
> Sent: Montag, 24. September 2018 05:49
> To: serviceabilit
value of [0]
> -Original Message-
> From: Jini George
> Sent: Thursday, July 12, 2018 6:43 PM
> To: Lindenmaier, Goetz ; serviceability-
> d...@openjdk.java.net
> Subject: Re: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X
>
>
> >
> > I'll run
Hi Jini,
I had a look at your change.
It makes tests fail if shouldSAAttach returns false.
Now, these tests say "Errror: cannot attach",
while before they would terminate silently.
It is not an Error if the SA can not attach.
You can reproduce this by just changing
Platform.shouldSAAttach() t
Hi,
Thanks for reviewing!
Yes, what Jini is saying is also what I found in the comments.
Best regards,
Goetz.
> -Original Message-
> From: Chris Plummer
> Sent: Monday, June 25, 2018 7:02 PM
> To: Lindenmaier, Goetz ; 'Jini George'
> ; serviceability
Hi Jini
Thanks for reviewing again, I fixed the typo's!
Best regards,
Goetz.
> -Original Message-
> From: Jini George
> Sent: Monday, June 25, 2018 6:20 PM
> To: Lindenmaier, Goetz ; 'Chris Plummer'
> ; serviceability-dev (serviceability-
> d...@open
gards,
Goetz.
> -Original Message-
> From: Jini George
> Sent: Thursday, June 21, 2018 12:18 PM
> To: Lindenmaier, Goetz ; 'Chris Plummer'
> ; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(S/M): 8205419: [testbug] TestJmap
ne. Even if you
Sudo the jtreg runner as proposed in JDK-8199700.
Thanks and best regards,
Goetz
> -Original Message-
> From: David Holmes
> Sent: Thursday, June 21, 2018 1:14 PM
> To: Lindenmaier, Goetz ; serviceability-dev
> (serviceability-dev@openjdk.java.net) d...@
s for mac, they are also done by @requires
and not as a check using Platform at runtime.
> Sorry, I don't have an answer to your VMProps evaluation question. You
> might need to ask a wider audience than just svc.
Whom should I ask? Hotspot-dev?
Best regards,
Goetz.
>
> thank
Hi,
TestJmapCore is failing on aix because there jhsdb is not implemented.
So far, such tests check at runtime Platform.shouldSAAttach() which is missing
in TestJmapCore.
Instead, I implement @requires vm.hasSAandCanAttach.
This makes jtreg skip the tests without compiling and starting them.
I a
Hi Arno,
thanks for the 'r'eview!
Best regards,
Goetz.
> -Original Message-
> From: Zeller, Arno
> Sent: Mittwoch, 20. Juni 2018 10:12
> To: Lindenmaier, Goetz
> Cc: serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net>; Thomas
ginal Message-
> From: Thomas Stüfe [mailto:thomas.stu...@gmail.com]
> Sent: Samstag, 16. Juni 2018 19:26
> To: Lindenmaier, Goetz
> Cc: serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net>
> Subject: Re: RFR(XS): 8205108: [testbug] Fix pattern matching
Hi,
Please review this test fix:
http://cr.openjdk.java.net/~goetz/wr18/8205108-fixJstatDTestPattern/01/
The values for 'M' must be parsed as PERCENTAGE_OR_DASH.
The parsing of numbers should not depend on the locale.
I changed the parsing to use java.text.NumberFormat
Best regards,
Goetz.
Goetz.
>
>
> Rest seems fine.
>
> ..Thomas
>
> On Mon, Jun 11, 2018 at 3:14 PM, Lindenmaier, Goetz
> wrote:
> > Hi,
> >
> > please review this test fix:
> > http://cr.openjdk.java.net/~goetz/wr18/8204654-fixJstatTest/01
> >
> > gcCau
Hi,
please review this test fix:
http://cr.openjdk.java.net/~goetz/wr18/8204654-fixJstatTest/01
gcCauseOutput1.awk:
The pattern scans 11 numbers, while the output contains 13. Also, more '-' are
possible then checked.
The other awk scripts need to check more patterns where '-' can appear.
W
Hi,
please review this test fix:
http://cr.openjdk.java.net/~goetz/wr18/8204654-fixJstatTest/01
gcCauseOutput1.awk:
The pattern scans 11 numbers, while the output contains 13. Also, more '-' are
possible then checked.
The other awk scripts need to check more patterns where '-' can appear.
W
Hi
this discussion touched a lot of points so far, which seem
to lead to different conclusions.
I think we should look at the values printed:
1. cpu=6300.65ms elapsed=123.28s
Overhead
cpu time:
* system calls at thread dump time
elapsed time:
* 1 system call at thread creation time
*
; Sent: Mittwoch, 11. April 2018 09:45
> To: Lindenmaier, Goetz ; serviceability-
> d...@openjdk.java.net
> Cc: hotspot-...@openjdk.java.net
> Subject: RE: RFR (M): 8201247: Various cleanups in the attach framework
>
> Hi Goetz,
>
> thanks for the review.
Ah, ok, thanks for the info!
Best regards,
Goetz.
> -Original Message-
> From: Chris Plummer [mailto:chris.plum...@oracle.com]
> Sent: Dienstag, 10. April 2018 19:31
> To: Lindenmaier, Goetz ; Langer, Christoph
> ; serviceability-dev@openjdk.java.net
> Cc: hotspot-..
Hi Christoph,
thanks for doing this laborious change ... comparing all these files :)
Change looks good, just some minor comments:
You say you are sorting the includes, but in the VirtualMachineImpl.c
files the order is changed, but according to which order? It's
not alphabetical as in other f
Hi,
The CSR for this change is approved now.
https://bugs.openjdk.java.net/browse/JDK-8191477
If there aren't any more objections, I will push this.
Webrev rebased and with updated 2018 copyright messages:
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.08/
Best regards,
Goet
-dev-boun...@openjdk.java.net]
On Behalf Of Lindenmaier, Goetz
Sent: Tuesday, December 12, 2017 11:37 AM
To: Alan Bateman ; core-libs-...@openjdk.java.net;
'compiler-...@openjdk.java.net' ;
serviceability-dev (serviceability-dev@openjdk.java.net)
Subject: RE: FW: RFR(M): 8189102: All to
ateman [mailto:alan.bate...@oracle.com]
> Sent: Montag, 11. Dezember 2017 17:53
> To: Lindenmaier, Goetz ; core-libs-
> d...@openjdk.java.net; 'compiler-...@openjdk.java.net' d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: FW:
of them on
all the platforms we build.
Best regards,
Goetz.
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Mittwoch, 11. Oktober 2017 22:07
> To: hotspot-dev developers
> Subject: RFR(M): 8189102: All tools should support -?, -h and --help
>
> Hi
>
Hi Christoph,
thanks for doing this change.
I would appreciate if the coverity findings get into the codebase,
at minimum it simplifies repeated runs.
I’m not sure about the syntax cleanups, especially invoker.c,
this seems too trivial to touch the file.
Thanks for explaining inStream.c, I think
them to our testing :)
Thanks for further testing and best regards,
Goetz.
> -Original Message-
> From: Kumar Srinivasan [mailto:kumar.x.sriniva...@oracle.com]
> Sent: Freitag, 1. Dezember 2017 15:42
> To: Lindenmaier, Goetz
> Cc: core-libs-...@openjdk.java.
Thanks, Robert!
Best regards,
Goetz.
> -Original Message-
> From: Robert Field [mailto:robert.fi...@oracle.com]
> Sent: Mittwoch, 29. November 2017 19:31
> To: Lindenmaier, Goetz
> Cc: Kumar Srinivasan ; serviceability-dev
> (serviceability-dev@openjdk.java.net) d..
webrev.
Best regards,
Goetz.
> -Original Message-
> From: Kumar Srinivasan [mailto:kumar.x.sriniva...@oracle.com]
> Sent: Montag, 27. November 2017 17:43
> To: Lindenmaier, Goetz
> Cc: core-libs-...@openjdk.java.net; 'compiler-...@openjdk.java.net
is very platform dependent (most differences are
between unix/windows) so this platform coverage should suffice
I think.
I'll post a new webrev later on.
Best regards,
Goetz.
>
> Kumar
>
>
> On 11/17/2017 3:23 AM, Lindenmaier, Goetz wrote:
> > Hi,
> >
>
.
> -Original Message-
> From: serviceability-dev [mailto:serviceability-dev-
> boun...@openjdk.java.net] On Behalf Of Lindenmaier, Goetz
> Sent: Friday, November 17, 2017 12:23 PM
> To: core-libs-...@openjdk.java.net; 'compiler-...@openjdk.java.net'
> ; serviceabil
OK, thanks!
Best regards,
Goetz.
> -Original Message-
> From: Weijun Wang [mailto:weijun.w...@oracle.com]
> Sent: Wednesday, November 22, 2017 8:08 AM
> To: Lindenmaier, Goetz
> Cc: core-libs-...@openjdk.java.net; compiler-...@openjdk.java.net;
> serviceability-dev (
ith the same names and we need to keep
> the option (and maybe the help screen) as similar as possible.
>
> I am OK with supporting the --help option undocumented.
>
> Thanks
> Max
>
> > On Nov 20, 2017, at 9:46 PM, Lindenmaier, Goetz
> wrote:
> >
> > Hi
]
> Sent: Sonntag, 19. November 2017 01:28
> To: Lindenmaier, Goetz
> Cc: core-libs-...@openjdk.java.net; compiler-...@openjdk.java.net;
> serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net>
> Subject: Re: RFR: 8189102: All tools should support -?, -h an
From: Alan Bateman [mailto:alan.bate...@oracle.com]
> Sent: Samstag, 18. November 2017 09:42
> To: Lindenmaier, Goetz ; core-libs-
> d...@openjdk.java.net; 'compiler-...@openjdk.java.net' d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
>
Message-
> From: Robert Field [mailto:robert.fi...@oracle.com]
> Sent: Freitag, 17. November 2017 20:07
> To: Lindenmaier, Goetz
> Cc: core-libs-...@openjdk.java.net; compiler-...@openjdk.java.net;
> serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net>
&g
{
@Override
public void process(OptionHelper helper, String option) throws
InvalidValueException {
Log log = helper.getLog();
> -Original Message-
> From: Jonathan Gibbons [mailto:jonathan.gibb...@oracle.com]
> Sent: Freitag, 17. November 2017
Hi,
please review this change. I also filed a CSR for this:
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8189102
CSR: https://bugs.openjdk.java.net/browse/JDK-8191477
See the webrev for a detailed description of the changes.
Hi Steve,
There are three development repos for jdk10: client, hs (hotspot) and jdk10.
Where changes are submitted depends on the focus of the change.
This goes along with the mailing lists it was discussed on.
E.g. if you change in the gc, you get reviews on the hotspot-gc-dev
mailing list and t
Hi David,
thanks for looking at my change!
> Should JDK-8185436 have made the changes to TEST.ROOT? I don't
> understand all the changes that have been added there. Did JDK-8185436
> make VMProps.java dependent on WhitBox API but not provide a means to
> actually build VMProps properly??
8185436
Hi,
Could I please get a review for this small fix to the tests?
http://cr.openjdk.java.net/~goetz/wr17/8186719-cdsRequires/webrev.01/
I introduces property @requires vm.cds in the hotspot test suite, and
now identified three tests in the jdk suite that require the same.
Best regards,
Goetz.
Hi David,
Thanks for reviewing and sponsoring!
Best, Götz
> Am 21.08.2017 um 04:00 schrieb David Holmes :
>
> Hi Goetz,
>
>> On 18/08/2017 4:08 PM, Lindenmaier, Goetz wrote:
>> Hi,
>> Thanks Volker!
>> Could I please get a second review? I
t 2017 19:33
> To: Lindenmaier, Goetz
> Cc: serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net>; Zeller, Arno
> Subject: Re: RFR(XS): 8185112: [TESTBUG] Servicability tests cannot parse
> float
> if non US locale.
>
> Thanks Goetz - looks good
sage-
> From: Volker Simonis [mailto:volker.simo...@gmail.com]
> Sent: Freitag, 28. Juli 2017 16:45
> To: Lindenmaier, Goetz
> Cc: serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net>; Zeller, Arno
> Subject: Re: RFR(XS): 8185112: [TESTBUG] Servica
regards,
Goetz.
> -Original Message-
> From: Volker Simonis [mailto:volker.simo...@gmail.com]
> Sent: Thursday, July 27, 2017 11:49 AM
> To: Lindenmaier, Goetz
> Cc: serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net>; Zeller, Arno
>
Hi,
Some tests use Float.valueOf for String to float converting. If an other locale
than US is used the test failed. We observed this on Mac.
Changed to use NumberFormat to work with all locales.
Please review this change. I please need a sponsor.
http://cr.openjdk.java.net/~goetz/wr17/8185112-m
Hi,
I think this merge
http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a28955e16c78
wrongly added
+ * @ignore 8169232
to
TestCpoolForInvokeDynamic.java
which was fixed in
8169232: SA: TestCpoolForInvokeDynamic.java fails with
sun.jvm.hotspot.debugger.DebuggerException: binary search
om: David Holmes [mailto:david.hol...@oracle.com]
> Sent: Wednesday, December 14, 2016 9:55 PM
> To: Lindenmaier, Goetz ;
> daniel.daughe...@oracle.com; 'Dmitry Samersoff'
> ; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Su
> object to the change to k_standard.c for the same reason.
Ok, I remove that too.
Best regards,
Goetz.
> -Original Message-
> From: David Holmes [mailto:david.hol...@oracle.com]
> Sent: Mittwoch, 14. Dezember 2016 12:29
> To: Lindenmaier, Goetz ;
> daniel.da
avid Holmes [mailto:david.hol...@oracle.com]
> Sent: Mittwoch, 14. Dezember 2016 11:42
> To: Lindenmaier, Goetz ;
> daniel.daughe...@oracle.com; 'Dmitry Samersoff'
> ; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subj
. Dezember 2016 11:04
> To: Lindenmaier, Goetz ;
> daniel.daughe...@oracle.com; 'Dmitry Samersoff'
> ; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and se
Dezember 2016 23:03
> To: daniel.daughe...@oracle.com; Lindenmaier, Goetz
> ; 'Dmitry Samersoff'
> ; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabi
Hi,
I'll post a new webrev once the hs code has been propagated to
dev.
Best regards,
Goetz.
> -Original Message-
> From: David Holmes [mailto:david.hol...@oracle.com]
> Sent: Donnerstag, 8. Dezember 2016 23:03
> To: daniel.daughe...@oracle.com; Lindenmaier,
ked me to add it. But I think it's ok.
Can I consider this reviewed now? I.e. could I push it once 8066474 is
promoted and Joe Darcy agreed?
Best regards,
Goetz.
> -Original Message-
> From: David Holmes [mailto:david.hol...@oracle.com]
> Sent: Donnerstag, 8. Dezemb
samers...@oracle.com]
> Sent: Wednesday, December 07, 2016 2:43 PM
> To: Lindenmaier, Goetz ; Java Core Libs
> ; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
> coding.
>
> Goetz,
>
> SD
Ah, you're right, the 'lastslash' assignment!
Thanks,
Goetz.
> -Original Message-
> From: David Holmes [mailto:david.hol...@oracle.com]
> Sent: Wednesday, December 07, 2016 10:32 AM
> To: Lindenmaier, Goetz ; 'Dmitry Samersoff'
> ; Java Core Libs
rc/jdk.jdwp.agent/unix/native/libdt_socket/socket_md.c
> It might be better to write
> arg.l_linger = (on) ? (unsigned short)value.i : 0;
> and leave one copy of setsockopt() call
Yes, looks better.
Best regards,
Goetz
>
> -Dmitry
>
>
> On 2016-12-06 16:12, Lindenma
Hi,
This change fixes some minor issues found in our code scans.
I hope this correctly addresses corelib and serviceability issues.
Please review:
http://cr.openjdk.java.net/~goetz/wr16/8170663-corlib_s11y/webrev.01/
Best regards,
Goetz.
Changes in detail:
e_asin.c
Code scan reports missing
-runtime-dev d...@openjdk.java.net>; hotspot-compiler-...@openjdk.java.net;
> Lindenmaier, Goetz
> Subject: Re: RFR(S): PING! JDK-8134434: JVM_DoPrivileged() fires
> assert(_exception_caught == false) failed: _exception_caught is out of phase
>
> Everybody,
>
> Updated we
Hi Dmitry,
thanks for looking at this issue.
I think your fix will crash if thread->jvmti_thread_state();
returns NULL. Also, please add the #include with leading
directory prims/ at the proper alphabetic position.
Also, you could add the test Richard supplied, see below.
Best regards,
Goetz.
Vote: yes
Best regards,
Goetz.
> -Original Message-
> From: serviceability-dev [mailto:serviceability-dev-
> boun...@openjdk.java.net] On Behalf Of Daniel D. Daugherty
> Sent: Freitag, 8. Juli 2016 01:48
> To: serviceability-dev@openjdk.java.net
> Subject: CFV: New Serviceability Group
Great, looks good. Thanks a lot!
Best regards,
Goetz.
> -Original Message-
> From: Dmitry Samersoff [mailto:dmitry.samers...@oracle.com]
> Sent: Dienstag, 17. November 2015 14:42
> To: Lindenmaier, Goetz; Thomas Stüfe
> Cc: David Holmes; hotspot-runtime-...@o
.
> -Original Message-
> From: Dmitry Samersoff [mailto:dmitry.samers...@oracle.com]
> Sent: Montag, 16. November 2015 11:53
> To: Lindenmaier, Goetz; Thomas Stüfe
> Cc: David Holmes; hotspot-runtime-...@openjdk.java.net; serviceability-
> dev
> Subject: Re: RFR(M): 814
That's great, thanks a lot!
Best regards,
Goetz.
> -Original Message-
> From: Dmitry Samersoff [mailto:dmitry.samers...@oracle.com]
> Sent: Dienstag, 17. November 2015 09:34
> To: Lindenmaier, Goetz; Thomas Stüfe
> Cc: David Holmes; hotspot-runtime-...@openjdk.java
s,
Goetz.
-Original Message-
From: Dmitry Samersoff [mailto:dmitry.samers...@oracle.com]
Sent: Montag, 16. November 2015 09:23
To: David Holmes; Thomas Stüfe; Lindenmaier, Goetz
Cc: serviceability-dev; hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR(M): 8141529: Fix handling of _JAVA_SR_SIG
oses.
Here is the new webrev:
http://cr.openjdk.java.net/~goetz/webrevs/8141529-NSIG/webrev.02/
Best regards,
Goetz.
From: Thomas Stüfe [mailto:thomas.stu...@gmail.com]
Sent: Freitag, 13. November 2015 10:54
To: Lindenmaier, Goetz
Cc: Dmitry Samersoff; David Holmes; hotspot-runtime-...@open
1 - 100 of 115 matches
Mail list logo
