Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-21 Thread Andrew Hughes
On Wed, 21 Nov 2018 at 10:20, Severin Gehwolf wrote: > > On Wed, 2018-11-21 at 06:47 +, Andrew Hughes wrote: > > On Mon, 19 Nov 2018 at 15:39, Severin Gehwolf wrote: > > > > snip... > > > > > > > > Two reasons: (1) JDK-8140482 isn't a small change. (2) The patch > > > doesn't apply

Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-21 Thread Severin Gehwolf
On Wed, 2018-11-21 at 06:47 +, Andrew Hughes wrote: > On Mon, 19 Nov 2018 at 15:39, Severin Gehwolf wrote: > > snip... > > > > > Two reasons: (1) JDK-8140482 isn't a small change. (2) The patch > > doesn't apply cleanly[1] from JDK 9 so would be some work to get the > > pre-requisite in. >

Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-20 Thread Andrew Hughes
On Mon, 19 Nov 2018 at 15:39, Severin Gehwolf wrote: snip... > > Two reasons: (1) JDK-8140482 isn't a small change. (2) The patch > doesn't apply cleanly[1] from JDK 9 so would be some work to get the > pre-requisite in. > > It appears the code is already out of sync and the risk would be

Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-19 Thread Severin Gehwolf
On Mon, 2018-11-19 at 15:09 +, Andrew Hughes wrote: > On Fri, 9 Nov 2018 at 16:02, Severin Gehwolf wrote: > > > > Hi, > > > > Could somebody please review this 8u backport of 8210836 as I'd like to > > get 8210647 (opt for sa) backported to 8u as well? Unfortunately the > > change from JDK

Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-19 Thread Andrew Hughes
On Fri, 9 Nov 2018 at 16:02, Severin Gehwolf wrote: > > Hi, > > Could somebody please review this 8u backport of 8210836 as I'd like to > get 8210647 (opt for sa) backported to 8u as well? Unfortunately the > change from JDK 12 doesn't apply cleanly so I've included select > changes from 8140482

Re: [PING] [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-16 Thread Severin Gehwolf
On Tue, 2018-11-13 at 09:28 +0100, Severin Gehwolf wrote: > On Tue, 2018-11-13 at 10:46 +0530, Jini George wrote: > > Looks good to me, Severin. > > Thanks for the review! > > I believe I still need a review from a JDK 8u Reviewer: > http://openjdk.java.net/census#jdk8u Any JDK 8u Reviewer

Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-13 Thread Severin Gehwolf
On Tue, 2018-11-13 at 10:46 +0530, Jini George wrote: > Looks good to me, Severin. Thanks for the review! I believe I still need a review from a JDK 8u Reviewer: http://openjdk.java.net/census#jdk8u Thanks, Severin > While looking at this, I realized that the code improvement change of >

Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-12 Thread Jini George
Looks good to me, Severin. While looking at this, I realized that the code improvement change of 8140482 in ps_core.c of increasing the BUF_SIZE by 1 and adding the '\0' would be needed for MacOS also -- I will file another bug for that for JDK 12. Thanks! Jini. On 11/9/2018 9:31 PM,

Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-09 Thread Severin Gehwolf
Hi JC, On Fri, 2018-11-09 at 08:46 -0800, JC Beyler wrote: > Hi Severin, > > The fix looks good to me. Thanks for the review! > For reference for other reviewers, the original change can be seen > here: > http://hg.openjdk.java.net/jdk/jdk/rev/c0f9161f591e > > And it contains fixes from the

[8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-09 Thread Severin Gehwolf
Hi, Could somebody please review this 8u backport of 8210836 as I'd like to get 8210647 (opt for sa) backported to 8u as well? Unfortunately the change from JDK 12 doesn't apply cleanly so I've included select changes from 8140482 so that the backport remains minimal. If anything, this makes the