Re: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-18 Thread Staffan Larsen
t; Sent: Thursday, August 11, 2016 5:55 AM > To: Amit Sapre; serviceability-dev > Subject: Re: RFR : JDK-8162530 : > src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't > handle JNI exceptions properly > > On 10/08/2016 8:46 PM, Amit Sapre wrote: >

RE: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-17 Thread Amit Sapre
mit > > > > -Original Message- > From: David Holmes > Sent: Wednesday, August 03, 2016 5:50 AM > To: Amit Sapre; serviceability-dev > Subject: Re: RFR : JDK-8162530 : > src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c > doesn't handle JNI exceptions p

Re: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-10 Thread David Holmes
; serviceability-dev Subject: Re: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly Hi Amit, On 2/08/2016 7:49 PM, Amit Sapre wrote: Hello, I have made changes as David suggested. Here is the new webrev link. http

RE: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-10 Thread Amit Sapre
gt; Thanks, > Amit > > -Original Message- > From: David Holmes > Sent: Monday, August 01, 2016 12:33 PM > To: Amit Sapre; serviceability-dev > Subject: Re: RFR : JDK-8162530 : > src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c > doesn't handle JNI except

Re: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-02 Thread David Holmes
PM To: Amit Sapre; serviceability-dev Subject: Re: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly Hi Amit, On 1/08/2016 4:10 PM, Amit Sapre wrote: Hello, Please review JNI exception handling related changes. Bug

RE: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-02 Thread Amit Sapre
: JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly Hi Amit, On 1/08/2016 4:10 PM, Amit Sapre wrote: > Hello, > > > > Please review JNI exception handling related changes. > > Bug id : https://bugs.openjd

Re: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-01 Thread David Holmes
Hi Amit, On 1/08/2016 4:10 PM, Amit Sapre wrote: Hello, Please review JNI exception handling related changes. Bug id : https://bugs.openjdk.java.net/browse/JDK-8162530 Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162530/webrev.00/ Sorry but that's wrong way to fix this. We should

RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-01 Thread Amit Sapre
Hello, Please review JNI exception handling related changes. Bug id : https://bugs.openjdk.java.net/browse/JDK-8162530 Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162530/webrev.00/ Thanks, Amit