On Fri, 13 Sep 2024 06:54:40 GMT, David Holmes wrote:
>> This is a trivial point fix for the `strace` tests to add in the missing
>> event (super)constructors. These tests have started failing more regularly
>> after the `Thread.sleep` code was recently changed.
>>
>> The fragility of these te
On Thu, 12 Sep 2024 23:18:48 GMT, David Holmes wrote:
> This is a trivial point fix for the `strace` tests to add in the missing
> event (super)constructors. These tests have started failing more regularly
> after the `Thread.sleep` code was recently changed.
>
> The fragility of these tests i
On Thu, 12 Sep 2024 23:18:48 GMT, David Holmes wrote:
> This is a trivial point fix for the `strace` tests to add in the missing
> event (super)constructors. These tests have started failing more regularly
> after the `Thread.sleep` code was recently changed.
>
> The fragility of these tests i
On Mon, 2 Sep 2024 12:25:05 GMT, Alan Bateman wrote:
> This PR proposes to add a JDK-specific monitoring and management interface
> for the virtual thread scheduler. The interface is named
> VirtualThreadSchedulerMXBean and allows JMX based tooling monitor/manage the
> schedu
On Sun, 8 Sep 2024 15:30:21 GMT, SendaoYan wrote:
> Hi all,
> The newly added testcase
> `serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java`
> fails with `-Xcomp` jvm option. The jvm option `-Xcomp` will make
> `BackgroundCompilation` false. In this test, disable `Bac
On Sun, 8 Sep 2024 15:30:21 GMT, SendaoYan wrote:
> Hi all,
> The newly added testcase
> `serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java`
> fails with `-Xcomp` jvm option. The jvm option `-Xcomp` will make
> `BackgroundCompilation` false. In this test, disable `Bac
ated command for the jcmd tool is also in that repo and will be proposed
> separately).
Alan Bateman has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains eight
On Sun, 8 Sep 2024 15:30:21 GMT, SendaoYan wrote:
> Hi all,
> The newly added testcase
> `serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java`
> fails with `-Xcomp` jvm option. The jvm option `-Xcomp` will make
> `BackgroundCompilation` false. In this test, disable `Bac
On Fri, 6 Sep 2024 10:47:29 GMT, Kevin Walls wrote:
> The ObjectName String "jdk.management:type=VirtualThreadScheduler" could have
> a public static final definition somewhere in future, but there is no obvious
> home, e.g. java.lang.management.ManagementFactory is in the wrong package.
> Som
On Fri, 6 Sep 2024 05:24:18 GMT, David Holmes wrote:
> One general query: does this stuff work if the user defines their own initial
> application classloader?
Just to say that there isn't any support in the JDK for replacing any of the 3
built-in class loaders. In normal setup, the system cl
On Thu, 5 Sep 2024 17:59:50 GMT, David M. Lloyd wrote:
> The API docs don't seem to specify what a value of `-1` means; is it meant to
> indicate "not known"? It seems like other implementations are returning e.g.
> `MAX_VALUE` sometimes too; is that worth calling out in the doc for
> `getPara
ated command for the jcmd tool is also in that repo and will be proposed
> separately).
Alan Bateman has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains six addit
ated command for the jcmd tool is also in that repo and will be proposed
> separately).
Alan Bateman has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains four addit
On Wed, 4 Sep 2024 11:53:34 GMT, Kevin Walls wrote:
>> Deprecation annotations and warnings on starting the tool(s).
>> Handle man page in a separate issue.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> --connect option te
On Wed, 4 Sep 2024 11:10:54 GMT, Kevin Walls wrote:
> you mention "warnings in the --help output", I still have a warning in the
> middle of the help text here, I tried it elsewhere but liked having the
> warning about --connect next to where --connect is mentioned in the help.
I had added a c
On Wed, 4 Sep 2024 11:02:55 GMT, Kevin Walls wrote:
>> Deprecation annotations and warnings on starting the tool(s).
>> Handle man page in a separate issue.
>
> Kevin Walls has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - --connect message
On Wed, 4 Sep 2024 09:20:53 GMT, Kevin Walls wrote:
>> Deprecation annotations and warnings on starting the tool(s).
>> Handle man page in a separate issue.
>
> Kevin Walls has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Update src/jdk.ho
On Tue, 3 Sep 2024 10:31:40 GMT, Kevin Walls wrote:
>>> Maybe we can call these tags pointless. But they do give a useful check
>>> that our own code (which should be limited to the tool being deprecated
>>> here) has to be aware of and suppress the deprecation.
>>
>> If you find them useful t
This PR proposes to add a JDK-specific monitoring and management interface for
the virtual thread scheduler. The interface is named
VirtualThreadSchedulerMXBean and allows JMX based tooling monitor/manage the
scheduler's target parallelism and monitor thread counts.
The JDK 5/6 era JDK-specific
On Tue, 3 Sep 2024 14:48:05 GMT, Kevin Walls wrote:
> OK one other addition, as jhsdb debugd and the --connect option are two sides
> of the same feature:
>
> We generally expect attaches between the same JDK version (see the SA version
> mismatch warning), so a later JDK with the ability to c
On Tue, 3 Sep 2024 08:06:14 GMT, Kevin Walls wrote:
> Deprecation annotations and warnings on starting the tool(s).
> Handle man page in a separate issue.
I can look at the CSR when it is ready.
-
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/
On Tue, 3 Sep 2024 09:59:32 GMT, Kevin Walls wrote:
> Maybe we can call these tags pointless. But they do give a useful check that
> our own code (which should be limited to the tool being deprecated here) has
> to be aware of and suppress the deprecation.
If you find them useful then okay, ma
On Tue, 3 Sep 2024 08:06:14 GMT, Kevin Walls wrote:
> Deprecation annotations and warnings on starting the tool(s).
> Handle man page in a separate issue.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HotSpotAgent.java line 207:
> 205: to which the RMI connector is bound. If not spe
On Mon, 2 Sep 2024 15:52:27 GMT, Kevin Walls wrote:
> Trivial "since" tag addition in javadoc: since 1.6
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20823#pullrequestreview-2275934152
On Mon, 2 Sep 2024 11:50:11 GMT, Kevin Walls wrote:
> Trivial change.
> Javadoc has a misplaced and unnecessary blockquote tag which cuts across two
> sections. Removing this fixes the odd indent.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pu
On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie wrote:
>> As a preparation for Hermetic Java, we need to have a way to look up during
>> runtime if we are using a statically linked library or not.
>>
>> This change will be the first step needed towards compiling the object files
>> only o
On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wal
On Mon, 26 Aug 2024 13:54:36 GMT, Joakim Nordström
wrote:
>> Can I get a review of this documentation update to clarify the usage of
>> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and
>> GetProcessCpuLoad.
>>
>> Calling either of these methods in quick succession can lead to
>> u
On Mon, 26 Aug 2024 13:46:41 GMT, Joakim Nordström
wrote:
>> src/jdk.management/share/classes/com/sun/management/OperatingSystemMXBean.java
>> line 154:
>>
>>> 152: * affecting the observation period and the result.
>>> 153: *
>>> 154: * @implNote There is only one observation p
On Fri, 23 Aug 2024 10:04:42 GMT, Magnus Ihse Bursie wrote:
> But, if you look at the actual functions that are affected, you can see that
> it is just a handful of calls that are all done at startup time.
That is true for now but there 30-50 other places that will need attention once
this ef
On Fri, 23 Aug 2024 08:49:38 GMT, Joakim Nordström
wrote:
>> Can I get a review of this documentation update to clarify the usage of
>> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and
>> GetProcessCpuLoad.
>>
>> Calling either of these methods in quick succession can lead to
>> u
On Wed, 21 Aug 2024 13:42:18 GMT, Joakim Nordström
wrote:
>> Can I get a review of this documentation update to clarify the usage of
>> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and
>> GetProcessCpuLoad.
>>
>> Calling either of these methods in quick succession can lead to
>> u
On Wed, 21 Aug 2024 11:27:44 GMT, David Holmes wrote:
>> Can I get a review of this documentation update to clarify the usage of
>> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and
>> GetProcessCpuLoad.
>>
>> Calling either of these methods in quick succession can lead to
>> unrepr
On 21/08/2024 10:50, Egor Ushakov wrote:
Hi Chris,
I tried it on jdk 23 and it works the same way :(
It is clear that calling Thread.interrupted() in debugger should
modify the interrupted state, but it does not...
It looks like the debugger is taking thread interrupted state from
somewhere
On Thu, 15 Aug 2024 20:28:28 GMT, Dhamoder Nalla wrote:
>> Use the GetTempPath2 APIs instead of the GetTempPath APIs in native code
>> across the OpenJDK repository to retrieve the temporary directory path, as
>> GetTempPath2 provides enhanced security. While GetTempPath may still
>> function
On Wed, 31 Jul 2024 19:10:41 GMT, Henry Lin wrote:
> Adds a command line option `-redact` to `jcmd`, `redact` to `jmap` and
> `-XX:+HeapDumpRedacted` enabling redacted heap dumps. When enabled, the
> output binary heap dump has zeroes written out in place of the original
> primitive values in
On Mon, 29 Jul 2024 22:58:09 GMT, Serguei Spitsyn wrote:
> Can you convert the test to use `.cpp` instead of `.c` as well?
or maybe it could use VThreadPinner which allows calling through a native frame
for tests like this.
-
PR Comment: https://git.openjdk.org/jdk/pull/20373#is
On Mon, 29 Jul 2024 11:26:06 GMT, Jiawei Tang wrote:
>> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTraceWithAgent/TestPinCaseWithTrace.java
>> line 70:
>>
>>> 68: static int native2Java(int b) {
>>> 69: try {
>>> 70: Thread.sleep(500); // try yield, will pin,
On Mon, 29 Jul 2024 10:09:36 GMT, David Holmes wrote:
> Can we not just preload the problematic class so that it won't happen during
> the transition?
It's potentially dozens of classes as it's everything to support the
StackWalker API, stream pipelines, and printing code. This diagnostic opti
On Mon, 29 Jul 2024 09:49:11 GMT, Jiawei Tang wrote:
>> I add the testcase which can reproduce the crash. I hope that I could get
>> some advise if the codes need changing.
>
> Jiawei Tang has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental
On Thu, 11 Jul 2024 17:30:21 GMT, Alan Bateman wrote:
> Bringover some of the changes accumulated in the loom repo to the main line,
> most of these changes are test updates and have been baking in the loom repo
> for several months. The motive is partly to reduce the large set o
s
> - Reimplement of JVMTI VThreadEvent test to improve reliability
> - Rename some tests to get consistent naming
> - Diagnostic output in several stress tests to help trace progress in the
> event of a timeout
>
> Testing: tier1-6
Alan Bateman has updated the pull request with a
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote:
> Before RC we need to update the man pages in the repo from their Markdown
> sources. All pages at a minimum have 23-ea replaced with 23, and publication
> year set to 2024 if needed.
>
> This also picks up the unpublished changes to java.
On Thu, 18 Jul 2024 10:52:43 GMT, Serguei Spitsyn wrote:
> Q: There are some new files with a copyright year ranges.
I will check but there are a few renames that have to keep the initial year.
Also there are some new files that have been checked into the loom repo for a
long time so they have
On Thu, 18 Jul 2024 10:46:16 GMT, Serguei Spitsyn wrote:
>> Bringover some of the changes accumulated in the loom repo to the main line,
>> most of these changes are test updates and have been baking in the loom repo
>> for several months. The motive is partly to reduce the large set of changes
On Wed, 17 Jul 2024 14:07:55 GMT, Thomas Stuefe wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updating copyright headers
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1138:
>
>> 1136: str
Bringover some of the changes accumulated in the loom repo to the main line,
most of these changes are test updates and have been baking in the loom repo
for several months. The motive is partly to reduce the large set of changes
that have accumulated in the loom repo, and partly to improve robu
On Mon, 15 Jul 2024 09:04:24 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to fix the
>> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>>
>> The JBS issue has comments which explains what causes the timeout. The
>> commit
On Mon, 15 Jul 2024 08:16:25 GMT, Jaikiran Pai wrote:
> Hello David,
>
> > @jaikiran there is a lot of unrelated refactoring and style changes here
> > that obscures what the actual fix is.
>
> I've updated the PR to undo some of the cosmetic changes that were introduced
> to cleanup the code
On Fri, 12 Jul 2024 09:22:54 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to fix the
> test timeout reported in https://bugs.openjdk.org/browse/JDK-8334167?
>
> The JBS issue has comments which explains what causes the timeout. The commit
> in th
On Wed, 10 Jul 2024 20:10:13 GMT, Volker Simonis wrote:
>> Since Java 5 the `java.lang.instrument` package provides services that allow
>> Java programming language agents to instrument (i.e. modify the bytecode) of
>> programs running on the Java Virtual Machine. The `java.lang.instrument`
>>
On Wed, 10 Jul 2024 16:56:37 GMT, Volker Simonis wrote:
>> src/java.instrument/share/classes/java/lang/instrument/ClassFileTransformer.java
>> line 179:
>>
>>> 177: * This means that a {@link LinkageError} triggered during
>>> transformation of
>>> 178: * {@code C} in a class {@code D} not d
On Thu, 11 Jul 2024 15:38:29 GMT, Kevin Walls wrote:
>> Follow-on from JDK-8207908.
>>
>> Two tests are broken by that change:
>> sun/management/jmxremote/startstop/JMXStartStopTest.java
>> sun/management/jmxremote/startstop/JMXStatusPerfCountersTest.java
>>
>> These are additional tests w
On Tue, 9 Jul 2024 14:18:53 GMT, Volker Simonis wrote:
>> Since Java 5 the `java.lang.instrument` package provides services that allow
>> Java programming language agents to instrument (i.e. modify the bytecode) of
>> programs running on the Java Virtual Machine. The `java.lang.instrument`
>>
On 10/07/2024 16:37, Jaroslav Bachorik wrote:
:
This may not always be possible. Some systems have rather complex and
inlexible launchers - for example Apache Spark with its clusters,
drivers and executors and automatic distribution of resources. For
that system, if one needs to add an on-sta
On Fri, 5 Jul 2024 07:28:13 GMT, Volker Simonis wrote:
> @AlanBateman would you mind having a quick look at this trivial,
> documentation-only PR and let me know if you're OK with it?
(Catching up as I was away for a few days).
I agree it would be useful to have an API note on this topic. The
On 03/07/2024 11:26, Thiago Henrique Hupner wrote:
Dear JDK developers,
I'd like to propose adding an option that allows the JVM to ignore a
non-existent -javaagent instead of aborting.
Currently, if a -javaagent is specified but the agent jar file doesn't
exist, the JVM aborts with an error
On Tue, 25 Jun 2024 08:25:00 GMT, Kevin Walls wrote:
>> Man page update for JDK-8327793 which marked jstatd as deprecated for
>> removal in JDK 24.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> text update
Marked as revi
On Fri, 21 Jun 2024 14:05:51 GMT, Kevin Walls wrote:
> Man page update for JDK-8327793 which marked jstatd as deprecated for removal
> in JDK 24.
I assume we should hold off reviewing until the warning and the experiment note
are combined.
-
PR Comment: https://git.openjdk.org/jd
On Tue, 11 Jun 2024 21:09:14 GMT, Sean Mullan wrote:
>> I also think a period at the end is not necessary.
>
> For the Security Manager, the warning was worded a little differently:
>
> "WARNING: The Security Manager is deprecated and will be removed in a future
> release"
>
> I think that wor
On Wed, 19 Jun 2024 07:31:41 GMT, David Holmes wrote:
> I don't follow. We have checked vt is not null and not the carrier, so we do
> have it.
My comment was about the case where the thread dump happens during a transition
so sees the self-reference. In the loom repo the JavaThread has the th
On Wed, 19 Jun 2024 06:18:12 GMT, David Holmes wrote:
> FWIW I would have kept the vt name just in case it does have one. But as Alan
> said that can be added in later if desired.
I suggested we drop this for now because the thread dump can happen at times
when there isn't a reference to the v
On Tue, 18 Jun 2024 11:51:31 GMT, Inigo Mediavilla Saiz
wrote:
>> Follow up to https://github.com/openjdk/jdk/pull/19482 that was causing
>> issues when the PrintMountedVirtualTest.java was
>> running with `JTREG_TEST_THREAD_FACTORY=Virtual` in the loom repo.
>>
>> - Fixes issues where the te
On Mon, 17 Jun 2024 13:24:23 GMT, Inigo Mediavilla Saiz
wrote:
>> Follow up to https://github.com/openjdk/jdk/pull/19482 that was causing
>> issues when the PrintMountedVirtualTest.java was
>> running with `JTREG_TEST_THREAD_FACTORY=Virtual` in the loom repo.
>>
>> - Fixes issues where the te
On Mon, 17 Jun 2024 20:51:34 GMT, Kevin Walls wrote:
>> JMX uses APIs related to the Security Mananger which are deprecated. Use of
>> AccessControlContext will be removed when Security Manager is removed.
>>
>> Until then, updates are needed to not require setting
>> -Djava.security.manager
On Mon, 17 Jun 2024 12:37:01 GMT, David Holmes wrote:
>> Follow up to https://github.com/openjdk/jdk/pull/19482 that was causing
>> issues when the PrintMountedVirtualTest.java was
>> running with `JTREG_TEST_THREAD_FACTORY=Virtual` in the loom repo.
>>
>> - Fixes issues where the test observe
On Mon, 17 Jun 2024 12:35:15 GMT, David Holmes wrote:
> We need a comment explaining why we have to check for this as without knowing
> the implementation quirks it seems non-sensical for a thread to have mounted
> itself!
Just to note that JavaThread._vthread is always the "current thread". I
On Wed, 12 Jun 2024 08:45:46 GMT, Inigo Mediavilla Saiz
wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove unn
On Thu, 13 Jun 2024 14:37:45 GMT, Inigo Mediavilla Saiz
wrote:
> Would you mind explaining why unparking the main (virtual) thread can end up
> with the main thread observing the dummy thread in transition ?
The unpark of main requires queueing the task for main. This can trigger a new
FJP wo
On Wed, 12 Jun 2024 08:45:46 GMT, Inigo Mediavilla Saiz
wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove unn
On Wed, 12 Jun 2024 14:23:07 GMT, Daniel Fuchs wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> udpates
>
> test/jdk/javax/management/remote/mandatory/notif/policy.negative line 7:
>
>> 5: permission javax.manag
On Wed, 12 Jun 2024 07:14:59 GMT, Inigo Mediavilla Saiz
wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix scope
On Tue, 11 Jun 2024 21:05:38 GMT, Inigo Mediavilla Saiz
wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Require co
On Tue, 11 Jun 2024 18:11:55 GMT, Kevin Walls wrote:
>> jstatd is an RMI server application which monitors HotSpot VMs, and provides
>> an interface to the monitoring tool jstat, for use across a remote RMI
>> connection.
>>
>> RMI is not how modern applications communicate. It is an old trans
On Tue, 11 Jun 2024 16:54:36 GMT, Kevin Walls wrote:
>> jstatd is an RMI server application which monitors HotSpot VMs, and provides
>> an interface to the monitoring tool jstat, for use across a remote RMI
>> connection.
>>
>> RMI is not how modern applications communicate. It is an old trans
On Tue, 11 Jun 2024 16:52:13 GMT, Kevin Walls wrote:
> Sure, happy to not add annotations in sun.jvmstat.monitor.remote
> (RemoteHost.java, RemoteVm.java).
Right, you can drop it from all the source files except for module-info.java.
-
PR Comment: https://git.openjdk.org/jdk/pull/
On Tue, 11 Jun 2024 13:09:06 GMT, Kevin Walls wrote:
> jstatd is an RMI server application which monitors HotSpot VMs, and provides
> an interface to the monitoring tool jstat, for use across a remote RMI
> connection.
>
> RMI is not how modern applications communicate. It is an old transport
On Mon, 10 Jun 2024 07:36:50 GMT, Inigo Mediavilla Saiz
wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes
On Tue, 4 Jun 2024 08:06:28 GMT, Alan Bateman wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Cleanup test
>>
>>- Stop virtualthread
>>- Remove un
On Mon, 10 Jun 2024 11:28:28 GMT, Kevin Walls wrote:
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allo
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote:
> Sets the version to 24/24-ea and the copyright year to 2025.
>
> Content changes related to the start of release (e.g. for removed options in
> java.1) are handled separately.
>
> This initial generation also picks up the unpublished chan
On Wed, 5 Jun 2024 15:58:28 GMT, Thomas Stuefe wrote:
>> Thanks !
>>
>> Your PR looks very promising @tstuefe, I would indeed prefer to wait for
>> your changes as a way to add additional indentation to the stack of the
>> virtual thread.
>>
>> What do you think if I leave the current PR with
On 05/06/2024 07:45, Iñigo Mediavilla wrote:
Thanks, Alan. Sorry, I wasn't clear in my message. I wasn't thinking
about including unmounted threads in the output of `Thread.print`, I
agree with you that besides the formatting things that still need to
be fixed there's no need to add more change
On 04/06/2024 21:52, Iñigo Mediavilla wrote:
Hello,
While there's ongoing work on:
https://github.com/openjdk/jdk/pull/19482
to add the stack trace of mounted virtual threads to the `jcmd
Thread.print` command, I'm starting to think about how I could do to
print the stack trace for virtual
On Wed, 5 Jun 2024 01:21:36 GMT, Nizar Benalla wrote:
>> This is a simple noreg cleanup. The motivation was that I noticed javac
>> doesn't recognise package.html files well.
>>
>> Some of the contents of the `package.html` files (and code in the package)
>> may be outdated, but I think it is
On Mon, 27 May 2024 09:01:48 GMT, Nizar Benalla wrote:
>> This is a simple noreg cleanup. The motivation was that I noticed javac
>> doesn't recognise package.html files well.
>>
>> Some of the contents of the `package.html` files (and code in the package)
>> may be outdated, but I think it is
On Tue, 4 Jun 2024 07:25:41 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Cleanup te
On Tue, 4 Jun 2024 06:38:36 GMT, Serguei Spitsyn wrote:
>> The intent is to provide a definition of what a null pointer is, for both C
>> and C++ programs. Is there a better place to do that so that elsewhere the
>> spec can simply to refer to "a null pointer" or "null"?
>
> Thanks, David. I al
On Mon, 3 Jun 2024 11:26:27 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add indentat
On Thu, 30 May 2024 01:13:20 GMT, SendaoYan wrote:
>> Hi all,
>> ObjectMonitorUsage.java failed with `unexpected waiter_count` after
>> [JDK-8328083](https://bugs.openjdk.org/browse/JDK-8328083) on linux x86_32.
>> There are two changes in this PR:
>> 1. In `JvmtiEnvBase::get_object_monitor_
On Fri, 31 May 2024 02:07:25 GMT, David Holmes wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> I'd probably give preference to the stack of the virtual thread, as the stack
> of the carrier when a vthread is mounted is generally quite uninte
On Thu, 30 May 2024 14:13:34 GMT, Inigo Mediavilla Saiz
wrote:
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Thanks for take this one. Here's the result with the changes in 1a75277e.
"ForkJoinPool-1-worker-1" #25 [33795] daemon prio=5 os_prio=31 cpu=
On Thu, 30 May 2024 06:51:54 GMT, David Holmes wrote:
>> Hopefully the ports will catch up someday and the alternative implementation
>> can be removed.
>>
>> We decided not to rename java.lang.VirtualThread when introducing the
>> alternative implementation as it's just too disruptive. The s
On Thu, 30 May 2024 06:14:21 GMT, David Holmes wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change from java_lang_VirtualThread::is_instance(thread_oop) to
>> hread_oop->is_a(vmClasses::BaseVirtualThread_klass())
On Wed, 29 May 2024 20:17:30 GMT, Chris Plummer wrote:
> Fixed broken javadoc link. I confirmed that it currently is broken as can be
> seen in the JDK 22 javadocs:
>
> https://docs.oracle.com/en%2Fjava%2Fjavase%2F22%2Fdocs%2Fapi%2F%2F/jdk.jdi/com/sun/jdi/VirtualMachine.html#allThreads()
>
> C
I don't know if Alex Menkov is subscribed here, better to ask on
serviceability-dev.
-Alan
On 28/05/2024 11:03, Iñigo Mediavilla wrote:
On Tue, May 28, 2024 at 11:28 AM Iñigo Mediavilla
wrote:
Hello,
I've been looking at possible tickets that I could work on under
the loo
On Sun, 26 May 2024 14:24:27 GMT, SendaoYan wrote:
> > That would mean it's not tested. I suspect the
> > java_lang_VirtualThread::is_instance checks will need to be changed to test
> > with is_a(vmClasses::BaseVirtualThread_klass()) to allow for the
> > alternative implementation.
>
> Do you
On Sun, 26 May 2024 09:27:00 GMT, SendaoYan wrote:
> Hi all,
> ObjectMonitorUsage.java failed with `unexpected waiter_count` after
> [JDK-8328083](https://bugs.openjdk.org/browse/JDK-8328083) on linux x86_32.
> It should be predicated with `@requires vm.continuations` to be skipped.
>
> Addi
On Fri, 24 May 2024 18:11:18 GMT, Nizar Benalla wrote:
> This is a simple noreg cleanup. The motivation was that I noticed javac
> doesn't recognise package.html files well.
>
> Some of the contents of the `package.html` files (and code in the package)
> may be outdated, but I think it is out
On Wed, 15 May 2024 20:29:17 GMT, Serguei Spitsyn wrote:
>> The fix is to degrade virtual threads support in the JVM TI
>> `GetObjectMonitorUsage` function so that it is specified to only return an
>> owner when the owner is a platform thread. Also, virtual threads are not
>> listed in the bot
1 - 100 of 621 matches
Mail list logo
