On Wed, 12 Jun 2024 07:14:59 GMT, Inigo Mediavilla Saiz <d...@openjdk.org> wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd <pid> >> Thread.print`. > > Inigo Mediavilla Saiz has updated the pull request incrementally with one > additional commit since the last revision: > > Fix scope of the try block Thanks for taking feedback, I don't have any other comments. test/hotspot/jtreg/serviceability/dcmd/thread/PrintMountedVirtualThread.java line 38: > 36: * @requires vm.continuations > 37: * @library /test/lib > 38: * @modules java.base The `@modules` line isn't needed, it's not possible to have a run-time image without java.base. ------------- Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19482#pullrequestreview-2112334068 PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1636049421
