On Tue, 23 Sep 2025 09:29:57 GMT, Fredrik Bredberg
wrote:
> This is a general cleanup after removing `LockingMode` related code.
> It's a sub-task of [JDK-8344261](https://bugs.openjdk.org/browse/JDK-8344261).
> It includes:
> - Removing asserts that are no longer necessary, since we removed leg
On Thu, 6 Feb 2025 18:41:12 GMT, Coleen Phillimore wrote:
> It might be that you need to add some nop() bytecode or something to
> generate the code attribute?
@coleenp This seems like a valid solution. By the way, can we modify this
testcase in OpenJDK or should the OpenJ9 team make the chan
On Thu, 12 Jun 2025 05:44:45 GMT, Matthias Baesken wrote:
>> There are a couple of jtreg tests, especially in the HS area, with very
>> special assumptions about memory layout/sizes .
>> Those fail when the address sanitizer is configured ( --enable-asan ).
>> The change adds a way to tag those
On Thu, 21 Nov 2024 12:13:50 GMT, Coleen Phillimore wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reduce test, fix bug in verifier, move and add comments to
>> is_eligible_for_verification.
>
> Thanks David
On Thu, 2 Jan 2025 13:20:20 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Wed, 25 Dec 2024 22:35:02 GMT, Andrew Haley wrote:
> > This is breaking s390x build. Would you please added below patch :)
>
> Maybe `testbit_16` isn't the rbest name. Perhaps `testbit_ushort` is better?
Sure, updated patch:
[s390_port_updated.patch](https://github.com/user-attachments/file
On Fri, 20 Dec 2024 13:17:17 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>
On Thu, 7 Nov 2024 09:40:19 GMT, Alan Bateman wrote:
>I think we can add @requires vm.continuations to this test. It's not useful to
>run with the alternative virtual thread implementation.
Sure, that sounds ok. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/21565#issuecom
On Wed, 6 Nov 2024 17:38:59 GMT, Patricio Chilano Mateo
wrote:
>> Good work! I'll approve the GC related changes.
>>
>> There are some simplifications I think can be done in the ObjectMonitor
>> layer, but nothing that should go into this PR.
>>
>> Similarly, (even if some of this is preexist
On Thu, 17 Oct 2024 14:28:30 GMT, Patricio Chilano Mateo
wrote:
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes hav
On Tue, 5 Nov 2024 16:43:35 GMT, Roman Kennke wrote:
>Hi Amit,
sorry I only now get to reply to this, I have been traveling. What does the
change do? Is it critical? Would it be possible to fix it after I intergrated
the JEP? Because any change that I do now invalidates existing reviews, and
m
On Tue, 5 Nov 2024 01:40:15 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the changes
On Tue, 22 Oct 2024 16:22:20 GMT, Roman Kennke wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update copyright
>> - Avoid assert/endless-loop in JFR code
>
> @egahlin / @mgronlun could you please review the JFR
On Tue, 22 Oct 2024 16:22:20 GMT, Roman Kennke wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update copyright
>> - Avoid assert/endless-loop in JFR code
>
> @egahlin / @mgronlun could you please review the JFR
On Thu, 24 Oct 2024 09:22:34 GMT, Thomas Stuefe wrote:
>>> This code causes test errors in
>>> `CompressedClassPointersEncodingScheme.java` on s390 and PPC64. It forces
>>> the shift to `log_cacheline` which is 7 on PPC64 and 9 on s390. The test
>>> passes when we remove "s > log_cacheline &&
On Mon, 14 Oct 2024 21:47:00 GMT, Martin Doerr wrote:
>@offamitkumar: It could still be done after this PR is integrated, but I guess
>you want to provide an s390 implementation.
I haven't looked into it yet. I am looking into other issues for now, but I
will if I can get time to work on this.
On Fri, 30 Aug 2024 20:11:06 GMT, Coleen Phillimore wrote:
>> Coleen Phillimore has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Fix jvmci code.
>> - Some C2 refactoring.
>> - Assembly corrections from Matias and Dean.
>
> Thanks Ch
On Tue, 11 Jun 2024 18:07:10 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This change ensures we don't get undefined behavior when
>> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
>> `isspace` accepts an `int` argument that "the application shall
On Tue, 4 Jun 2024 20:51:52 GMT, Cesar Soares Lucas wrote:
> Please, consider this patch to remove unused methods from the code base. To
> the best of my knowledge, these methods are only defined but never used.
>
> Here is a list with names of delete methods:
> https://gist.github.com/JohnTor
On Tue, 4 Jun 2024 20:51:52 GMT, Cesar Soares Lucas wrote:
> Please, consider this patch to remove unused methods from the code base. To
> the best of my knowledge, these methods are only defined but never used.
>
> Here is a list with names of delete methods:
> https://gist.github.com/JohnTor
On Thu, 30 May 2024 01:13:20 GMT, SendaoYan wrote:
>> Hi all,
>> ObjectMonitorUsage.java failed with `unexpected waiter_count` after
>> [JDK-8328083](https://bugs.openjdk.org/browse/JDK-8328083) on linux x86_32.
>> There are two changes in this PR:
>> 1. In `JvmtiEnvBase::get_object_monitor_
On Fri, 29 Mar 2024 19:35:45 GMT, Vladimir Kozlov wrote:
> Revert [JDK-8152664](https://bugs.openjdk.org/browse/JDK-8152664) RFE
> [changes](https://github.com/openjdk/jdk/commit/b853eb7f5ca24eeeda18acbb14287f706499c365)
> which was used for AOT [JEP 295](https://openjdk.org/jeps/295)
> implem
On Mon, 12 Feb 2024 18:04:21 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
On Thu, 23 Nov 2023 08:08:51 GMT, suchismith1993 wrote:
> The JBS issue with respect to that has been closed. Need to check if that PR
> is required. Currently putting it on hold.
This response on the issue suggest otherwise:
: The JDK does not support dynamically loaded archive files
(.a fi
On Wed, 22 Nov 2023 16:24:24 GMT, suchismith1993 wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
On Wed, 22 Nov 2023 16:24:24 GMT, suchismith1993 wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
not a review, but would you like to check if these could replaced as well :-)
./cpu/ppc/macroAssembler_ppc.hpp:
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Wed, 19 Apr 2023 13:22:54 GMT, Martin Doerr wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 17 commits:
>>
>> - Merge branch 'master' into 8304915-arch-enum
>> - ArchTest on Debian RISC-V 64 confirmed by
On Tue, 11 Apr 2023 18:07:41 GMT, Martin Doerr wrote:
> Another remark: Old JDK on s390 used "os.arch = zArch_64", current one
> "os.arch = s390x". @offamitkumar: You probably want to take a look.
Martin, only concern was that I didn't have a good experience with `s390x`
string in
[past](http
On Mon, 27 Mar 2023 14:43:04 GMT, Matias Saavedra Silva
wrote:
>> The current structure used to store the resolution information for
>> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
>> ambigious fields f1 and f2. This structure can hold information for fields,
>>
On Mon, 27 Mar 2023 14:43:04 GMT, Matias Saavedra Silva
wrote:
>> The current structure used to store the resolution information for
>> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
>> ambigious fields f1 and f2. This structure can hold information for fields,
>>
On Tue, 17 Jan 2023 13:33:34 GMT, Martin Doerr wrote:
>>> Works on PPC64. Thanks! Tests have passed on other platforms as well.
>>
>> Does "other platforms" include S390?
>
>> > Works on PPC64. Thanks! Tests have passed on other platforms as well.
>>
>> Does "other platforms" include S390?
>
>
34 matches
Mail list logo
