On Thu, 21 Nov 2024 12:13:50 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Reduce test, fix bug in verifier, move and add comments to >> is_eligible_for_verification. > > Thanks David and Johan for the reviews. Hi @coleenp, I am repeating the message from Theresa, since she is part of OpenJ9 and can't accept OpenJDK Terms: `serviceability/jvmti/RedefineClasses/RedefineVerifyError.java` I believe the correct behavior should be throwing a ClassFormatException since the generated class is not well formed. According to the JVM specification in section 4.7.3 The Code Attribute: If the method is either native or abstract, and is not a class or interface initialization method, then its method_info structure must not have a Code attribute in its attributes table. Otherwise, its method_info structure must have exactly one Code attribute in its attributes table. also The value of code_length must be greater than zero Can you clarify why VerifyError is expected to be caught here? ------------- PR Comment: https://git.openjdk.org/jdk/pull/22116#issuecomment-2636942548
