On Fri, 1 Sep 2023 23:06:15 GMT, Leonid Mesnik wrote:
>> The fix changes test serviceability/jdwp/AllModulesCommandTest.java to
>> accept VM flags.
>> 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start
>> debugee
>> 2) The stderr is just logging and tests doesn't check
On Fri, 1 Sep 2023 22:55:44 GMT, Leonid Mesnik wrote:
>> I don't like approach to compare handlers. Better to just add logging into
>> these listeners.
>
> updated
stdout logging could be improved if needed when test fails.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/155
On Fri, 1 Sep 2023 23:01:01 GMT, Leonid Mesnik wrote:
>> The fix changes test serviceability/jdwp/AllModulesCommandTest.java to
>> accept VM flags.
>> 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start
>> debugee
>> 2) The stderr is just logging and tests doesn't check
> The fix changes test serviceability/jdwp/AllModulesCommandTest.java to accept
> VM flags.
> 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start
> debugee
> 2) The stderr is just logging and tests doesn't check if it is empty. stderr
> might contain some VM output which
On Fri, 1 Sep 2023 22:55:36 GMT, Leonid Mesnik wrote:
>> test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 100:
>>
>>> 98:
>>> 99: @Override
>>> 100: public void onStringRead(String line) {
>>
>> Is there a reason not to also echo the stdout output? Seems it would be
>
On Fri, 1 Sep 2023 21:46:13 GMT, Chris Plummer wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> logging
>
> test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 100:
>
>> 98:
>> 99: @Override
>>
