On Fri, 1 Sep 2023 21:46:13 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> logging
>
> test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 100:
>
>> 98:
>> 99: @Override
>> 100: public void onStringRead(String line) {
>
> Is there a reason not to also echo the stdout output? Seems it would be
> useful if the test ever failed. Doing so probably means adding back in the
> StreamHandler argument.
I don't like approach to compare handlers. Better to just add logging into
these listeners.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15544#discussion_r1313615147
