Re: RFR: 8321971: Improve the user name detection logic in perfMemory get_user_name_slow [v2]

2023-12-20 Thread Jaikiran Pai
On Tue, 19 Dec 2023 20:13:58 GMT, Chris Plummer wrote: >> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - David's review comments - reduce if blocks and release the array outside >> if block >> - David's review comment

Re: RFR: 8321971: Improve the user name detection logic in perfMemory get_user_name_slow [v2]

2023-12-19 Thread Chris Plummer
On Mon, 18 Dec 2023 10:24:06 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to improve the code >> in `get_user_name_slow` function, which is used to identify the target JVM >> owner's user name? This addresses >>

Re: RFR: 8321971: Improve the user name detection logic in perfMemory get_user_name_slow [v2]

2023-12-18 Thread Jaikiran Pai
On Mon, 18 Dec 2023 09:55:30 GMT, Johan Sjölen wrote: >> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - David's review comments - reduce if blocks and release the array outside >> if block >> - David's review comment -

Re: RFR: 8321971: Improve the user name detection logic in perfMemory get_user_name_slow [v2]

2023-12-18 Thread Jaikiran Pai
On Fri, 15 Dec 2023 06:08:33 GMT, David Holmes wrote: >> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - David's review comments - reduce if blocks and release the array outside >> if block >> - David's review comment -

Re: RFR: 8321971: Improve the user name detection logic in perfMemory get_user_name_slow [v2]

2023-12-18 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to improve the code > in `get_user_name_slow` function, which is used to identify the target JVM > owner's user name? This addresses https://bugs.openjdk.org/browse/JDK-8321971. > > As noted in that JBS issue, in its current form, the