On Mon, 18 Dec 2023 09:55:30 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - David's review comments - reduce if blocks and release the array outside >> if block >> - David's review comment - punctuation > > src/hotspot/os/posix/perfMemory_posix.cpp line 447: > >> 445: >> 446: return name; >> 447: } > > This drops the `snprintf` return value which indicates if an error has > occurred, can this be remediated? Hello Johan, I'll take a look at the code if there are other places where this is happening. Since this is existing code (not added by this PR), if there are too many other unrelated places where this is happening then I'll create a separate issue to address it. Otherwise, I'll do it in this PR itself. Thank you for catching this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17104#discussion_r1429868521
