Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread Andrew Dinn
45-jigsaw-jvmti-pkg.1/ > > > The Jdk webrev: > http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.jdk1/ I don't seem to be able to access those webrevs: Server not found Firefox can't find the server at javaweb.sfbay.sun.com. . . . regards,

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-23 Thread Andrew Dinn
gets revoked thanks, say, to a regression of some sort it's important to be able to go back and re-read that audit trail. regards, Andrew Dinn --- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michae

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Andrew Dinn
ing the complexity that that multiplicity implies I am concerned with. I think I probably speak for Remi here too and, perhaps, others agent implementors. I'd like to see a much better argument for the security benefits of this change before it gets rolled into a release. regards, Andrew Dinn --- Senior

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Andrew Dinn
te, legacy and the ability to interoperate between JDK releases. On the credit side, I'm not yet convinced that this change achieves an improvement in security that is not available via other, better means. Perhaps, you could provide more meat on that particular bone? regards, Andrew Dinn ---

Re: RFC (csr): 8221528: Introduce compatibility mode with VM option -XX:AllowRedefinitionToAddOrDeleteMethods

2019-03-28 Thread Andrew Dinn
ans the outcome is down to a race between the bit-rot and the deprecation axe. If bit-rot wins then isn't that simply the deprecation axe swinging a tad earlier? (i.e. de facto deprecation rather than de jure :-). regards, Andrew Dinn --- Senior Principal Software Engineer Red Hat UK Lt

Re: [PING] RFR: 8220579: [Containers] SubSystem.java out of sync with osContainer_linux.cpp

2019-03-18 Thread Andrew Dinn
On 18/03/2019 10:06, Severin Gehwolf wrote: > Could I get a review from an OpenJDK Reviewer for this, please? Bob is > already OK with it. Yes, this is fine. Reviewed. regards, Andrew Dinn ---

Re: RFR: 8229118: [TESTBUG] serviceability/sa/ClhsdbFindPC fails on AArch64

2019-08-14 Thread Andrew Dinn
For some reason I thought it was in the lib directory with > LingeredApp. Yes, it's good the way it is. I'm still happy with this patch to go in after these changes. regards, Andrew Dinn --- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

Re: RFR: 8229118: [TESTBUG] serviceability/sa/ClhsdbFindPC fails on AArch64

2019-08-08 Thread Andrew Dinn
lag from the command line would not fulfil the test's remit. If that is the point of the test then I agree, reluctantly, that your hack is the right solution. On those grounds I'm happy to accept the patch. However, I'd prefer someone else (Andrew Haley?) also to review this before it gets pushed.

Re: RFR: 8215355: Object monitor deadlock with no threads holding the monitor (using jemalloc 5.1)

2019-11-18 Thread Andrew Dinn
and developers) for > continuing to investigate this issue from their side. Without their > persistence this issue would have languished. > . . . Wow, nice work tracking that one down! regards, Andrew Dinn ---

Re: Should optimizations be observable for JVMTI agents?

2019-09-25 Thread Andrew Dinn
he cost of disabling or reversing the optimisation when needed; and - the overall cost and complexity it adds to the development and maintenance of the JVM" regards, Andrew Dinn --- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxiliary classes [v2]

2021-04-22 Thread Andrew Dinn
On Fri, 16 Apr 2021 20:30:15 GMT, Rafael Winterhalter wrote: >> To allow agents the definition of auxiliary classes, an API is needed to >> allow this. Currently, this is often achieved by using `sun.misc.Unsafe` or >> `jdk.internal.misc.Unsafe` ever since the `defineClass` method was removed