hg: jdk7/hotspot-rt/hotspot: 7003456: ADLC files not correctly generated on Windows

Changeset: 01c0559441c8 Author:brutisso Date: 2010-12-01 03:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/01c0559441c8 7003456: ADLC files not correctly generated on Windows Summary: Added target architecture parameters to make ADLC build properly

hg: jdk7/hotspot-rt/hotspot: 7034625: Product builds in Visual Studio projects should produce full symbol information

Changeset: c49c3947b98a Author:brutisso Date: 2011-04-11 11:12 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/c49c3947b98a 7034625: Product builds in Visual Studio projects should produce full symbol information Summary: Add the /debug flag to the linker command

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: f457154eee8b Author:brutisso Date: 2012-01-30 12:36 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f457154eee8b 7140882: Don't return booleans from methods returning pointers Summary: Changed return false to return NULL Reviewed-by: dholmes, rottenha

hg: hsx/hotspot-rt/hotspot: 7148488: Whitebox tests for the Diagnostic Framework Parser

Changeset: 51612f0c0a79 Author:nloodin Date: 2012-03-15 13:37 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/51612f0c0a79 7148488: Whitebox tests for the Diagnostic Framework Parser Reviewed-by: brutisso, sla, mgerdin ! make/bsd/makefiles/wb.make !

Re: Review request (S) 7195557 NPG: Unexpected number of memory pools

this fix? Thanks /Mikael On 2012-09-05 12:38, Mikael Gerdin wrote: Bengt, On 2012-09-05 10:52, Bengt Rutisson wrote: Hi Mikael, I think this looks good. One minor thing. You kind of solved the same problem in two different ways. In CollectionUsageThreshold.java you reduce the expected number

hg: hsx/hotspot-rt/hotspot: 7200092: Make NMT a bit friendlier to work with

Changeset: b711844284e2 Author:nloodin Date: 2012-09-21 10:56 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b711844284e2 7200092: Make NMT a bit friendlier to work with Reviewed-by: kvn, ysr, azeemj ! src/share/vm/services/memTracker.cpp

Re: Fwd: Re: RFR (S): 8006400: Add support for defining trace types in closed code

Hi Erik, Looks good to me. (I just subscribed to the serviceability-dev mailing list, so I hope this message gets through to the list. Otherwise I'll resend it when my subscription has been confirmed.) Bengt On 1/17/13 1:49 PM, Erik Helin wrote: Original Message

Re: RFR (S): 8008536: Add HotSpot support for printing class loader statistics for JMap

Erik, Looks good! Bengt On 2/21/13 2:06 PM, Erik Helin wrote: All, based on some internal feedback, I've updated the change. The file PermStat.java can be removed already in this first change. This means that 'hg mv' can be used, which provides a better history. Webrev:

Re: RFR (XS): 8008541 Remove old code in HotSpot that supported the jmap -permstat functionality

Erik, Looks good! Bengt On 2/21/13 2:06 PM, Erik Helin wrote: All, based on some internal feedback, I've updated the change. The removal of PermStat.java could be done in the first change, reducing the size of this change. Webrev: http://cr.openjdk.java.net/~ehelin/8008541/webrev.01/ The

Re: Committed should not larger than max_size in ContiguousSpacePool while using ParNew with UseAdaptiveSizePolicy

Hi Hongxi Thanks for supplying the patch. What Java version are you using? I think that using adaptive sizing with ParNew has never worked very well. In fact this feature has been disabled in the main branch about a year ago (I think it went in to 7u4). See: 7112413 : JVM Crash, possibly

Re: RFR(XS): 8010227: Remove promotion failed from young collection event

Hi Jesper, I think you can remove the YoungGCInfo class all together. Other than that it looks good. Bengt On 3/18/13 10:04 PM, Jesper Wilhelmsson wrote: Could I have a couple of reviews for this really small change? Bug 8010227: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010227

Re: RFR: Update to test java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java

Hi Staffan, I think this looks good. Two minor comments about the @run commands. Both of these will use the SerialOld collector and since the test really only test the old generation I think one is enough: * @run main/othervm -XX:+UseSerialGC -Xmn8m ResetPeakMemoryUsage * @run

Re: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap

, Bengt Rutisson wrote: Hi Erik, Looks good. Two minor nits: Could we make 0.05 into a flag or at least a declared constant? Good suggestion, I've turned into a flag: ObjectCountCutOffPercent. On 05/07/2013 11:42 AM, Bengt Rutisson wrote: Could we rename _used_heap_in_words to something like

Re: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException

Staffan, Looks good. One minor question: Would it make sense to move the comment regarding MarkSweepAlwaysCompactCount into the existing comment section rather than adding a new section for it? I think it might increase the chances that someone reads the comment if it is closer to the @run

Re: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException

On 5/28/13 10:56 AM, Staffan Larsen wrote: On 28 maj 2013, at 10:34, Bengt Rutisson bengt.rutis...@oracle.com wrote: Staffan, Looks good. One minor question: Would it make sense to move the comment regarding MarkSweepAlwaysCompactCount into the existing comment section rather than adding

Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

Hi Markus, Looks reasonable. Bengt On 7/17/13 12:25 PM, Markus Grönlund wrote: Hi again, Trying again, could I please have a couple of reviews for this? Many thanks Markus From: Markus Grönlund Sent: den 16 juli 2013 17:48 To: serviceability-dev@openjdk.java.net;

Re: RFR: 7164841: Improvements to the GC log file rotation

/2013 4:47 AM, Bengt Rutisson wrote: Hi Yumin and Tao, I have not reviewed the code change but I have a comment inlined below. On 8/24/13 1:05 AM, Yumin Qi wrote: Tao, Thanks for your review. On 8/23/2013 3:33 PM, Tao Mao wrote: Hi, I reviewed most of the code and test-ran a build from

Re: jmx-dev RFR 8020467: Inconsistency between usage.getUsed() and isUsageThresholdExceeded() with CMS Old Gen pool

Hi again Jaroslav, On 2013-10-23 17:07, Jaroslav Bachorik wrote: On 23.10.2013 16:43, Bengt Rutisson wrote: Hi Jaroslav, On 2013-10-23 16:32, Jaroslav Bachorik wrote: On 23.10.2013 15:15, Bengt Rutisson wrote: On 2013-10-23 14:55, Jaroslav Bachorik wrote: Hi Bengt, On 23.10.2013 14:40

Re: RFR: JDK-8029395 SA: jstack throws WrongTypeException

Hi Staffan, Looks good. Thanks, Bengt On 2013-12-02 17:30, Staffan Larsen wrote: The problem here happens when SA wants to walk every object in the heap, to do that it needs to figure out what parts of the heap are in active use (the live regions). It gets the list of GC spaces as a start.

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

Hi Jesper, The calculation in PSAdaptiveSizePolicy::calculated_old_free_size_in_bytes() looks wrong to me. I would have expected this: 86 // free = (live*ratio) / (1-ratio) 87 size_t max_free = (size_t)((heap-old_gen()-used_in_bytes() * mhfr_as_percent) / (1.0 -

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

though so I will not attack that problem in this change. As Mikael wrote in his review we have talked offline about the changes and how to make them more correct and readable. Thanks Mikael for the input! More comments inline. Bengt Rutisson skrev 22/1/14 11:21 AM: Hi Jesper, The calculation

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

Hi Jesper, On 1/28/14 11:09 PM, Jesper Wilhelmsson wrote: Bengt, Thanks for looking at the change. Answers inline. Bengt Rutisson skrev 28/1/14 2:02 PM: Hi Jesper, On 2014-01-27 21:46, Jesper Wilhelmsson wrote: Staffan, Bengt, Mikael, Thanks for the reviews! I have made the changes you

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

if the limits have been exceeded. That way the code would be more self sustained. Jesper will file a separate RFE for that. Bengt On 1/29/14 9:25 PM, Jesper Wilhelmsson wrote: Hi Bengt, Just a short clarification inline. Looking forward to your comments later today. Bengt Rutisson skrev 29/1/14 4

Re: RFR (backport of): 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

Hi Jesper, I browsed the 7u60 back port and it looks fine as far as I can tell. I did not look at the 8u20 back port since I don't think you need a review if it applied cleanly. One small detail that you probably should not change for these back ports but that I should have noticed in the

Re: 8055111: [TESTBUG] jdk.testlibrary.Utils.removeGcOpts doesn't remove -Xconcgc

Hi Stefan, On 2014-08-18 13:43, Stefan Karlsson wrote: Jon suggested that I should add -Xincgc. Here's the updated webrev: http://cr.openjdk.java.net/~stefank/8055111/webrev.01/ Looks good. Thanks, Bengt thanks, StefanK On 2014-08-14 14:04, Stefan Karlsson wrote: Hi all, Please,

Re: RFR: 8035939: java/lang/management/MemoryMXBean/MemoryManagement.java timed out on Linux-amd64

Hi Stefank, Seems reasonable. Reviewed. Bengt On 2014-08-19 12:25, Stefan Karlsson wrote: Hi all, Please review this patch harden two MemoryMXBean tests. These tests cause intermittent test failures when the allocated objects are put in the young gen instead of the old gen. The proposed

Re: RFR: JDK-8055845 - Add trace event for promoted objects

Hi all, Staffan sent me an updated webrev based on Erik's comments. I uploaded it here: http://cr.openjdk.java.net/~brutisso/8055845/webrev.01/ Thanks, Bengt On 2014-08-25 19:32, Staffan Friberg wrote: Hi Erik, No issue with naming the field class, since the event is similar to the

Re: 8056148: Add java/lang/management/MemoryMXBean/LowMemoryTest.java to ProblemList.txt

Hi Stefan, Thanks for fixing the separate bug. Looks good. Bengt On 8/27/14 11:11 AM, Stefan Karlsson wrote: Hi all, Please review this patch to put the LowMemoryTest.java test in the ProblemLists.txt. It currently hangs and leaves processes running after the test run has completed.

Re: RFR: JDK-8055845 - Add trace event for promoted objects

, Bengt On 8/26/14 10:50 AM, Bengt Rutisson wrote: Hi all, Staffan sent me an updated webrev based on Erik's comments. I uploaded it here: http://cr.openjdk.java.net/~brutisso/8055845/webrev.01/ Thanks, Bengt On 2014-08-25 19:32, Staffan Friberg wrote: Hi Erik, No issue with naming

Re: RFR: JDK-8055845 - Add trace event for promoted objects

Hi Staffan, psPromotionManager.inline.hpp I think the PSPromotionManager::copy_to_survivor_space() might send multiple events. If the allocation to the young gen fails we will fall through to do an old gen allocation. But we send the events before we realize that the allocation has failed,

Re: RFR: JDK-8055845 - Add trace event for promoted objects

bool tenured = _g1h-heap_region_containing_raw(obj)-is_old(); 145 _g1h-_gc_tracer_stw-report_promotion_outside_plab_event(old, word_sz, 146 age, tenured); 147 } Thanks, Bengt Cheers, Staffan On 09/15/2014 02:06 PM, Bengt Rutisson wrote: Hi Staffan

Re: RFR: JDK-8055845 - Add trace event for promoted objects

if anyone wants a full new webrev with this. Looks good. Reviewed. Bengt Thanks, Staffan On 11/06/2014 12:01 PM, Bengt Rutisson wrote: Hi Staffan, On 2014-11-06 11:12, Staffan Friberg wrote: Hi, After further off list discussion it was decided to keep the gc_tracer in par_promote

Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

On 2014-11-08 09:11, Dmitry Fazunenko wrote: Hi Mandy, On 08.11.2014 02:41, Mandy Chung wrote: On 11/7/14 3:34 AM, Evgeniya Stepanova wrote: http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/ What are the valid values ofvm.gc? It's a bit awk for null as a valid value and I would

Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

On 2014-11-12 16:21, Evgeniya Stepanova wrote: Hi everyone! Since the decision was made to change only tests which fail because of conflict for now (skip selfish tests), I post new webrev for jdk part of the JDK-8019361 https://bugs.openjdk.java.net/browse/JDK-8019361:

Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

On 2014-11-12 16:43, Bengt Rutisson wrote: On 2014-11-12 16:21, Evgeniya Stepanova wrote: Hi everyone! Since the decision was made to change only tests which fail because of conflict for now (skip selfish tests), I post new webrev for jdk part of the JDK-8019361 https

Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

Hi Evgeniya, On 2014-11-12 17:07, Evgeniya Stepanova wrote: Hi Bengt, Please see comments inline On 12.11.2014 19:43, Bengt Rutisson wrote: On 2014-11-12 16:21, Evgeniya Stepanova wrote: Hi everyone! Since the decision was made to change only tests which fail because of conflict for now

Re: [urgent] RFR: 8081470 com/sun/jdi tests are failing with Error. failed to clean up files after test with jtreg 4.1 b12

On 2015-05-29 10:53, Staffan Larsen wrote: Can I have a fast review of the following change that is currently blocking hotspot pushes in jprt. jtreg 4.1b12 adds stricter checking of @library tags. Some com/sun/jdi tests have @library clauses that are not needed. I do not intend to wait 24

Re: RFR(xs): 8080930: SA changes broke bootcycle-images builds

Hi Per, On 2015-05-22 13:23, Per Liden wrote: JDK-8080581 introduced two new packages in the SA, but missed to add those to make/sa.files. This problem went unnoticed since it's only exposed when doing bootcycle-images builds where JDK9's javac no longer emits classes for implicit

Re: JDK-8140384: TicksToTimeHelper::milliseconds() should return a double

Thanks Markus -Original Message- From: Bengt Rutisson Sent: den 23 oktober 2015 10:27 To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net Subject: JDK-8140384: TicksToTimeHelper::milliseconds() should return a double Hi all, Could I have a couple of reviews

Re: JDK-8140384: TicksToTimeHelper::milliseconds() should return a double

heers, David Thanks Markus -Original Message- From: Bengt Rutisson Sent: den 23 oktober 2015 10:27 To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net Subject: JDK-8140384: TicksToTimeHelper::milliseconds() should return a double Hi all, Could I have a couple of r

Re: JDK-8140384: TicksToTimeHelper::milliseconds() should return a double

class. I'll leave it untouched for now. Thanks Markus and David for looking at this anyway! Bengt On 2015-10-23 13:13, Bengt Rutisson wrote: Hi David, Thanks for looking at this! On 2015-10-23 12:53, David Holmes wrote: On 23/10/2015 6:41 PM, Markus Gronlund wrote: Hi Bengt, Looks good

JDK-8140384: TicksToTimeHelper::milliseconds() should return a double

Hi all, Could I have a couple of reviews for this small change? http://cr.openjdk.java.net/~brutisso/8140384/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8140384 The TicksToTimeHelper class use different return values depending on if you want to convert to seconds or milliseconds.

Re: RFR (XS): 8142483: Unified logging log instances cause warnings on windows when only static functions are used

Hi Marcus, On 2015-11-13 10:20, Marcus Larsson wrote: Hi, Please review the following small patch to avoid 'unused variable' warnings on windows when only static functions are used on a log instance. Using log instances like this saves us from specifying the log tags for every function

Re: RFR: 8142366: Add develop_debug and develop_trace levels to Unified Logging

Hi all, I agree with Marcus here. Adding more levels below the Trace level seems odd. I interpret Marcus' suggestion 2) as that there would be for example a log_develop_trace() macro that does nothing in product builds and that calls log_trace() in debug builds. Similarly for info and

Re: RFR (S): 8142482: Improve the support for prefix functions in unified logging

Hi Marcus. On 2015-11-11 15:19, Marcus Larsson wrote: Hi, Please review the following small patch to improve the support for prefixes in unified logging. Instead of the previous format and value/callback, a prefix is now defined as a function that receives the log buffer as argument,

Re: RFR: JDK-8133818: Additional number of processed references printed with -XX:+PrintReferenceGC after JDK-8047125

ted webrev that I just sent out. Thanks, Bengt thanks! -- ramki On Tue, Sep 1, 2015 at 10:02 AM, Thomas Schatzl <thomas.scha...@oracle.com <mailto:thomas.scha...@oracle.com>> wrote: On Tue, 2015-09-01 at 14:54 +0200, Bengt Rutisson wrote: > Hi everyone, >

Re: RFR: 8144220: UL does not support full path names for log files on windows

Hi Marcus, On 2015-12-03 11:11, Marcus Larsson wrote: Hi, New webrev: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.00-01/ Looks good. One small detail: I think the test should have the annotation "@bug 8144220".

Re: RFR: 8144220: UL does not support full path names for log files on windows

Hi Marcus, On 2015-12-02 14:41, Marcus Larsson wrote: Hi, Please review the following patch to allow full path names for log files on windows. The full path to files will on windows contain a colon (from the C:\ part), and there used to be no way to avoid that colon from being parsed as

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

On 2015-12-16 22:43, Coleen Phillimore wrote: On 12/16/15 4:01 PM, John Rose wrote: On Dec 15, 2015, at 12:26 PM, Rachel Protacio wrote: - each incident of ttyLocker that involved separate logging lines for the same message have been consolidated to one line -

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

On 2015-12-18 06:44, David Holmes wrote: On 17/12/2015 6:41 PM, Bengt Rutisson wrote: On 2015-12-16 22:43, Coleen Phillimore wrote: On 12/16/15 4:01 PM, John Rose wrote: On Dec 15, 2015, at 12:26 PM, Rachel Protacio <rachel.prota...@oracle.com> wrote: - each incident of tty

Re: RFR: 8142979: Add programmatic enable/disable methods to Unified Logging

Hi Marcus, On 2015-11-25 13:13, Marcus Larsson wrote: Hi, Please review the following patch adding support for configuration of the stdout unified logging output from within the VM itself. The patch adds the configure_stdout() function, allowing a set of tags to be set to the given level

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

Hi Marcus, On 2015-11-26 16:17, Marcus Larsson wrote: Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.00-01/ Looks good. Changes: * LogLevel::Unchanged

Re: RFR: 8143229: Replace the develop level with develop macros in Unified Logging

Hi Marcus, On 2015-11-20 12:58, Marcus Larsson wrote: Hi, Please review the following patch to replace the previous 'develop' level with macros, in the unified logging framework. The macros are essentially regular log calls inside a #ifndef PRODUCT. In the product they do nothing / return

Re: RFR: 8146879: Truncate new UL log files

On 2016-01-14 23:43, Kim Barrett wrote: On Jan 14, 2016, at 10:00 AM, Marcus Larsson wrote: Hi, Please review the following patch to make sure UL truncates existing log files before writing to them. Since files are opened in append mode, truncation isn't done

Re: RFR: 8147348: LogTagLevelExpression not properly initialized in configure_stdout

Hi Marcus, On 2016-01-21 11:42, Marcus Larsson wrote: Hi, Please review the following patch to fix an initialization error in LogTagLevelExpression. If not using the parse() method (as is the case in LogConfiguration::configure_stdout) instances of the class would not be properly

Re: RFR: JDK-8151196 Several tests fail due to test library not found

d ClassFileInstaller *sun.hotspot.WhiteBox On 9 mars 2016, at 10:54, Bengt Rutisson <bengt.rutis...@oracle.com> wrote: Hi Staffan, Changes look good. However it looks like this test has the same issue, right? http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/file/59d3a69564dc/test/gc/g1/plab/TestPLABResize.jav

Re: RFR: 8146879: Add option for handling existing log files in UL

Hi Marcus, On 2016-03-11 15:21, Marcus Larsson wrote: Third time's the charm. Webrev: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.03/ I had a quick look at the code changes. It is not really my area of the code, so I'll leave to someone else to formally review it. However, I

Re: RFR(m): 8150015: Integrate TraceTime with Unified Logging more seamlessly

Hi Robbin, On 2016-03-15 21:31, Robbin Ehn wrote: Hi, please review this enhancement. This adds support for multiple UL tags in TraceTime. Bug: https://bugs.openjdk.java.net/browse/JDK-8150015/ Webrev: http://cr.openjdk.java.net/~rehn/8150015/v1/webrev/ I think this is fine but I just

Re: RFR(xs): 8153845: UL log write method missing essential assert

Hi Robbin, On 2016-04-08 14:45, Robbin Ehn wrote: Hi again, I missed LogLevel:Off, it should be: diff -r 35cb720769c5 src/share/vm/logging/logTagSet.cpp --- a/src/share/vm/logging/logTagSet.cppFri Apr 08 08:51:45 2016 +0200 +++ b/src/share/vm/logging/logTagSet.cppFri Apr 08 14:44:33

Re: RFR(xs): 8153845: UL log write method missing essential assert

Hi Robbin, On 2016-04-08 14:19, Marcus Larsson wrote: Hi Robbin, On 04/08/2016 01:54 PM, Robbin Ehn wrote: Hi all, Please review, Bug: https://bugs.openjdk.java.net/browse/JDK-8153845 Tested with jprt. diff -r 35cb720769c5 src/share/vm/logging/logTagSet.cpp ---

Re: RFR: 8151438: UL instantiates duplicate tag sets

Hi Marcus, Looks good to me. Thanks, Bengt On 2016-03-23 11:59, Marcus Larsson wrote: Hi Stefan, On 03/23/2016 11:00 AM, Stefan Karlsson wrote: Hi Marcus, On 2016-03-23 10:23, Marcus Larsson wrote: Hi, Please review the following patch to fix the issue where duplicate tagsets are

Re: RFR: 8152538: UL doesn't inline the LogTagSet::is_level check

Hi StefanK, Looks good! Bengt On 2016-03-23 11:28, Stefan Karlsson wrote: Hi all, Please, review this patch to optimize the log_is_enabled check in the Unified Logging framework. http://cr.openjdk.java.net/~stefank/8152538/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8152538 The

Re: PING Re: RFR(s): 8150026: Add the ability to log with variable log level

Hi Robbin, On 2016-03-03 07:41, Robbin Ehn wrote: Hi, Could someone else also please review this? On 02/29/2016 11:22 AM, Marcus Larsson wrote: Hi Robbin, On 02/18/2016 08:37 PM, Robbin Ehn wrote: Hi, please review. This adds a write method to the UL log which takes the level as

Re: RFR: JDK-8151196 Several tests fail due to test library not found

Hi Staffan, Changes look good. However it looks like this test has the same issue, right? http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/file/59d3a69564dc/test/gc/g1/plab/TestPLABResize.java It is currently ignored, but we should probably fix it too... Thanks, Bengt On 2016-03-09 10:47,

Re: RFR(xs): 8153396: Remove unused ResourceMarks from UL internal vm tests

Hi Robbin, On 2016-04-04 17:09, Robbin Ehn wrote: Hi all, Please review, Webrev: http://cr.openjdk.java.net/~rehn/8153396/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8153396 Looks good. Bengt Tested with internal vm test. Thanks! /Robbin

Re: ThreadMXBean.getThreadAllocatedBytes() allocates memory

ad a field in the thread it surprises me that it needs to allocate. I'll file an RFE for 10. Thanks again for the help with this! Cheers, Bengt 2016-09-19 1:45 GMT+02:00 David Holmes <david.hol...@oracle.com>: > Hi Bengt, > > On 19/09/2016 7:14 AM, Bengt Rutisson wrote

ThreadMXBean.getThreadAllocatedBytes() allocates memory

Hi Serviceability, Not sure, but I hope this is the correct list to post this on. I wanted to use the ThreadMXBean.getThreadAllocatedBytes() method to get some information about how much memory some Java code allocated. When I dug into the results they didn't properly add up until I realized