Re: JVMTI not receiving field access events with fast_getfield

Adding chris.plum...@oracle.com Chris - could you remove the personal number from the bug report please? The system won't let me do it. Thank you- Tim (list moderator for serviceability-dev@openjdk.java.net) On 12/20/17 05:40, Amir Rapson wrote: Hi, If you could please remove my phone nu

Re: [PING] RFR(XS): 8208091: SA: jhsdb jstack --mixed throws UnmappedAddressException on i686

Severin: Latest webrev with JNI properly compiled with -fomit-frame-pointer and -O3. There was a bug in the test where the exception wasn't properly rethrown: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8208091/webrev.03/ I'm going to run this through jdk-submit too. Adding build-dev for b

Re: RFR: JDK-8076557: The specified procedure could not be found in management.dll

Erik- Looks good to me. Tim On 04/07/15 08:21, Erik Joelsson wrote: (corrected subject) On 2015-04-07 17:15, Erik Joelsson wrote: Hello, When upgrading the toolchain to VS2013, management.dll stopped working on certain Windows hosts. I've identified this to be related to the call to GetPr

Re: RFR: JDK-8077422: hprof agent: Build failed with VS2013 Update 4

Erik: Looks good to me as well. Tim On 05/04/15 08:13, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 4 maj 2015, at 15:46, Erik Joelsson wrote: Hello, This bug has been marked as won't fix since the code it affects is going to be removed. However, until that removal happens, we

Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

Erik: When building hotspot with closed sources present and configuring with --enable-openjdk-only, various closed parts are included in the build anyway, at least on Windows. This needs to be fixed in preparation for the new hotspot build for build output comparisons to be meaningful between

Re: RFR(XS): JDK-8152679 DeadlockDetectionTest.java fails due to expected output missing

On 04/07/16 10:56, Dmitry Samersoff wrote: Everybody, Please review small changes. Note: I am not a "R"eviewer in Serviceability. Free advice follows: http://cr.openjdk.java.net/~dsamersoff/JDK-8152679/webrev.01/ Test that is not expected to work on OS X, detect OS X and exits. 84

Re: CFV: New Serviceability Group Member: Staffan Larsen

Vote: yes I hereby nominate Staffan Larsen to Membership in the Serviceability Group. Tim

Re: CFV: New Serviceability Group Lead: Staffan Larsen

Vote: yes On 07/07/16 16:48, Daniel D. Daugherty wrote: I hereby nominate Staffan Larsen to Serviceability Group Lead [1]. Tim

Re: RFR: JDK-8161057 Solaris: deprecated/obsolete compiler flags should be removed

Alan: This removes redundant/incorrect compilation flags from the Solaris build environment. https://bugs.openjdk.java.net/browse/JDK-8161057 http://cr.openjdk.java.net/~dcubed/for_alanbur/8161057-webrev/0-jdk9-hs-all/ I already have one commend from DanD: jdk/src/demo/share/jvmti/java_c

Re: RFR: JDK-8166202: Tracefile gensrc cannot handle closed src dir in different location

Erik: The xml/xsl source files used to generate sources for trace in hotspot have hard coded relative paths in them that make assumptions on where the oracle closed files are located. The source files should not make these kind of assumptions since that makes it difficult to change the repositor

Re: CFV: New Serviceability Group Lead: Serguei Spitsyn

Vote: yes Tim On 04/04/17 06:46, Daniel D. Daugherty wrote: I hereby nominate Serguei Spitsyn to Serviceability Group Lead

Re: RFR: Changes to disable and/or remove Solaris 32-bit from JDK8

Kumar - the makefile changes look good to me. Tim On 09/ 7/13 03:50 AM, Staffan Larsen wrote: This is a welcome change. I've looked at the serviceability test and the changes look good except: test/demo/jvmti/DemoRun.java test/sun/tools/jhat/HatRun.java - Looks like there are still some -d

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Open changes look good to me as well. Tim On 10/ 1/13 06:48 AM, Daniel D. Daugherty wrote: Thanks (again). You previously posted a review for the OpenJDK side on 2013.09.23... :-) Dan On 10/1/13 2:42 AM, Erik Joelsson wrote: I have looked at the build changes in the root and jdk repos and th

Re: code review round 0 for minor FDS makefile fix (8033714)

On 02/ 6/14 08:32 AM, Daniel D. Daugherty wrote: Looks good to me, Dan Tim On 6/02/2014 9:20 AM, Daniel D. Daugherty wrote: This code review request is going to three different aliases. Don't use Thunderbird's "reply to list" option since it will pick just _one_ of the _three_ lists. Greeti

Re: RFR: 7172176 java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing

Erik: Well done - thank you for fixing this! I apologize for inflicting the original test implementation on jconsole. It is very embarrassing to look at code I wrote eight years ago. Tim Bell On 05/30/12 04:40, Erik Gahlin wrote: Hi, Could you please review 7172176, which is a test fix

Re: Need reviewer: a couple of hprof fixes for Parfait

7176138: Fixes for missing close() calls and possible null pointer reference instead of fatal error http://cr.openjdk.java.net/~ohair/openjdk8/parfait_hprof_fixes/webrev/ Looks good to me - reviewed! Tim

Re: Need reviewer: a couple of hprof fixes for Parfait

On 06/12/12 13:49, Kelly O'Hair wrote: Calling table_get_info() kind of assumes you are asking for an info structure, and that info structures exist. Again, no change from the way it always was. The only real change is get_info(), which no longer explicitly returns NULL. There is really nothing

Re: Need reviewer for warning error fix on hprof_init.c

Kelly wrote: 7198327: Fix mac warning error in hprof_init.c http://cr.openjdk.java.net/~ohair/openjdk8/repo-jdk/webrev/src/share/demo/jvmti/hprof/hprof_init.c.sdiff.html The Mac

Re: code review request for 7153050 remove crufty '_g' support

This looks fine to me from a build and build-infra perspective. Thanks for taking this on - code deletion is all good. Tim On 12/13/12 15:33, Daniel D. Daugherty wrote: Trying again... now my e-mail client is complaining... Adding back in the other OpenJDK aliases... Ron's e-mail has gone of

hg: jdk8/tl: 8009019: Updates to generated-configure.sh required for 8008914

Changeset: cb0ac8979caa Author:tbell Date: 2013-02-26 09:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/cb0ac8979caa 8009019: Updates to generated-configure.sh required for 8008914 Reviewed-by: sundar, jlaskey, jjg ! common/autoconf/generated-configure.sh

Re: Tools or VM agents to verify hashCode/equals/compareTo contracts

On 04/04/13 01:35, Alan Bateman wrote: On The TimSort then I assume you know there is a system property to use merge sort (this will of course hide the problem as before but useful as a get-of-jail card if you need it). In that case, a debug or assert checking mode could do the sorting both w

Re: RFR (XS): 8019155 Update makefiles with correct jfr packages

Looks good to me as well. Tim On 06/26/13 05:32 AM, David Holmes wrote: +1 from me. David On 26/06/2013 6:08 PM, Staffan Larsen wrote: Thanks Erik and Markus. Widening the audience to get the required number of reviewers. Thanks, /Staffan On 26 jun 2013, at 10:02, Erik Joelsson wrote:

Re: RFR(S): 8022071 Some vm/jvmti tests fail because cannot attach to the Java virtual machine

On 08/16/13 09:51 AM, Staffan Larsen wrote: This failure happens when compiling with the VS 2012 compiler. The attach code relies on the order of two methods in the compiled binary and VS 2012 changed that order. The solution used is the linker flag /ORDER [1] which allows us to specify the or

Re: RFR (XS) 8023406 - [windows] build_vm_def.sh takes too long even when BUILD_WIN_SA != 1

Hello Ioi: build-dev folks, any comments? I have updated the patch to remove the SKIP_GENERATED changes: http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_002/ make/windows/build_vm_def.sh Seems as if line 86: 86 "$CAT" vm1.def vm2.def > vm.def Will clobber the friendly

Re: RFR (XS) 8023406 - [windows] build_vm_def.sh takes too long even when BUILD_WIN_SA != 1

On 08/21/13 12:34 PM, Tim Bell wrote: Hello Ioi: build-dev folks, any comments? I have updated the patch to remove the SKIP_GENERATED changes: http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_002/ make/windows/build_vm_def.sh Seems as if line 86: 86 "$CAT" v

hg: jdk7/tl/corba: 2 new changesets

Changeset: 07b3e9ba5085 Author:xdono Date: 2009-08-13 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/07b3e9ba5085 Added tag jdk7-b69 for changeset 8120d308ec4e ! .hgtags Changeset: 175bd6877954 Author:tbell Date: 2009-08-14 08:49 -0700 URL: http://hg.

hg: jdk7/tl/hotspot: 2 new changesets

Changeset: 5021b9893d0a Author:xdono Date: 2009-08-13 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5021b9893d0a Added tag jdk7-b69 for changeset 54fd4d923296 ! .hgtags Changeset: 0632c3e615a3 Author:tbell Date: 2009-08-14 08:50 -0700 URL: http://h

hg: jdk7/tl/jaxp: 2 new changesets

Changeset: 8287833daabc Author:xdono Date: 2009-08-13 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/8287833daabc Added tag jdk7-b69 for changeset a4ab0d6ded63 ! .hgtags Changeset: c83f0106b78a Author:tbell Date: 2009-08-14 08:50 -0700 URL: http://hg.o

hg: jdk7/tl/jaxws: 3 new changesets

Changeset: 1041c9cce799 Author:xdono Date: 2009-08-13 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/1041c9cce799 Added tag jdk7-b69 for changeset 3e64fdfb9291 ! .hgtags Changeset: 6608dd3dae86 Author:tbell Date: 2009-08-14 08:51 -0700 URL: http://hg.

hg: jdk7/tl/jdk: 6 new changesets

Changeset: 7e491e39ea0f Author:tbell Date: 2009-08-06 17:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7e491e39ea0f 6865853: Additional code changes needed to build deploy using WXP SP2 and Visual Studio 2008 Reviewed-by: ohair ! src/windows/native/sun/jkernel/kernel.cp

hg: jdk7/tl/langtools: 3 new changesets

Changeset: 4ac89259512f Author:xdono Date: 2009-08-13 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4ac89259512f Added tag jdk7-b69 for changeset ce9bcdcb7859 ! .hgtags Changeset: 97d06f3e8787 Author:tbell Date: 2009-08-14 08:53 -0700 URL: http:/

Re: Need reviewer - jdk7 jdwpgen, added netbeans project, fixed findbugs errors

Hi Kelly >6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project > > > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-jdwpgen-6853636/webrev/ > > Pretty harmless code cleanup on the tool used to generate > some of the JDWP code for the debugger. This is a tool run at buil

Re: Need reviewer - jdk7 jdwpgen, added netbeans project, fixed findbugs errors

Hi Kelly > Let me know if this looks ok now. This looks fine, although I didn't review the netbeans files. Tim

Re: Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException

Hi Alan: > Tim - do you mind reviewing this one? Sure. > The issue as you know, arises > when the debuggee is connected to something that isn't a debugger and > the handshake fails. The transport code writes the error message into a > buffer on the stack that isn't sized correctly and so can t

hg: jdk7/tl: 4 new changesets

Changeset: 51a71c2c4b80 Author:xdono Date: 2009-08-13 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/51a71c2c4b80 Added tag jdk7-b69 for changeset 82e6c820c51a ! .hgtags Changeset: 175cb3fe6159 Author:tbell Date: 2009-08-14 08:49 -0700 URL: http://hg.openjd

hg: jdk7/tl/corba: Added tag jdk7-b70 for changeset 175bd6877954

Changeset: 9f1959c73473 Author:xdono Date: 2009-08-20 11:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/9f1959c73473 Added tag jdk7-b70 for changeset 175bd6877954 ! .hgtags

hg: jdk7/tl/hotspot: 42 new changesets

Changeset: 50a704b1d838 Author:xdono Date: 2009-08-20 11:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/50a704b1d838 Added tag jdk7-b70 for changeset 0632c3e615a3 ! .hgtags Changeset: f753dffae23e Author:trims Date: 2009-08-13 17:47 -0700 URL: http://h

hg: jdk7/tl/jaxp: Added tag jdk7-b70 for changeset c83f0106b78a

Changeset: ff94d8ce0dad Author:xdono Date: 2009-08-20 11:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/ff94d8ce0dad Added tag jdk7-b70 for changeset c83f0106b78a ! .hgtags

hg: jdk7/tl/jaxws: Added tag jdk7-b70 for changeset dd3c5f3ec28d

Changeset: 03314cf56a72 Author:xdono Date: 2009-08-20 11:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/03314cf56a72 Added tag jdk7-b70 for changeset dd3c5f3ec28d ! .hgtags

hg: jdk7/tl/jdk: 16 new changesets

Changeset: fb51d4974400 Author:uta Date: 2009-07-31 17:24 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fb51d4974400 6851688: Hung up in applet application Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_To

hg: jdk7/tl/langtools: 3 new changesets

Changeset: 6f07b50a8796 Author:xdono Date: 2009-08-20 11:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6f07b50a8796 Added tag jdk7-b70 for changeset 97d06f3e8787 ! .hgtags Changeset: 33c8c38e1757 Author:tbell Date: 2009-08-24 22:28 -0700 URL: http:/

hg: jdk7/tl: Added tag jdk7-b71 for changeset 4c36e9853dda

Changeset: 378f57273f09 Author:xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/378f57273f09 Added tag jdk7-b71 for changeset 4c36e9853dda ! .hgtags

hg: jdk7/tl/corba: 4 new changesets

Changeset: 8001ba2bf10d Author:andrew Date: 2009-08-20 01:28 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/8001ba2bf10d 6873059: Explicitly use -source 6 -target 6 when compiling with the boot jdk javac Summary: The bootstrap javac currently uses the default source and ta

hg: jdk7/tl/hotspot: Added tag jdk7-b71 for changeset 50a95aa4a247

Changeset: 6e6427f797c0 Author:xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6e6427f797c0 Added tag jdk7-b71 for changeset 50a95aa4a247 ! .hgtags

hg: jdk7/tl/jaxp: Added tag jdk7-b71 for changeset ff94d8ce0dad

Changeset: 37c805b6156f Author:xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/37c805b6156f Added tag jdk7-b71 for changeset ff94d8ce0dad ! .hgtags

hg: jdk7/tl/jaxws: Added tag jdk7-b71 for changeset 03314cf56a72

Changeset: 4c990aa99bc0 Author:xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/4c990aa99bc0 Added tag jdk7-b71 for changeset 03314cf56a72 ! .hgtags

hg: jdk7/tl/jdk: 9 new changesets

Changeset: 80368890a2a0 Author:andrew Date: 2009-08-18 19:50 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/80368890a2a0 6873059: Explicitly use -source 6 -target 6 when compiling with the boot jdk javac Summary: The bootstrap javac currently uses the default source and targ

hg: jdk7/tl/langtools: 2 new changesets

Changeset: d434aa041b52 Author:xdono Date: 2009-09-03 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d434aa041b52 Added tag jdk7-b71 for changeset 33c8c38e1757 ! .hgtags Changeset: 90c28923e449 Author:tbell Date: 2009-09-03 18:34 -0700 URL: http:/

Re: Review request for 6529758: JVMTI Waiters demo crashes. Double free.

Alan Bateman wrote: > This one is a fix to the JVM TI "waiters" demo. When the VM terminates, > the agent frees the Monitors on its list but some may already have been > freed by the ObjectFree callback. The fix changes the ObjectFree > callback so that it removes the Monitor from the agent's li

hg: jdk7/tl: 2 new changesets

Changeset: 4079d923a501 Author:peterz Date: 2009-08-31 14:10 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4079d923a501 6844267: Nimbus generator depends on JIBX Summary: Nimbus generator now uses JAXB instead of JIBX Reviewed-by: jasper ! README-builds.html Changeset: 0d7e03b

hg: jdk7/tl/hotspot: 31 new changesets

Changeset: a05ea7791ee3 Author:trims Date: 2009-08-21 20:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a05ea7791ee3 6873236: Fork HS16 to HS17 - renumber Major and build numbers of JVM Summary: Update the Major and build numbers for HS17 fork Reviewed-by: jcoomes ! m

hg: jdk7/tl/jdk: 30 new changesets

Changeset: 559fb14d0ae9 Author:anthony Date: 2009-08-27 16:42 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/559fb14d0ae9 6780496: Javaw process taking up 80-90 percent of CPU time! Summary: The transparency effects get enabled on showing, and disabled on hiding a window Rev

hg: jdk7/tl: Added tag jdk7-b72 for changeset 0d7e03b426df

Changeset: 4c4fe09fb670 Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4c4fe09fb670 Added tag jdk7-b72 for changeset 0d7e03b426df ! .hgtags

hg: jdk7/tl/corba: Added tag jdk7-b72 for changeset c793a3120926

Changeset: 12991b453239 Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/12991b453239 Added tag jdk7-b72 for changeset c793a3120926 ! .hgtags

hg: jdk7/tl/hotspot: Added tag jdk7-b72 for changeset a94714c55065

Changeset: 1e5f0e56d242 Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1e5f0e56d242 Added tag jdk7-b72 for changeset a94714c55065 ! .hgtags

hg: jdk7/tl/jaxp: Added tag jdk7-b72 for changeset 37c805b6156f

Changeset: 93dfa6e0fe76 Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/93dfa6e0fe76 Added tag jdk7-b72 for changeset 37c805b6156f ! .hgtags

hg: jdk7/tl/jaxws: Added tag jdk7-b72 for changeset 4c990aa99bc0

Changeset: d79f0d601c2b Author:xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d79f0d601c2b Added tag jdk7-b72 for changeset 4c990aa99bc0 ! .hgtags

hg: jdk7/tl/jdk: 2 new changesets

Changeset: f09a2bfba691 Author:xdono Date: 2009-09-17 13:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f09a2bfba691 Added tag jdk7-b72 for changeset 460639b036f3 ! .hgtags Changeset: f119e21c0ca7 Author:tbell Date: 2009-09-18 08:47 -0700 URL: http://hg.op

hg: jdk7/tl/langtools: 2 new changesets

Changeset: bfad32768345 Author:xdono Date: 2009-09-17 13:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bfad32768345 Added tag jdk7-b72 for changeset 261c54b2312e ! .hgtags Changeset: 5dd400fd62d9 Author:tbell Date: 2009-09-18 08:48 -0700 URL: http:/

hg: jdk7/tl: 5 new changesets

Changeset: e76b72562a98 Author:ohair Date: 2009-09-03 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/e76b72562a98 6855174: Improve log output when builds transition from one workspace to another Reviewed-by: jjg ! make/Defs-internal.gmk ! make/corba-rules.gmk ! make/deploy

hg: jdk7/tl/corba: 6 new changesets

Changeset: 1c130e7b7a2e Author:ohair Date: 2009-09-02 09:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/1c130e7b7a2e 6875240: Reduce Makefile build time by limiting repeated exec's (mostly for cygwin building) Reviewed-by: jjg, iris ! make/Makefile ! make/common/BuildT

hg: jdk7/tl/hotspot: 6884624: Update copyright year

Changeset: 89e0543e1737 Author:xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/89e0543e1737 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! agen

hg: jdk7/tl/jaxp: 3 new changesets

Changeset: 534e23823a1b Author:ohair Date: 2009-09-21 13:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/534e23823a1b 6856630: Restructure jaxp/jaxws repositories Reviewed-by: darcy, tbell ! .hgignore ! README + build-defs.xml + build-drop-template.xml + build.properties

hg: jdk7/tl/jaxws: 2 new changesets

Changeset: ae2bec597586 Author:ohair Date: 2009-09-21 13:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/ae2bec597586 6856630: Restructure jaxp/jaxws repositories Reviewed-by: darcy, tbell ! .hgignore ! README + build-defs.xml + build-drop-template.xml + build.properties

hg: jdk7/tl/langtools: 3 new changesets

Changeset: 14735c7932d7 Author:xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/14735c7932d7 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! sr

Please review test fix: 6787605 "OpenSolaris doesn't have /usr/ucb/ps so ShellScaffold fails"

jdk/test/com/sun/jdi/ShellScaffold.sh is used in many of the jdk/test/com/sun/jdi JTreg tests. JDI tests are unlike other JTreg tests because they typically start up two additional JVMs - one for the debugger and one for the debugee. This raises the problem of keeping track of the child process(es

Re: Please review test fix: 6787605 "OpenSolaris doesn't have /usr/ucb/ps so ShellScaffold fails"

Daniel D. Daugherty wrote: > Looks good to me. Thanks, Dan! Tim

hg: jdk7/tl/jdk: 6787605: OpenSolaris doesn't have /usr/ucb/ps so ShellScaffold fails

Changeset: 9fcca0aae3da Author:tbell Date: 2009-10-02 08:49 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9fcca0aae3da 6787605: OpenSolaris doesn't have /usr/ucb/ps so ShellScaffold fails Reviewed-by: dcubed ! test/com/sun/jdi/ShellScaffold.sh

Re: Please review test fix: 6787605 "OpenSolaris doesn't have /usr/ucb/ps so ShellScaffold fails"

Kelly O'Hair wrote: > Looks ok to me. Thanks! I pushed the changeset. I have been meaning to get this off my desk for a long time. Tim

hg: jdk7/tl/jdk: 6888888: new javah throws NullPointerException when building in jdk/make/java/nio

Changeset: 14bd992a Author:tbell Date: 2009-10-07 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/14bd992a 688: new javah throws NullPointerException when building in jdk/make/java/nio Summary: Use the bootstrap javah during the build until bug-ID 6889255 is

hg: jdk7/tl: 2 new changesets

Changeset: 2c88089b6e1c Author:xdono Date: 2009-10-02 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/2c88089b6e1c Added tag jdk7-b73 for changeset 3ac6dcf78232 ! .hgtags Changeset: d1516b9f2395 Author:xdono Date: 2009-10-15 16:40 -0700 URL: http://hg.openjd

hg: jdk7/tl/corba: 2 new changesets

Changeset: 5d0cf59a3203 Author:xdono Date: 2009-10-02 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/5d0cf59a3203 Added tag jdk7-b73 for changeset b751c528c555 ! .hgtags Changeset: 0fb137085952 Author:xdono Date: 2009-10-15 16:40 -0700 URL: http://hg.

hg: jdk7/tl/hotspot: 54 new changesets

Changeset: 489a4f8dcd0f Author:twisti Date: 2009-08-27 06:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/489a4f8dcd0f 6865583: Verbose CIPrintMethodCodes asserts when ldc an empty String Summary: ldc seems to load an empty String and that leads to an assert on offset

hg: jdk7/tl/jaxp: 3 new changesets

Changeset: feb05980f9f2 Author:ohair Date: 2009-09-28 19:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/feb05980f9f2 6886359: Missing jaxws property files and missing changes in jaxp/jaxws drop bundles Reviewed-by: jjg, tbell ! build-defs.xml ! jaxp.properties Changese

hg: jdk7/tl/jaxws: 3 new changesets

Changeset: 558985e26fe1 Author:ohair Date: 2009-09-28 19:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/558985e26fe1 6886359: Missing jaxws property files and missing changes in jaxp/jaxws drop bundles Reviewed-by: jjg, tbell ! build-defs.xml ! jaxws.properties Change

hg: jdk7/tl/jdk: 42 new changesets

Changeset: 59b45d636384 Author:xdono Date: 2009-10-02 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/59b45d636384 Added tag jdk7-b73 for changeset f708138c9aca ! .hgtags Changeset: 8e5d45fc8d1e Author:jgodinez Date: 2009-07-01 12:07 -0700 URL: http://hg

hg: jdk7/tl/langtools: 4 new changesets

Changeset: d498d6ef9c6c Author:xdono Date: 2009-10-02 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d498d6ef9c6c Added tag jdk7-b73 for changeset 9596dff46093 ! .hgtags Changeset: 1a66b08deed0 Author:tbell Date: 2009-10-07 14:14 -0700 URL: http:/

Please review test fix: 6893426 ShellScaffold.sh fails on Solaris 10 update releases: /usr/bin/id: illegal option -- u

Hello- My ShellScaffold.sh fix in 6787605 [1] works fine on OpenSolaris, but fails on older Solaris 10 releases. My fault for not testing it there as well. I have prepared 6893426 [2] as a fix that works on both flavors of Solaris: http://cr.openjdk.java.net/~tbell/6893426/ Thanks in advance-

hg: jdk7/tl/jdk: 6893426: ShellScaffold.sh fails on Solaris 10 update releases: /usr/bin/id: illegal option -- u

Changeset: b0433598e26d Author:tbell Date: 2009-10-21 00:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b0433598e26d 6893426: ShellScaffold.sh fails on Solaris 10 update releases: /usr/bin/id: illegal option -- u Reviewed-by: ohair, dcubed ! test/com/sun/jdi/ShellScaffol

Re: Please review test fix: 6893426 ShellScaffold.sh fails on Solaris 10 update releases: /usr/bin/id: illegal option -- u

I wrote: > I have prepared 6893426 [2] as a fix that works on both flavors of Solaris: > > http://cr.openjdk.java.net/~tbell/6893426/ Dan, Kelly - thank you for the review. I pushed the test fix: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b0433598e26d Tim

hg: jdk7/tl/hotspot: 30 new changesets

Changeset: 528d98fe1037 Author:xlu Date: 2009-09-24 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/528d98fe1037 6880029: JDK 1.6.0_u14p Application crashed very early Reviewed-by: never, ysr, acorn ! src/share/vm/runtime/safepoint.cpp Changeset: 054afbef9081 Autho

hg: jdk7/tl/jdk: 3 new changesets

Changeset: 8885b2256507 Author:ohair Date: 2009-10-29 11:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8885b2256507 6896472: Missing libjsig.so causes jdk build failure Reviewed-by: tbell, kvn, phh ! make/java/redist/Makefile Changeset: 9618f9a100e4 Author:tbell Dat

Re: Need reviewer for 6896829: test/sun/util/logging/PlatformLoggerTest.java needs @compile tag to be compiled by jtreg

Alan Bateman wrote: > I need a reviewer for a tiny change to a test that fails to compile as > it uses sun.* APIs. The fix is to replace the @build tag with the > @compile tag and specify that the symbol file used by javac be ignored. Looks good to me. Approved! Quite a few tests under jdk/te

Re: Need reviewer - Fixing demo/jvmti tests and correcting problem list

Kelly O'Hair wrote: > Need reviewer: > > 6899444: Fix demo/jvmti tests so they can run in jtreg samevm mode, cleanup > problemlist > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-samevm-6899444/webrev/ Looks good to me. > Fixed the demo/jvmti tests so they work in samevm mode (samevm > mod

Re: Need reviewers - 3 bugs

Hi Kelly: > Need a reviewer. > > The jhat change is from keith.rand...@gmail.com. I wasn't able to > come up with a testcase for that change. > > The other two just fix a couple of broken tests and remove them from > the ProblemList. > > 6892742: Improve root set used by jhat > 6902323: Fix test

FYI: JDK7 TL forest PIT freeze times through the end of 2009

Based on [1] (published earlier today), here are some key dates for the next few weeks: Promotion:November 12 2009 for B76 TL PIT freeze:November 16 2009 for B77 (10PM Pacific) TL Integration: November 20 2009 for B77 Promotion:December 3 2009 for B77 TL PIT freeze:Dec

hg: jdk7/tl: 4 new changesets

Changeset: 0619361ff7c5 Author:ohair Date: 2009-11-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/0619361ff7c5 Merge Changeset: c8b63075403d Author:ohair Date: 2009-11-08 14:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/c8b63075403d Merge Chang

hg: jdk7/tl/corba: 3 new changesets

Changeset: 6995f81e3b53 Author:ohair Date: 2009-11-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/6995f81e3b53 Merge Changeset: 937144222e22 Author:ohair Date: 2009-11-08 14:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/937144222e22 M

hg: jdk7/tl/hotspot: 20 new changesets

Changeset: 08780c8a9f04 Author:kamg Date: 2009-10-20 16:34 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/08780c8a9f04 6893483: DTrace probe return values for a couple JNI methods are wrong Summary: Fix the shadowing and incorrect macro usages Reviewed-by: coleenp ! src/

hg: jdk7/tl/jaxp: 2 new changesets

Changeset: 86cc67d46db5 Author:katleman Date: 2009-11-12 15:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/86cc67d46db5 Added tag jdk7-b76 for changeset 233a4871d336 ! .hgtags Changeset: bfadab8c7b1b Author:tbell Date: 2009-11-17 10:23 -0800 URL: http://h

hg: jdk7/tl/jaxws: 2 new changesets

Changeset: 701ccbf55ae5 Author:katleman Date: 2009-11-12 15:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/701ccbf55ae5 Added tag jdk7-b76 for changeset 765d2077d1e6 ! .hgtags Changeset: 5b4968c11047 Author:tbell Date: 2009-11-17 10:23 -0800 URL: http://

hg: jdk7/tl/jdk: 5 new changesets

Changeset: 7916c43cc007 Author:ohair Date: 2009-11-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7916c43cc007 Merge ! make/java/redist/Makefile Changeset: 8fb602395be0 Author:ohair Date: 2009-11-08 14:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl

hg: jdk7/tl/langtools: 3 new changesets

Changeset: 4c8c6159159c Author:katleman Date: 2009-11-12 15:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4c8c6159159c Added tag jdk7-b76 for changeset 8fb9b4be3cb1 ! .hgtags Changeset: 0398ae15b90a Author:tbell Date: 2009-11-17 10:35 -0800 URL: htt

hg: jdk7/tl/jdk: 44 new changesets

Changeset: 31e68419715e Author:igor Date: 2009-10-02 10:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/31e68419715e 6887292: memory leak in freetypeScaler.c Reviewed-by: bae, prr ! src/share/native/sun/font/freetypeScaler.c Changeset: ccc36189f2a7 Author:rkennke Date

Re: Need reviewer - fix to amd64 change and fix to exit codes in makefile

Hi Kelly > My last set of changes did not get the > "amd64/java" change right, and I messed up the exit code in > the test/Makefile... > > 6905705: Fix broken exit code values in jdk/test/Makefile > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-6905705/webrev/ > > Consequently, I was ge

Re: Need reviewers, jdk7 testing changes

Hi Kelly See below: > Need reviewer for JDK7 testing changes, e.g. testing via: >cd jdk/make && gmake all images && cd ../test && gmake jdk_all > > 6906210: Fix another minor typo in test/Makefile > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-changes4/webrev/ > > Dan had pointe

Re: Need approval, JDI updates to openjdk6

Kelly O'Hair wrote: > Andrew John Hughes wrote: >> 2009/12/7 Kelly O'Hair : >>> OpenJDK6 changes for JDI. I'm ready to push. >>> >>> I would like approvals from Joe, Jim, Alan, Dan, and Tim. >>> >>> In the process of trying to get good test results running the openjdk6 >>> debugger (JDI) and jvmti

Re: Need reviewers - 3 bugs

Kelly O'Hair wrote: > How could I at least see some email on these bugs? > Aren't they connected to the various openjdk email aliases? > > Sorry I'm not bugzilla-savy. :^( Visit http://bugs.openjdk.java.net/ and log into your bugzilla account (Sun employee logins are probably firstname.lastn...@

Re: Need reviewers - 3 bugs

Where are the "components" listed? Even >>> watch-serviceability-other reported "did not match anything" :( >>> >>> Otherwise great info, but I sure wish it was a lot easier to manage. >>> >>> Thanks, >>> David >>> >

hg: jdk7/tl: 5 new changesets

Changeset: 721c1696c124 Author:mikejwre Date: 2009-12-03 12:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/721c1696c124 Added tag jdk7-b77 for changeset 1f17ca8353ba ! .hgtags Changeset: 80161484b6b1 Author:tbell Date: 2009-12-08 09:14 -0800 URL: http://hg.ope

  1   2   3   4   >