On 04/07/16 10:56, Dmitry Samersoff wrote:
Everybody,

Please review small changes.

Note:  I am not a "R"eviewer in Serviceability.  Free advice follows:

http://cr.openjdk.java.net/~dsamersoff/JDK-8152679/webrev.01/

Test that is not expected to work on OS X, detect OS X and exits.

  84             // Coredump stackwalking is not implemented for Darwin
  85             System.err.println("Error! This test is not expected to work on OS 
X.");


It is not implemented, so landing here during a test run on Mac OS should not 
be surprising.

Rather than printing 'Error!' I suggest removing that alarming string, as on 
line 107   .

My 0x02 cents.

Tim


Reply via email to