Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-04-02 Thread Yasumasa Suenaga
Hi, As other option, we can replace Observe/Observable to other class /interface. AFAICS most of classes which call VM.registerVMInitializedObserver() seems not to use arguments in Observable. For example: VM.registerVMInitializedObserver(() -> initialize(VM.getVM().getTypeDataBase())); or

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-04-02 Thread Kevin Walls
Thanks Magnus -  I think webrev.03 expanded to change all the imports will keep us all happy for now, Thanks Kevin

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-04-01 Thread David Holmes
On 2/04/2020 10:21 am, Chris Plummer wrote: On 4/1/20 4:29 PM, David Holmes wrote: On 2/04/2020 8:16 am, coleen.phillim...@oracle.com wrote: On 4/1/20 4:01 PM, Chris Plummer wrote: On 4/1/20 5:13 AM, Magnus Ihse Bursie wrote: On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all -

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-04-01 Thread Chris Plummer
On 4/1/20 4:29 PM, David Holmes wrote: On 2/04/2020 8:16 am, coleen.phillim...@oracle.com wrote: On 4/1/20 4:01 PM, Chris Plummer wrote: On 4/1/20 5:13 AM, Magnus Ihse Bursie wrote: On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove at

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-04-01 Thread David Holmes
On 2/04/2020 8:16 am, coleen.phillim...@oracle.com wrote: On 4/1/20 4:01 PM, Chris Plummer wrote: On 4/1/20 5:13 AM, Magnus Ihse Bursie wrote: On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-04-01 Thread coleen . phillimore
On 4/1/20 4:01 PM, Chris Plummer wrote: On 4/1/20 5:13 AM, Magnus Ihse Bursie wrote: On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope of what a clhsdb can do in future. Commands like jstac

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-04-01 Thread Chris Plummer
On 4/1/20 5:13 AM, Magnus Ihse Bursie wrote: On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope of what a clhsdb can do in future. Commands like jstack are a one-shot operation.  A Tool like clh

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-04-01 Thread coleen . phillimore
On 4/1/20 6:22 AM, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope of what a clhsdb can do in future. Commands like jstack are a one-shot operation.  A Tool like clhsdb is ideally more flexible than that. The

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-04-01 Thread Magnus Ihse Bursie
On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope of what a clhsdb can do in future. Commands like jstack are a one-shot operation.  A Tool like clhsdb is ideally more flexible than that. Th

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-04-01 Thread Kevin Walls
Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope of what a clhsdb can do in future. Commands like jstack are a one-shot operation.  A Tool like clhsdb is ideally more flexible than that. The SA is (I suggest) "too static" in its "the

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-03-31 Thread coleen . phillimore
On 3/31/20 4:55 PM, Chris Plummer wrote: On 3/31/20 1:32 PM, coleen.phillim...@oracle.com wrote: On 3/31/20 12:19 PM, Poonam Parhar wrote: Hello Coleen, Does the removal of this code only impact the 'reattach' functionality, and it does not affect any commands available in 'clhsdb' once

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-03-31 Thread Chris Plummer
On 3/31/20 1:32 PM, coleen.phillim...@oracle.com wrote: On 3/31/20 12:19 PM, Poonam Parhar wrote: Hello Coleen, Does the removal of this code only impact the 'reattach' functionality, and it does not affect any commands available in 'clhsdb' once it is attached to a core file? If that's tru

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-03-31 Thread coleen . phillimore
On 3/31/20 12:19 PM, Poonam Parhar wrote: Hello Coleen, Does the removal of this code only impact the 'reattach' functionality, and it does not affect any commands available in 'clhsdb' once it is attached to a core file? If that's true, then I think it should be okay to remove this code.

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-03-31 Thread Poonam Parhar
Hello Coleen, Does the removal of this code only impact the 'reattach' functionality, and it does not affect any commands available in 'clhsdb' once it is attached to a core file? If that's true, then I think it should be okay to remove this code. Thanks, Poonam On 3/31/20 5:34 AM, coleen.p

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-03-31 Thread Magnus Ihse Bursie
On 2020-03-31 14:34, coleen.phillim...@oracle.com wrote: To answer my own question, this functionality is used to allow detach/reattach from {cl}hsdb.  Which seems to work on linux but not windows with this code removed. The next question is whether this is useful functionality to justify

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-03-31 Thread coleen . phillimore
To answer my own question, this functionality is used to allow detach/reattach from {cl}hsdb.  Which seems to work on linux but not windows with this code removed. The next question is whether this is useful functionality to justify all this code (900+ and this new code that Magnus has adde

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-03-30 Thread coleen . phillimore
I was wondering why this is needed when debugging a core file, which is the key thing we need the SA for:   /** This is used by both the debugger and any runtime system. It is   the basic mechanism by which classes which mimic underlying VM   functionality cause themselves to be initi

Re: Discussion about fixing deprecation in jdk.hotspot.agent

2020-03-30 Thread Magnus Ihse Bursie
No opinions on this? /Magnus On 2020-03-25 23:34, Magnus Ihse Bursie wrote: Hi everyone, As a follow-up to the ongoing review for JDK-8241618, I have also looked at fixing the deprecation warnings in jdk.hotspot.agent. These fall in three broad categories: * Deprecation of the boxing type

Discussion about fixing deprecation in jdk.hotspot.agent

2020-03-25 Thread Magnus Ihse Bursie
Hi everyone, As a follow-up to the ongoing review for JDK-8241618, I have also looked at fixing the deprecation warnings in jdk.hotspot.agent. These fall in three broad categories: * Deprecation of the boxing type constructors (e.g. "new Integer(42)"). * Deprecation of java.util.Observer and