Re: RFR(S): 8196909: gcc 7.2.1 compiler warning in libdt_socket

2018-02-15 Thread Chris Plummer 

Thanks Christoph and Serguei.

Chris

On 2/14/18 11:47 PM, Langer, Christoph wrote:

Hi Chris,

looks good.

Best regards
Christoph


-Original Message-
From: serviceability-dev [mailto:serviceability-dev-
boun...@openjdk.java.net] On Behalf Of Chris Plummer
Sent: Mittwoch, 14. Februar 2018 23:31
To: serviceability-dev 
Cc: Indu Bhagat 
Subject: RFR(S): 8196909: gcc 7.2.1 compiler warning in libdt_socket

Hello,

Please review the following simple fix for a compiler warning:

https://bugs.openjdk.java.net/browse/JDK-8196909

diff --git
a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
--- a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
+++ b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
@@ -398,7 +398,7 @@
      return instr;
   }

-    *mask = htonl(-1 << (32 - m));
+    *mask = htonl((uint32_t)(~0) << (32 - m));
   return s;
   }


Tested with all open and closed jdb, jdwp, and jdi test suites on all
supported platforms.

thanks,

Chris

RE: RFR(S): 8196909: gcc 7.2.1 compiler warning in libdt_socket

2018-02-14 Thread Langer, Christoph 
Hi Chris,

looks good.

Best regards
Christoph

> -Original Message-
> From: serviceability-dev [mailto:serviceability-dev-
> boun...@openjdk.java.net] On Behalf Of Chris Plummer
> Sent: Mittwoch, 14. Februar 2018 23:31
> To: serviceability-dev 
> Cc: Indu Bhagat 
> Subject: RFR(S): 8196909: gcc 7.2.1 compiler warning in libdt_socket
> 
> Hello,
> 
> Please review the following simple fix for a compiler warning:
> 
> https://bugs.openjdk.java.net/browse/JDK-8196909
> 
> diff --git
> a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
> b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
> --- a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
> +++ b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
> @@ -398,7 +398,7 @@
>      return instr;
>   }
> 
> -    *mask = htonl(-1 << (32 - m));
> +    *mask = htonl((uint32_t)(~0) << (32 - m));
>   return s;
>   }
> 
> 
> Tested with all open and closed jdb, jdwp, and jdi test suites on all
> supported platforms.
> 
> thanks,
> 
> Chris

Re: RFR(S): 8196909: gcc 7.2.1 compiler warning in libdt_socket

2018-02-14 Thread serguei.spit...@oracle.com 

Hi Chris,

Looks good.

Thanks,
Serguei


On 2/14/18 14:30, Chris Plummer wrote:

Hello,

Please review the following simple fix for a compiler warning:

https://bugs.openjdk.java.net/browse/JDK-8196909

diff --git 
a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c 
b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c

--- a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
+++ b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
@@ -398,7 +398,7 @@
    return instr;
 }

-    *mask = htonl(-1 << (32 - m));
+    *mask = htonl((uint32_t)(~0) << (32 - m));
 return s;
 }


Tested with all open and closed jdb, jdwp, and jdi test suites on all 
supported platforms.


thanks,

Chris

RFR(S): 8196909: gcc 7.2.1 compiler warning in libdt_socket

2018-02-14 Thread Chris Plummer 

Hello,

Please review the following simple fix for a compiler warning:

https://bugs.openjdk.java.net/browse/JDK-8196909

diff --git 
a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c 
b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c

--- a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
+++ b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
@@ -398,7 +398,7 @@
    return instr;
 }

-    *mask = htonl(-1 << (32 - m));
+    *mask = htonl((uint32_t)(~0) << (32 - m));
 return s;
 }


Tested with all open and closed jdb, jdwp, and jdi test suites on all 
supported platforms.


thanks,

Chris