Re: RFR(S) 8161225: Assert failure in JVMTI GetNamedModule at JPLISAgent.c line: 792

2016-09-28 Thread Dmitry Samersoff
Chris, Looks good for me. But please, wait for Serguei. -Dmitry On 2016-09-21 08:07, Chris Plummer wrote: > Hello, > > Please help review the following: > > https://bugs.openjdk.java.net/browse/JDK-8161225 > http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/ > > The main fix is in JPLI

Re: RFR(S) 8161225: Assert failure in JVMTI GetNamedModule at JPLISAgent.c line: 792

2016-09-21 Thread Chris Plummer
On 9/21/16 9:33 AM, Chris Plummer wrote: On 9/21/16 7:33 AM, Daniel D. Daugherty wrote: On 9/20/16 11:07 PM, Chris Plummer wrote: Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8161225 http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/ hotspot/src/sh

Re: RFR(S) 8161225: Assert failure in JVMTI GetNamedModule at JPLISAgent.c line: 792

2016-09-21 Thread Chris Plummer
On 9/21/16 7:33 AM, Daniel D. Daugherty wrote: On 9/20/16 11:07 PM, Chris Plummer wrote: Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8161225 http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/ hotspot/src/share/vm/prims/jvmtiEnter.xsl L490:

Re: RFR(S) 8161225: Assert failure in JVMTI GetNamedModule at JPLISAgent.c line: 792

2016-09-21 Thread Chris Plummer
Hi Serguei, Thanks for the review. I'll fix the missing space and run the java/lang/instrument tests. thanks, Chris On 9/21/16 1:25 AM, serguei.spit...@oracle.com wrote: Chris, Forgot to tell about the testing. You also need to run all the JTREG java/lang/instrument tests. Thanks, Serguei

Re: RFR(S) 8161225: Assert failure in JVMTI GetNamedModule at JPLISAgent.c line: 792

2016-09-21 Thread Daniel D. Daugherty
On 9/20/16 11:07 PM, Chris Plummer wrote: Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8161225 http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/ hotspot/src/share/vm/prims/jvmtiEnter.xsl L490: log_trace(jvmti)("[-] %s %s(%d)", func_na

Re: RFR(S) 8161225: Assert failure in JVMTI GetNamedModule at JPLISAgent.c line: 792

2016-09-21 Thread serguei.spit...@oracle.com
Chris, Forgot to tell about the testing. You also need to run all the JTREG java/lang/instrument tests. Thanks, Serguei On 9/21/16 01:21, serguei.spit...@oracle.com wrote: Hi Chris, It looks good. One minor comment: http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/webrev.hotspot/src

Re: RFR(S) 8161225: Assert failure in JVMTI GetNamedModule at JPLISAgent.c line: 792

2016-09-21 Thread serguei.spit...@oracle.com
Hi Chris, It looks good. One minor comment: http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/webrev.hotspot/src/share/vm/prims/jvmtiEnter.xsl.frames.html 491 JvmtiUtil::error_name(JVMTI_ERROR_WRONG_PHASE),JvmtiEnv::get_phase()); A space is missed after the comma. Thanks, Serguei

Re: RFR(S) 8161225: Assert failure in JVMTI GetNamedModule at JPLISAgent.c line: 792

2016-09-20 Thread Chris Plummer
On 9/20/16 10:48 PM, David Holmes wrote: Hi Chris, On 21/09/2016 3:07 PM, Chris Plummer wrote: Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8161225 http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/ Looks fine. Only comment: test/java/lang/instrum

Re: RFR(S) 8161225: Assert failure in JVMTI GetNamedModule at JPLISAgent.c line: 792

2016-09-20 Thread David Holmes
Hi Chris, On 21/09/2016 3:07 PM, Chris Plummer wrote: Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8161225 http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/ Looks fine. Only comment: test/java/lang/instrument/DaemonThread/TestDaemonThreadLauncher.

RFR(S) 8161225: Assert failure in JVMTI GetNamedModule at JPLISAgent.c line: 792

2016-09-20 Thread Chris Plummer
Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8161225 http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/ The main fix is in JPLISAgent.c, which is to no longer call jplis_assert_msg() when there is a PHASE error, and also remove the test from ProblemL