Hi JC,
I have looked through your changes.
In threadLocalAllocBuffer.cpp:
349 HeapWord* ThreadLocalAllocBuffer::allocate_sampled_object(size_t
size) {
350 Thread* thread = myThread();
351 thread->tlab().set_back_allocation_end();
352 HeapWord* result = thread->tlab().allocate(size);
Hi,
On Mon, 2018-05-14 at 13:02 -0700, JC Beyler wrote:
> Hi Robbin and all,
>
> Thank you for your continuous help!
>
> Done then! Here is the new webrev:
> http://cr.openjdk.java.net/~jcbeyler/8171119/heap_event.20/
>
> and the incremental is:
> http://cr.openjdk.java.net/~jcbeyler/8171119/he
Hi Robbin and all,
Thank you for your continuous help!
Done then! Here is the new webrev:
http://cr.openjdk.java.net/~jcbeyler/8171119/heap_event.20/
and the incremental is:
http://cr.openjdk.java.net/~jcbeyler/8171119/heap_event.19_20/
Thanks again all!
Jc
On Mon, May 14, 2018 at 12:43 PM Ro
On 2018-05-14 21:37, JC Beyler wrote:
Hi Robbin,
I did this then, which should be explicit enough, no?
// If we want to be sampling, protect the allocated object with a Handle
// before doing the callback. The callback is done in the destructor of
// the JvmtiSampledObject
Hi JC,
On 2018-05-14 17:09, JC Beyler wrote:
Hi Robbin,
First off: Thanks for looking! There were 3 comments here and I'll try to
address all three :)
From easy to more difficult:
- The thread state keeping a pointer of the collector: yes I agree but it
follows the other collector impleme
Hi Robbin,
First off: Thanks for looking! There were 3 comments here and I'll try to
address all three :)
>From easy to more difficult:
- The thread state keeping a pointer of the collector: yes I agree but it
follows the other collector implementations and with Serguei we tried to
keep that impl
Hi JC, I found a .19 which I looked at:
src/hotspot/share/gc/shared/collectedHeap.inline.hpp
CollectedHeap::allocate_memory
This is the only place I found which calls the
~JvmtiSampledObjectAllocEventCollector
It is not intuitive with creating a handle for the destructor, I suggest
something li
Hi Jc and Serguei,
I have looked at the test fixes and overall they look good. I am a little
concerned with some of the comments
I read that included “Flakiness” and “unlucky” like this comment in
HeapMonitorArrayAllSampledTest.java:
// 10% error ensures a sanity test without becoming fl
Hi Jc,
I'll make one more pass through the JVMTI and test fixes.
However, it would be good if at least one more pair of eyes
looked at the tests as they are a big part of the fix.
Thanks,
Serguei
On 5/7/18 19:28, JC Beyler wrote:
Hi Vladimir,
Good catch, I believe it was used before but no l
I did not look on JVMTI part and tests. It looks good to me.
Where _thread field is used?
Thanks,
Vladimir
On 5/7/18 6:10 PM, JC Beyler wrote:
Hi all,
With the awesome help of Serguei Spitsyn, we have moved forward on the
implementation for JEP-331 and have the following webrev for review:
W
10 matches
Mail list logo
