Re: [sigrok-devel] PS/2 Protocol decoder

2016-11-04 Thread Uwe Hermann
Hi, On Sat, Oct 15, 2016 at 07:10:48PM +0200, trilader wrote: > I've written a basic PS/2 protocol decoder. Merged with a bunch of smaller consistency and style fixes, plus some more detailed decoding, thanks a lot! I also grabbed a sample *.sr file for sigrok-dumps and created a simple test-cas

Re: [sigrok-devel] PS/2 Protocol decoder

2016-10-19 Thread Uwe Hermann
Hi, On Sat, Oct 15, 2016 at 08:29:57PM +0300, Paul Fertser wrote: > I think it would be much better to change this to > > You should have received a copy of the GNU General Public License > along with this program. If not, see . > > (that's verbatim from GPLv3) >

Re: [sigrok-devel] PS/2 Protocol decoder

2016-10-16 Thread trilader
Hey Paul, I've updated my patch with your suggestion. Thanks for the heads up. I used the parallel decoder as a basis for the PS/2 one and just copied the header information from that file. Regards Daniel On 15.10.2016 19:29, Paul Fertser wrote: > Hey Daniel, > > On Sat, Oct 15, 2016 at 07:10:

Re: [sigrok-devel] PS/2 Protocol decoder

2016-10-15 Thread Paul Fertser
Hey Daniel, On Sat, Oct 15, 2016 at 07:10:48PM +0200, trilader wrote: > +## You should have received a copy of the GNU General Public License > +## along with this program; if not, write to the Free Software > +## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA I think i

Re: [sigrok-devel] PS/2 Protocol decoder

2016-10-15 Thread Soeren Apel
Hi Daniel, thanks for the PD! Do you have sample measurements (.sr) that we can add to the sigrok-dumps repository? We use them to verify correct operation of the PD when making changes. All the best,  -Soeren On Sat, 2016-10-15 at 19:10 +0200, trilader wrote: > Hi. > > I've written a basic

[sigrok-devel] PS/2 Protocol decoder

2016-10-15 Thread trilader
Hi. I've written a basic PS/2 protocol decoder. It still has some issues decoding keyboard initialization sequences but works fine for normal keyboard to host communication. I've attached the commit adding the decoder against libsigrokdecode master to this email. Regards Daniel >From ac1e0bad67b