Re: [soci-devel] Supporting EditorConfig in SOCI

2017-09-10 Thread Mateusz Loskot
On 10 September 2017 at 21:30, Vadim Zeitlin wrote: > On Sun, 10 Sep 2017 20:04:55 +0200 Mateusz Loskot wrote: > > ML> I wonder if there is need to take care of EOLs. > ML> I'm quite certain, most if not all of us who develop/build SOCI on Windows > ML> follow the Git/GitHub guidelines for dealin

Re: [soci-devel] Supporting EditorConfig in SOCI

2017-09-10 Thread Vadim Zeitlin
On Sun, 10 Sep 2017 20:04:55 +0200 Mateusz Loskot wrote: ML> I wonder if there is need to take care of EOLs. ML> I'm quite certain, most if not all of us who develop/build SOCI on Windows ML> follow the Git/GitHub guidelines for dealing with EOLs ML> https://help.github.com/articles/dealing-with-

Re: [soci-devel] Supporting EditorConfig in SOCI

2017-09-10 Thread Alex Ott
Yes, you're right - I put LF as default option into config, but maybe it would clash with this settings - I'll comment out it right now. And I completely agree with you about discussion about SOCI source code style - we need to define defaults for putting braces, etc. I planned to start this disc

Re: [soci-devel] Supporting EditorConfig in SOCI

2017-09-10 Thread Mateusz Loskot
On 10 September 2017 at 17:58, Alex Ott wrote: > Hello all > > I've just merged pull request that adds EditorConfig support for SOCI source > code. Thanks Alex. I wonder if there is need to take care of EOLs. I'm quite certain, most if not all of us who develop/build SOCI on Windows follow the G