[jira] Commented: (SOLR-1367) Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList

2009-08-19 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12745013#action_12745013 ] Grant Ingersoll commented on SOLR-1367: --- bq. That said, docListToSolrDocList isn't

[jira] Commented: (SOLR-1367) Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList

2009-08-19 Thread Erik Hatcher (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12745019#action_12745019 ] Erik Hatcher commented on SOLR-1367: My opinion on this... this code should not be

[jira] Commented: (SOLR-1367) Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList

2009-08-19 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12745024#action_12745024 ] Grant Ingersoll commented on SOLR-1367: --- Just because something isn't used internally

[jira] Commented: (SOLR-1367) Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList

2009-08-19 Thread Erik Hatcher (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12745029#action_12745029 ] Erik Hatcher commented on SOLR-1367: Just because it is useful in one situation does not

[jira] Commented: (SOLR-1367) Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList

2009-08-19 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12745032#action_12745032 ] Noble Paul commented on SOLR-1367: -- IMHO the performance improvement is almost none with

[jira] Commented: (SOLR-1367) Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList

2009-08-19 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12745091#action_12745091 ] Grant Ingersoll commented on SOLR-1367: --- OK, I will revert. Provide Callback

[jira] Commented: (SOLR-1367) Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList

2009-08-18 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12744748#action_12744748 ] Yonik Seeley commented on SOLR-1367: I'm puzzled wondering why this is an improvement.

[jira] Commented: (SOLR-1367) Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList

2009-08-18 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12744784#action_12744784 ] Grant Ingersoll commented on SOLR-1367: --- B/c docListToSolrDocList also requires

[jira] Commented: (SOLR-1367) Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList

2009-08-18 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12744788#action_12744788 ] Yonik Seeley commented on SOLR-1367: It seems in this case that iteration is more

[jira] Commented: (SOLR-1367) Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList

2009-08-18 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12744818#action_12744818 ] Grant Ingersoll commented on SOLR-1367: --- What's hard to understand about a callback

[jira] Commented: (SOLR-1367) Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList

2009-08-18 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12744826#action_12744826 ] Yonik Seeley commented on SOLR-1367: bq. What's hard to understand about a callback