Re: Code style

2007-05-19 Thread Otis Gospodnetic
etter <[EMAIL PROTECTED]> To: solr-dev@lucene.apache.org Sent: Saturday, May 19, 2007 2:05:33 AM Subject: Re: Code style : thinking might be useful (in Lucene as well) is to have downloadable : codestyle templates for IntelliJ and Eclipse defined and linked to : from the developer section of

Re: Code style

2007-05-18 Thread Chris Hostetter
: thinking might be useful (in Lucene as well) is to have downloadable : codestyle templates for IntelliJ and Eclipse defined and linked to : from the developer section of the website (or it could even be I certainly have no objection to hosting any style files for any editors people like on the

Re: Code style

2007-05-18 Thread Grant Ingersoll
crete example of what the code style should be and one could do a friendly nag every now and then for people to use it. Just a thought, Grant [1] See further down on http://maven.apache.org/guides/development/ guide-m2-development.html On May 17, 2007, at 2:56 PM, Otis Gospodnetic wrote:

Re: Code style

2007-05-17 Thread Otis Gospodnetic
Hi, - Original Message From: Chris Hostetter <[EMAIL PROTECTED]> I'd certianly prefer if all new code and new changes met teh style guidelines we have setup -- tidying up the lines that are being changed anyway as part of the commit, but frankly i'd just as soon leave code that works but

Re: Code style

2007-05-17 Thread Otis Gospodnetic
Hi, - Original Message From: Yonik Seeley <[EMAIL PROTECTED]> To: solr-dev@lucene.apache.org Sent: Thursday, May 17, 2007 2:05:41 PM Subject: Re: Code style On 5/17/07, Otis Gospodnetic <[EMAIL PROTECTED]> wrote: > Should Solr be following the Lucene code f

Re: Code style

2007-05-17 Thread Chris Hostetter
: > How do the rest of you feel? I volunteer to tidy up the code, if : > others agree with following Lucene's formating. I believe Nutch and : > Hadoop already follow it. : : Solr already has a policy that is the same as Lucene. : I'm fine with cleanups... just try to avoid breaking patches in J

Re: Code style

2007-05-17 Thread Yonik Seeley
On 5/17/07, Otis Gospodnetic <[EMAIL PROTECTED]> wrote: Touchy topic: code style Uh, oh... something everyone will have an opinion about ;-) Should Solr be following the Lucene code formatting/style? Lucene follows Sun's recommendation except for the 2-space indent, I beli

Code style

2007-05-17 Thread Otis Gospodnetic
Hi, Touchy topic: code style Should Solr be following the Lucene code formatting/style? Lucene follows Sun's recommendation except for the 2-space indent, I believe. I'm asking because Solr is full of variable and method names that look like abbrevs ;) - e.g. getDocListC - "