Re: Code style

2007-05-19 Thread Otis Gospodnetic
[EMAIL PROTECTED] To: solr-dev@lucene.apache.org Sent: Saturday, May 19, 2007 2:05:33 AM Subject: Re: Code style : thinking might be useful (in Lucene as well) is to have downloadable : codestyle templates for IntelliJ and Eclipse defined and linked to : from the developer section of the website

Re: Code style

2007-05-17 Thread Yonik Seeley
On 5/17/07, Otis Gospodnetic [EMAIL PROTECTED] wrote: Touchy topic: code style Uh, oh... something everyone will have an opinion about ;-) Should Solr be following the Lucene code formatting/style? Lucene follows Sun's recommendation except for the 2-space indent, I believe. Well, that's

Re: Code style

2007-05-17 Thread Chris Hostetter
: How do the rest of you feel? I volunteer to tidy up the code, if : others agree with following Lucene's formating. I believe Nutch and : Hadoop already follow it. : : Solr already has a policy that is the same as Lucene. : I'm fine with cleanups... just try to avoid breaking patches in

Re: Code style

2007-05-17 Thread Otis Gospodnetic
Hi, - Original Message From: Yonik Seeley [EMAIL PROTECTED] To: solr-dev@lucene.apache.org Sent: Thursday, May 17, 2007 2:05:41 PM Subject: Re: Code style On 5/17/07, Otis Gospodnetic [EMAIL PROTECTED] wrote: Should Solr be following the Lucene code formatting/style

Re: Code style

2007-05-17 Thread Otis Gospodnetic
Hi, - Original Message From: Chris Hostetter [EMAIL PROTECTED] I'd certianly prefer if all new code and new changes met teh style guidelines we have setup -- tidying up the lines that are being changed anyway as part of the commit, but frankly i'd just as soon leave code that works but