Re: CVS commit: src/sys/dev

2011-05-26 Thread Iain Hibbert
On Fri, 27 May 2011, Masao Uebayashi wrote: > On Thu, May 26, 2011 at 8:24 PM, Iain Hibbert wrote: > > On Thu, 26 May 2011, Masao Uebayashi wrote: > > > >> On Thu, May 26, 2011 at 5:39 PM, Iain Hibbert > >> wrote: > >> > On Thu, 26 May 2011, Masao Uebayashi wrote: > >> >> - I can't think of how

Re: CVS commit: src/sys/dev

2011-05-26 Thread Masao Uebayashi
On Thu, May 26, 2011 at 8:24 PM, Iain Hibbert wrote: > On Thu, 26 May 2011, Masao Uebayashi wrote: > >> On Thu, May 26, 2011 at 5:39 PM, Iain Hibbert wrote: >> > On Thu, 26 May 2011, Masao Uebayashi wrote: >> >> - I can't think of how cfdriver decls can lead to type inconsistency bugs. >> > >> >

Re: CVS commit: src/sys/dev

2011-05-26 Thread Masao Uebayashi
On Fri, May 27, 2011 at 1:30 AM, David Laight wrote: > On Thu, May 26, 2011 at 07:12:57AM +, David Holland wrote: >> On Wed, May 25, 2011 at 04:33:38PM +, Masao Uebayashi wrote: >>  > Modified Files: >>  >    src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c >>  >    src/sys/dev/ieee1394: fwd

Re: CVS commit: src/sys/dev

2011-05-26 Thread Masao Uebayashi
On Fri, May 27, 2011 at 7:54 AM, Christos Zoulas wrote: > In article <20110526071257.ga16...@netbsd.org>, > David Holland   wrote: >>On Wed, May 25, 2011 at 04:33:38PM +, Masao Uebayashi wrote: >> > Modified Files: >> >     src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c >> >     src/sys/dev/ie

Re: CVS commit: src/sys/dev

2011-05-26 Thread Christos Zoulas
In article <20110526071257.ga16...@netbsd.org>, David Holland wrote: >On Wed, May 25, 2011 at 04:33:38PM +, Masao Uebayashi wrote: > > Modified Files: > > src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c > > src/sys/dev/ieee1394: fwdev.c fwmem.c fwohci.c > > > > Log Message: > > Declar

Re: CVS commit: src

2011-05-26 Thread David Young
On Thu, May 26, 2011 at 05:35:20PM +0100, David Laight wrote: > On Thu, May 26, 2011 at 11:32:51AM -0500, David Young wrote: > > On Thu, May 26, 2011 at 06:10:42PM +0200, Lars Heidieker wrote: > > > On 05/26/11 06:25, Masao Uebayashi wrote: > ... > > > with those changes I can't compile a kernel wi

Re: CVS commit: src

2011-05-26 Thread Lars Heidieker
On 05/26/11 18:30, Julio Merino wrote: > On 5/26/11 5:10 PM, Lars Heidieker wrote: >> Hi, >> >> with those changes I can't compile a kernel without USERCONF option set. >> The changes in x86_machdep.c should be with in if defs on that options >> >> Ok to commit the attached patch? >> >> @@ -178,6 +

Re: CVS commit: src

2011-05-26 Thread David Laight
On Thu, May 26, 2011 at 11:32:51AM -0500, David Young wrote: > On Thu, May 26, 2011 at 06:10:42PM +0200, Lars Heidieker wrote: > > On 05/26/11 06:25, Masao Uebayashi wrote: ... > > with those changes I can't compile a kernel without USERCONF option set. > > The changes in x86_machdep.c should be wi

Re: CVS commit: src

2011-05-26 Thread David Young
On Thu, May 26, 2011 at 06:10:42PM +0200, Lars Heidieker wrote: > On 05/26/11 06:25, Masao Uebayashi wrote: > > Module Name:src > > Committed By: uebayasi > > Date: Thu May 26 04:25:28 UTC 2011 > > > > Modified Files: > > src/share/man/man5: boot.cfg.5 > > src/s

Re: CVS commit: src/sys/dev

2011-05-26 Thread David Laight
On Thu, May 26, 2011 at 07:12:57AM +, David Holland wrote: > On Wed, May 25, 2011 at 04:33:38PM +, Masao Uebayashi wrote: > > Modified Files: > >src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c > >src/sys/dev/ieee1394: fwdev.c fwmem.c fwohci.c > > > > Log Message: > > Declare c

Re: CVS commit: src

2011-05-26 Thread Julio Merino
On 5/26/11 5:10 PM, Lars Heidieker wrote: Hi, with those changes I can't compile a kernel without USERCONF option set. The changes in x86_machdep.c should be with in if defs on that options Ok to commit the attached patch? @@ -178,6 +182,7 @@ module_init_md(void) } #endif/* MODULAR

Re: CVS commit: src

2011-05-26 Thread Masao Uebayashi
On Fri, May 27, 2011 at 1:10 AM, Lars Heidieker wrote: > On 05/26/11 06:25, Masao Uebayashi wrote: >> Module Name:  src >> Committed By: uebayasi >> Date:         Thu May 26 04:25:28 UTC 2011 >> >> Modified Files: >>       src/share/man/man5: boot.cfg.5 >>       src/share/man/man8/man8.i386: boot.

Re: CVS commit: src

2011-05-26 Thread Lars Heidieker
On 05/26/11 06:25, Masao Uebayashi wrote: > Module Name: src > Committed By: uebayasi > Date: Thu May 26 04:25:28 UTC 2011 > > Modified Files: > src/share/man/man5: boot.cfg.5 > src/share/man/man8/man8.i386: boot.8 > src/sys/arch/i386/stand/boot: boot2.c > src/sys/

Re: CVS commit: src/sys/dev

2011-05-26 Thread Joerg Sonnenberger
On Thu, May 26, 2011 at 07:12:57AM +, David Holland wrote: > On Wed, May 25, 2011 at 04:33:38PM +, Masao Uebayashi wrote: > > Modified Files: > >src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c > >src/sys/dev/ieee1394: fwdev.c fwmem.c fwohci.c > > > > Log Message: > > Declare c

Re: CVS commit: src

2011-05-26 Thread Julio Merino
On 5/26/11 5:25 AM, Masao Uebayashi wrote: Module Name:src Committed By: uebayasi Date: Thu May 26 04:25:28 UTC 2011 Modified Files: src/share/man/man5: boot.cfg.5 src/share/man/man8/man8.i386: boot.8 src/sys/arch/i386/stand/boot: boot2.c src/sys/a

Re: CVS commit: src/sys/dev

2011-05-26 Thread Iain Hibbert
On Thu, 26 May 2011, Masao Uebayashi wrote: > On Thu, May 26, 2011 at 5:39 PM, Iain Hibbert wrote: > > On Thu, 26 May 2011, Masao Uebayashi wrote: > >> - I can't think of how cfdriver decls can lead to type inconsistency bugs. > > > > Ok, somebody makes a mistake and writes > > > > extern struct

Re: CVS commit: src/sys/dev

2011-05-26 Thread Masao Uebayashi
On Thu, May 26, 2011 at 5:39 PM, Iain Hibbert wrote: > On Thu, 26 May 2011, Masao Uebayashi wrote: > >> > I wonder if that can be worked around by stripping or ignoring the thing >> > you want to ignore (non-global symbols), rather than potentially >> > introducing type inconsistency bugs? ("objco

Re: CVS commit: src/sys/dev

2011-05-26 Thread Iain Hibbert
On Thu, 26 May 2011, Masao Uebayashi wrote: > > I wonder if that can be worked around by stripping or ignoring the thing > > you want to ignore (non-global symbols), rather than potentially > > introducing type inconsistency bugs? ("objcopy -x" will discard all > > non-global symbols, I don't know

Re: CVS commit: src/sys/dev

2011-05-26 Thread Masao Uebayashi
On Thu, May 26, 2011 at 4:12 PM, David Holland wrote: > On Wed, May 25, 2011 at 04:33:38PM +, Masao Uebayashi wrote: >  > Modified Files: >  >      src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c >  >      src/sys/dev/ieee1394: fwdev.c fwmem.c fwohci.c >  > >  > Log Message: >  > Declare cfdriv

Re: CVS commit: src/sys/dev

2011-05-26 Thread Masao Uebayashi
On Thu, May 26, 2011 at 4:24 PM, Iain Hibbert wrote: > On Thu, 26 May 2011, Masao Uebayashi wrote: > >> On Thu, May 26, 2011 at 4:41 AM, David Laight wrote: >> > On Thu, May 26, 2011 at 02:33:38AM +0900, Masao Uebayashi wrote: >> >> >> >> >> >> Modified Files: >> >> >> ? ? ? src/sys/dev/bluetooth

Re: CVS commit: src/sys/dev

2011-05-26 Thread Iain Hibbert
On Thu, 26 May 2011, Iain Hibbert wrote: > you might note that the bthub.o file (at least, I didn't check the others) > does not actually use __func__ (unless DEBUG) and in fact the objdump does > not change with the removal of "ioconf.h" sorry: does not change with the addition of "no ehci" iai

Re: CVS commit: src/sys/dev

2011-05-26 Thread Iain Hibbert
On Thu, 26 May 2011, Masao Uebayashi wrote: > On Thu, May 26, 2011 at 4:41 AM, David Laight wrote: > > On Thu, May 26, 2011 at 02:33:38AM +0900, Masao Uebayashi wrote: > >> >> > >> >> Modified Files: > >> >> ? ? ? src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c > >> >> ? ? ? src/sys/dev/ieee1394:

Re: CVS commit: src/sys/dev

2011-05-26 Thread David Holland
On Wed, May 25, 2011 at 04:33:38PM +, Masao Uebayashi wrote: > Modified Files: > src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c > src/sys/dev/ieee1394: fwdev.c fwmem.c fwohci.c > > Log Message: > Declare cfdrivers using extern rather than including ioconf.h. This is wrong. Ple