Re: CVS commit: src

2012-11-29 Thread Matthias Drochner
On Thu, 29 Nov 2012 19:20:14 + Nick Hudson nick.hud...@gmx.co.uk wrote: On Sunday 18 November 2012 17:41:55 Emmanuel Dreyfus wrote: -#if defined(_INCOMPLETE_XOPEN_C063) +#if (_POSIX_C_SOURCE - 0) = 200809L || (_XOPEN_SOURCE - 0 = 700) || \ +defined(_INCOMPLETE_XOPEN_C063) ||

Re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core

2012-01-29 Thread Matthias Drochner
lars.heidie...@googlemail.com said: where does the diagnostic panic occur? It was in the course of a realloc() from drm code. It did apparently assume that the to be free'd block was allocated by the pool code where it was allocated by kmem. best regards Matthias

Re: CVS commit: src/sys/arch/i386/i386

2012-01-20 Thread Matthias Drochner
m...@eterna.com.au said: alloc/free here for whatever is using a lot of memory would be much better than increasing the minimum each LWP requires. Agreed. In the ppbattach case, it should be sufficient to put the devinfo printf into a separate function, so that it doesn't stack up when called

Re: CVS commit: src/sys/arch/i386/i386

2012-01-20 Thread Matthias Drochner
chris...@astron.com said: /.*sub.*,%[er]sp/ very nice 18648 80494b55:stbi_gif_load_from_memory+0xd So this can never have worked on x86, with only 12k stack. best regards Matthias

Re: CVS commit: src/sys/arch/i386/i386

2012-01-19 Thread Matthias Drochner
dyo...@pobox.com said: increased stack use lead to stack overflow on amd64 with a deep PCI hierarchy Tell me more about this. It was sys/dev/pci/pci.c rev.1.141 which triggered it. Stack use must already have been tight, and the additional device number array was the last straw. The

Re: CVS commit: src/sys/arch/i386/i386

2012-01-18 Thread Matthias Drochner
dyo...@pobox.com said: was setting pba_sub = 255 causing material problems for someone, or are you concerned that lossage will eventually occur on certain server-class machines? No, this wasn't causing damage. I was tracking another problem which was incidentally triggered by another of your

Re: CVS commit: src/sys/compat

2012-01-04 Thread Matthias Drochner
Module Name:src Committed By: apb Date: Wed Jan 4 13:45:55 UTC 2012 Modified Files: src/sys/compat/common: kern_time_50.c src/sys/compat/sys: clockctl.h Log Message: Provide a COMPAT_50 version of the CLOCKCTL_NTP_ADJTIME ioctl. When time_t was changed

Re: CVS commit: src/lib/libcrypt

2011-11-29 Thread Matthias Drochner
jo...@britannica.bec.de said: Well, the way it is done, it won't help. What do you mean - a duplication of efforts? Just noticed this myself... I'm not sure it is a good idea to do this in MD5Final because it might be unnecessary if the hash is just used for indexing or so. In addition, this is

Re: CVS commit: src/lib/libcrypt

2011-11-29 Thread Matthias Drochner
m.droch...@fz-juelich.de said: a disassembly of MD5Final() on i386 shows that the final zeroing is present in the binary OK, this is no surprise. At this point the compiler can't know that it is a dead store. best regards Matthias

Re: CVS commit: src/lib/libcrypt

2011-11-29 Thread Matthias Drochner
dholland-sourcechan...@netbsd.org said: You also want to take steps to make sure that the zeroed cache line is flushed out. This would be good, but it is a bit hard on x86 from userland because wbinv is a privileged instruction. Would need a system call. Anyway, here is a first cut on an

Re: CVS commit: src/lib/libm/arch/i387

2011-06-20 Thread Matthias Drochner
jo...@britannica.bec.de said: why do you think it is incorrect? You just did an unifdef. best regards Matthias

Re: CVS commit: src/sys/dev/usb

2011-05-28 Thread Matthias Drochner
[toggle bit] jakll...@kollasch.net said: These are basically the same changes FreeBSD and OpenBSD made? Possibly... I had this patch in my tree for almost a year and just stumbled over it when I switched my local VCS. I'll work on OHCI anyway. Great -- the problem is not easily reproduced. I

Re: CVS commit: src/sys/arch/amd64/conf

2011-02-19 Thread Matthias Drochner
jeanyves.mig...@free.fr said: I can't see why MONOLITHIC is needed in the first place I think before modular kernels are forced onto the masses, at least 2 design problems should be fixed: 1. Autoloading needs to be done differently: The kernel doesn't have the smarts to know which module is

Re: CVS commit: src/sys/arch/amd64/conf

2011-02-19 Thread Matthias Drochner
jruoho...@iki.fi said: Have you measured how much modules supposedly increase the size compared to compiling things directly to the kernel? This seems like a rather silly point to me (without numbers, at least). The difference is that I can control what is built into my kernel, but I can't

Re: CVS commit: src/lib/csu

2011-02-01 Thread Matthias Drochner
jo...@britannica.bec.de said: The attached patch seems to sort this out. Yes, thanks, this works. best regards Matthias

Re: CVS commit: src/lib/csu

2011-01-31 Thread Matthias Drochner
jo...@britannica.bec.de said: $ ~/work/NetBSD/obj/clang-base/tools/bin/nbmake-amd64 -V .OBJDIR /home/joerg/work/NetBSD/obj/clang-base/amd64/lib/csu This shows that you are not using an .OBJDIR, in the sense that it is different from .CURDIR. See the make(1) manpage. There are various rules

Re: CVS commit: src/lib/csu

2011-01-31 Thread Matthias Drochner
jo...@britannica.bec.de said: BSDOBJDIR doesn't seem to do anything. BUILDID breaks this. I have no idea why those variables even exist, the code in bsd.own.mk is messy at best I agree that the code is messy, but at least BUILDID serves a useful purpose: I can use the same source tree from

Re: CVS commit: src/sys/kern

2010-09-11 Thread Matthias Drochner
tsugutomo.en...@jp.sony.com said: Does malloc(3) return zero-initialized memory? You are right - seems that I confused the macros. So it might make sense to pull this up. I'll ask for testers. best regards Matthias

Re: CVS commit: src/sys/arch

2010-07-26 Thread Matthias Drochner
c...@cubidou.net said: keep out paddr_t from the kernel ABI relevant to modules. You won't keep bus_addr_t out of the ABI any time soon, so this is not a fix. It is not correct anyway to tie bus_addr_t to paddr_t -- the semantics of the buses don't depend on the CPU but on chipsets, or are

Re: CVS commit: src/sys/arch

2010-07-24 Thread Matthias Drochner
christoph_eg...@gmx.de said: How about making paddr_t always 64bit? That makes it much easier to deal with in libkvm. I don't think this is a good argument. The little gain of making a rarely used library like libkvm simpler can't justify adding overhead to the kernel. PAE is a bridge

Re: CVS commit: src/sys/arch

2010-07-24 Thread Matthias Drochner
c...@cubidou.net said: Kernel modules, on the other hand... Hmm, didn't think of that. (using them myself only for testing) a gaping ABI incompatibility is completely unacceptable There are two ways to fix this without the 64-bit-paddr overhead, a short-term and a long-term one. The

Re: CVS commit: src/lib/libpthread

2010-05-17 Thread Matthias Drochner
Is the SEE ALSO section meant to refer to external sources? Just as a data point, OSF/1 does this. To cite eg inet(7): RELATED INFORMATION Functions: ioctl(2), socket(2). Network Information: netintro(7), tcp(7), udp(7), ip(7), icmp(7). Network Programmer's Guide Technical Overview

Re: CVS commit: src/lib/libc/compat/gen

2010-04-27 Thread Matthias Drochner
m...@eterna.com.au said: the mono runtime dlopen(3)s some libc functions directly and misses the RENAMEs apparently.) sounds like this was already not working properly anyway! it would have picked the wrong symbol, but one that may have sort of worked.. Yes I know. Fixing this in mono

Re: CVS commit: src/sys/dev/isa

2010-03-23 Thread Matthias Drochner
[reposting, was sent to s-c first] Module Name:src Committed By: dyoung Date: Mon Mar 22 22:30:58 UTC 2010 Modified Files: src/sys/dev/isa: isadma.c pcdisplay.c Log Message: [...] pcdisplay.c: #if 0 some code that compares two bus_space_tag_t's in order to

Re: CVS commit: src/sys/dev/isa

2010-03-23 Thread Matthias Drochner
dyo...@pobox.com said: How many pcdisplay at isa can there be one machine? Iirc, this code is originating from alpha where you can have multiple independant PCI/ISA/EISA hierarchies and thus multiple pcdisplay/ega/vga devices. Can the two tags that pcdisplay_is_console() compared ever come

Re: CVS commit: src/sys/dev/isa

2010-03-23 Thread Matthias Drochner
dyo...@pobox.com said: How many pcdisplay at isa can there be one machine? Iirc, this code is originating from alpha where you can have multiple independant PCI/ISA/EISA hierarchies and thus multiple pcdisplay/ega/vga devices. Can the two tags that pcdisplay_is_console() compared ever come

Re: CVS commit: src/sys/dev/isa

2010-03-23 Thread Matthias Drochner
dyo...@pobox.com said: Let us add a bus_space_is_equal(bus_space_tag_t t1, bus_space_tag_t t2) for implementation in MD code That's generally OK. (We have this in pthread_equal().) return memcpy(t1, t2, sizeof(t1)) == 0; That will work even if bus_space_tag_t is a struct. I hope you

CVS commit: src/external/bsd/tre/dist/po

2010-02-27 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Sat Feb 27 12:08:56 UTC 2010 Removed Files: src/external/bsd/tre/dist/po: fi.gmo sv.gmo Log Message: remove generated binary files To generate a diff of this commit: cvs rdiff -u -r1.1.1.1 -r0

CVS commit: src/external/bsd/tre/dist/po

2010-02-27 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Sat Feb 27 12:08:56 UTC 2010 Removed Files: src/external/bsd/tre/dist/po: fi.gmo sv.gmo Log Message: remove generated binary files To generate a diff of this commit: cvs rdiff -u -r1.1.1.1 -r0

Re: CVS commit: src/sys/dev

2010-02-26 Thread Matthias Drochner
m...@eterna.com.au said: this is a pretty serious change to have only compile tested! can you please get some real testing done on this? Seconded. And: Starting to commit without having an idea what it breaks and where it ends isn't great engineering either. best regards Matthias

CVS commit: src/lib/libcurses

2010-02-25 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Thu Feb 25 10:56:25 UTC 2010 Modified Files: src/lib/libcurses: acs.c Log Message: fix wrong widechar assignment for up arrow To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/lib/libcurses/acs.c Please note

CVS commit: src/sys/dev

2010-02-25 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Thu Feb 25 11:20:10 UTC 2010 Modified Files: src/sys/dev/ic: pcdisplay_chars.c vga.c src/sys/dev/wscons: unicode.h wsemul_vt100_chars.c Log Message: retire our private definitions for the scan1/3/5/7/9 DEC graphics

CVS commit: src/lib/libcurses

2010-02-24 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Wed Feb 24 13:02:13 UTC 2010 Modified Files: src/lib/libcurses: curses_cursor.3 curses_touch.3 Log Message: document wsyncup/wsyncdown/wcursyncup To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/sys/dev/ic

2010-02-24 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Wed Feb 24 18:33:45 UTC 2010 Modified Files: src/sys/dev/ic: pcdisplay_chars.c Log Message: map some more punctuation to more or less good replacements in the IBM character set To generate a diff of this commit: cvs rdiff -u

CVS commit: src/external/gpl3/binutils/dist/bfd

2010-02-23 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Tue Feb 23 20:42:40 UTC 2010 Modified Files: src/external/gpl3/binutils/dist/bfd: elf32-i386.c Log Message: adjust INTERP path for NetBSD (needed eg for -static -pie) To generate a diff of this commit: cvs rdiff -u -r1.2

CVS commit: src

2010-02-21 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Sun Feb 21 13:17:51 UTC 2010 Modified Files: src/share/man/man4: options.4 src/share/man/man7: sysctl.7 src/sys/uvm: files.uvm uvm_map.c Log Message: rename the va0_disabled option and cpp conditional to disable

CVS commit: src/sys/uvm

2010-02-20 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Sat Feb 20 13:21:58 UTC 2010 Modified Files: src/sys/uvm: uvm_map.c Log Message: rename the new sysctl to vm.user_va0_disable, for consistency with the majority of existing sysctl flags, suggested by yamt To generate a diff

Re: CVS commit: src/sys/uvm

2010-02-19 Thread Matthias Drochner
e...@netbsd.org said: (cannot be cleared at securelevel0) I was wondering how you achieved that without modifying any of the secmodel code itself Well, that's the problem with kauth: If it needs code changes for each simple check added in other parts of the kernel, it twarts modularity and

CVS commit: src/lib/libcurses

2010-02-19 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Fri Feb 19 19:09:15 UTC 2010 Modified Files: src/lib/libcurses: curses_line.3 Log Message: explain a non-portable behavior To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/lib/libcurses/curses_line.3 Please

CVS commit: src/sys/uvm

2010-02-18 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Thu Feb 18 14:57:01 UTC 2010 Modified Files: src/sys/uvm: files.uvm uvm_map.c Log Message: Disable mapping of virtual address 0 by user programs per default. This blocks an easy exploit of kernel bugs leading to dereference of

Re: CVS commit: src/sys/arch/i386/i386

2010-02-16 Thread Matthias Drochner
da...@l8s.co.uk said: I presume the panic was in the 'return to user' sequence? Yes, in the iret. Does it now SIGSEGV the program? Yes, which is a bit strange because this happened before even the first instruction was fetched, and no user-supplied data are involved (as opposed to

CVS commit: src/sys/arch/i386/i386

2010-02-14 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Sun Feb 14 11:09:54 UTC 2010 Modified Files: src/sys/arch/i386/i386: ibcs2_machdep.c svr4_machdep.c Log Message: fix confused CS selector, fixes the panic reported by Mark Davis per PR port-i386/42787 (the panic happens due to

CVS commit: src/sys/compat/svr4

2010-02-14 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Sun Feb 14 11:54:03 UTC 2010 Modified Files: src/sys/compat/svr4: files.svr4 Log Message: add missing glue file, otherwise the emulation will not work if compiled into the kernel (and the module loader will load another

Re: CVS commit: src/sys/dev/wscons (wsemul_vt100.c)

2010-02-11 Thread Matthias Drochner
nick.hud...@gmx.co.uk said: On Thursday 11 February 2010 00:28:23 Geoff Wing wrote: This reversal removed variables that were being used. I have no idea if my quick hack was correct. The variables are really needed, for that obscure WSDISPLAY_CUSTOM_OUTPUT hack which I had missed initially.

CVS commit: src/sys/dev/wscons

2010-02-10 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Wed Feb 10 19:39:39 UTC 2010 Modified Files: src/sys/dev/wscons: wsemul_vt100.c wsemul_vt100_chars.c wsemul_vt100_keys.c wsemul_vt100_subr.c wsemul_vt100var.h Added Files: src/sys/dev/wscons: vt100_base.h

CVS commit: src/sys/dev/ic

2010-02-10 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Wed Feb 10 19:45:30 UTC 2010 Modified Files: src/sys/dev/ic: pcdisplay_chars.c Log Message: add some more mappings from punctuation and accented characters to more or less adequate replacements in the builtin IBM character set

CVS commit: src/usr.bin/hexdump

2010-02-09 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Tue Feb 9 14:06:37 UTC 2010 Modified Files: src/usr.bin/hexdump: conv.c hexdump.c hexdump.h od.1 odsyntax.c Log Message: remove agitation that od(1) was deprecated -- it is still POSIX To generate a diff of this commit: cvs

CVS commit: src/sys/dev/wscons

2010-02-05 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Fri Feb 5 18:26:38 UTC 2010 Modified Files: src/sys/dev/wscons: wskbdutil.c Log Message: add some missing (mostly hungarian or polish) dead accent combinations, from lkundrak's netbsd-sk_cz-howto To generate a diff of this

CVS commit: src/sys/dev/wscons

2010-02-02 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Tue Feb 2 16:54:40 UTC 2010 Modified Files: src/sys/dev/wscons: wsdisplay.c wsdisplayvar.h Log Message: give up some silly macros which were only used ~once, and reduce dependency on locators.h makes the code more LKM frienly

Re: CVS commit: src

2010-02-02 Thread Matthias Drochner
Hi - t...@back-street.net said: the version of libutil's shared library should be changed in some way, shoudn't it? Maybe as a matter of principle... Technically, I see no need for this. The code has never been used in the NetBSD tree, so there is no compatibility issue. And it is extremely

CVS commit: src/lib/libc

2010-01-27 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Wed Jan 27 14:10:41 UTC 2010 Modified Files: src/lib/libc/compat/gen: compat_modf_ieee754.c src/lib/libc/gen: modf_ieee754.c Log Message: fix behavior in case of +-Inf or NaN input: return the proper values and set

CVS commit: src

2010-01-27 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Wed Jan 27 19:10:31 UTC 2010 Modified Files: src/distrib/sets/lists/comp: mi src/include: util.h src/lib/libutil: Makefile Removed Files: src/lib/libutil: pw_policy.3 pw_policy.c Log Message: retire

CVS commit: src/lib/libm/src

2010-01-27 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Wed Jan 27 20:23:53 UTC 2010 Modified Files: src/lib/libm/src: k_standard.c Log Message: fix return values for atan2(+-0,+-0) in the POSIX case To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15

CVS commit: src/sys/dev/acpi

2010-01-27 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Wed Jan 27 22:17:28 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: the Battery Present Rate is only required to be valid if the battery is discharging; it might make sense when charging, but it doesn't make

Re: CVS commit: src

2010-01-27 Thread Matthias Drochner
[removal from pw_policy from libutil] thor...@shagadelic.org said: bump the major version # of this library? Hmm, in theory yes, but the code has never been used inside the NetBSD tree, and there are good reasons to assume that noone outside hasn't either. best regards Matthias

Re: CVS commit: src/dist/dhcp/dst

2010-01-26 Thread Matthias Drochner
chris...@astron.com said: I think that the EREPORT macro should be changed instead. Macros that look like statements, should behave like statements. OK, I'll check whether/how upstream fixed it first. best regards Matthias

Re: CVS commit: src/dist/dhcp/dst

2010-01-26 Thread Matthias Drochner
m.droch...@fz-juelich.de said: OK, I'll check whether/how upstream fixed it first. Found that bind9 (bundling the same library) sets the macro to (void)0, so I've done likewise. best regards Matthias

CVS commit: src/dist/dhcp/dst

2010-01-25 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Mon Jan 25 20:33:57 UTC 2010 Modified Files: src/dist/dhcp/dst: dst_api.c prandom.c Log Message: fix some cases where the EREPORT macro defined to null (as in the NetBSD build) could change the behaviour of the code in

CVS commit: src/etc/rc.d

2010-01-23 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Sat Jan 23 17:44:44 UTC 2010 Modified Files: src/etc/rc.d: mdnsd Log Message: fix an obvious typo in directory check To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/etc/rc.d/mdnsd Please note that diffs are

CVS commit: src/lib/libm/src

2010-01-20 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Wed Jan 20 16:49:43 UTC 2010 Modified Files: src/lib/libm/src: k_standard.c Log Message: let the previous fix apply to acos rather than atan2, and get rid of #ifdef vax To generate a diff of this commit: cvs rdiff -u -r1.13

CVS commit: src

2010-01-17 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Sun Jan 17 14:54:44 UTC 2010 Modified Files: src/sys/arch/i386/stand/boot: boot2.c src/sys/arch/i386/stand/lib: boot_params.S src/sys/arch/i386/stand/pxeboot: Makefile main.c src/sys/sys: bootblock.h

CVS commit: src/sys/arch/i386/stand/pxeboot

2010-01-17 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Sun Jan 17 17:02:47 UTC 2010 Modified Files: src/sys/arch/i386/stand/pxeboot: Makefile Log Message: fix tyop in default flag definition To generate a diff of this commit: cvs rdiff -u -r1.19 -r1.20

CVS commit: src/sys/dev/pci

2010-01-13 Thread Matthias Drochner
Module Name:src Committed By: drochner Date: Wed Jan 13 12:18:55 UTC 2010 Modified Files: src/sys/dev/pci: pci_subr.c Log Message: fix some bitmask in PCI Express capabilities decoding being here, fix some typos and add a comma for clarity To generate a diff of this

Re: CVS commit: src/sys/dev/pci

2009-09-10 Thread Matthias Drochner
jo...@britannica.bec.de said: I would have said that the suspend/resume and shutdown hooks could be part of device_t directly Shutdown handlers are often bus frontend specific because they deal with power and/or interrupts. I think it makes a lot of sense to have them installed by the

Re: CVS commit: src/sys/kern

2009-08-13 Thread Matthias Drochner
a...@cequrux.com said: What is an undescribed, direct ioctl, and where is it documented? As I understand it this is where the third ioctl argument is used as data instead of a pointer to data. This is only useful to provide source compatibility to non-BSD sources, and there are ways to get that

Re: CVS commit: src/sys/kern

2009-07-27 Thread Matthias Drochner
m...@msys.ch said: yes, please mail me some hints, I find it gross myself, but did not yet find a better way. It is pretty easy: -in files.gpio, change the declaration to defpseudodev gpiosim: gpiobus and remove the attach line -in the kernel config, change gpiosim0 at root (or what you have

Re: CVS commit: src/sys/kern

2009-07-27 Thread Matthias Drochner
lacom...@gmail.com said: config(9) doesn't seem to know anything about 'defpseudodev' config(5) mentions it. (I've written that part. It anyone has suggestions for better wording please tell me.) best regards Matthias

Re: CVS commit: src/sys/kern

2009-07-27 Thread Matthias Drochner
m.droch...@fz-juelich.de said: In that function, you can call config_attach_pseudo(9) to attach the actual instances. See eg sys/dev/vnd.c for an example. Forgot to mention that you need to call config_cfattach_attach() before. sys/dev/md.c is a better example. best regards Matthias

Re: CVS commit: src/sys/arch/x86/x86

2009-07-07 Thread Matthias Drochner
p...@whooppee.com said: I guess maybe the minus signs shouldn't ever happen? someone out here with a liquid nitrogen cooler? best regards Matthias

Re: CVS commit: src/sys/uvm

2009-04-18 Thread Matthias Drochner
christoph_eg...@gmx.de said: if (flags FLAG1) do_something(); What is wrong with this? best regards Matthias --- --- Forschungszentrum Juelich GmbH