CVS commit: src/common/lib/libc/string

2024-01-20 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sat Jan 20 14:55:11 UTC 2024 Modified Files: src/common/lib/libc/string: strpbrk.c Log Message: Add __UNCONST To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/common/lib/libc/string/strpbrk.c Please note that

CVS commit: src/common/lib/libc/string

2024-01-20 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sat Jan 20 14:55:11 UTC 2024 Modified Files: src/common/lib/libc/string: strpbrk.c Log Message: Add __UNCONST To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/common/lib/libc/string/strpbrk.c Please note that

CVS commit: src/common/lib/libc/string

2023-06-18 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jun 18 22:18:13 UTC 2023 Modified Files: src/common/lib/libc/string: strspn.c Log Message: strspn: fix typo in comment To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/common/lib/libc/string/strspn.c Please

CVS commit: src/common/lib/libc/string

2023-06-18 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jun 18 22:18:13 UTC 2023 Modified Files: src/common/lib/libc/string: strspn.c Log Message: strspn: fix typo in comment To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/common/lib/libc/string/strspn.c Please

CVS commit: src/common/lib/libc/string

2022-01-15 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Sat Jan 15 10:38:56 UTC 2022 Modified Files: src/common/lib/libc/string: memset2.c Log Message: fix typos in comments. To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11 src/common/lib/libc/string/memset2.c Please

CVS commit: src/common/lib/libc/string

2022-01-15 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Sat Jan 15 10:38:56 UTC 2022 Modified Files: src/common/lib/libc/string: memset2.c Log Message: fix typos in comments. To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11 src/common/lib/libc/string/memset2.c Please

Re: CVS commit: src/common/lib/libc/string

2020-08-08 Thread David Holland
(yes, change is from January, I'm hugely behind) On Mon, Jan 27, 2020 at 10:22:03PM +, Andrew Doran wrote: > Modified Files: > src/common/lib/libc/string: bcmp.c memcmp.c > > Log Message: > Drop the alignment check if __NO_STRICT_ALIGNMENT (x86, m68k, vax). Even on machines that

Re: CVS commit: src/common/lib/libc/string

2016-10-13 Thread Joerg Sonnenberger
On Thu, Oct 13, 2016 at 01:27:00AM +, Christos Zoulas wrote: > In article <20161012220744.gb...@britannica.bec.de>, > Joerg Sonnenberger wrote: > > >So strchrnul(a,b) seems to be a + strcspn(a,b), just in a non-portable > >way. I don't see the point of it at all. Please revert

Re: CVS commit: src/common/lib/libc/string

2016-10-12 Thread Christos Zoulas
In article <20161012220744.gb...@britannica.bec.de>, Joerg Sonnenberger wrote: >So strchrnul(a,b) seems to be a + strcspn(a,b), just in a non-portable >way. I don't see the point of it at all. Please revert this. Also hit >anyone using strchrnul with a cluebat please... That

Re: CVS commit: src/common/lib/libc/string

2016-10-12 Thread Joerg Sonnenberger
On Thu, Oct 13, 2016 at 12:01:58AM +0200, Joerg Sonnenberger wrote: > On Wed, Oct 12, 2016 at 04:01:40PM -0400, Christos Zoulas wrote: > > Module Name:src > > Committed By: christos > > Date: Wed Oct 12 20:01:40 UTC 2016 > > > > Added Files: > >

Re: CVS commit: src/common/lib/libc/string

2016-10-12 Thread Joerg Sonnenberger
On Wed, Oct 12, 2016 at 04:01:40PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Wed Oct 12 20:01:40 UTC 2016 > > Added Files: > src/common/lib/libc/string: strchrnul.c > > Log Message: > Add strchrnul This seems to be completely pointless GNU

Re: CVS commit: src/common/lib/libc/string

2015-05-30 Thread Matt Thomas
On May 29, 2015, at 12:46 PM, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Fri, May 29, 2015 at 07:39:41PM +, Matt Thomas wrote: Module Name: src Committed By:matt Date:Fri May 29 19:39:41 UTC 2015 Modified Files: src/common/lib/libc/string:

Re: CVS commit: src/common/lib/libc/string

2014-04-23 Thread David Laight
On Tue, Apr 15, 2014 at 03:41:55PM +0200, Joerg Sonnenberger wrote: I remember a discussion about this topic from the LLVM lists and the reasons for the standard language on this are extremely weak. IIRC the *only* justification was for some platforms with broken (trapping) prefetch

Re: CVS commit: src/common/lib/libc/string

2014-04-15 Thread Alan Barrett
On Mon, 14 Apr 2014, Joerg Sonnenberger wrote: Modified Files: src/common/lib/libc/string: bcopy.c Log Message: Using bcopy/memcpy with NULL arguments is valid as long as the size is also 0. No, it's undefined behaviour. C99 section 7.21.1: Unless explicitly stated otherwise in

Re: CVS commit: src/common/lib/libc/string

2014-04-15 Thread Steffen Nurpmeso
Hello, Joerg Sonnenberger jo...@netbsd.org wrote: |Module Name: src |Committed By: joerg |Date: Mon Apr 14 18:18:58 UTC 2014 | |Modified Files: | src/common/lib/libc/string: bcopy.c | |Log Message: |Using bcopy/memcpy with NULL arguments is valid as long as the size is |also 0.

Re: CVS commit: src/common/lib/libc/string

2014-04-15 Thread Steffen Nurpmeso
P.S.: i wasn't subscribed to this list (until hopefully now), so i haven't seen that Alan Barrett already commented. But now that i read it, ISO C 2011 states the same (7.24.1). --steffen

Re: CVS commit: src/common/lib/libc/string

2014-04-15 Thread Joerg Sonnenberger
On Tue, Apr 15, 2014 at 08:06:57AM +0200, Alan Barrett wrote: On Mon, 14 Apr 2014, Joerg Sonnenberger wrote: Modified Files: src/common/lib/libc/string: bcopy.c Log Message: Using bcopy/memcpy with NULL arguments is valid as long as the size is also 0. No, it's undefined behaviour.

Re: CVS commit: src/common/lib/libc/string

2012-03-02 Thread Alan Barrett
On Fri, 02 Mar 2012, Jukka Ruohonen wrote: Log Message: Change CTASSERT to __CTASSERT (the spelling used in sys/cdefs.h), include sys/cdefs.h so that it will be defined, and move it to a better place. The previous CTASSERT would never have been used because of the ifdef. If it had been used,

Re: CVS commit: src/common/lib/libc/string

2012-03-02 Thread Matt Thomas
On Mar 2, 2012, at 11:15 AM, Alan Barrett wrote: On Fri, 02 Mar 2012, Jukka Ruohonen wrote: Log Message: Change CTASSERT to __CTASSERT (the spelling used in sys/cdefs.h), include sys/cdefs.h so that it will be defined, and move it to a better place. The previous CTASSERT would never have

Re: CVS commit: src/common/lib/libc/string

2011-09-24 Thread Joerg Sonnenberger
On Fri, Sep 23, 2011 at 08:33:22PM +, Christos Zoulas wrote: In article 20110923163839.ga4...@kleink.org, Klaus Klein kle...@kleink.org wrote: [Yay, catching up with a month's worth of source-changes...] On Mon, Aug 22, 2011 at 12:46:21PM +, Christos Zoulas wrote: In article

Re: CVS commit: src/common/lib/libc/string

2011-09-24 Thread Christos Zoulas
In article 20110924094308.ga30...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Fri, Sep 23, 2011 at 08:33:22PM +, Christos Zoulas wrote: In article 20110923163839.ga4...@kleink.org, Klaus Klein kle...@kleink.org wrote: [Yay, catching up with a month's worth of

Re: CVS commit: src/common/lib/libc/string

2011-09-23 Thread Klaus Klein
[Yay, catching up with a month's worth of source-changes...] On Mon, Aug 22, 2011 at 12:46:21PM +, Christos Zoulas wrote: In article 20110822104822.gb15...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Mon, Aug 22, 2011 at 01:26:24AM +, David Holland wrote:

Re: CVS commit: src/common/lib/libc/string

2011-09-23 Thread Christos Zoulas
In article 20110923163839.ga4...@kleink.org, Klaus Klein kle...@kleink.org wrote: [Yay, catching up with a month's worth of source-changes...] On Mon, Aug 22, 2011 at 12:46:21PM +, Christos Zoulas wrote: In article 20110822104822.gb15...@britannica.bec.de, Joerg Sonnenberger

Re: CVS commit: src/common/lib/libc/string

2011-08-22 Thread Joerg Sonnenberger
On Mon, Aug 22, 2011 at 01:26:24AM +, David Holland wrote: On Mon, Aug 22, 2011 at 03:13:29AM +0200, Joerg Sonnenberger wrote: On Sun, Aug 21, 2011 at 11:37:08PM +, David Holland wrote: On Mon, Aug 22, 2011 at 01:31:31AM +0200, Joerg Sonnenberger wrote: Modified Files:

Re: CVS commit: src/common/lib/libc/string

2011-08-22 Thread Christos Zoulas
In article 20110822104822.gb15...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Mon, Aug 22, 2011 at 01:26:24AM +, David Holland wrote: On Mon, Aug 22, 2011 at 03:13:29AM +0200, Joerg Sonnenberger wrote: On Sun, Aug 21, 2011 at 11:37:08PM +, David Holland

Re: CVS commit: src/common/lib/libc/string

2011-08-22 Thread Joerg Sonnenberger
On Mon, Aug 22, 2011 at 04:48:02PM +0400, Valeriy E. Ushakov wrote: It doesn't. The prototypes in strings.h already ensure that uint32_t/uint64_t are present and that's the only thing it could ever need from stdint.h. Yes it does. strings.h is included by string.h and is

Re: CVS commit: src/common/lib/libc/string

2011-08-22 Thread Valeriy E. Ushakov
On Mon, Aug 22, 2011 at 16:48:02 +0400, Valeriy E. Ushakov wrote: On Mon, Aug 22, 2011 at 12:48:22 +0200, Joerg Sonnenberger wrote: [...] You are skinning the wrong cat. string.h shouldn't include strings.h in first place. #if defined(_NETBSD_SOURCE) #include strings.h /* for

Re: CVS commit: src/common/lib/libc/string

2011-08-22 Thread David Holland
On Mon, Aug 22, 2011 at 12:48:22PM +0200, Joerg Sonnenberger wrote: Requires stdint.h. No? uh what? It doesn't. The prototypes in strings.h already ensure that uint32_t/uint64_t are present and that's the only thing it could ever need from

Re: CVS commit: src/common/lib/libc/string

2011-08-21 Thread Joerg Sonnenberger
On Sun, Aug 21, 2011 at 09:25:04PM +, David A. Holland wrote: Module Name: src Committed By: dholland Date: Sun Aug 21 21:25:04 UTC 2011 Modified Files: src/common/lib/libc/string: popcount32.c popcount64.c Log Message: Requires stdint.h. To generate a diff of

Re: CVS commit: src/common/lib/libc/string

2011-08-21 Thread David Holland
On Mon, Aug 22, 2011 at 01:31:31AM +0200, Joerg Sonnenberger wrote: Modified Files: src/common/lib/libc/string: popcount32.c popcount64.c Log Message: Requires stdint.h. No? uh what? -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/common/lib/libc/string

2011-08-21 Thread Joerg Sonnenberger
On Sun, Aug 21, 2011 at 11:37:08PM +, David Holland wrote: On Mon, Aug 22, 2011 at 01:31:31AM +0200, Joerg Sonnenberger wrote: Modified Files: src/common/lib/libc/string: popcount32.c popcount64.c Log Message: Requires stdint.h. No? uh what? It doesn't. The

Re: CVS commit: src/common/lib/libc/string

2011-08-21 Thread David Holland
On Mon, Aug 22, 2011 at 03:13:29AM +0200, Joerg Sonnenberger wrote: On Sun, Aug 21, 2011 at 11:37:08PM +, David Holland wrote: On Mon, Aug 22, 2011 at 01:31:31AM +0200, Joerg Sonnenberger wrote: Modified Files: src/common/lib/libc/string: popcount32.c popcount64.c