Re: CVS commit: src/sys/dev/acpi

> Module Name:src > Committed By: christos > Date: Fri Apr 26 18:19:18 UTC 2024 > > Modified Files: > src/sys/dev/acpi: acpi_bat.c > > Log Message: > PR/58201: Malte Dehling: re-order sysmon initialization before acpi > registration, to avoid needing to call to

re: CVS commit: src/sys/dev/acpi

"Jason R Thorpe" writes: > Module Name: src > Committed By: thorpej > Date: Sat Jan 16 01:23:04 UTC 2021 > > Modified Files: > src/sys/dev/acpi: tpm_acpi.c > > Log Message: > Match PNP0C31 as a TPM 1.2 device. Works on my ThinkPad X260, and > eliminates the last of the devices that

Re: CVS commit: src/sys/dev/acpi

On Mon, Jun 22, 2020 at 04:14:18PM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Mon Jun 22 16:14:18 UTC 2020 > > Modified Files: > src/sys/dev/acpi: acpi.c > > Log Message: > Fix memory leak. Found by kLSan. > + > + default: > +

Re: CVS commit: src/sys/dev/acpi

On 10/08/2018 18:11, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Fri Aug 10 17:11:56 UTC 2018 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Don't hold up boot: defer acpibat(4) inquiry until threads are running. ok jmcneill@

Re: CVS commit: src/sys/dev/acpi

On 2019/08/05 23:06, Joerg Sonnenberger wrote: > On Mon, Aug 05, 2019 at 10:12:04AM +, SAITOH Masanobu wrote: >> Module Name: src >> Committed By:msaitoh >> Date:Mon Aug 5 10:12:04 UTC 2019 >> >> Modified Files: >> src/sys/dev/acpi: acpi_ec.c >> >> Log Message: >>

Re: CVS commit: src/sys/dev/acpi

On Mon, Aug 05, 2019 at 10:12:04AM +, SAITOH Masanobu wrote: > Module Name: src > Committed By: msaitoh > Date: Mon Aug 5 10:12:04 UTC 2019 > > Modified Files: > src/sys/dev/acpi: acpi_ec.c > > Log Message: > - Fix a bug that acpiec_space_handler() doesn't access more than

Re: CVS commit: src/sys/dev/acpi

On 2019/08/05 19:12, SAITOH Masanobu wrote: > Module Name: src > Committed By: msaitoh > Date: Mon Aug 5 10:12:04 UTC 2019 > > Modified Files: > src/sys/dev/acpi: acpi_ec.c > > Log Message: > - Fix a bug that acpiec_space_handler() doesn't access more than 64bit > correctly.

Re: CVS commit: src/sys/dev/acpi

Hi Jaromir -- This change breaks the build of the one kernel that includes this code (evbarm GENERIC64) as intr_establish_xname is not an MI API. Cheers, Jared On Mon, 15 Oct 2018, Jaromir Dolecek wrote: Module Name:src Committed By: jdolecek Date: Mon Oct 15 06:58:08 UTC

Re: CVS commit: src/sys/dev/acpi

On Mon, Dec 11, 2017 at 12:22:56AM +0100, Jaromír Dole?ek wrote: [in response to acpi_intr_establish() introduction] > Can we have acpi_intr_establish() accept the xname? It's very useful to > have the driver name registered for "intrctl list". The attached patch does it.

Re: CVS commit: src/sys/dev/acpi

Can we have acpi_intr_establish() accept the xname? It's very useful to have the driver name registered for "intrctl list". Jaromir 2017-12-10 17:51 GMT+01:00 Manuel Bouyer : > Module Name:src > Committed By: bouyer > Date: Sun Dec 10 16:51:30 UTC 2017 > >

Re: CVS commit: src/sys/dev/acpi/wmi

On Sun, Dec 03, 2017 at 11:53:37PM +0100, Manuel Bouyer wrote: > On Sun, Dec 03, 2017 at 11:06:47AM -0800, bch wrote: > > ... > > /usr/src/sys/dev/acpi/wmi/wmi_dell.c: In function 'wmi_dell_action': > > /usr/src/sys/dev/acpi/wmi/wmi_dell.c:234:16: error: comparison between > > signed and

Re: CVS commit: src/sys/dev/acpi/wmi

On Sun, Dec 03, 2017 at 11:06:47AM -0800, bch wrote: > ... > /usr/src/sys/dev/acpi/wmi/wmi_dell.c: In function 'wmi_dell_action': > /usr/src/sys/dev/acpi/wmi/wmi_dell.c:234:16: error: comparison between > signed and unsigned integer expressions [-Werror=sign-compare] > for (i = 0; i <

Re: CVS commit: src/sys/dev/acpi/wmi

... /usr/src/sys/dev/acpi/wmi/wmi_dell.c: In function 'wmi_dell_action': /usr/src/sys/dev/acpi/wmi/wmi_dell.c:234:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for (i = 0; i < __arraycount(wmi_dell_actions); i++) { ^ cc1: all

Re: CVS commit: src/sys/dev/acpi

On Fri, Aug 05, 2011 at 06:27:48PM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Fri Aug 5 18:27:48 UTC 2011 Modified Files: src/sys/dev/acpi: acpi.c Log Message: As we add a handler for the ACPI fixed feature button events, ensure

Re: CVS commit: src/sys/dev/acpi

On Sat, Aug 06, 2011 at 02:55:15PM +0300, Jukka Ruohonen wrote: On Fri, Aug 05, 2011 at 06:27:48PM +, Jonathan A. Kollasch wrote: Module Name:src Committed By: jakllsch Date: Fri Aug 5 18:27:48 UTC 2011 Modified Files: src/sys/dev/acpi: acpi.c

Re: CVS commit: src/sys/dev/acpi

On Sat, Aug 06, 2011 at 12:02:52PM +, Jonathan A. Kollasch wrote: The current version does what I needed. But what is that? - Jukka.

Re: CVS commit: src/sys/dev/acpi

On Sat, Aug 06, 2011 at 03:04:27PM +0300, Jukka Ruohonen wrote: On Sat, Aug 06, 2011 at 12:02:52PM +, Jonathan A. Kollasch wrote: The current version does what I needed. But what is that? Prevent immediate shutdowns because the button was pressed at power up. Jonathan Kollasch

Re: CVS commit: src/sys/dev/acpi

On Sun, 22 May 2011, Joerg Sonnenberger wrote: Modified Files: src/sys/dev/acpi: acpi_power.c Log Message: Let's not be silly. Use a fancy if else to decide behavior of a bool and hope cosmic radition doesn't create a third state. I'll just say here, that I found a code generation

Re: CVS commit: src/sys/dev/acpi

In article 20110425053021.afdbf17...@cvs.netbsd.org, Jukka Ruohonen source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: jruoho Date: Mon Apr 25 05:30:21 UTC 2011 Modified Files: src/sys/dev/acpi: acpi_cpu.c Log Message: Add a missing case value in a

Re: CVS commit: src/sys/dev/acpi

Jukka Ruohonen jruoho...@iki.fi wrote: Are there any plans for kernel equivalent to cpuset(3)? Yes, there is kcpuset(9), see kcpuset_create() and friends. I plan to modify it so it could be used early in MD code (when memory allocation is not yet available) and thus unify random MD cpuset

Re: CVS commit: src/sys/dev/acpi

On Fri, Feb 25, 2011 at 07:55:07PM +, Jukka Ruohonen wrote: Log Message: Start to derive the percpu(9) (or per-domain) state coordination mechanisms by parsing the _CSD, _PSD, and _TSD objects by default. This is quite interesting development affecting the whole x86; the sleep and

Re: CVS commit: src/sys/dev/acpi

On Tue, Feb 22, 2011 at 09:34:13AM +, Jukka Ruohonen wrote: in acpicpu_cstate_fadt(). Note that this violates the specification, given: PBlockAddress provides the system I/O address for the processors register block. Each processor can supply a different such address.

Re: CVS commit: src/sys/dev/acpi

The so-called wakedev code might be broken for a short while. The reasons are listed below. - Jukka. On Thu, Feb 17, 2011 at 10:49:30AM +, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Thu Feb 17 10:49:30 UTC 2011 Modified Files: src/sys/dev/acpi:

Re: CVS commit: src/sys/dev/acpi

On Thu, Feb 17, 2011 at 07:36:49PM +, Jukka Ruohonen wrote: Log Message: As explained in the new ACPICA documentation, as of ACPICA 20101207, the _PRW methods are no longer automatically executed as part of the ACPICA initialization. Refactor and rewrite the wake-device code to account

Re: CVS commit: src/sys/dev/acpi

Jukka Ruohonen jruoho...@iki.fi wrote: +/* + * sysmon_task_queue_cancel: + * + * Cancel a scheduled task. + */ +int +sysmon_task_queue_cancel(void (*func)(void *)) +{ + struct sysmon_task *st; + + if (func == NULL) + return EINVAL; + +

Re: CVS commit: src/sys/dev/acpi

On Tue, Jan 04, 2011 at 12:52:57PM +, Mindaugas Rasiukevicius wrote: 1) There is a use-after-free. Hint: TAILQ_FOREACH_SAFE(). 2) It is not safe; while lock is dropped, the 'next' entry may also be removed and freed. Hint: have a local list and avoid relocking. Hmm. 2) implies that the

Re: CVS commit: src/sys/dev/acpi

On Tue, Jan 04, 2011 at 05:48:49AM +, Jukka Ruohonen wrote: Do not queue functions via sysmon_taskq(9) in the pmf(9) resume hooks. There is a small and unlikely race when the drivers are loaded as modules; suspend, resume, queue a function, and immediately unload the module.

Re: CVS commit: src/sys/dev/acpi

On 09.08.10 07:00, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Mon Aug 9 05:00:24 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_cpu_cstate.c Log Message: Downgrade the currently supported maximum C-state to C1. There appears to be timer-related

Re: CVS commit: src/sys/dev/acpi

On Mon, Aug 09, 2010 at 07:30:52AM +0200, Christoph Egger wrote: Log Message: Downgrade the currently supported maximum C-state to C1. There appears to be timer-related interrupt issues also in C2. With C1 it is guaranteed that acpicpu(4) will not cause any slowdowns due stalled local APIC

Re: CVS commit: src/sys/dev/acpi

On Sun, Jul 18, 2010 at 08:59:33PM -0400, Christos Zoulas wrote: 1. ACPI seems to define cpuids 1..n; we define 0..n-1. Adjust for that 2. My laptop is dual core, but ACPI reports 4 cpu nodes. Instead of attaching the unmatched ones, make the match fail. Do we want to attach and do

Re: CVS commit: src/sys/dev/acpi

In article 20100730072156.ga20...@marx.bitnet, Jukka Ruohonen jruoho...@iki.fi wrote: -=-=-=-=-=- On Sun, Jul 18, 2010 at 08:59:33PM -0400, Christos Zoulas wrote: 1. ACPI seems to define cpuids 1..n; we define 0..n-1. Adjust for that 2. My laptop is dual core, but ACPI reports 4 cpu nodes.

Re: CVS commit: src/sys/dev/acpi

On Mon, Jul 19, 2010 at 12:39:08PM +, Quentin Garnier wrote: When the platform uses the APIC interrupt model, OSPM associates processors declared in the namespace with entries in the MADT. Prior to ACPI 3.0, this was accomplished using the processor object's ProcessorID and the ACPI

Re: CVS commit: src/sys/dev/acpi

On 19.07.10 02:59, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Mon Jul 19 00:59:32 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_cpu.c acpi_cpu.h acpi_cpu_cstate.c Log Message: XXX: If this is not correct, revert or fix. This makes my laptop

Re: CVS commit: src/sys/dev/acpi

On Mon, Jul 19, 2010 at 09:32:58AM +0300, Jukka Ruohonen wrote: This is a known issue. No clean solution exist in any implementation I am aware of. The IDs may also vary between the processor object and MADT. As I noted to Christos in private mail, the right solution is likely to include the

Re: CVS commit: src/sys/dev/acpi

Module Name: src Committed By: christos Date: Mon Jul 19 00:59:32 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_cpu.c acpi_cpu.h acpi_cpu_cstate.c Log Message: XXX: If this is not correct, revert or fix. This makes my laptop boot instead of panic: panic: kernel

Re: CVS commit: src/sys/dev/acpi

On Mon, Jul 19, 2010 at 09:32:58AM +0300, Jukka Ruohonen wrote: On Sun, Jul 18, 2010 at 08:59:33PM -0400, Christos Zoulas wrote: 1. ACPI seems to define cpuids 1..n; we define 0..n-1. Adjust for that ACPI is silent about the CPU IDs in the processor object. In all three Huh? 8.4 Declaring

Re: CVS commit: src/sys/dev/acpi

On 03.04.10 18:29, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Sat Apr 3 16:29:22 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Update the limits when a change from absent to present is detected. Does acpi_bat also detect the

Re: CVS commit: src/sys/dev/acpi

On Sat, Apr 03, 2010 at 06:39:54PM +0200, Christoph Egger wrote: Does acpi_bat also detect the other way around ? I.e. when you have multiple batteries you can unplug a full charged battery and then re-plug an empty one for charging. Yes, this should be possible. (This change only fixed an

Re: CVS commit: src/sys/dev/acpi

On Sat, 3 Apr 2010, Christoph Egger wrote: On 03.04.10 18:29, Jukka Ruohonen wrote: Module Name:src Committed By: jruoho Date: Sat Apr 3 16:29:22 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Update the limits when a change from absent to present

Re: CVS commit: src/sys/dev/acpi

This doesn't sound right: if sysmon_envsys(9) functions are specifically used in these drivers, then depending on header pollution for the prototypes of these functions instead of explicitly including dev/sysmon/sysmonvar.h sounds like a definite bug, not at all a feature. C. On 05/03/2010,

Re: CVS commit: src/sys/dev/acpi

On Thu, 4 Mar 2010, Jukka Ruohonen wrote: Well, this is wrong in the sense that the _COMPONENT definition was incorrect to begin with, and in the sense that we have explicitly tried to recently add the _COMPONENT definitions. Also: now it does BadThings(tm) if the memory tracking of ACPICA is

Re: CVS commit: src/sys/dev/acpi

On Thu, Mar 04, 2010 at 05:12:43AM -0800, Paul Goyette wrote: On Thu, 4 Mar 2010, Jukka Ruohonen wrote: Well, this is wrong in the sense that the _COMPONENT definition was incorrect to begin with, and in the sense that we have explicitly tried to recently add the _COMPONENT definitions.

Re: CVS commit: src/sys/dev/acpi

On Thu, Mar 04, 2010 at 03:10:18AM +, Paul Goyette wrote: Module Name: src Committed By: pgoyette Date: Thu Mar 4 03:10:18 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: Replace ACPI_FREE() with AcpiOsFree() so we no longer need to define

re: CVS commit: src/sys/dev/acpi

Module Name: src Committed By:jruoho Date:Sun Feb 28 09:23:30 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_lid.c Log Message: Cleanup: * Semantics. * Remove ACPI_LID_DEBUG. * Reduce the amount of error reporting.

Re: CVS commit: src/sys/dev/acpi

On Sun, Feb 28, 2010 at 09:16:38PM +1100, matthew green wrote: i'm curious why ignoring the various errors is a good thing. in particular, sysmon_pswitch_register() and pmf_device_register() failure mean the device won't work properly, yet there is nothing to indicate such... Well, generally

Re: CVS commit: src/sys/dev/acpi

On Sat, Feb 06, 2010 at 08:10:18PM +, Paul Goyette wrote: Module Name: src Committed By: pgoyette Date: Sat Feb 6 20:10:18 UTC 2010 Modified Files: src/sys/dev/acpi: files.acpi Added Files: src/sys/dev/acpi: smbus_acpi.c Log Message: Import my experimental

Re: CVS commit: src/sys/dev/acpi

On Dec 3, 2009, at 1:04 PM, Christoph Egger wrote: Module Name: src Committed By: cegger Date: Thu Dec 3 21:04:29 UTC 2009 Modified Files: src/sys/dev/acpi: acpi.c files.acpi Added Files: src/sys/dev/acpi: acpi_pci.c acpi_pci.h Log Message: Enumerate ACPI PCI

Re: CVS commit: src/sys/dev/acpi

On Thu, Dec 03, 2009 at 01:54:19PM -0800, Jason Thorpe wrote: On Dec 3, 2009, at 1:04 PM, Christoph Egger wrote: Module Name:src Committed By: cegger Date: Thu Dec 3 21:04:29 UTC 2009 Modified Files: src/sys/dev/acpi: acpi.c files.acpi Added

Re: CVS commit: src/sys/dev/acpi

On Thu, Dec 03, 2009 at 04:18:52PM -0600, David Young wrote: On Thu, Dec 03, 2009 at 01:54:19PM -0800, Jason Thorpe wrote: On Dec 3, 2009, at 1:04 PM, Christoph Egger wrote: Module Name: src Committed By: cegger Date: Thu Dec 3 21:04:29 UTC 2009

Re: CVS commit: src/sys/dev/acpi

Paul Goyette wrote: On Fri, 4 Dec 2009, Quentin Garnier wrote: IMO, very few devices should attach at acpi, but autoconfiguration should use ACPI data, when it is available, for the direct configuration of devices that we would otherwise have to probe for. Was there ever a disagreement on

re: CVS commit: src/sys/dev/acpi

Christoph - who wonder's why this discussion started after commit instead of after presenting the patch on tech-kern. partly, because you did not wait very long for comments. again. .mrg.

Re: CVS commit: src/sys/dev/acpi

On Sun, 30 Aug 2009, David Brownlee wrote: From: Jared D. McNeill jmcne...@netbsd.org Log Message: PR# port-i386/39671: panic while booting with an acpi kernel on a 790GX board If the firmware describes duplicate keyboard controller nodes, don't panic when the driver fails to map registers.

Re: CVS commit: src/sys/dev/acpi

From: Jared D. McNeill jmcne...@netbsd.org Modified Files: src/sys/dev/acpi: pckbc_acpi.c Log Message: PR# port-i386/39671: panic while booting with an acpi kernel on a 790GX board If the firmware describes duplicate keyboard controller nodes, don't panic when the driver fails to map

Re: CVS commit: src/sys/dev/acpi

On Wed, Apr 08, 2009 at 12:15:45AM +, David Young wrote: Modified Files: src/sys/dev/acpi: acpi_timer.c acpi_timer.h Log Message: Add acpitimer_detach() to eventually support acpi(4) detachment. tc_detach() does not work correctly on a running system. It can race with

Re: CVS commit: src/sys/dev/acpi

- From: David Young dyo...@netbsd.org Sent: Tuesday, April 07, 2009 8:23 PM To: source-changes-f...@netbsd.org Subject: CVS commit: src/sys/dev/acpi Module Name: src Committed By: dyoung Date: Wed Apr 8 00:23:30 UTC 2009 Modified Files:

Re: CVS commit: src/sys/dev/acpi/acpica

On Tue, Mar 31, 2009 at 05:17:47PM +, Matthias Drochner wrote: Module Name: src Committed By: drochner Date: Tue Mar 31 17:17:47 UTC 2009 Modified Files: src/sys/dev/acpi/acpica: OsdSchedule.c OsdSynch.c Log Message: avoid tsleep also during shutdown (and in