Re: CVS commit: src/usr.bin/rsh

2014-10-30 Thread David Holland
On Thu, Oct 30, 2014 at 04:40:57PM +, David Holland wrote: } } Module Name:src } Committed By: dholland } Date: Thu Oct 30 06:13:50 UTC 2014 } } Modified Files: } src/usr.bin/rsh: rsh.c } } Log Message: } Drop setuid before

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread David Holland
On Thu, Oct 30, 2014 at 09:27:06PM +0900, Masao Uebayashi wrote: So, while you expect that options works before it's defined, you also expect the order is honored for no use. I'm not sure how it can work internally. At this moment, no are evaluated when it's parsed. Those no agp*

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Masao Uebayashi
On Thu, Oct 30, 2014 at 10:01 PM, Quentin Garnier c...@cubidou.net wrote: On Thu, Oct 30, 2014 at 09:27:06PM +0900, Masao Uebayashi wrote: On Thu, Oct 30, 2014 at 8:36 PM, Alan Barrett a...@netbsd.org wrote: On Thu, 30 Oct 2014, Masao Uebayashi wrote: What do you expect by doing:

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Masao Uebayashi
On Fri, Oct 31, 2014 at 1:33 AM, Antti Kantee po...@homeworld.netbsd.org wrote: On Thu, Oct 30, 2014 at 11:14:50AM +0900, Masao Uebayashi wrote: On Thu, Oct 30, 2014 at 10:51 AM, Christos Zoulas chris...@astron.com wrote: In article 20141030012621.0982...@cvs.netbsd.org, Masao Uebayashi

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Antti Kantee
On 30/10/14 17:28, Masao Uebayashi wrote: Is there a problem rototilling config is going to solve over what is possible with the existing mechanism (*)? You're welcomed to fix any problems without rotorill and/or breakage. You're not answering the question. *) you probably also heard that

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Masao Uebayashi
On Fri, Oct 31, 2014 at 2:28 AM, Masao Uebayashi uebay...@gmail.com wrote: On Fri, Oct 31, 2014 at 1:33 AM, Antti Kantee po...@homeworld.netbsd.org wrote: On Thu, Oct 30, 2014 at 11:14:50AM +0900, Masao Uebayashi wrote: On Thu, Oct 30, 2014 at 10:51 AM, Christos Zoulas chris...@astron.com

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Masao Uebayashi
On Fri, Oct 31, 2014 at 3:00 AM, Antti Kantee po...@netbsd.org wrote: On 30/10/14 17:28, Masao Uebayashi wrote: Is there a problem rototilling config is going to solve over what is possible with the existing mechanism (*)? You're welcomed to fix any problems without rotorill and/or

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Masao Uebayashi
On Fri, Oct 31, 2014 at 1:49 AM, David Holland dholland-sourcechan...@netbsd.org wrote: On Thu, Oct 30, 2014 at 09:27:06PM +0900, Masao Uebayashi wrote: So, while you expect that options works before it's defined, you also expect the order is honored for no use. I'm not sure how it can

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Taylor R Campbell
Date: Fri, 31 Oct 2014 03:36:45 +0900 From: Masao Uebayashi uebay...@gmail.com On Fri, Oct 31, 2014 at 1:49 AM, David Holland dholland-sourcechan...@netbsd.org wrote: On Thu, Oct 30, 2014 at 09:27:06PM +0900, Masao Uebayashi wrote: At this moment, no are evaluated when it's

Re: CVS commit: src/usr.bin/config

2014-10-29 Thread Christos Zoulas
In article 20141030012621.0982...@cvs.netbsd.org, Masao Uebayashi source-changes-d@NetBSD.org wrote: Re: constructors/destructors: Using them will create a portability constraint on elf. This has the implication that rump will not work on some platforms. christos

Re: CVS commit: src/usr.bin/config

2014-10-29 Thread Masao Uebayashi
On Thu, Oct 30, 2014 at 10:51 AM, Christos Zoulas chris...@astron.com wrote: In article 20141030012621.0982...@cvs.netbsd.org, Masao Uebayashi source-changes-d@NetBSD.org wrote: Re: constructors/destructors: Using them will create a portability constraint on elf. This has the implication

Re: CVS commit: src/usr.bin/config

2014-10-29 Thread Christos Zoulas
On Oct 30, 11:14am, uebay...@gmail.com (Masao Uebayashi) wrote: -- Subject: Re: CVS commit: src/usr.bin/config | Could you show me an example failure senario? What do you propose instead? I don't have anything *better* to propose. I think mach-o constructors are different. | I heard that rump

Re: CVS commit: src/usr.bin/config

2014-10-29 Thread Matt Thomas
On Oct 29, 2014, at 7:30 PM, Christos Zoulas chris...@zoulas.com wrote: On Oct 30, 11:14am, uebay...@gmail.com (Masao Uebayashi) wrote: -- Subject: Re: CVS commit: src/usr.bin/config | Could you show me an example failure senario? What do you propose instead? I don't have anything

Re: CVS commit: src/usr.bin/config

2014-10-29 Thread Masao Uebayashi
On Thu, Oct 30, 2014 at 11:38 AM, Matt Thomas m...@3am-software.com wrote: arm doesn’t use .ctors/.dtors it has init/fini array instead. The section names don't really matter. Probably .kctors/.kdtors are less confusing (+ to avoid confliction with rump). and where would they be executed?

Re: CVS commit: src/usr.bin/config

2014-10-10 Thread Jared McNeill
Are you able to build the arch/evbarm/conf/CUBIEBOARD kernel with these changes? The kernel config has options CPU_CORTEXA7, which depends on CPU_CORTEX, which depends on CPU_ARMV7. Neither CPU_CORTEX nor CPU_ARMV7 are defined in opt_cputypes.h On Fri, 10 Oct 2014, Masao Uebayashi wrote:

Re: CVS commit: src/usr.bin/config

2014-10-10 Thread Masao Uebayashi
My bad. Reproduced here. Hopefully fixed now. On Fri, Oct 10, 2014 at 10:55 PM, Jared McNeill jmcne...@netbsd.org wrote: Are you able to build the arch/evbarm/conf/CUBIEBOARD kernel with these changes? The kernel config has options CPU_CORTEXA7, which depends on CPU_CORTEX, which depends

Re: CVS commit: src/usr.bin/make

2014-09-09 Thread Joerg Sonnenberger
On Tue, Sep 09, 2014 at 06:18:17AM +, David A. Holland wrote: Module Name: src Committed By: dholland Date: Tue Sep 9 06:18:17 UTC 2014 Modified Files: src/usr.bin/make: main.c Log Message: Restore apb's 20140820 commit (-r1.228 of main.c): It should not be an error

Re: CVS commit: src/usr.bin/make

2014-09-09 Thread David Holland
On Tue, Sep 09, 2014 at 02:19:02PM +0200, Joerg Sonnenberger wrote: Log Message: Restore apb's 20140820 commit (-r1.228 of main.c): It should not be an error to have VAR != command that prints no output Joerg reverted a bit too enthusiastically. Thanks. I will go over the

Re: CVS commit: src/usr.bin/make

2014-09-07 Thread Christos Zoulas
In article 20140907205534.98d4...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: joerg Date: Sun Sep 7 20:55:34 UTC 2014 Modified Files: src/usr.bin/make: compat.c lst.h main.c make.c make.h nonints.h parse.c

Re: CVS commit: src/usr.bin/make

2014-08-31 Thread Christos Zoulas
On Aug 31, 12:36am, u...@stderr.spb.ru (Valery Ushakov) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | On Fri, Aug 29, 2014 at 05:27:44 -0400, Christos Zoulas wrote: | | Module Name:src | Committed By: christos | Date: Fri Aug 29 09:27:44 UTC 2014

Re: CVS commit: src/usr.bin/make

2014-08-30 Thread Valery Ushakov
On Fri, Aug 29, 2014 at 05:27:44 -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Fri Aug 29 09:27:44 UTC 2014 Modified Files: src/usr.bin/make: parse.c Log Message: undo eating the trailing backslash now that the shell has been fixed. IIRC,

Re: CVS commit: src/usr.bin/flock

2014-08-18 Thread Alan Barrett
On Mon, 18 Aug 2014, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Mon Aug 18 09:14:03 UTC 2014 Modified Files: src/usr.bin/flock: flock.c Log Message: make this behave like linux. Please describe the actual change, which seems to have something

re: CVS commit: src/usr.bin/man

2014-08-14 Thread matthew green
Alan Barrett writes: Module Name: src Committed By: apb Date: Thu Aug 14 15:31:12 UTC 2014 Modified Files: src/usr.bin/man: man.c Log Message: For an argument to be interpreted as a local file name, bypassing the search rules in man.conf or MANPATH, it must begin with

Re: CVS commit: src/usr.bin/sed

2014-06-07 Thread Ryo ONODERA
Hi, This change breaks many pkgsrc packages. Please take a look at PR bin/48880. Thank you. From: Christos Zoulas chris...@netbsd.org, Date: Thu, 5 Jun 2014 20:13:13 -0400 Module Name: src Committed By: christos Date: Fri Jun 6 00:13:13 UTC 2014 Modified Files:

Re: CVS commit: src/usr.bin/calendar/calendars

2014-05-30 Thread SAITOH Masanobu
(2014/05/31 3:45), John Nemeth wrote: On May 30, 8:36am, SAITOH Masanobu wrote: } } Module Name:src } Committed By: msaitoh } Date: Fri May 30 08:36:28 UTC 2014 } } Modified Files: } src/usr.bin/calendar/calendars: calendar.netbsd } } Log Message: }

Re: CVS commit: src/usr.bin/calendar/calendars

2014-05-30 Thread John Nemeth
On May 30, 8:36am, SAITOH Masanobu wrote: } } Module Name: src } Committed By: msaitoh } Date: Fri May 30 08:36:28 UTC 2014 } } Modified Files: } src/usr.bin/calendar/calendars: calendar.netbsd } } Log Message: } Add 5.1.4, 5.2.2. 6.0.4 and 6.1.3. Uh, those entries were

Re: CVS commit: src/usr.bin/netstat

2014-04-28 Thread Takahiro HAYASHI
hi, (04/25/14 04:02), Christos Zoulas wrote: In article 20140424191900.gp20...@snowdrop.l8s.co.uk, David Laight da...@l8s.co.uk wrote: On Thu, Apr 24, 2014 at 10:56:29AM -0400, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Thu Apr 24 14:56:29 UTC 2014

Re: CVS commit: src/usr.bin/netstat

2014-04-24 Thread David Laight
On Thu, Apr 24, 2014 at 10:56:29AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Thu Apr 24 14:56:29 UTC 2014 Modified Files: src/usr.bin/netstat: main.c route.c Log Message: The sysctl code does not support verbose route printing that prints

Re: CVS commit: src/usr.bin/netstat

2014-04-24 Thread Christos Zoulas
In article 20140424191900.gp20...@snowdrop.l8s.co.uk, David Laight da...@l8s.co.uk wrote: On Thu, Apr 24, 2014 at 10:56:29AM -0400, Christos Zoulas wrote: Module Name: src Committed By:christos Date:Thu Apr 24 14:56:29 UTC 2014 Modified Files:

Re: CVS commit: src/usr.bin/xlint/lint1

2014-04-18 Thread Alan Barrett
On Fri, 18 Apr 2014, matthew green wrote: don't include fmemopen in tools builds. Since tools does not define _NETBSD_SOURCE, we don't get the fmemopen prototype hmm is that because we define _SOMEOTHER_SOURCE? _NETBSD_SOURCE should be defined normally, unless you start to ask for

re: CVS commit: src/usr.bin/xlint/lint1

2014-04-18 Thread Christos Zoulas
On Apr 18, 3:24pm, m...@eterna.com.au (matthew green) wrote: -- Subject: re: CVS commit: src/usr.bin/xlint/lint1 | | Christos Zoulas writes: | Module Name:src | Committed By: christos | Date: Fri Apr 18 02:17:14 UTC 2014 | | Modified Files: | src/usr.bin

re: CVS commit: src/usr.bin/xlint/lint1

2014-04-18 Thread matthew green
Alan Barrett writes: On Fri, 18 Apr 2014, matthew green wrote: don't include fmemopen in tools builds. Since tools does not define _NETBSD_SOURCE, we don't get the fmemopen prototype hmm is that because we define _SOMEOTHER_SOURCE? _NETBSD_SOURCE should be defined normally,

re: CVS commit: src/usr.bin/xlint/lint1

2014-04-17 Thread matthew green
Christos Zoulas writes: Module Name: src Committed By: christos Date: Fri Apr 18 02:17:14 UTC 2014 Modified Files: src/usr.bin/xlint/lint1: main1.c Log Message: don't include fmemopen in tools builds. Since tools does not define _NETBSD_SOURCE, we don't get the fmemopen

Re: CVS commit: src/usr.bin/config

2013-11-01 Thread Valery Ushakov
On Fri, Nov 01, 2013 at 13:09:59 -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Fri Nov 1 17:09:59 UTC 2013 Modified Files: src/usr.bin/config: main.c util.c Log Message: make config errors look more like other programs: file,line: instead

Re: CVS commit: src/usr.bin/config

2013-11-01 Thread Christos Zoulas
On Nov 1, 11:04pm, u...@stderr.spb.ru (Valery Ushakov) wrote: -- Subject: Re: CVS commit: src/usr.bin/config | On Fri, Nov 01, 2013 at 13:09:59 -0400, Christos Zoulas wrote: | | Module Name:src | Committed By: christos | Date: Fri Nov 1 17:09:59 UTC 2013

Re: CVS commit: src/usr.bin/flock

2013-10-30 Thread Christos Zoulas
In article 20131029220912.05f7d58a26dcea4217544...@pandora.be, dieter roelants dieter.net...@pandora.be wrote: On Tue, 29 Oct 2013 12:02:15 -0400 Christos Zoulas chris...@netbsd.org wrote: Module Name: src Committed By:christos Date:Tue Oct 29 16:02:15 UTC 2013

Re: CVS commit: src/usr.bin/flock

2013-10-29 Thread Jukka Ruohonen
On Tue, Oct 29, 2013 at 12:02:15PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Tue Oct 29 16:02:15 UTC 2013 Modified Files: src/usr.bin/flock: flock.c Log Message: PR/48351: Dennis Ferguson: Fix incorrect parsing of flock flags. XXX: still

Re: CVS commit: src/usr.bin/flock

2013-10-29 Thread dieter roelants
On Tue, 29 Oct 2013 12:02:15 -0400 Christos Zoulas chris...@netbsd.org wrote: Module Name: src Committed By: christos Date: Tue Oct 29 16:02:15 UTC 2013 Modified Files: src/usr.bin/flock: flock.c Log Message: PR/48351: Dennis Ferguson: Fix incorrect parsing of flock

Re: CVS commit: src/usr.bin/rump_allserver

2013-09-10 Thread Christos Zoulas
In article 20130910203608.3ae6...@cvs.netbsd.org, Antti Kantee source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: pooka Date: Tue Sep 10 20:36:08 UTC 2013 Modified Files: src/usr.bin/rump_allserver: rump_allserver.c Log Message: Not all systems

Re: CVS commit: src/usr.bin/make

2013-09-04 Thread David Holland
On Tue, Sep 03, 2013 at 09:58:55PM +0200, Alan Barrett wrote: On Mon, 02 Sep 2013, Simon J. Gerraty wrote: Modified Files: src/usr.bin/make: compat.c Log Message: Do not apply shellErrFlag unless errCheck is true. To generate a diff of this commit: cvs rdiff -u -r1.92

Re: CVS commit: src/usr.bin/make

2013-09-03 Thread Alan Barrett
On Mon, 02 Sep 2013, Simon J. Gerraty wrote: Modified Files: src/usr.bin/make: compat.c Log Message: Do not apply shellErrFlag unless errCheck is true. To generate a diff of this commit: cvs rdiff -u -r1.92 -r1.93 src/usr.bin/make/compat.c Will this fix PR 45356? --apb (Alan

Re: CVS commit: src/usr.bin

2013-08-12 Thread David Holland
On Mon, Aug 12, 2013 at 02:03:18PM +, Joerg Sonnenberger wrote: Modified Files: src/usr.bin/audiocfg: main.c src/usr.bin/checknr: checknr.c src/usr.bin/rpcgen: rpc_main.c rpc_util.h Log Message: Add more __dead. I don't suppose there's a way to get gcc to enforce

Re: CVS commit: src/usr.bin

2013-08-12 Thread Joerg Sonnenberger
On Mon, Aug 12, 2013 at 05:55:28PM +, David Holland wrote: On Mon, Aug 12, 2013 at 02:03:18PM +, Joerg Sonnenberger wrote: Modified Files: src/usr.bin/audiocfg: main.c src/usr.bin/checknr: checknr.c src/usr.bin/rpcgen: rpc_main.c rpc_util.h Log Message: Add

Re: CVS commit: src/usr.bin/man

2013-07-18 Thread Valery Ushakov
On Thu, Jul 18, 2013 at 11:39:08 -0400, Christos Zoulas wrote: - fix cast qual issues Do you really need EMPTY hack? Why not just (untested) - pg-gl_pathv[cnt] = ; + *pg-gl_pathv[cnt] = '\0'; -uwe

Re: CVS commit: src/usr.bin/man

2013-07-18 Thread Valery Ushakov
On Thu, Jul 18, 2013 at 11:39:08 -0400, Christos Zoulas wrote: - don't use snprintf on a user-provided buffer This: - (void)snprintf(buf, sizeof(buf), fmt, escpage, suffix-s); + fixstring(buf, sizeof(buf), fmt, escpage); seems wrong, as it loses suffix-s, doesn't it? And fixstring is a

Re: CVS commit: src/usr.bin/make

2013-07-16 Thread Ryo ONODERA
Hi, From: Christos Zoulas chris...@netbsd.org, Date: Tue, 16 Jul 2013 10:00:53 -0400 Module Name: src Committed By: christos Date: Tue Jul 16 14:00:53 UTC 2013 Modified Files: src/usr.bin/make: main.c make.1 var.c Log Message: More gmake compatibility: 1. add -w flag

Re: CVS commit: src/usr.bin/make

2013-07-16 Thread Christos Zoulas
On Jul 16, 11:20pm, ryo...@yk.rim.or.jp (Ryo ONODERA) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | With this change, I have gotten following errors. | I think -lutil is needed. No, I fixed it... I was supposed to use bmake_foo() not efoo(). christos

Re: CVS commit: src/usr.bin/make

2013-07-16 Thread Ryo ONODERA
From: chris...@zoulas.com (Christos Zoulas), Date: Tue, 16 Jul 2013 10:23:04 -0400 On Jul 16, 11:20pm, ryo...@yk.rim.or.jp (Ryo ONODERA) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | With this change, I have gotten following errors. | I think -lutil is needed. No, I fixed

Re: CVS commit: src/usr.bin/make

2013-07-16 Thread David Holland
On Tue, Jul 16, 2013 at 08:00:56PM +, Simon J. Gerraty wrote: Modified Files: src/usr.bin/make: var.c Log Message: When a var is set in the CMD context, it prevents the same name being set in GLOBAL context. We should also delete any such variable in GLOBAL context, else

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Christos Zoulas
In article krbu04$2j1$1...@ger.gmane.org, Christos Zoulas chris...@astron.com wrote: Module Name: src Committed By: sjg Date: Sat Jul 6 18:19:17 UTC 2013 Modified Files: src/usr.bin/make: main.c var.c Log Message: If using gmake's MAKELEVEL; use it the same way Now you put it

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Ryo ONODERA
From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 13:08:49 + (UTC) In article krbu04$2j1$1...@ger.gmane.org, Christos Zoulas chris...@astron.com wrote: Module Name: src Committed By:sjg Date:Sat Jul 6 18:19:17 UTC 2013 Modified Files:

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Christos Zoulas
In article 20130710.232445.202823964487691297.ryo...@yk.rim.or.jp, Ryo ONODERA ryo...@yk.rim.or.jp wrote: From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 13:08:49 + (UTC) In article krbu04$2j1$1...@ger.gmane.org, Christos Zoulas chris...@astron.com wrote: Module Name:

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Ryo ONODERA
From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 15:08:39 + (UTC) In article 20130710.232445.202823964487691297.ryo...@yk.rim.or.jp, Ryo ONODERA ryo...@yk.rim.or.jp wrote: From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 13:08:49 + (UTC) In

Re: CVS commit: src/usr.bin/make

2013-07-07 Thread Christos Zoulas
Module Name: src Committed By: sjg Date: Sat Jul 6 18:19:17 UTC 2013 Modified Files: src/usr.bin/make: main.c var.c Log Message: If using gmake's MAKELEVEL; use it the same way Now you put it back the way it was before which is wrong. Gmake does not behave this way. Before

Re: CVS commit: src/usr.bin/make

2013-06-18 Thread Christos Zoulas
In article 20130618200609.a234...@cvs.netbsd.org, Simon J. Gerraty source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: sjg Date: Tue Jun 18 20:06:09 UTC 2013 Modified Files: src/usr.bin/make: main.c make.h var.c Log Message: Use a #define for the

Re: CVS commit: src/usr.bin/tftp

2013-04-01 Thread Joerg Sonnenberger
On Fri, Mar 29, 2013 at 06:53:22PM +, Radoslaw Kujawa wrote: Module Name: src Committed By: rkujawa Date: Fri Mar 29 18:53:21 UTC 2013 Modified Files: src/usr.bin/tftp: Makefile Log Message: Work around variable might be clobbered by longjmp gcc warning when

Re: CVS commit: src/usr.bin/tftp

2013-03-29 Thread Christos Zoulas
In article 20130329185322.aab9717...@cvs.netbsd.org, Radoslaw Kujawa source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: rkujawa Date: Fri Mar 29 18:53:21 UTC 2013 Modified Files: src/usr.bin/tftp: Makefile Log Message: Work around variable might be

Re: CVS commit: src/usr.bin/make

2013-03-08 Thread Christos Zoulas
On Mar 8, 5:21pm, lu...@netbsd.org (Luke Mewburn) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | Removing the source files would be an epic, | if brutal, method of fixing the problem. :-) I think it is still possible to do this with the code I added :-) christos

Re: CVS commit: src/usr.bin/make

2013-03-07 Thread Luke Mewburn
On Tue, Mar 05, 2013 at 08:35:42PM +, Christos Zoulas wrote: | In article CADbF7eeV2AcmiVZJzuxsN8gvwQHfMLYVN63gRdXpv8-jV=x...@mail.gmail.com, | Masao Uebayashi uebay...@gmail.com wrote: | -=-=-=-=-=- | | I like make(1) to exit when stale depend is found. | | I was thinking of

Re: CVS commit: src/usr.bin/make

2013-03-06 Thread Christos Zoulas
In article 20130306073342.gg4...@apb-laptoy.apb.alt.za, Alan Barrett a...@cequrux.com wrote: On Tue, 05 Mar 2013, Christos Zoulas wrote: Modified Files: src/usr.bin/make: dir.c job.c job.h make.1 parse.c Log Message: Add a .STALE special target that gets invoked when dependency files

Re: CVS commit: src/usr.bin/make

2013-03-05 Thread Masao Uebayashi
I like make(1) to exit when stale depend is found. On Tue, Mar 5, 2013 at 11:04 AM, Christos Zoulas chris...@netbsd.orgwrote: Module Name:src Committed By: christos Date: Tue Mar 5 02:04:11 UTC 2013 Modified Files: src/usr.bin/make: dir.c job.c parse.c Log

Re: CVS commit: src/usr.bin/make

2013-03-05 Thread Christos Zoulas
In article CADbF7eeV2AcmiVZJzuxsN8gvwQHfMLYVN63gRdXpv8-jV=x...@mail.gmail.com, Masao Uebayashi uebay...@gmail.com wrote: -=-=-=-=-=- I like make(1) to exit when stale depend is found. I was thinking of adding a .STALE target, so you can do what you like, for example: .STALE: rm -f

Re: CVS commit: src/usr.bin/make

2013-03-05 Thread Alan Barrett
On Tue, 05 Mar 2013, Christos Zoulas wrote: Modified Files: src/usr.bin/make: dir.c job.c job.h make.1 parse.c Log Message: Add a .STALE special target that gets invoked when dependency files contain stail entries. Please discuss this sort of thing first. There may be a way to solve

Re: CVS commit: src/usr.bin/vis

2013-02-20 Thread Valeriy E. Ushakov
On Sun, Feb 17, 2013 at 23:58:21 +, David Holland wrote: On Sun, Feb 17, 2013 at 08:58:41PM +0200, Alan Barrett wrote: On Thu, 14 Feb 2013, Christos Zoulas wrote: Modified Files: src/usr.bin/vis: vis.c More fixes from J.R. Oldroyd: - In the call to strvisx() the

Re: CVS commit: src/usr.bin/vis

2013-02-17 Thread Alan Barrett
On Thu, 14 Feb 2013, Christos Zoulas wrote: Modified Files: src/usr.bin/vis: vis.c More fixes from J.R. Oldroyd: - In the call to strvisx() the count must be 1, not mbilen which can be 2 or 3 etc for a multibyte character. This value is a count of characters - not bytes - to

Re: CVS commit: src/usr.bin/vis

2013-02-17 Thread David Holland
On Sun, Feb 17, 2013 at 08:58:41PM +0200, Alan Barrett wrote: On Thu, 14 Feb 2013, Christos Zoulas wrote: Modified Files: src/usr.bin/vis: vis.c More fixes from J.R. Oldroyd: - In the call to strvisx() the count must be 1, not mbilen which can be 2 or 3 etc for a multibyte

Re: CVS commit: src/usr.bin/make

2013-01-26 Thread David Laight
On Sat, Jan 26, 2013 at 10:53:00AM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat Jan 26 15:53:00 UTC 2013 Modified Files: src/usr.bin/make: job.c main.c Log Message: Check read and write errors to avoid warnings from linux. XXX: Should

Re: CVS commit: src/usr.bin/make

2013-01-26 Thread Christos Zoulas
In article 20130126205325.gd28...@snowdrop.l8s.co.uk, David Laight da...@l8s.co.uk wrote: I'd have been tempted to do: int stupid_glibc_wont_let_us_ignore_the_result_of_write(int fd, const void *buf, size_t len) { return write(fd, buf, len); } It is the linux headers :-) I'm not sure,

re: CVS commit: src/usr.bin/make

2013-01-26 Thread matthew green
Not much point writing an error is you'vejust failed to write to stderr! i disagree -- ktrace sees it and thus it is not entirely lost :)

Re: CVS commit: src/usr.bin/mail

2013-01-03 Thread Christos Zoulas
In article 20130104015455.d9d3e17...@cvs.netbsd.org, Christos Zoulas source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: christos Date: Fri Jan 4 01:54:55 UTC 2013 Modified Files: src/usr.bin/mail: mime_attach.c Log Message: PR/47396: Steffen:

Re: CVS commit: src/usr.bin/units

2012-12-28 Thread Robert Elz
Date:Fri, 28 Dec 2012 17:57:46 + From:Alan Barrett a...@netbsd.org Message-ID: 20121228175746.e19f117...@cvs.netbsd.org | because unit names cannot contain hyphens. Should that not be mentioned in the man page? Perhaps together with a suggestion that if the

Re: CVS commit: src/usr.bin/units

2012-12-28 Thread Alan Barrett
On Sat, 29 Dec 2012, Robert Elz wrote: | because unit names cannot contain hyphens. Should that not be mentioned in the man page? Perhaps together with a suggestion that if the name the user requires should have hyphens, it simply be entered with the hyphens deleted ... perhaps even using

Re: CVS commit: src/usr.bin/mkubootimage

2012-11-29 Thread Marc Balmer
Comments inline... Module Name: src Committed By: reed Date: Thu Nov 29 23:23:23 UTC 2012 Added Files: src/usr.bin/mkubootimage: mkubootimage.1 Log Message: Add a manual for mkubootimage(1). It was missing. It had one review on netbsd-docs@. I didn't add the manual to

re: CVS commit: src/usr.bin/pkill

2012-11-22 Thread matthew green
| this seems like a fairly big semantic change to me. | | could you change it to take a new option to look in argv[0] instead | of p_comm? p_comm is not changeable by the user. You could already do this with -f. The point was to make the default case behave intuitively. Adding an option

Re: CVS commit: src/usr.bin/pkill

2012-11-21 Thread Christos Zoulas
In article 20121121080326.gl...@snowdrop.l8s.co.uk, David Laight da...@l8s.co.uk wrote: On Tue, Nov 20, 2012 at 05:52:02PM -0500, Christos Zoulas wrote: Module Name: src Committed By:christos Date:Tue Nov 20 22:52:02 UTC 2012 Modified Files: src/usr.bin/pkill:

re: CVS commit: src/usr.bin/pkill

2012-11-21 Thread matthew green
In article 20121121080326.gl...@snowdrop.l8s.co.uk, David Laight da...@l8s.co.uk wrote: On Tue, Nov 20, 2012 at 05:52:02PM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Tue Nov 20 22:52:02 UTC 2012 Modified Files:

re: CVS commit: src/usr.bin/pkill

2012-11-21 Thread Christos Zoulas
On Nov 22, 4:39am, m...@eterna.com.au (matthew green) wrote: -- Subject: re: CVS commit: src/usr.bin/pkill | this seems like a fairly big semantic change to me. | | could you change it to take a new option to look in argv[0] instead | of p_comm? p_comm is not changeable by the user. You could

Re: CVS commit: src/usr.bin/pkill

2012-11-21 Thread David Laight
On Wed, Nov 21, 2012 at 12:43:20PM -0500, Christos Zoulas wrote: On Nov 22, 4:39am, m...@eterna.com.au (matthew green) wrote: -- Subject: re: CVS commit: src/usr.bin/pkill | this seems like a fairly big semantic change to me. | | could you change it to take a new option to look in argv[0

Re: CVS commit: src/usr.bin/pkill

2012-11-21 Thread Christos Zoulas
In article 20121121200309.gn...@snowdrop.l8s.co.uk, David Laight da...@l8s.co.uk wrote: On Wed, Nov 21, 2012 at 12:43:20PM -0500, Christos Zoulas wrote: On Nov 22, 4:39am, m...@eterna.com.au (matthew green) wrote: -- Subject: re: CVS commit: src/usr.bin/pkill | this seems like a fairly big

Re: CVS commit: src/usr.bin/pkill

2012-11-21 Thread David Laight
On Wed, Nov 21, 2012 at 01:36:01PM -0700, Warner Losh wrote: Is pkill() guaranteed to do an atomic traversal of the process list? So it will kill something that keeps using fork() to change its pid. I don't think our libkvm offers that. How could you guarantee this short of moving this

Re: CVS commit: src/usr.bin/pkill

2012-11-21 Thread Warner Losh
On Nov 21, 2012, at 1:55 PM, David Laight wrote: On Wed, Nov 21, 2012 at 01:36:01PM -0700, Warner Losh wrote: Is pkill() guaranteed to do an atomic traversal of the process list? So it will kill something that keeps using fork() to change its pid. I don't think our libkvm offers that.

Re: CVS commit: src/usr.bin/pkill

2012-11-20 Thread David Laight
On Tue, Nov 20, 2012 at 05:52:02PM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Tue Nov 20 22:52:02 UTC 2012 Modified Files: src/usr.bin/pkill: pkill.c Log Message: Don't use p_comm since it is only 16 characters long and you can find the

Re: CVS commit: src/usr.bin/make

2012-11-03 Thread David Laight
On Sat, Nov 03, 2012 at 02:25:14AM +, Simon J. Gerraty wrote: Module Name: src Committed By: sjg Date: Sat Nov 3 02:25:13 UTC 2012 Modified Files: src/usr.bin/make: cond.c Log Message: Allow cond_state[] to grow. The need is rare, but real. 128 nested conditional

Re: CVS commit: src/usr.bin/config

2012-08-30 Thread Izumi Tsutsui
Modified Files: src/usr.bin/config: config.1 main.c Log Message: make config -x look at the booted kernel first. Probably it's better to use #if !defined(HAVE_NBTOOL_CONFIG_H) rather than #ifdef __NetBSD__ ? --- Izumi Tsutsui

Re: CVS commit: src/usr.bin/config

2012-08-30 Thread Christos Zoulas
On Aug 31, 12:02am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/usr.bin/config | Probably it's better to use #if !defined(HAVE_NBTOOL_CONFIG_H) | rather than #ifdef __NetBSD__ ? I'll have to think about it a little more (i.e. what's the scenario of building

re: CVS commit: src/usr.bin/ktruss

2012-03-12 Thread matthew green
Module Name: src Committed By: dyoung Date: Mon Mar 12 22:02:07 UTC 2012 Modified Files: src/usr.bin/ktruss: makeerrnos.sh Log Message: Use 'sort -n -k 3' instead of 'sort -n +2' since the former is more portable. The latter is not supported by Mac OS X Lion. h,

Re: CVS commit: src/usr.bin/tip

2012-02-24 Thread Joerg Sonnenberger
On Fri, Feb 24, 2012 at 08:11:19AM +, David Laight wrote: On Thu, Feb 23, 2012 at 11:39:19PM +, Joerg Sonnenberger wrote: Module Name:src Committed By: joerg Date: Thu Feb 23 23:39:19 UTC 2012 Modified Files: src/usr.bin/tip: cmds.c Log

Re: CVS commit: src/usr.bin/tip

2012-02-24 Thread David Laight
On Fri, Feb 24, 2012 at 09:27:09AM +0100, Joerg Sonnenberger wrote: On Fri, Feb 24, 2012 at 08:11:19AM +, David Laight wrote: On Thu, Feb 23, 2012 at 11:39:19PM +, Joerg Sonnenberger wrote: Module Name: src Committed By: joerg Date: Thu Feb 23 23:39:19 UTC

Re: CVS commit: src/usr.bin/look

2012-02-24 Thread Christos Zoulas
In article 4f473b48.1040...@netbsd.org, Marc Balmer mbal...@netbsd.org wrote: Am 23.02.12 23:57, schrieb Joerg Sonnenberger: Module Name: src Committed By:joerg Date:Thu Feb 23 22:57:53 UTC 2012 Modified Files: src/usr.bin/look: look.c Log Message: Don't

Re: CVS commit: src/usr.bin/tip

2012-02-24 Thread Christos Zoulas
In article 20120224082709.ga24...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Fri, Feb 24, 2012 at 08:11:19AM +, David Laight wrote: On Thu, Feb 23, 2012 at 11:39:19PM +, Joerg Sonnenberger wrote: Module Name: src Committed By: joerg Date:

Re: CVS commit: src/usr.bin/quota

2012-01-31 Thread Manuel Bouyer
On Mon, Jan 30, 2012 at 06:14:43AM +, David A. Holland wrote: Module Name: src Committed By: dholland Date: Mon Jan 30 06:14:43 UTC 2012 Modified Files: src/usr.bin/quota: quotautil.c quotautil.h Log Message: Remove stray p in identifier name. This has (as far as I

Re: CVS commit: src/usr.bin/audio/record

2011-09-22 Thread Marc Balmer
Am 21.09.2011 um 16:32 schrieb Christos Zoulas: Module Name: src Committed By: christos Date: Wed Sep 21 14:32:14 UTC 2011 Modified Files: src/usr.bin/audio/record: record.c Log Message: PR/45384: Henning Petersen: Swapped arguments in lseek To generate a diff of

Re: CVS commit: src/usr.bin/audio/record

2011-09-22 Thread Christos Zoulas
In article dbe1242c-f99e-4b75-b356-516245aca...@msys.ch, Marc Balmer m...@msys.ch wrote: if (outfd == STDOUT_FILENO) return; -if (lseek(outfd, SEEK_SET, 0) 0) +if (lseek(outfd, (off_t)0, SEEK_SET) == (off_t)-1) err(1, could not seek to start of file

Re: CVS commit: src/usr.bin/audio/record

2011-09-22 Thread Marc Balmer
Am 22.09.2011 um 19:34 schrieb Christos Zoulas: In article dbe1242c-f99e-4b75-b356-516245aca...@msys.ch, Marc Balmer m...@msys.ch wrote: if (outfd == STDOUT_FILENO) return; - if (lseek(outfd, SEEK_SET, 0) 0) + if (lseek(outfd, (off_t)0, SEEK_SET) == (off_t)-1)

Re: CVS commit: src/usr.bin/audio/record

2011-09-22 Thread David Laight
On Thu, Sep 22, 2011 at 09:28:56PM +0200, Marc Balmer wrote: Am 22.09.2011 um 19:34 schrieb Christos Zoulas: In article dbe1242c-f99e-4b75-b356-516245aca...@msys.ch, Marc Balmer m...@msys.ch wrote: if (outfd == STDOUT_FILENO) return; - if (lseek(outfd, SEEK_SET, 0)

Re: CVS commit: src/usr.bin/touch

2011-09-07 Thread David Holland
On Tue, Sep 06, 2011 at 11:59:50PM +0400, Valeriy E. Ushakov wrote: Please commit changes like the following together instead of spamming the source-changes list. I don't think that spamming source-changes is a very high priority consideration. OTOH, I know that per-directory commits

re: CVS commit: src/usr.bin/fstat

2011-09-06 Thread matthew green
Module Name: src Committed By: christos Date: Sat Sep 3 13:22:56 UTC 2011 Modified Files: src/usr.bin/fstat: fstat.1 Log Message: Mention that fstat -f will not list open unix sockets on that filesystem. shouldn't this be a .Sh BUGS entry? it sure isn't a feature.

Re: CVS commit: src/usr.bin/touch

2011-09-06 Thread Valeriy E. Ushakov
On Tue, Sep 06, 2011 at 14:04:45 -0500, David Young wrote: Joerg, Please commit changes like the following together instead of spamming the source-changes list. I don't think that spamming source-changes is a very high priority consideration. OTOH, I know that per-directory commits were

Re: CVS commit: src/usr.bin/unzip

2011-08-18 Thread Christos Zoulas
In article 20110818051549.gb24...@arresum.veego.de, Bernd Ernesti source-changes-d@NetBSD.org wrote: On Thu, Aug 18, 2011 at 01:49:30AM +, Christos Zoulas wrote: In article 20110817212950.gc16...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: Did you test this change

Re: CVS commit: src/usr.bin/unzip

2011-08-17 Thread Joerg Sonnenberger
Did you test this change for breaking compatibility with 3rd party scripts that parse the output of unzip? Joerg On Wed, Aug 17, 2011 at 09:37:40AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed Aug 17 13:37:40 UTC 2011 Modified Files:

<    1   2   3   4   5   >