Re: CVS commit: src/sys/compat/netbsd32

2023-07-29 Thread Rin Okuyama
Oops, thanks for quick fix, and it seems that I need a cup of coffee... Thanks, rin On 2023/07/29 22:57, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Sat Jul 29 13:57:28 UTC 2023 Modified Files: src/sys/compat/netbsd32: netbsd32_compat_80.c

Re: CVS commit: src/sys/compat/netbsd32

2023-07-29 Thread Rin Okuyama
On 2023/07/29 22:13, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Sat Jul 29 13:13:50 UTC 2023 Modified Files: src/sys/compat/netbsd32: netbsd32_compat_50.c Log Message: Now, netbsd32_compat_50 module requires netbsd32_compat_100. Thanks pgoyette@ for

Re: CVS commit: src/sys/compat/netbsd32

2021-01-17 Thread Roy Marples
Hi Simon On 17/01/2021 11:26, Simon Burge wrote: On 15/01/2021 07:15, matthew green wrote: Oh, I quite agree. However, in6_nbrinfo predates my involvement with NetBSD and is the same struct on all BSD. While bringing the same functionality to IPv4, I elected to keep the same struct just to

Re: CVS commit: src/sys/compat/netbsd32

2021-01-17 Thread Simon Burge
Hi Roy, Roy Marples wrote: > On 15/01/2021 07:15, matthew green wrote: > >> Oh, I quite agree. However, in6_nbrinfo predates my involvement with NetBSD > >> and is the same struct on all BSD. While bringing the same functionality to > >> IPv4, I elected to keep the same struct just to have the

Re: CVS commit: src/sys/compat/netbsd32

2021-01-15 Thread Roy Marples
On 15/01/2021 02:43, Simon Burge wrote: I'll test a bit more I can't actually test as my ERLite won't boot anymore. Console light is green, cu says I'm connected but I get nothing out of it. With cat5 cables plugged in the ports they flash green and then stick on amber. I'm guessing this is

Re: CVS commit: src/sys/compat/netbsd32

2021-01-14 Thread Roy Marples
On 15/01/2021 07:15, matthew green wrote: Oh, I quite agree. However, in6_nbrinfo predates my involvement with NetBSD and is the same struct on all BSD. While bringing the same functionality to IPv4, I elected to keep the same struct just to have the same API, warts and all. I like consistency.

re: CVS commit: src/sys/compat/netbsd32

2021-01-14 Thread matthew green
> Oh, I quite agree. > However, in6_nbrinfo predates my involvement with NetBSD and is the same > struct > on all BSD. While bringing the same functionality to IPv4, I elected to keep > the > same struct just to have the same API, warts and all. I like consistency. [ .. ] > > That breaks

Re: CVS commit: src/sys/compat/netbsd32

2021-01-14 Thread Roy Marples
On 15/01/2021 02:43, Simon Burge wrote: Hi Roy, Roy Marples wrote: On 14/01/2021 11:03, Simon Burge wrote: Sure, I will have a look. Anything IPv6 related I might need a helping hand to get a test case though :). As they share a similar structure, you solve one you likely solve the other.

Re: CVS commit: src/sys/compat/netbsd32

2021-01-14 Thread Simon Burge
Hi Roy, Roy Marples wrote: > On 14/01/2021 11:03, Simon Burge wrote: > > Sure, I will have a look. Anything IPv6 related I might need a helping > > hand to get a test case though :). > > As they share a similar structure, you solve one you likely solve the other. > I can assume you have working

Re: CVS commit: src/sys/compat/netbsd32

2021-01-14 Thread Roy Marples
On 14/01/2021 11:03, Simon Burge wrote: Sure, I will have a look. Anything IPv6 related I might need a helping hand to get a test case though :). As they share a similar structure, you solve one you likely solve the other. I can assume you have working IPv4 ;) Roy

Re: CVS commit: src/sys/compat/netbsd32

2021-01-14 Thread Simon Burge
Roy Marples wrote: > On 14/01/2021 08:00, Simon Burge wrote: > > Module Name:src > > Committed By: simonb > > Date: Thu Jan 14 08:00:45 UTC 2021 > > > > Modified Files: > > src/sys/compat/netbsd32: netbsd32.h netbsd32_ioctl.c netbsd32_ioctl.h > > > > Log Message:

Re: CVS commit: src/sys/compat/netbsd32

2021-01-14 Thread Roy Marples
On 14/01/2021 08:00, Simon Burge wrote: Module Name:src Committed By: simonb Date: Thu Jan 14 08:00:45 UTC 2021 Modified Files: src/sys/compat/netbsd32: netbsd32.h netbsd32_ioctl.c netbsd32_ioctl.h Log Message: Handle FSSIOCSET and FSSIOCGET; vndconfig(8) works with

Re: CVS commit: src/sys/compat/netbsd32

2020-03-08 Thread Paul Goyette
On Mon, 9 Mar 2020, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Mon Mar 9 01:06:34 UTC 2020 Modified Files: src/sys/compat/netbsd32: netbsd32_mod.c Log Message: If a syscall requires a module to be autoloaded, the initial invocation of that

Re: CVS commit: src/sys/compat/netbsd32

2019-11-04 Thread Rin Okuyama
On 2019/11/04 20:20, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Mon Nov 4 11:20:22 UTC 2019 Modified Files: src/sys/compat/netbsd32: syscalls.master Log Message: For netbsd32_readlinkat(2), bufsize is netbsd_size_t, not size_t. Since bufsize is the last

Re: CVS commit: src/sys/compat/netbsd32

2019-08-21 Thread Christos Zoulas
Thanks for the quick review! The errors below should be all fixed. christos > On Aug 20, 2019, at 3:18 PM, Maxime Villard wrote: > > 1) In compat_drm_agp_info(), seems like it should be info64to32. > > 2) In compat_drm_getstats(), the assignments in the loop are inverted, it's > st32 which

Re: CVS commit: src/sys/compat/netbsd32

2019-08-20 Thread Maxime Villard
Le 20/08/2019 à 11:32, Christos Zoulas a écrit : Module Name:src Committed By: christos Date: Tue Aug 20 09:32:21 UTC 2019 Modified Files: src/sys/compat/netbsd32: files.netbsd32 netbsd32_ioctl.c netbsd32_ioctl.h Added Files: src/sys/compat/netbsd32:

re: CVS commit: src/sys/compat/netbsd32

2019-01-29 Thread matthew green
"Paul Goyette" writes: > Module Name: src > Committed By: pgoyette > Date: Wed Jan 30 02:00:02 UTC 2019 > > Modified Files: > src/sys/compat/netbsd32: netbsd32_compat_80.c > > Log Message: > Remove #ifdef COMPAT_80 > > The file will only be selected if "options COMPAT_80" is

re: CVS commit: src/sys/compat/netbsd32

2017-12-06 Thread Christos Zoulas
On Dec 7, 7:34am, m...@eterna.com.au (matthew green) wrote: -- Subject: re: CVS commit: src/sys/compat/netbsd32 | can they make 32 bit trace records instead? if not, why not? Because every other syscall is making 64 bit records, so ktrace.out file is only parseable/readable by the 64 bit

re: CVS commit: src/sys/compat/netbsd32

2017-12-06 Thread matthew green
"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Wed Dec 6 19:15:27 UTC 2017 > > Modified Files: > src/sys/compat/netbsd32: netbsd32_netbsd.c netbsd32_signal.c > > Log Message: > disable 32 bit signal ktrace records; 32 bit traced process produce 64

Re: CVS commit: src/sys/compat/netbsd32

2016-11-20 Thread Rin Okuyama
On 2016/11/20 21:18, Michael van Elst wrote: Looks fine to me. Committed. Thank you for your review! Rin

Re: CVS commit: src/sys/compat/netbsd32

2016-11-20 Thread Michael van Elst
On Thu, Nov 17, 2016 at 09:46:09PM +0900, Rin Okuyama wrote: > On 2016/11/16 18:33, Michael van Elst wrote: > >So I suggest to make the compat32 code handle CLOCK_NTP_ADJTIME even > >when compiled with !NTP but just return ENOTTY. > > > >N.B. clockctlioctl returns EINVAL for unrecognized ioctl

Re: CVS commit: src/sys/compat/netbsd32

2016-11-17 Thread Rin Okuyama
On 2016/11/16 18:33, Michael van Elst wrote: So I suggest to make the compat32 code handle CLOCK_NTP_ADJTIME even when compiled with !NTP but just return ENOTTY. N.B. clockctlioctl returns EINVAL for unrecognized ioctl commands, it should also return ENOTTY. I wrote a patch. Besides your

Re: CVS commit: src/sys/compat/netbsd32

2016-11-16 Thread Rin Okuyama
On 2016/11/16 18:33, Michael van Elst wrote: There is a slight twist. If NTP isn't defined, the code will call the standard (64bit) ioctl handler with the assumption that the arg uses the same layout in 64bit and 32bit mode. If the ioctl handler is builtin, it won't understand the ioctl either

Re: CVS commit: src/sys/compat/netbsd32

2016-11-16 Thread Michael van Elst
On Tue, Nov 15, 2016 at 07:44:52PM +0900, Rin Okuyama wrote: > On 2016/11/15 19:26, Martin Husemann wrote: > >On Tue, Nov 15, 2016 at 07:23:09PM +0900, Rin Okuyama wrote: > >>This results in build failure for most ARM environments: > >> > >> http://releng.netbsd.org/builds/HEAD/201611140950Z/ >

re: CVS commit: src/sys/compat/netbsd32

2016-11-15 Thread matthew green
> > i didn't look closely, but note that netbsd 5.0 had different > > time_t -- it was only 32 bits. > > > > please check the compat50 and earlier code works fine with this. > > I've checked that i386 binaries from 5.2.2 work on amd64. perfect, thanks! .mrg.

Re: CVS commit: src/sys/compat/netbsd32

2016-11-15 Thread Rin Okuyama
Hi, On 2016/11/13 1:06, Michael van Elst wrote: Module Name:src Committed By: mlelstv Date: Sat Nov 12 16:06:04 UTC 2016 Modified Files: src/sys/compat/netbsd32: netbsd32_ioctl.c netbsd32_ioctl.h Log Message: Fix netbsd32 emulation for clockctl_ntp_adjtime. The ioctl

Re: CVS commit: src/sys/compat/netbsd32

2016-11-15 Thread Rin Okuyama
On 2016/11/15 19:26, Martin Husemann wrote: On Tue, Nov 15, 2016 at 07:23:09PM +0900, Rin Okuyama wrote: This results in build failure for most ARM environments: http://releng.netbsd.org/builds/HEAD/201611140950Z/ I think that NTP stuff should be protected by "#ifdef NTP". Can I commit the

Re: CVS commit: src/sys/compat/netbsd32

2016-11-15 Thread Martin Husemann
On Tue, Nov 15, 2016 at 07:23:09PM +0900, Rin Okuyama wrote: > This results in build failure for most ARM environments: > > http://releng.netbsd.org/builds/HEAD/201611140950Z/ > > I think that NTP stuff should be protected by "#ifdef NTP". > Can I commit the attached patch? Sounds good, but

Re: CVS commit: src/sys/compat/netbsd32

2016-11-15 Thread Rin Okuyama
On 2016/11/15 8:16, matthew green wrote: "Rin Okuyama" writes: Module Name:src Committed By: rin Date: Sun Nov 13 13:59:45 UTC 2016 Modified Files: src/sys/compat/netbsd32: netbsd32_conv.h Log Message: correct wrong casting. some are considered harmless, but - tv_sec

re: CVS commit: src/sys/compat/netbsd32

2016-11-14 Thread matthew green
"Rin Okuyama" writes: > Module Name: src > Committed By: rin > Date: Sun Nov 13 13:59:45 UTC 2016 > > Modified Files: > src/sys/compat/netbsd32: netbsd32_conv.h > > Log Message: > correct wrong casting. some are considered harmless, but > - tv_sec in netbsd32_timeval is

re: CVS commit: src/sys/compat/netbsd32

2016-11-14 Thread matthew green
"Rin Okuyama" writes: > Module Name: src > Committed By: rin > Date: Sun Nov 13 13:52:41 UTC 2016 > > Modified Files: > src/sys/compat/netbsd32: netbsd32.h > > Log Message: > tv_usec in netbsd32_timeval is suseconds_t (aka int32_t) rather than > netbsd32_long (considered harmless)

re: CVS commit: src/sys/compat/netbsd32

2015-06-23 Thread matthew green
David A. Holland writes: Module Name: src Committed By: dholland Date: Tue Jun 23 04:44:08 UTC 2015 Modified Files: src/sys/compat/netbsd32: syscalls.master Log Message: Don't reference netbsd32_nfssvc unless NFSSERVER is defined. Fixes PR 49994. thanks.

Re: CVS commit: src/sys/compat/netbsd32

2015-06-23 Thread David Holland
On Tue, Jun 23, 2015 at 06:23:36PM +1000, matthew green wrote: Log Message: Don't reference netbsd32_nfssvc unless NFSSERVER is defined. Fixes PR 49994. thanks. *bow* -- David A. Holland dholl...@netbsd.org

re: CVS commit: src/sys/compat/netbsd32

2015-05-15 Thread matthew green
Matt Thomas writes: Module Name: src Committed By: matt Date: Fri May 15 07:52:51 UTC 2015 Modified Files: src/sys/compat/netbsd32: netbsd32_lwp.c Log Message: In lwp_ctl, convert ptr to 32 bits before copyout. i wonder if we should KASSERT() that the vaddr_t fits in 32

Re: CVS commit: src/sys/compat/netbsd32

2014-06-16 Thread David Laight
On Fri, Jun 13, 2014 at 10:42:26AM +, Joerg Sonnenberger wrote: Module Name: src Committed By: joerg Date: Fri Jun 13 10:42:26 UTC 2014 Modified Files: src/sys/compat/netbsd32: netbsd32_sysctl.c Log Message: Rename stack gap arguments. stack gap ? that was expunged

Re: CVS commit: src/sys/compat/netbsd32

2011-01-04 Thread Paul Goyette
On Tue, 4 Jan 2011, Matt Thomas wrote: Module Name:src Committed By: matt Date: Tue Jan 4 10:59:29 UTC 2011 Modified Files: src/sys/compat/netbsd32: files.netbsd32 netbsd32_sa.c Log Message: Make the SA support as optional as is possible. This commit appears to have

Re: CVS commit: src/sys/compat/netbsd32

2011-01-04 Thread Paul Goyette
The following patch seems to take care of things, at least on my amd64 machine. I'm not sure if this is the correct fix, so I will let someone else handle the commit! Index: netbsd32_sa.c === RCS file:

re: CVS commit: src/sys/compat/netbsd32

2009-12-10 Thread matthew green
Module Name: src Committed By:njoly Date:Thu Dec 10 14:58:28 UTC 2009 Modified Files: src/sys/compat/netbsd32: netbsd32_ioctl.c Log Message: Make netbsd32_from_{ifreq,oifreq}() copy the whole structure, not only the interface name.