Re: CVS commit: src/sys/fs/tmpfs

2011-05-09 Thread Christos Zoulas
On May 8,  9:21pm, m...@3am-software.com (Matt Thomas) wrote:
-- Subject: Re: CVS commit: src/sys/fs/tmpfs

| The kernel explicitly allows C99 and actually C99 is encouraged.
| So that should reverted :)

Test it. Build a DEBUG kernel and when it works, you can or I will revert it.
In this case it thinks that i is used out of the loop.

christos


Re: CVS commit: src/distrib/sets/lists/comp

2011-05-09 Thread Adam Hamsik

On May,Monday 9 2011, at 1:55 PM, Nicolas Joly wrote:

 Module Name:  src
 Committed By: njoly
 Date: Mon May  9 11:55:34 UTC 2011
 
 Modified Files:
   src/distrib/sets/lists/comp: mi
 
 Log Message:
 Small typo (perfuse.debug - perfused.debug).
 

I'm getting this error with sources updated couple of minutes ago 

===  24 extra files in DESTDIR  =
Files in DESTDIR but missing from flist.
File is obsolete or flist is out of date ?
--
./usr/include/perfuse.h
./usr/lib/i386/libperfuse.a
./usr/lib/i386/libperfuse.so
./usr/lib/i386/libperfuse.so.0
./usr/lib/i386/libperfuse.so.0.0
./usr/lib/i386/libperfuse_p.a
./usr/lib/i386/libperfuse_pic.a
./usr/lib/libperfuse.a
./usr/lib/libperfuse.so
./usr/lib/libperfuse.so.0
./usr/lib/libperfuse.so.0.0
./usr/lib/libperfuse_p.a
./usr/lib/libperfuse_pic.a
./usr/libdata/debug/usr/lib/i386/libperfuse.so.0.0.debug
./usr/libdata/debug/usr/lib/libperfuse.so.0.0.debug
./usr/libdata/debug/usr/sbin/perfused.debug
./usr/libdata/lint/llib-lperfuse.ln
./usr/sbin/perfused
./usr/share/man/cat3/libperfuse.0
./usr/share/man/cat8/perfused.0
./usr/share/man/html3/libperfuse.html
./usr/share/man/html8/perfused.html
./usr/share/man/man3/libperfuse.3
./usr/share/man/man8/perfused.8
=  end of 24 extra files  ===

Regards

Adam.



Re: CVS commit: src/distrib/sets/lists/comp

2011-05-09 Thread Nicolas Joly
On Mon, May 09, 2011 at 03:17:54PM +0200, Adam Hamsik wrote:
 
 I'm getting this error with sources updated couple of minutes ago 
 
 ===  24 extra files in DESTDIR  =
 Files in DESTDIR but missing from flist.
 File is obsolete or flist is out of date ?
 --
 ./usr/include/perfuse.h
 ./usr/lib/i386/libperfuse.a
 ./usr/lib/i386/libperfuse.so
 ./usr/lib/i386/libperfuse.so.0
 ./usr/lib/i386/libperfuse.so.0.0
 ./usr/lib/i386/libperfuse_p.a
 ./usr/lib/i386/libperfuse_pic.a
 ./usr/lib/libperfuse.a
 ./usr/lib/libperfuse.so
 ./usr/lib/libperfuse.so.0
 ./usr/lib/libperfuse.so.0.0
 ./usr/lib/libperfuse_p.a
 ./usr/lib/libperfuse_pic.a
 ./usr/libdata/debug/usr/lib/i386/libperfuse.so.0.0.debug
 ./usr/libdata/debug/usr/lib/libperfuse.so.0.0.debug
 ./usr/libdata/debug/usr/sbin/perfused.debug
 ./usr/libdata/lint/llib-lperfuse.ln
 ./usr/sbin/perfused
 ./usr/share/man/cat3/libperfuse.0
 ./usr/share/man/cat8/perfused.0
 ./usr/share/man/html3/libperfuse.html
 ./usr/share/man/html8/perfused.html
 ./usr/share/man/man3/libperfuse.3
 ./usr/share/man/man8/perfused.8
 =  end of 24 extra files  ===

All these entries have the `perfuse' keyword, which means that they
will be selected for MKPERFUSE=yes builds only. But MKPERFUSE variable
is not defined anywhere ...

Do we need to add another optional component here (Makefiles will then
need some tweaks), or should the keywords need to be wiped out from
lists ?

Manu ?

-- 
Nicolas Joly

Projects and Developments in Bioinformatics
Institut Pasteur, Paris.


Re: CVS commit: src/distrib/sets/lists/comp

2011-05-09 Thread Alistair Crooks
On Mon, May 09, 2011 at 03:58:10PM +0200, Nicolas Joly wrote:
 On Mon, May 09, 2011 at 03:17:54PM +0200, Adam Hamsik wrote:
  
  I'm getting this error with sources updated couple of minutes ago 
  
  ===  24 extra files in DESTDIR  =
  Files in DESTDIR but missing from flist.
  File is obsolete or flist is out of date ?
  --
  ./usr/include/perfuse.h
  ./usr/lib/i386/libperfuse.a
  ./usr/lib/i386/libperfuse.so
  ./usr/lib/i386/libperfuse.so.0
  ./usr/lib/i386/libperfuse.so.0.0
  ./usr/lib/i386/libperfuse_p.a
  ./usr/lib/i386/libperfuse_pic.a
  ./usr/lib/libperfuse.a
  ./usr/lib/libperfuse.so
  ./usr/lib/libperfuse.so.0
  ./usr/lib/libperfuse.so.0.0
  ./usr/lib/libperfuse_p.a
  ./usr/lib/libperfuse_pic.a
  ./usr/libdata/debug/usr/lib/i386/libperfuse.so.0.0.debug
  ./usr/libdata/debug/usr/lib/libperfuse.so.0.0.debug
  ./usr/libdata/debug/usr/sbin/perfused.debug
  ./usr/libdata/lint/llib-lperfuse.ln
  ./usr/sbin/perfused
  ./usr/share/man/cat3/libperfuse.0
  ./usr/share/man/cat8/perfused.0
  ./usr/share/man/html3/libperfuse.html
  ./usr/share/man/html8/perfused.html
  ./usr/share/man/man3/libperfuse.3
  ./usr/share/man/man8/perfused.8
  =  end of 24 extra files  ===
 
 All these entries have the `perfuse' keyword, which means that they
 will be selected for MKPERFUSE=yes builds only. But MKPERFUSE variable
 is not defined anywhere ...
 
 Do we need to add another optional component here (Makefiles will then
 need some tweaks), or should the keywords need to be wiped out from
 lists ?

I think get rid of the perfuse guard keyword - it may be that I
misled people with my post to tech-userlevel, sorry, since the
examples I used had the guard in place; however none of the other
puffs-based entries use any guards so best to get rid of it.

Regards,
Alistair


Re: CVS commit: src/sys/fs/tmpfs

2011-05-09 Thread Jukka Ruohonen
On Mon, May 09, 2011 at 06:50:08PM +0200, Adam Hoka wrote:
 So can we use for (int i = 0; ... ? :p

Hopefully not...

- Jukka.


Re: CVS commit: src/sys/fs/tmpfs

2011-05-09 Thread Matt Thomas

On May 9, 2011, at 5:25 AM, Christos Zoulas wrote:

 On May 8,  9:21pm, m...@3am-software.com (Matt Thomas) wrote:
 -- Subject: Re: CVS commit: src/sys/fs/tmpfs
 
 | The kernel explicitly allows C99 and actually C99 is encouraged.
 | So that should reverted :)
 
 Test it. Build a DEBUG kernel and when it works, you can or I will revert it.

Been doing DEBUG builds with tmpfs for a long time with no problems.

 In this case it thinks that i is used out of the loop.

Where?  After the for loop, it returns.

Re: CVS commit: src/distrib/sets/lists/comp

2011-05-09 Thread Emmanuel Dreyfus
On Mon, May 09, 2011 at 04:36:02PM +0200, Alistair Crooks wrote:
 I think get rid of the perfuse guard keyword - it may be that I
 misled people with my post to tech-userlevel, sorry, since the
 examples I used had the guard in place; however none of the other
 puffs-based entries use any guards so best to get rid of it.

My fault: I did not ran yet another full build before integrating it.
I will commit a fix ASAP. 

-- 
Emmanuel Dreyfus
m...@netbsd.org


Re: CVS commit: src/distrib/sets/lists

2011-05-09 Thread Adam Hamsik

Hmm I have already added MKPERFUSE so please revert mine commits or yours :).

On May,Monday 9 2011, at 7:13 PM, Emmanuel Dreyfus wrote:

 Module Name:  src
 Committed By: manu
 Date: Mon May  9 17:13:21 UTC 2011
 
 Modified Files:
   src/distrib/sets/lists/base: ad.mips64eb ad.mips64el md.amd64
   md.sparc64 mi shl.mi
   src/distrib/sets/lists/comp: ad.mips64eb ad.mips64el md.amd64
   md.sparc64 mi shl.mi
   src/distrib/sets/lists/man: mi
 
 Log Message:
 Attempt to fix build after perfuse addition (there is no MKPERFUSE)
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.47 -r1.48 src/distrib/sets/lists/base/ad.mips64eb
 cvs rdiff -u -r1.45 -r1.46 src/distrib/sets/lists/base/ad.mips64el
 cvs rdiff -u -r1.120 -r1.121 src/distrib/sets/lists/base/md.amd64
 cvs rdiff -u -r1.113 -r1.114 src/distrib/sets/lists/base/md.sparc64
 cvs rdiff -u -r1.937 -r1.938 src/distrib/sets/lists/base/mi
 cvs rdiff -u -r1.582 -r1.583 src/distrib/sets/lists/base/shl.mi
 cvs rdiff -u -r1.30 -r1.31 src/distrib/sets/lists/comp/ad.mips64eb \
src/distrib/sets/lists/comp/ad.mips64el
 cvs rdiff -u -r1.112 -r1.113 src/distrib/sets/lists/comp/md.amd64
 cvs rdiff -u -r1.95 -r1.96 src/distrib/sets/lists/comp/md.sparc64
 cvs rdiff -u -r1.1622 -r1.1623 src/distrib/sets/lists/comp/mi
 cvs rdiff -u -r1.169 -r1.170 src/distrib/sets/lists/comp/shl.mi
 cvs rdiff -u -r1.1315 -r1.1316 src/distrib/sets/lists/man/mi
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 
 Modified files:
 
 Index: src/distrib/sets/lists/base/ad.mips64eb
 diff -u src/distrib/sets/lists/base/ad.mips64eb:1.47 
 src/distrib/sets/lists/base/ad.mips64eb:1.48
 --- src/distrib/sets/lists/base/ad.mips64eb:1.47  Mon May  9 08:51:08 2011
 +++ src/distrib/sets/lists/base/ad.mips64eb   Mon May  9 17:13:19 2011
 @@ -1,4 +1,4 @@
 -# $NetBSD: ad.mips64eb,v 1.47 2011/05/09 08:51:08 manu Exp $
 +# $NetBSD: ad.mips64eb,v 1.48 2011/05/09 17:13:19 manu Exp $
 ./libexec/ld.elf_so-64base-compat-shlib   
 compat,pic
 ./libexec/ld.elf_so-o32   base-sysutil-bin
 compat,pic
 ./usr/lib/64  base-compat-lib
 @@ -179,8 +179,8 @@
 ./usr/lib/64/libpcap.so.4.0   base-compat-shlib   
 compat,pic
 ./usr/lib/64/libpci.so.2  base-compat-shlib   
 compat,pic
 ./usr/lib/64/libpci.so.2.0base-compat-shlib   
 compat,pic
 -./usr/lib/64/libperfuse.so.0 base-compat-shlib   
 compat,pic,perfuse
 -./usr/lib/64/libperfuse.so.0.0   base-compat-shlib   
 compat,pic,perfuse
 +./usr/lib/64/libperfuse.so.0 base-compat-shlib   
 compat,pic
 +./usr/lib/64/libperfuse.so.0.0   base-compat-shlib   
 compat,pic
 ./usr/lib/64/libposix.so.0base-compat-shlib   
 compat,pic
 ./usr/lib/64/libposix.so.0.1  base-compat-shlib   
 compat,pic
 ./usr/lib/64/libprop.so.1 base-compat-shlib   
 compat,pic
 @@ -456,8 +456,8 @@
 ./usr/lib/o32/libpcap.so.4.0  base-compat-shlib   
 compat,pic
 ./usr/lib/o32/libpci.so.2 base-compat-shlib   
 compat,pic
 ./usr/lib/o32/libpci.so.2.0   base-compat-shlib   
 compat,pic
 -./usr/lib/o32/libperfuse.so.0base-compat-shlib   
 compat,pic,perfuse
 -./usr/lib/o32/libperfuse.so.0.0  base-compat-shlib   
 compat,pic,perfuse
 +./usr/lib/o32/libperfuse.so.0base-compat-shlib   
 compat,pic
 +./usr/lib/o32/libperfuse.so.0.0  base-compat-shlib   
 compat,pic
 ./usr/lib/o32/libposix.so.0   base-compat-shlib   
 compat,pic
 ./usr/lib/o32/libposix.so.0.1 base-compat-shlib   
 compat,pic
 ./usr/lib/o32/libprop.so.1base-compat-shlib   
 compat,pic
 
 Index: src/distrib/sets/lists/base/ad.mips64el
 diff -u src/distrib/sets/lists/base/ad.mips64el:1.45 
 src/distrib/sets/lists/base/ad.mips64el:1.46
 --- src/distrib/sets/lists/base/ad.mips64el:1.45  Mon May  9 08:51:08 2011
 +++ src/distrib/sets/lists/base/ad.mips64el   Mon May  9 17:13:19 2011
 @@ -1,4 +1,4 @@
 -# $NetBSD: ad.mips64el,v 1.45 2011/05/09 08:51:08 manu Exp $
 +# $NetBSD: ad.mips64el,v 1.46 2011/05/09 17:13:19 manu Exp $
 ./libexec/ld.elf_so-64base-compat-shlib   
 compat,pic
 ./libexec/ld.elf_so-o32   base-sysutil-bin
 compat,pic
 ./usr/lib/64  base-compat-lib
 @@ -179,8 +179,8 @@
 ./usr/lib/64/libpcap.so.4.0   base-compat-shlib   
 compat,pic
 ./usr/lib/64/libpci.so.2  base-compat-shlib   
 compat,pic
 ./usr/lib/64/libpci.so.2.0   

Re: CVS commit: src/distrib/sets/lists

2011-05-09 Thread Jukka Ruohonen
On Mon, May 09, 2011 at 07:57:46PM +0200, Adam Hamsik wrote:
 
 Hmm I have already added MKPERFUSE so please revert mine commits or yours :).

Please also document these MKVOODOOS.

I have a gut feeling that half of these won't even build...

- Jukka.


Re: CVS commit: src/sys/fs/tmpfs

2011-05-09 Thread Christos Zoulas
On May 9, 10:23am, m...@3am-software.com (Matt Thomas) wrote:
-- Subject: Re: CVS commit: src/sys/fs/tmpfs

| 
| On May 9, 2011, at 5:25 AM, Christos Zoulas wrote:
| 
|  On May 8,  9:21pm, m...@3am-software.com (Matt Thomas) wrote:
|  -- Subject: Re: CVS commit: src/sys/fs/tmpfs
| =20
|  | The kernel explicitly allows C99 and actually C99 is encouraged.
|  | So that should reverted :)
| =20
|  Test it. Build a DEBUG kernel and when it works, you can or I will revert=
|  it.
| 
| Been doing DEBUG builds with tmpfs for a long time with no problems.
| 
|  In this case it thinks that i is used out of the loop.
| 
| Where?  After the for loop, it returns.

Well, just add back the commented out #CPPFLAGS+=-DDEBUG in
/usr/src/sys/rump/Makefile.rump and build again. My MKDEBUG
build causes that to happen too, and so it fails.

christos



Re: CVS commit: src/sys/fs/tmpfs

2011-05-09 Thread Takahiro Kambe
In message 20110509170006.GA15831@marx.bitnet
on Mon, 9 May 2011 20:00:06 +0300,
Jukka Ruohonen jruoho...@iki.fi wrote:
 On Mon, May 09, 2011 at 06:50:08PM +0200, Adam Hoka wrote:
 So can we use for (int i = 0; ... ? :p
lint(1) support them?

 Hopefully not...
Me, too.

-- 
Takahiro Kambe t...@back-street.net


Re: CVS commit: src/sys/fs/tmpfs

2011-05-09 Thread Matt Thomas

On May 9, 2011, at 4:35 PM, Christos Zoulas wrote:

 | Been doing DEBUG builds with tmpfs for a long time with no problems.
 | 
 |  In this case it thinks that i is used out of the loop.
 | 
 | Where?  After the for loop, it returns.
 
 Well, just add back the commented out #CPPFLAGS+=-DDEBUG in
 /usr/src/sys/rump/Makefile.rump and build again. My MKDEBUG
 build causes that to happen too, and so it fails.

Oh.  rump.  Rump incorrectly didn't use -std=gnu99.  That has now been fixed.


Re: CVS commit: src/sys/fs/tmpfs

2011-05-09 Thread Matt Thomas

On May 9, 2011, at 10:00 AM, Jukka Ruohonen wrote:

 On Mon, May 09, 2011 at 06:50:08PM +0200, Adam Hoka wrote:
 So can we use for (int i = 0; ... ? :p
 
 Hopefully not...

For the kernel, for (int ...  is allowed.