Re: CVS commit: src

2018-12-31 Thread Kamil Rytarowski 
On 01.01.2019 04:13, Joerg Sonnenberger wrote:
>> Log Message:
>> Install most of the llvm headers.
>>
>> This is missing some generated files, llvm/include/IR/*.inc
> Can you please not do such changes without proper discussion? I'm *very*
> strongly against this. At the very least it is not useful in this form
> and before any kind of decision on the ABI stability we are willing to
> commit for LLVM is made, this should never have been committed. As is,
> it should be reverted.

LLVM has no API/ABI stability contract and we are down to just keep
syncing the headers and libraries with LLVM releases.

There is an open thread (without complains) about this import.

Regarding usefulness, it's a step forward to reusing builtin toolchain
for dependencies (xsrc, pkgsrc).



signature.asc
Description: OpenPGP digital signature

Re: CVS commit: src

2018-12-31 Thread Thomas Klausner 
On Tue, Jan 01, 2019 at 04:13:57AM +0100, Joerg Sonnenberger wrote:
> On Mon, Dec 31, 2018 at 07:33:08PM +, Maya Rashish wrote:
> > Module Name:src
> > Committed By:   maya
> > Date:   Mon Dec 31 19:33:07 UTC 2018
> > 
> > Modified Files:
> > src/distrib/sets/lists/comp: mi
> > src/etc/mtree: NetBSD.dist.base
> > src/external/bsd/llvm/include: Makefile
> > Added Files:
> > src/external/bsd/llvm/include: Makefile.inc
> > src/external/bsd/llvm/include/llvm: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm-c: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm-c/Transforms: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm-c/Transforms/AggressiveInstCombine:
> > Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm-c/Transforms/IPO: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm-c/Transforms/InstCombine: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm-c/Transforms/Instrumentation:
> > Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm-c/Transforms/Scalar: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm-c/Transforms/Utils: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm-c/Transforms/Vectorize: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/ADT: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/Analysis: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/AsmParser: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/BinaryFormat: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/BinaryFormat/ELFRelocs: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/Bitcode: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/CodeGen: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/Config: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/DebugInfo: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/DebugInfo/CodeView: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/Demangle: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/ExecutionEngine: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/FuzzMutate: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/IR: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/IRReader: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/LTO: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/LineEditor: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/Linker: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/MC: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/Object: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/ObjectYAML: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/Option: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/Passes: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/ProfileData: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/ProfileData/Coverage: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/Support: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/TableGen: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/Target: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/Transforms: Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/Transforms/AggressiveInstCombine:
> > Makefile Makefile.inc
> > src/external/bsd/llvm/include/llvm/Transforms/IPO: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/Transforms/InstCombine: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/Transforms/Instrumentation: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/Transforms/Scalar: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/Transforms/Utils: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/Transforms/Vectorize: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/WindowsManifest: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/WindowsResource: Makefile
> > Makefile.inc
> > src/external/bsd/llvm/include/llvm/XRay: Makefile Makefile.inc
> > 
> > Log Message:
> > Install most of the llvm headers.
> > 
> > This is missing some generated files, llvm/include/IR/*.inc
> 
> Can you please not do such changes without proper discussion?

She did discuss this on tech-toolchain
(https://mail-index.netbsd.org/tech-toolchain/2018/12/26/msg003362.html)
and even cc'd you on the initial email...
 Thomas

> I'm *very*
> strongly against this. At

Re: CVS commit: src/libexec/ld.elf_so

2018-12-31 Thread Joerg Sonnenberger 
On Sat, Dec 29, 2018 at 08:48:37PM -0500, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date: Sun Dec 30 01:48:37 UTC 2018
> 
> Modified Files:
>   src/libexec/ld.elf_so: reloc.c rtld.c rtld.h
> 
> Log Message:
> binutils 2.31.1 can put copy relocations in the relro segment. Delay
> protecting the relro segment for the main object until copy relocations
> are done.

This sounds really really wrong...

Joerg

Re: CVS commit: src

2018-12-31 Thread Joerg Sonnenberger 
On Mon, Dec 31, 2018 at 07:33:08PM +, Maya Rashish wrote:
> Module Name:  src
> Committed By: maya
> Date: Mon Dec 31 19:33:07 UTC 2018
> 
> Modified Files:
>   src/distrib/sets/lists/comp: mi
>   src/etc/mtree: NetBSD.dist.base
>   src/external/bsd/llvm/include: Makefile
> Added Files:
>   src/external/bsd/llvm/include: Makefile.inc
>   src/external/bsd/llvm/include/llvm: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm-c: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm-c/Transforms: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm-c/Transforms/AggressiveInstCombine:
>   Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm-c/Transforms/IPO: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm-c/Transforms/InstCombine: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm-c/Transforms/Instrumentation:
>   Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm-c/Transforms/Scalar: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm-c/Transforms/Utils: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm-c/Transforms/Vectorize: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/ADT: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/Analysis: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/AsmParser: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/BinaryFormat: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/BinaryFormat/ELFRelocs: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/Bitcode: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/CodeGen: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/Config: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/DebugInfo: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/DebugInfo/CodeView: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/Demangle: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/ExecutionEngine: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/FuzzMutate: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/IR: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/IRReader: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/LTO: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/LineEditor: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/Linker: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/MC: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/Object: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/ObjectYAML: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/Option: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/Passes: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/ProfileData: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/ProfileData/Coverage: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/Support: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/TableGen: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/Target: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/Transforms: Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/Transforms/AggressiveInstCombine:
>   Makefile Makefile.inc
>   src/external/bsd/llvm/include/llvm/Transforms/IPO: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/Transforms/InstCombine: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/Transforms/Instrumentation: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/Transforms/Scalar: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/Transforms/Utils: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/Transforms/Vectorize: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/WindowsManifest: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/WindowsResource: Makefile
>   Makefile.inc
>   src/external/bsd/llvm/include/llvm/XRay: Makefile Makefile.inc
> 
> Log Message:
> Install most of the llvm headers.
> 
> This is missing some generated files, llvm/include/IR/*.inc

Can you please not do such changes without proper discussion? I'm *very*
strongly against this. At the very least it is not useful in this form
and before any kind of decision on the ABI stability we are willing to
commit for LLVM is made, this should never have been committed. As is,
it should be reverted.

Joerg