Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-17 Thread Christos Zoulas
On Nov 18, 12:05am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/sys/arch/atari/stand/installboot | I still don't understand why people don't want one additional | -fno-strict-aliasing even for Tier-II ports... | http://nxr.netbsd.org/search?q=fno-strict-aliasing

Re: CVS commit: src/sys/sys

2014-11-17 Thread Christos Zoulas
On Nov 17, 3:27pm, jo...@britannica.bec.de (Joerg Sonnenberger) wrote: -- Subject: Re: CVS commit: src/sys/sys | I don't agree, for most the complexity of the call doesn't justify the | extra code, so inline is fine. That said, days_in_month is quite | wasteful with using an array of int... I wi

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-17 Thread Izumi Tsutsui
martin@ wrote: > (and not paper over it by disabling some optimizations in the > current compiler). I still don't understand why people don't want one additional -fno-strict-aliasing even for Tier-II ports... http://nxr.netbsd.org/search?q=fno-strict-aliasing&project=src&defs=&refs=&path=%2Fsrc%2

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-17 Thread Taylor R Campbell
Date: Mon, 17 Nov 2014 15:55:56 +0100 From: Martin Husemann On Mon, Nov 17, 2014 at 11:48:49PM +0900, Izumi Tsutsui wrote: > You don't think consistently using uint16_t assingments is not necessary. > I think it's necessary to explicitly describe how cksum should be > caluclated

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-17 Thread Martin Husemann
On Mon, Nov 17, 2014 at 11:48:49PM +0900, Izumi Tsutsui wrote: > You don't think consistently using uint16_t assingments is not necessary. > I think it's necessary to explicitly describe how cksum should be > caluclated and written. Both are personal opinions, and I don't think > there is a "right

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-17 Thread Izumi Tsutsui
christos@ wrote: > | So you are a person who are just interested in correctness > | but ignoring readabilty (no one can see why one uses normal > | assignments and others uses stream). Why don't you change > | the cksum assignment to convert via void * pointer? > > Why does everything have to be

Re: CVS commit: src/sys/sys

2014-11-17 Thread Joerg Sonnenberger
On Mon, Nov 17, 2014 at 08:50:20AM -0500, Christos Zoulas wrote: > On Nov 17, 7:56am, mar...@homeworld.netbsd.org (Martin Husemann) wrote: > -- Subject: Re: CVS commit: src/sys/sys > > | On Sun, Nov 16, 2014 at 09:27:26PM -0500, Christos Zoulas wrote: > | > Module Name: src > | > Committed B

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-17 Thread Christos Zoulas
On Nov 17, 10:06pm, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/sys/arch/atari/stand/installboot | So you are a person who are just interested in correctness | but ignoring readabilty (no one can see why one uses normal | assignments and others uses stream). Why

Re: CVS commit: src/sys/sys

2014-11-17 Thread Christos Zoulas
On Nov 17, 7:56am, mar...@homeworld.netbsd.org (Martin Husemann) wrote: -- Subject: Re: CVS commit: src/sys/sys | On Sun, Nov 16, 2014 at 09:27:26PM -0500, Christos Zoulas wrote: | > Module Name:src | > Committed By: christos | > Date: Mon Nov 17 02:27:26 UTC 2014 | >

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-17 Thread Izumi Tsutsui
christos@ wrote: > | > Yes be16enc() should work just fine, I think. > | > | Then why don't you guys also complain to fix existing abcksum() function > | which is called at the suggested memcpy? > > Because it is legally converting a void * pointer. So you are a person who are just interested i

Re: CVS commit: src/sys

2014-11-17 Thread Martin Husemann
On Mon, Nov 17, 2014 at 09:30:05PM +0900, Takeshi Nakayama wrote: > It is not easy to work, so I think it is a good idea to work > partially using rump kernel. I wonder if we should special case UTF8 locales in userland and provide in-kernel iconv only for those (which would NOT solve the problem

Re: CVS commit: src/sys

2014-11-17 Thread Takeshi Nakayama
>>> Justin Cormack wrote > You also need to wrap the #include in sys/netsmb/iconv.c in > #ifdef as well, as some platforms do not have the header. Committed yesterday. > How does it work when not using rump? Do we really need in kernel iconv? It works as before, -E option is silently ignored.

Re: CVS commit: src/sys

2014-11-17 Thread Takeshi Nakayama
>>> Antti Kantee wrote > On 15/11/14 23:46, Takeshi Nakayama wrote: > Justin Cormack wrote > > > >> Er, you can't do that. > >> > >> 1. It breaks the rump builds on most platforms > >> http://build.myriabit.eu:8012/waterfall as the prototypes dont match > >> eg see > >> http://build.myriab

Re: CVS commit: src

2014-11-17 Thread Masao Uebayashi
How about adding a new make variable CONFIGOPTS, which is passed to config(1)? This name is similar to COPTS and works similarly too.

re: CVS commit: src/sys/dev/videomode

2014-11-17 Thread Jared McNeill
On Mon, 17 Nov 2014, matthew green wrote: hmm, does this change the module ABI? ie, kernel version bump time? I don't think anything in sys/modules uses edidvar.h

Re: CVS commit: src

2014-11-17 Thread Masao Uebayashi
If there is an interface to set arguments to config(1), both "mkernel" and "mkernels" can be reverted. And "kernel.gdb" can be also reverted, I think. On Mon, Nov 17, 2014 at 5:37 PM, Alan Barrett wrote: > On Mon, 17 Nov 2014, Martin Husemann wrote: >> >> On Sun, Nov 16, 2014 at 06:08:13AM +

Re: CVS commit: src

2014-11-17 Thread Masao Uebayashi
On Mon, Nov 17, 2014 at 5:00 PM, Martin Husemann wrote: > On Sun, Nov 16, 2014 at 06:08:13AM +, Masao Uebayashi wrote: >> Module Name: src >> Committed By: uebayasi >> Date: Sun Nov 16 06:08:13 UTC 2014 >> >> Modified Files: >> src: build.sh >> >> Log Message: >> build.sh mkerne

Re: CVS commit: src

2014-11-17 Thread Alan Barrett
On Mon, 17 Nov 2014, Martin Husemann wrote: On Sun, Nov 16, 2014 at 06:08:13AM +, Masao Uebayashi wrote: Modified Files: src: build.sh Log Message: build.sh mkernels: Build all kernels in modular build Sorry to be slow here, but: this "modular" obviously differs from modular kerne

Re: CVS commit: src

2014-11-17 Thread Paul Goyette
On Sun, Nov 16, 2014 at 06:08:13AM +, Masao Uebayashi wrote: Module Name:src Committed By: uebayasi Date: Sun Nov 16 06:08:13 UTC 2014 Modified Files: src: build.sh Log Message: build.sh mkernels: Build all kernels in modular build Sorry to be slow here, but: this

Re: CVS commit: src

2014-11-17 Thread Martin Husemann
On Sun, Nov 16, 2014 at 06:08:13AM +, Masao Uebayashi wrote: > Module Name: src > Committed By: uebayasi > Date: Sun Nov 16 06:08:13 UTC 2014 > > Modified Files: > src: build.sh > > Log Message: > build.sh mkernels: Build all kernels in modular build Sorry to be slow here, but