Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jason Thorpe
> On Jun 20, 2018, at 12:29 PM, Jared McNeill wrote: >> Sure, but where is the code for the brcm2835 platform that *processes* it? >> I see stuff for parsing console / fb options, but not for standard boot >> flags. > > Firmware puts the string in /chosen/bootargs and we pick it up here: >

Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jared McNeill
> On Jun 20, 2018, at 4:25 PM, Jason Thorpe wrote: > >> On Jun 20, 2018, at 9:56 AM, Jared McNeill wrote: >> >> On Wed, 20 Jun 2018, Jason Thorpe wrote: >> >>> ofctl(8) is pretty useless for this purpose because it doesn't show you >>> which driver instance has attached to a given device

Re: CVS commit: src/sys/compat/sys

2018-06-20 Thread Taylor R Campbell
> Date: Fri, 15 Jun 2018 19:55:28 +0700 > From: Robert Elz > > Another way would be > > static const struct timespec50 zts = { 0 }; > and > *ts50 = zts; I have nothing substantive to add about the question at hand, but one tiny nit: there is no need for the initializer in this

Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jason Thorpe
> On Jun 20, 2018, at 9:56 AM, Jared McNeill wrote: > > On Wed, 20 Jun 2018, Jason Thorpe wrote: > >> ofctl(8) is pretty useless for this purpose because it doesn't show you >> which driver instance has attached to a given device tree node. As for >> passing generic boot args, it's not

Re: CVS commit: src/sys/arch

2018-06-20 Thread Jaromír Doleček
2018-06-20 18:03 GMT+02:00 Maxime Villard : > I haven't tested but looking at the code it seems to me that this part of > your > change breaks DAZ on native, and I don't see how it can help xsave on xen by > the way Thanks, I'll change the conditional to avoid any potential change of behaviour

Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jared McNeill
On Wed, 20 Jun 2018, Jason Thorpe wrote: ofctl(8) is pretty useless for this purpose because it doesn't show you which driver instance has attached to a given device tree node. As for passing generic boot args, it's not obvious how one does that on the RPI (and I don't even see the hook

Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jason Thorpe
> On Jun 20, 2018, at 2:06 AM, Jared McNeill wrote: > > Not a fan of this, some of these paths can get fairly long (boot the > VEXPRESS_A15 kernel to see for yourself) and the path is only really useful > if you are debugging something. Sigh. > If you want to see the debugging information

Re: CVS commit: src/sys/arch

2018-06-20 Thread Maxime Villard
Le 20/06/2018 à 16:31, Jaromír Doleček a écrit : The function is ever called only with x86_fpu_save >= FPU_SAVE_FXSAVE, so there should be no change in functionality AFAICS. There is a change in functionality, you added an xsave check in a function that is fxsave-specific. xsave != fxsave.

Re: CVS commit: src/sys/arch

2018-06-20 Thread Jaromír Doleček
The function is ever called only with x86_fpu_save >= FPU_SAVE_FXSAVE, so there should be no change in functionality AFAICS. 2018-06-20 10:34 GMT+02:00 Maxime Villard : > Le 19/06/2018 à 21:50, Jaromir Dolecek a écrit : >> >> Module Name:src >> Committed By: jdolecek >> Date: Tue

Re: CVS commit: src/sys/arch

2018-06-20 Thread Maxime Villard
Le 19/06/2018 à 21:50, Jaromir Dolecek a écrit : Module Name:src Committed By: jdolecek Date: Tue Jun 19 19:50:19 UTC 2018 Modified Files: src/sys/arch/x86/include: fpu.h src/sys/arch/x86/x86: cpu.c fpu.c identcpu.c src/sys/arch/xen/x86: cpu.c Log

Re: CVS commit: src/sys/dev/fdt

2018-06-20 Thread Jared McNeill
Not a fan of this, some of these paths can get fairly long (boot the VEXPRESS_A15 kernel to see for yourself) and the path is only really useful if you are debugging something. If you want to see the debugging information we already have a way to do that with boot -x. You can also inspect the