2018-06-20 18:03 GMT+02:00 Maxime Villard <m...@m00nbsd.net>: > I haven't tested but looking at the code it seems to me that this part of > your > change breaks DAZ on native, and I don't see how it can help xsave on xen by > the way
Thanks, I'll change the conditional to avoid any potential change of behaviour for native. Yes, I know that fxsave is different than xsave, but on Xen it seems to be somehow connected. The conditional on XSAVE wad been necessary on Xen according to my testing - with no-xsave that function faulted, with xsave active it didn't. The only difference in CPUID for working and faulting code was the OSXSAVE bit. Maybe Xen somehow traps/disables fxsave also with no-xsave, or maybe requires bigger alignment for some reason. I'll check if I can find something to make the fxsave case work for Xen. Jaromir