Module Name:src
Committed By: mlelstv
Date: Sat Feb 24 22:06:50 UTC 2024
Modified Files:
src/sys/dev/scsipi: sd.c
Log Message:
Don't try to discover wedges when the unit isn't online.
To generate a diff of this commit:
cvs rdiff -u -r1.335 -r1.336
Module Name:src
Committed By: mlelstv
Date: Sat Feb 24 22:06:50 UTC 2024
Modified Files:
src/sys/dev/scsipi: sd.c
Log Message:
Don't try to discover wedges when the unit isn't online.
To generate a diff of this commit:
cvs rdiff -u -r1.335 -r1.336
Module Name:src
Committed By: gutteridge
Date: Mon Jan 1 22:29:49 UTC 2024
Modified Files:
src/sys/dev/scsipi: if_dse.c
Log Message:
if_dse.c: s/addredses/addresses/ in comment
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/scsipi/if_dse.c
Module Name:src
Committed By: gutteridge
Date: Mon Jan 1 22:29:49 UTC 2024
Modified Files:
src/sys/dev/scsipi: if_dse.c
Log Message:
if_dse.c: s/addredses/addresses/ in comment
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/scsipi/if_dse.c
Module Name:src
Committed By: andvar
Date: Thu Dec 7 07:04:13 UTC 2023
Modified Files:
src/sys/dev/scsipi: scsi_disk.h
Log Message:
s/multiplcation/multiplication/ in comment.
To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 src/sys/dev/scsipi/scsi_disk.h
Module Name:src
Committed By: andvar
Date: Thu Dec 7 07:04:13 UTC 2023
Modified Files:
src/sys/dev/scsipi: scsi_disk.h
Log Message:
s/multiplcation/multiplication/ in comment.
To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 src/sys/dev/scsipi/scsi_disk.h
Module Name:src
Committed By: nat
Date: Thu Dec 22 23:06:11 UTC 2022
Modified Files:
src/sys/dev/scsipi: if_dse.c
Log Message:
Fix condition for ending the pacet read loop.
len is unsigned 16 bit so testing for less than zero is not valid.
To generate a diff of this
Module Name:src
Committed By: nat
Date: Thu Dec 22 23:06:11 UTC 2022
Modified Files:
src/sys/dev/scsipi: if_dse.c
Log Message:
Fix condition for ending the pacet read loop.
len is unsigned 16 bit so testing for less than zero is not valid.
To generate a diff of this
Module Name:src
Committed By: nat
Date: Thu Dec 22 22:39:20 UTC 2022
Modified Files:
src/sys/dev/scsipi: if_dse.c
Log Message:
Remove unused commented out code.
Remove unintentional stray debug printfs.
Fix DSE_DEBUG build.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: nat
Date: Thu Dec 22 22:39:20 UTC 2022
Modified Files:
src/sys/dev/scsipi: if_dse.c
Log Message:
Remove unused commented out code.
Remove unintentional stray debug printfs.
Fix DSE_DEBUG build.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: jmcneill
Date: Sat Oct 15 18:42:49 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
Add PQUIRK_ONLYBIG for Oracle OCI BlockVolumes.
Oracle cloud BlockVolumes do not appear to support SCSI READ6 or WRITE6
commands, so set
Module Name:src
Committed By: jmcneill
Date: Sat Oct 15 18:42:49 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
Add PQUIRK_ONLYBIG for Oracle OCI BlockVolumes.
Oracle cloud BlockVolumes do not appear to support SCSI READ6 or WRITE6
commands, so set
Module Name:src
Committed By: skrll
Date: Mon Aug 29 07:32:46 UTC 2022
Modified Files:
src/sys/dev/scsipi: if_se.c
Log Message:
Make this build again. Sorry about that.
To generate a diff of this commit:
cvs rdiff -u -r1.117 -r1.118 src/sys/dev/scsipi/if_se.c
Please
Module Name:src
Committed By: skrll
Date: Mon Aug 29 07:32:46 UTC 2022
Modified Files:
src/sys/dev/scsipi: if_se.c
Log Message:
Make this build again. Sorry about that.
To generate a diff of this commit:
cvs rdiff -u -r1.117 -r1.118 src/sys/dev/scsipi/if_se.c
Please
Module Name:src
Committed By: mlelstv
Date: Sun Aug 28 10:26:37 UTC 2022
Modified Files:
src/sys/dev/scsipi: sd.c sdvar.h
Log Message:
Don't fetch data beyond end of inquiry buffer, which, here, is not
NUL-terminated.
Reduce target buffer to needed size (product name +
Module Name:src
Committed By: mlelstv
Date: Sun Aug 28 10:26:37 UTC 2022
Modified Files:
src/sys/dev/scsipi: sd.c sdvar.h
Log Message:
Don't fetch data beyond end of inquiry buffer, which, here, is not
NUL-terminated.
Reduce target buffer to needed size (product name +
Module Name:src
Committed By: skrll
Date: Sun Aug 28 09:48:12 UTC 2022
Modified Files:
src/sys/dev/scsipi: if_se.c
Log Message:
se(4): don't set if_watchdog as it's not used.
if_timer is never set in this driver and so if_watchdog will never be
called.
To generate a
Module Name:src
Committed By: skrll
Date: Sun Aug 28 09:48:12 UTC 2022
Modified Files:
src/sys/dev/scsipi: if_se.c
Log Message:
se(4): don't set if_watchdog as it's not used.
if_timer is never set in this driver and so if_watchdog will never be
called.
To generate a
Module Name:src
Committed By: skrll
Date: Thu Jul 7 06:11:28 UTC 2022
Modified Files:
src/sys/dev/scsipi: if_se.c
Log Message:
Trailing whitespace
To generate a diff of this commit:
cvs rdiff -u -r1.115 -r1.116 src/sys/dev/scsipi/if_se.c
Please note that diffs are not
Module Name:src
Committed By: skrll
Date: Thu Jul 7 06:11:28 UTC 2022
Modified Files:
src/sys/dev/scsipi: if_se.c
Log Message:
Trailing whitespace
To generate a diff of this commit:
cvs rdiff -u -r1.115 -r1.116 src/sys/dev/scsipi/if_se.c
Please note that diffs are not
Module Name:src
Committed By: andvar
Date: Sun Jun 26 21:00:28 UTC 2022
Modified Files:
src/sys/dev/scsipi: cd.c
Log Message:
s/Ramdom/Random/ in comments.
To generate a diff of this commit:
cvs rdiff -u -r1.353 -r1.354 src/sys/dev/scsipi/cd.c
Please note that diffs
Module Name:src
Committed By: andvar
Date: Sun Jun 26 21:00:28 UTC 2022
Modified Files:
src/sys/dev/scsipi: cd.c
Log Message:
s/Ramdom/Random/ in comments.
To generate a diff of this commit:
cvs rdiff -u -r1.353 -r1.354 src/sys/dev/scsipi/cd.c
Please note that diffs
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:39:47 UTC 2022
Modified Files:
src/sys/dev/scsipi: sd.c
Log Message:
sd(4): Use d_cfdriver/devtounit to avoid open/detach races.
To generate a diff of this commit:
cvs rdiff -u -r1.333 -r1.334
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:39:47 UTC 2022
Modified Files:
src/sys/dev/scsipi: sd.c
Log Message:
sd(4): Use d_cfdriver/devtounit to avoid open/detach races.
To generate a diff of this commit:
cvs rdiff -u -r1.333 -r1.334
Module Name:src
Committed By: riastradh
Date: Sat Mar 12 16:57:16 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
scsi(9): Handle bogus number of LUNs in SCSI_REPORT_LUNS.
Reported-by: syzbot+76ef9084533d4bcce...@syzkaller.appspotmail.com
To
Module Name:src
Committed By: riastradh
Date: Sat Mar 12 16:57:16 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
scsi(9): Handle bogus number of LUNs in SCSI_REPORT_LUNS.
Reported-by: syzbot+76ef9084533d4bcce...@syzkaller.appspotmail.com
To
Module Name:src
Committed By: hannken
Date: Sat Feb 5 17:32:59 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
Initialize "replun" -- found with KMSAN.
To generate a diff of this commit:
cvs rdiff -u -r1.297 -r1.298 src/sys/dev/scsipi/scsiconf.c
Module Name:src
Committed By: hannken
Date: Sat Feb 5 17:32:59 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
Initialize "replun" -- found with KMSAN.
To generate a diff of this commit:
cvs rdiff -u -r1.297 -r1.298 src/sys/dev/scsipi/scsiconf.c
Module Name:src
Committed By: martin
Date: Sat Jan 29 11:20:30 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
In some cases the gcc optimizer is not smart enough to figure out why
the luns and nluns variables are never actually used when they are not
Module Name:src
Committed By: martin
Date: Sat Jan 29 11:20:30 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
In some cases the gcc optimizer is not smart enough to figure out why
the luns and nluns variables are never actually used when they are not
Module Name:src
Committed By: christos
Date: Fri Jan 28 18:23:28 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
Factor out the lun detection code to simplify control flow.
To generate a diff of this commit:
cvs rdiff -u -r1.295 -r1.296
Module Name:src
Committed By: christos
Date: Fri Jan 28 18:23:28 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
Factor out the lun detection code to simplify control flow.
To generate a diff of this commit:
cvs rdiff -u -r1.295 -r1.296
Module Name:src
Committed By: jakllsch
Date: Fri Jan 28 14:02:45 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
shut up GCC about possibly-uninit; some KNF
To generate a diff of this commit:
cvs rdiff -u -r1.294 -r1.295
Module Name:src
Committed By: jakllsch
Date: Fri Jan 28 14:02:45 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
shut up GCC about possibly-uninit; some KNF
To generate a diff of this commit:
cvs rdiff -u -r1.294 -r1.295
Module Name:src
Committed By: jakllsch
Date: Thu Jan 27 18:44:49 UTC 2022
Modified Files:
src/sys/dev/scsipi: sd.c
Log Message:
use powerof2() in sd_validate_blksize()
To generate a diff of this commit:
cvs rdiff -u -r1.332 -r1.333 src/sys/dev/scsipi/sd.c
Please note
Module Name:src
Committed By: jakllsch
Date: Thu Jan 27 18:44:49 UTC 2022
Modified Files:
src/sys/dev/scsipi: sd.c
Log Message:
use powerof2() in sd_validate_blksize()
To generate a diff of this commit:
cvs rdiff -u -r1.332 -r1.333 src/sys/dev/scsipi/sd.c
Please note
Module Name:src
Committed By: jakllsch
Date: Thu Jan 27 18:37:02 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsi_spc.h scsiconf.c
Log Message:
Try REPORT LUNS command to enumerate logical units.
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7
Module Name:src
Committed By: jakllsch
Date: Thu Jan 27 18:37:02 UTC 2022
Modified Files:
src/sys/dev/scsipi: scsi_spc.h scsiconf.c
Log Message:
Try REPORT LUNS command to enumerate logical units.
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7
Module Name:src
Committed By: riastradh
Date: Tue Dec 21 22:53:21 UTC 2021
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
scsi(4): Take kernel lock around entry into autoconf.
This code paths is entered by kthreads marked MP-safe, not just from
autoconf.
Module Name:src
Committed By: riastradh
Date: Tue Dec 21 22:53:21 UTC 2021
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
scsi(4): Take kernel lock around entry into autoconf.
This code paths is entered by kthreads marked MP-safe, not just from
autoconf.
Module Name:src
Committed By: thorpej
Date: Sun Sep 26 14:57:19 UTC 2021
Modified Files:
src/sys/dev/scsipi: ch.c
Log Message:
Use seltrue_filtops rather than rolling our own with filt_seltrue.
To generate a diff of this commit:
cvs rdiff -u -r1.94 -r1.95
Module Name:src
Committed By: thorpej
Date: Sun Sep 26 14:57:19 UTC 2021
Modified Files:
src/sys/dev/scsipi: ch.c
Log Message:
Use seltrue_filtops rather than rolling our own with filt_seltrue.
To generate a diff of this commit:
cvs rdiff -u -r1.94 -r1.95
I don't think this should be reverted, because LUN 0 must exist, but if
there is no device on it, it will report "NOT PRESENT". We do not want
the scan to stop in this case, but it should continue with other LUNs
(such as those found through REPORT LUNS in the future).
Kind regards,
+ Kimmo
On
On Sun, Jul 12, 2020 at 12:05:37AM +0700, Robert Elz wrote:
> Just to make things clear here, the LUN you're talking about is not
> the scsi unit number (which is what I think Martin was referring to)
> but a sub-device number within a single scsi ID. Right?
Correct. I should have written "SCSI
Date:Sat, 11 Jul 2020 18:24:51 +0300
From:Kimmo Suominen
Message-ID: <20200711152451.ga1...@homeworld.netbsd.org>
| On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote:
| > I don't understand the change. When was this broken? This has always
worked
On Sat, Jul 11, 2020 at 06:24:51PM +0300, Kimmo Suominen wrote:
> I think all real SCSI hardware I've had has always just only had LUN 0,
> and each disk has been on its own SCSI ID (target).
Yes, I confused ID and LUN here - just ignore me.
Martin
On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote:
> I don't understand the change. When was this broken? This has always worked
> for me e.g. with the sd0 at LUN 3 and the controller at 6 or 7.
I think all real SCSI hardware I've had has always just only had LUN 0,
and each disk
On Sat, Jul 11, 2020 at 05:57:46PM +0300, Kimmo Suominen wrote:
> On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote:
> > I'd reckon a pullup to NetBSD 9 would be in order?
>
> Yes, I was just waiting to be able to link to mail-index. I had
> already checked that the patch applies
On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote:
> I'd reckon a pullup to NetBSD 9 would be in order?
Yes, I was just waiting to be able to link to mail-index. I had
already checked that the patch applies cleanly to both netbsd-9
and netbsd-8.
On Sat, Jul 11, 2020 at 02:31:46PM +, Kimmo Suominen wrote:
> Use case 2: A Linode boot profile with multiple disks results in
> the first disk ("sda") on LUN 1, while the second disk ("sdb") is
> on LUN 0, each on their own bus.
As Linode is quite popular, and supposedly uses a rather
Module Name:src
Committed By: msaitoh
Date: Thu Sep 19 03:37:31 UTC 2019
Modified Files:
src/sys/dev/scsipi: scsipi_base.c
Log Message:
Use unsigned to avoid undefined behavior in scsipi_{get,put}_tag().
Found by kUBSan.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: msaitoh
Date: Thu Sep 19 03:37:31 UTC 2019
Modified Files:
src/sys/dev/scsipi: scsipi_base.c
Log Message:
Use unsigned to avoid undefined behavior in scsipi_{get,put}_tag().
Found by kUBSan.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: mlelstv
Date: Thu May 30 16:57:39 UTC 2019
Modified Files:
src/sys/dev/scsipi: scsipi_ioctl.c
Log Message:
use correct size when copying outgoing sense data.
To generate a diff of this commit:
cvs rdiff -u -r1.71 -r1.72
Module Name:src
Committed By: mlelstv
Date: Thu May 30 16:57:39 UTC 2019
Modified Files:
src/sys/dev/scsipi: scsipi_ioctl.c
Log Message:
use correct size when copying outgoing sense data.
To generate a diff of this commit:
cvs rdiff -u -r1.71 -r1.72
Module Name:src
Committed By: mlelstv
Date: Sun May 26 08:12:41 UTC 2019
Modified Files:
src/sys/dev/scsipi: scsipi_ioctl.c
Log Message:
Add sanity checks to SCIOCCOMMAND, adapter drivers might be confused or trigger
assertions (e.g. umass).
To generate a diff of this
Module Name:src
Committed By: mlelstv
Date: Sun May 26 08:12:41 UTC 2019
Modified Files:
src/sys/dev/scsipi: scsipi_ioctl.c
Log Message:
Add sanity checks to SCIOCCOMMAND, adapter drivers might be confused or trigger
assertions (e.g. umass).
To generate a diff of this
Module Name:src
Committed By: kardel
Date: Sun May 19 19:06:53 UTC 2019
Modified Files:
src/sys/dev/scsipi: st.c
Log Message:
Add simple position recovery when positioning to EOM by reading
the position with READ_POSITION.
this allows for
mt eom
mt st
to
On 24.03.2018 16:47, Martin Husemann wrote:
> On Sat, Mar 24, 2018 at 09:38:15AM +0100, Thomas Klausner wrote:
>> On Sat, Mar 24, 2018 at 09:06:25AM +0100, Michael van Elst wrote:
>>> On Sat, Mar 24, 2018 at 02:50:05AM +0100, Kamil Rytarowski wrote:
>>>
I had to revert this in order to
On Sat, Mar 24, 2018 at 09:38:15AM +0100, Thomas Klausner wrote:
> On Sat, Mar 24, 2018 at 09:06:25AM +0100, Michael van Elst wrote:
> > On Sat, Mar 24, 2018 at 02:50:05AM +0100, Kamil Rytarowski wrote:
> >
> > > I had to revert this in order to unbreak build.
> >
> >
> > Please never do that.
On Sat, Mar 24, 2018 at 09:06:25AM +0100, Michael van Elst wrote:
> On Sat, Mar 24, 2018 at 02:50:05AM +0100, Kamil Rytarowski wrote:
>
> > I had to revert this in order to unbreak build.
>
>
> Please never do that.
I think it's appropriate if it's a small patch that breaks the build
and can
On Sat, Mar 24, 2018 at 02:50:05AM +0100, Kamil Rytarowski wrote:
> I had to revert this in order to unbreak build.
Please never do that.
--
Michael van Elst
Internet: mlel...@serpens.de
"A potential Snark may lurk in every
Date:Sat, 24 Mar 2018 02:50:05 +0100
From:Kamil Rytarowski
Message-ID: <8b2f90cf-0c7f-1154-b3fb-c4c600d07...@gmx.com>
| > To generate a diff of this commit:
| > cvs rdiff -u -r1.231 -r1.232 src/sys/dev/scsipi/st.c
|
| I had to revert this in
On 23.03.2018 07:01, Michael van Elst wrote:
> Module Name: src
> Committed By: mlelstv
> Date: Fri Mar 23 06:01:07 UTC 2018
>
> Modified Files:
> src/sys/dev/scsipi: st.c
>
> Log Message:
> Use separate lock to protect internal state and release locks when
> calling biodone.
>
>
Hi,
Today, I found my environment panic while rebooting. As bisecting, it
seems the cause is below commit.
On 2017/06/18 7:35, Michael van Elst wrote:
> Module Name: src
> Committed By: mlelstv
> Date: Sat Jun 17 22:35:50 UTC 2017
>
> Modified Files:
> src/sys/dev/scsipi:
On Tue, Apr 11, 2017 at 02:13:42AM +, Christos Zoulas wrote:
> Can't we fix this a different way? What's the problem?
The log description might have been confusing.
It just makes no sense to try to autoload any module while / is not yet
available. It may make sense to move the check for this
In article <20170410215338.12a45f...@cvs.netbsd.org>,
Jaromir Dolecek wrote:
>-=-=-=-=-=-
>
>just do not autoload scsiverbose module, it causes deadlock if it happens
>while root fs is being mounted
>
>adresses second part of PR kern/52147 by Michael van Elst, thank
Hi Erik !
I agree that 5 minutes is a really long time. Actually the inventory
command will
wait even longer (5 min per element + 10 minutes as safeguard - I didn't
change that).
Generating a uprintf would mean to manage a separate callout and using,
I believe,
the tprintf() call from the
Erik,
I agree with this very much. Actually I have been toying around with
this idea
quite some time. My thoughts where to build a sysctl tree for all scsi
commands
with their default values and another level of sysctl timeout nodes
where the
vendor and device name or driver name is part of
On Aug 9, 2013, at 12:58 , Frank Kardel kar...@netbsd.org wrote:
Module Name: src
Committed By: kardel
Date: Fri Aug 9 19:58:44 UTC 2013
Modified Files:
src/sys/dev/scsipi: ch.c
Log Message:
bump command timeout to 5 minutes. several
types of changers (Overland
On Aug 9, 2013, at 12:58 , Frank Kardel kar...@netbsd.org wrote:
Module Name: src
Committed By: kardel
Date: Fri Aug 9 19:58:44 UTC 2013
Modified Files:
src/sys/dev/scsipi: ch.c
Log Message:
bump command timeout to 5 minutes. several
types of changers (Overland
On Thu, Apr 19, 2012 at 06:39:29PM -0600, Warner Losh wrote:
FreeBSD started out with MPSAFE and then went to NEEDS_GIANT as flags for the
drivers. I'm with Matthew: patch the drivers that are broken (or not known
to be safe) and then you have a convenient thing to grep for when you want to
On Fri, Apr 20, 2012 at 09:37:00AM +0200, Manuel Bouyer wrote:
we've never had autoconfig run with the kernel lock AFAICT, so this
assumption has never been true.
So this is a bug. The contract was really that spl-locked drivers would
continue to work as is when fine-grained locking
On Fri, Apr 20, 2012 at 07:46:35AM +, David Holland wrote:
On Fri, Apr 20, 2012 at 09:37:00AM +0200, Manuel Bouyer wrote:
we've never had autoconfig run with the kernel lock AFAICT, so this
assumption has never been true.
So this is a bug. The contract was really that
On Fri, Apr 20, 2012 at 06:06:35PM +1000, matthew green wrote:
we've never had autoconfig run with the kernel lock AFAICT, so this
assumption has never been true.
So this is a bug. The contract was really that spl-locked drivers would
continue to work as is when fine-grained locking
Module Name: src
Committed By: bouyer
Date: Wed Apr 18 20:37:49 UTC 2012
Modified Files:
src/sys/dev/scsipi: scsipi_base.c
Log Message:
Fix KASSERT(): autoconf doesn't run under the KERNEL_LOCK
this is true, but can you please fix it differently? ie autoconf
isn't
On Thu, Apr 19, 2012 at 04:41:04PM +1000, matthew green wrote:
Module Name:src
Committed By: bouyer
Date: Wed Apr 18 20:37:49 UTC 2012
Modified Files:
src/sys/dev/scsipi: scsipi_base.c
Log Message:
Fix KASSERT(): autoconf doesn't run under the
Module Name: src
Committed By: bouyer
Date: Wed Apr 18 20:37:49 UTC 2012
Modified Files:
src/sys/dev/scsipi: scsipi_base.c
Log Message:
Fix KASSERT(): autoconf doesn't run under the KERNEL_LOCK
this is true, but can you please fix it
On Thu, Apr 19, 2012 at 06:25:54PM +1000, matthew green wrote:
[...]
If the driver's attach is called after cold (e.g. after a detach/rescan
of the pci bus), the driver's attach should be called with KERNEL_LOCK
held, or bad things may happen when interrupts are enabled for this driver.
If the driver's attach is called after cold (e.g. after a detach/rescan
of the pci bus), the driver's attach should be called with KERNEL_LOCK
held, or bad things may happen when interrupts are enabled for this
driver.
there should be no reliance on cold being set for normal
On Thu, Apr 19, 2012 at 07:00:56PM +1000, matthew green wrote:
If the driver's attach is called after cold (e.g. after a detach/rescan
of the pci bus), the driver's attach should be called with KERNEL_LOCK
held, or bad things may happen when interrupts are enabled for this
scsipi depends upon kernel lock. thus, callers should arrange for it
to be held. since these are drivers calling, it is upto each driver
to do this currently. this is what we've done with other problems we
have hit as they've arrived.
if the caller is MPSAFE, I agree. Non-MPSAFE
On Apr 19, 2012, at 6:03 PM, matthew green wrote:
But that's a problem with autoconf not dealing with non-MPSAFE drivers,
not the driver themselve (they were working before the MP changes, they
should continue to work as-is). If you want autoconf to not run
under the KERNEL_LOCK when not
On Mon, Apr 25, 2011 at 02:14:23PM +, Juergen Hannken-Illjes wrote:
Module Name: src
Committed By: hannken
Date: Mon Apr 25 14:14:22 UTC 2011
Modified Files:
src/sys/dev/scsipi: scsiconf.c
Log Message:
Don't kill outstanding requests when detaching a scsibus on
On Mon, Apr 25, 2011 at 10:33:14AM -0500, David Young wrote:
On Mon, Apr 25, 2011 at 02:14:23PM +, Juergen Hannken-Illjes wrote:
Module Name:src
Committed By: hannken
Date: Mon Apr 25 14:14:22 UTC 2011
Modified Files:
src/sys/dev/scsipi: scsiconf.c
On Mon, Apr 25, 2011 at 06:26:09PM +0200, Juergen Hannken-Illjes wrote:
On Mon, Apr 25, 2011 at 10:33:14AM -0500, David Young wrote:
On Mon, Apr 25, 2011 at 02:14:23PM +, Juergen Hannken-Illjes wrote:
Module Name: src
Committed By: hannken
Date: Mon Apr 25
Module Name:src
Committed By: pooka
Date: Fri Feb 12 11:39:33 UTC 2010
Modified Files:
src/sys/dev/scsipi: scsipi_base.c
Log Message:
delay() is used here, so need to include machine/param.h.
To generate a diff of this commit:
cvs rdiff -u -r1.150 -r1.151
Module Name:src
Committed By: cegger
Date: Sat Feb 6 23:13:59 UTC 2010
Modified Files:
src/sys/dev/scsipi: scsi_spc.h
Log Message:
scsi_sense_data: add comments taken from src/sys/dev/ieee1394/sbp.h
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5
On May 13, 7:56am, christoph_eg...@gmx.de (Christoph Egger) wrote:
-- Subject: Re: CVS commit: src/sys/dev/scsipi
| Christos Zoulas wrote:
| Module Name:src
| Committed By: christos
| Date: Wed May 13 02:35:25 UTC 2009
|
| Modified Files:
| src/sys/dev
88 matches
Mail list logo