Re: CVS commit: src/sys/netinet

2015-02-19 Thread Ryo Shimizu
Module Name: src Committed By: christos Date: Wed Feb 18 17:00:16 UTC 2015 Modified Files: src/sys/netinet: icmp_var.h ip_icmp.h Log Message: PR/49676: Ryo Shimizu: ICMP_STATINC() buffer overflows XXX: pullup-7 please pullup-6 too. -- ryo shimizu

Re: CVS commit: src/sys/netinet

2014-04-16 Thread Manuel Bouyer
On Tue, Apr 15, 2014 at 02:10:33PM -0700, Erik Fair wrote: This should be pulled up to netbsd-6 this is not critical: the code is used only at boot time with root on nfs, and the condition that would cause the leak is always false anyway. -- Manuel Bouyer bou...@antioche.eu.org NetBSD: 26

Re: CVS commit: src/sys/netinet

2014-04-15 Thread Erik Fair
This should be pulled up to netbsd-6 On Apr 12, 2014, at 05:24, Greg Troxel g...@netbsd.org wrote: Module Name: src Committed By: gdt Date: Sat Apr 12 12:24:50 UTC 2014 Modified Files: src/sys/netinet: if_arp.c Log Message: revarprequest: Avoid leaking mbuf. In

Re: CVS commit: src/sys/netinet

2014-04-15 Thread Greg Troxel
Erik Fair f...@netbsd.org writes: On Apr 12, 2014, at 05:24, Greg Troxel g...@netbsd.org wrote: Module Name: src Committed By:gdt Date:Sat Apr 12 12:24:50 UTC 2014 Modified Files: src/sys/netinet: if_arp.c Log Message: revarprequest: Avoid leaking mbuf.

Re: CVS commit: src/sys/netinet

2013-06-05 Thread Greg Troxel
Christos Zoulas chris...@netbsd.org writes: Module Name: src Committed By: christos Date: Wed Jun 5 00:48:32 UTC 2013 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: conditionalize the net traversal code on FAST_IPSEC to make rump build. FAST_IPSEC does not

Re: CVS commit: src/sys/netinet

2013-06-05 Thread Christos Zoulas
In article rmili6ozh4c@fnord.ir.bbn.com, Greg Troxel g...@ir.bbn.com wrote: Christos Zoulas chris...@netbsd.org writes: Module Name: src Committed By:christos Date:Wed Jun 5 00:48:32 UTC 2013 Modified Files: src/sys/netinet: udp_usrreq.c Log Message:

Re: CVS commit: src/sys/netinet

2013-03-12 Thread Greg Troxel
Christos Zoulas chris...@netbsd.org writes: Module Name: src Committed By: christos Date: Tue Mar 12 21:54:36 UTC 2013 Modified Files: src/sys/netinet: in4_cksum.c Log Message: - Don't panic on short packets unless DIAGNOSTIC. In general we should try to make the

Re: CVS commit: src/sys/netinet

2011-12-23 Thread Christos Zoulas
In article 20111223220300.9e70b17...@cvs.netbsd.org, James Chacon source-changes-d@NetBSD.org wrote: -=-=-=-=-=- #define ICMP_PHOTURIS 40 /* security */ +#define ICMP_PHOTURIS_UNKNOWN_INDEX 1 /* Bad index */ +#define

Re: CVS commit: src/sys/netinet

2011-12-23 Thread James Chacon
Unfortunately pfctl references them if it sees ICMP_PHOTURIS defined. A quick search for these does show a lot of use out there between *BSD, linux, etc. And http://www.iana.org/assignments/icmp-parameters/icmp-parameters.xml#icmp-parameters-codes-40 shows a few more even and RFC2521 seems to

Re: CVS commit: src/sys/netinet

2011-12-23 Thread Christos Zoulas
On Dec 23, 2:20pm, chacon.ja...@gmail.com (James Chacon) wrote: -- Subject: Re: CVS commit: src/sys/netinet | Unfortunately pfctl references them if it sees ICMP_PHOTURIS defined. Ah. | A quick search for these does show a lot of use out there between | *BSD, linux, etc. | | And http

Re: CVS commit: src/sys/netinet

2011-12-23 Thread James Chacon
Think we should go ahead and add the codes for 0,4 and 5? James On Fri, Dec 23, 2011 at 2:44 PM, Christos Zoulas chris...@zoulas.com wrote: On Dec 23,  2:20pm, chacon.ja...@gmail.com (James Chacon) wrote: -- Subject: Re: CVS commit: src/sys/netinet | Unfortunately pfctl references them

Re: CVS commit: src/sys/netinet

2011-12-23 Thread Christos Zoulas
On Dec 23, 3:10pm, chacon.ja...@gmail.com (James Chacon) wrote: -- Subject: Re: CVS commit: src/sys/netinet | Think we should go ahead and add the codes for 0,4 and 5? Well, are the ones for 1 and 3 correct? I have really no opinion on this. I would like to read up some more on the RFC

Re: CVS commit: src/sys/netinet

2011-12-23 Thread James Chacon
On Fri, Dec 23, 2011 at 3:36 PM, Christos Zoulas chris...@zoulas.com wrote: On Dec 23,  3:10pm, chacon.ja...@gmail.com (James Chacon) wrote: -- Subject: Re: CVS commit: src/sys/netinet | Think we should go ahead and add the codes for 0,4 and 5? Well, are the ones for 1 and 3 correct? I have

Re: CVS commit: src/sys/netinet

2011-12-23 Thread Christos Zoulas
On Dec 23, 4:03pm, chacon.ja...@gmail.com (James Chacon) wrote: -- Subject: Re: CVS commit: src/sys/netinet | On Fri, Dec 23, 2011 at 3:36 PM, Christos Zoulas chris...@zoulas.com wrot= | e: | On Dec 23, =A03:10pm, chacon.ja...@gmail.com (James Chacon) wrote: | -- Subject: Re: CVS commit: src

Re: CVS commit: src/sys/netinet

2011-05-03 Thread Matt Thomas
On May 3, 2011, at 9:00 AM, David Young wrote: Module Name: src Committed By: dyoung Date: Tue May 3 16:00:30 UTC 2011 Modified Files: src/sys/netinet: if_arp.c Log Message: arp_drain() may be called with locks held, so instead of doing any work in arp_drain(), set a

Re: CVS commit: src/sys/netinet

2011-04-26 Thread Martin Husemann
On Mon, Apr 25, 2011 at 10:45:08PM +, YAMAMOTO Takashi wrote: somthing like the following. YAMAMOTO Takashi Index: ip_output.c === RCS file: /cvsroot/src/sys/netinet/ip_output.c,v retrieving revision 1.208 diff -u -p

Re: CVS commit: src/sys/netinet

2011-04-25 Thread YAMAMOTO Takashi
hi, On Thu, Apr 14, 2011 at 07:03:49AM +, YAMAMOTO Takashi wrote: please just weaken the assertion and clear the flag, rather than complicating the code. I'm not quite sure I see exactly what you would like the code to look like. What we have now: /* * We may not

Re: CVS commit: src/sys/netinet

2011-04-15 Thread tsugutomo . enami
David Young dyo...@pobox.com writes: You can probably still patch the ipintrq, It will be fine then. but is there any reason not to use sysctl? sysctl is available only after booting kernel. enami.

Re: CVS commit: src/sys/netinet

2011-04-14 Thread Martin Husemann
On Thu, Apr 14, 2011 at 07:03:49AM +, YAMAMOTO Takashi wrote: please just weaken the assertion and clear the flag, rather than complicating the code. I'm not quite sure I see exactly what you would like the code to look like. What we have now: /* * We may not use checksums

Re: CVS commit: src/sys/netinet

2011-04-14 Thread tsugutomo . enami
David Young dyo...@netbsd.org writes: Initialize ipintrq.ifq_maxlen using IFQ_MAXLEN directly instead of using the global ipqmaxlen. Get rid of the global ipqmaxlen. This prevents us from patching the variable, doesn't it? enami.

Re: CVS commit: src/sys/netinet

2011-04-14 Thread David Young
On Fri, Apr 15, 2011 at 09:48:04AM +0900, tsugutomo.en...@jp.sony.com wrote: David Young dyo...@netbsd.org writes: Initialize ipintrq.ifq_maxlen using IFQ_MAXLEN directly instead of using the global ipqmaxlen. Get rid of the global ipqmaxlen. This prevents us from patching the variable,

Re: CVS commit: src/sys/netinet

2010-10-06 Thread Christoph Egger
Can you try with a LOCKDEBUG + DEBUG/DIAGNOSTIC kernel? The kernel has all three options. Hm, if you have DEBUG enabled, kern_free() might fill free'ed area with WEIRD_ADDR. Yes, this patch makes boot with root on nfs work again. Please commit. Christoph enami. Index:

Re: CVS commit: src/sys/netinet

2010-10-06 Thread enami tsugutomo
Yes, this patch makes boot with root on nfs work again. Please commit. Just committed. enami.

Re: CVS commit: src/sys/netinet

2010-10-06 Thread Mindaugas Rasiukevicius
enami tsugutomo tsugutomo.en...@jp.sony.com wrote: Yes, this patch makes boot with root on nfs work again. Please commit. Just committed. enami. Thank you! -- Mindaugas

Re: CVS commit: src/sys/netinet

2010-10-05 Thread Mindaugas Rasiukevicius
Christoph Egger christoph_eg...@gmx.de wrote: Re-structure IPv4 reassembly code to make it more MP-friendly and simplify some code fragments while here. Also, use pool_cache(9) and mutex(9). IPv4 reassembly mechanism is MP-safe now. To generate a diff of this commit: cvs

Re: CVS commit: src/sys/netinet

2010-10-05 Thread Christoph Egger
Christoph Egger christoph_eg...@gmx.de wrote: Re-structure IPv4 reassembly code to make it more MP-friendly and simplify some code fragments while here. Also, use pool_cache(9) and mutex(9). IPv4 reassembly mechanism is MP-safe now. To generate a diff of this commit:

Re: CVS commit: src/sys/netinet

2010-10-05 Thread enami tsugutomo
Can you try with a LOCKDEBUG + DEBUG/DIAGNOSTIC kernel? The kernel has all three options. Hm, if you have DEBUG enabled, kern_free() might fill free'ed area with WEIRD_ADDR. enami. Index: sys/netinet/ip_reass.c === RCS file:

Re: CVS commit: src/sys/netinet

2010-08-11 Thread Jukka Ruohonen
On Wed, Aug 11, 2010 at 09:36:45AM +, Antti Kantee wrote: Module Name: src Committed By: pooka Date: Wed Aug 11 09:36:45 UTC 2010 Modified Files: src/sys/netinet: ip_carp.c Log Message: Use kpause() instead of DELAY() and sleep a minimum of 1 tick. This is possible

Re: CVS commit: src/sys/netinet

2010-08-11 Thread Antti Kantee
On Wed Aug 11 2010 at 14:22:40 +0300, Jukka Ruohonen wrote: On Wed, Aug 11, 2010 at 09:36:45AM +, Antti Kantee wrote: Module Name:src Committed By: pooka Date: Wed Aug 11 09:36:45 UTC 2010 Modified Files: src/sys/netinet: ip_carp.c Log

Re: CVS commit: src/sys/netinet

2010-08-11 Thread David Laight
On Wed, Aug 11, 2010 at 09:36:45AM +, Antti Kantee wrote: Module Name: src Committed By: pooka Date: Wed Aug 11 09:36:45 UTC 2010 Modified Files: src/sys/netinet: ip_carp.c Log Message: Use kpause() instead of DELAY() and sleep a minimum of 1 tick. This is possible

Re: CVS commit: src/sys/netinet

2010-08-11 Thread Antti Kantee
On Wed Aug 11 2010 at 17:46:07 +0100, David Laight wrote: Use kpause() instead of DELAY() and sleep a minimum of 1 tick. This is possible now since softints have a thread context. It's also not a very frequent code path. Addresses ABI issue with delay (kern/40505). 1) How many copies

re: CVS commit: src/sys/netinet

2010-07-19 Thread matthew green
Module Name: src Committed By: rmind Date: Mon Jul 19 14:09:45 UTC 2010 Modified Files: src/sys/netinet: in_var.h ip_input.c ip_reass.c ip_var.h Log Message: Abstract IP reassembly into single generic routine - ip_reass_packet(). Make struct ipq private and struct

Re: CVS commit: src/sys/netinet

2010-04-28 Thread Mihai Chelaru
Masaru OKI wrote: Module Name: src Committed By: oki Date: Fri Mar 12 13:33:19 UTC 2010 Modified Files: src/sys/netinet: in.c Log Message: Fixed a number of race conditions in the case of receiving ipv4 packet. found by iij seil team. To generate a diff of this commit:

Re: CVS commit: src/sys/netinet

2010-04-28 Thread David Young
On Wed, Apr 28, 2010 at 08:02:53PM +0300, Mihai Chelaru wrote: Masaru OKI wrote: Module Name: src Committed By: oki Date: Fri Mar 12 13:33:19 UTC 2010 Modified Files: src/sys/netinet: in.c Log Message: Fixed a number of race conditions in the case of receiving ipv4

Re: CVS commit: src/sys/netinet

2010-04-28 Thread David Young
On Wed, Apr 28, 2010 at 08:02:53PM +0300, Mihai Chelaru wrote: Masaru OKI wrote: Module Name: src Committed By: oki Date: Fri Mar 12 13:33:19 UTC 2010 Modified Files: src/sys/netinet: in.c Log Message: Fixed a number of race conditions in the case of receiving ipv4

CVS commit: src/sys/netinet

2009-12-29 Thread Elad Efrat
Module Name:src Committed By: elad Date: Wed Dec 30 06:59:32 UTC 2009 Modified Files: src/sys/netinet: tcp_usrreq.c Log Message: Get the uid from the socket's credentials. To generate a diff of this commit: cvs rdiff -u -r1.157 -r1.158 src/sys/netinet/tcp_usrreq.c

Re: CVS commit: src/sys/netinet

2009-05-12 Thread Quentin Garnier
On Tue, May 12, 2009 at 09:48:42PM +, Elad Efrat wrote: Module Name: src Committed By: elad Date: Tue May 12 21:48:42 UTC 2009 Modified Files: src/sys/netinet: ip_carp.c Log Message: Fix inverted permissions check. - if ((l == NULL) || (error =

Re: CVS commit: src/sys/netinet

2009-05-12 Thread Elad Efrat
Quentin Garnier wrote: On Tue, May 12, 2009 at 09:48:42PM +, Elad Efrat wrote: Module Name:src Committed By: elad Date: Tue May 12 21:48:42 UTC 2009 Modified Files: src/sys/netinet: ip_carp.c Log Message: Fix inverted permissions check. - if ((l ==

re: CVS commit: src/sys/netinet

2009-05-12 Thread matthew green
Quentin Garnier wrote: On Tue, May 12, 2009 at 09:48:42PM +, Elad Efrat wrote: Module Name: src Committed By: elad Date: Tue May 12 21:48:42 UTC 2009 Modified Files: src/sys/netinet: ip_carp.c Log Message: Fix inverted

<    1   2   3